Simple Machines Community Forum

Archived Boards and Threads... => Archived Boards => Install and Upgrade Help => Aiheen aloitti: jjfeenix - maaliskuu 25, 2011, 06:35:53 IP

Otsikko: Error in Package Installation 1.1.2 >> 1.1.3 with Pretty URLs mod
Kirjoitti: jjfeenix - maaliskuu 25, 2011, 06:35:53 IP
Hi,

I've inherited the assignment of maintaining an SMF forum. I'm a newbie at this. I am trying to make changes to the QuerySting.php file because of running Pretty URLs mod and getting the failed SMF upgrade error.

My problem, when searching for this string:

// Now make absolutely sure it's a number.
$board = (int) $_REQUEST['board'];


I'm finding lots more code between these two lines. Mine's in the middle of a IF block and looks like this:

// Now make absolutely sure it's a number.
// Check for pretty board URLs too, and possibly redirect if oldschool queries were used.
if (is_numeric($_REQUEST['board']))
{
$board = (int) $_REQUEST['board'];
if (!isset($_GET['pretty']))
{
$context['pretty']['oldschoolquery'] = true;
unset($_GET['pretty']);
}
} else {
$_REQUEST['board'] = str_replace(array(''', '\\'), array(chr(18), ''), $_REQUEST['board']);
$pretty_board_lookup = unserialize($modSettings['pretty_board_lookup']);
$board = (int) isset($pretty_board_lookup[$_REQUEST['board']]) ? $pretty_board_lookup[$_REQUEST['board']] : 0;

// Fix $_REQUEST for silly mods that don't check $board
$context['pretty']['query_string']['board'] = $_REQUEST['board'];
$_GET['board'] = $board;
$_REQUEST['board'] = $board;
}


Do I just add this line:
              $_REQUEST['start'] = isset($_REQUEST['start']) ? (int) $_REQUEST['start'] : 0;

in like this:

// Now make absolutely sure it's a number.
// Check for pretty board URLs too, and possibly redirect if oldschool queries were used.
if (is_numeric($_REQUEST['board']))
{
$board = (int) $_REQUEST['board'];
                        $_REQUEST['start'] = isset($_REQUEST['start']) ? (int) $_REQUEST['start'] : 0;
if (!isset($_GET['pretty']))
{
                         .
                         .
                         .


Lainaa
You HAVE backed-up, haven't you? ;)

As I said, I''m a newb at board maintenance. What is the suggested way to back up an SMF board before this kind of maintenance?

Thanks for your assistance,
JohnS
Otsikko: Re: Error in Package Installation 1.1.2 >> 1.1.3 with Pretty URLs mod
Kirjoitti: Illori - maaliskuu 26, 2011, 08:23:35 AP
How do I backup my database? (http://docs.simplemachines.org/index.php?topic=492.0)

as well as just backing up all your files. there are a few threads around about the issue you are seeing if you do a quick search you should find the answer.
Otsikko: Re: Error in Package Installation 1.1.2 >> 1.1.3 with Pretty URLs mod
Kirjoitti: JimM - maaliskuu 30, 2011, 09:40:04 IP
Welcome to SMF

I see you posted in this topic : http://www.simplemachines.org/community/index.php?topic=422130.msg2954109#msg2954109

where the same problems was discussed.  Were you able to complete the upgrade?