Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Hj Ahmad Rasyid Hj Ismail on August 04, 2011, 03:31:12 AM

Title: Unread Replies & Posts Empty Message
Post by: Hj Ahmad Rasyid Hj Ismail on August 04, 2011, 03:31:12 AM
Just a minor one (because I personally don't like them)  :P

Unread Replies
It says this when unread replies is click but empty: No unread topics found since your last visit. Click here to try all unread topics.

Isn't it better if it says: No unread replies found since your last visit. Click here to check other unread posts.

Unread Posts
It says this when unread posts is click but empty: No unread topics found since your last visit. Click here to try all unread topics.

Well there isn't anything to try since that is empty too, isn't it?

Isn't it better if it just says: No unread posts found since your last visit.
Title: Re: Unread Replies & Posts Empty Message
Post by: emanuele on August 04, 2011, 08:38:36 AM
Quote from: ahrasis on August 04, 2011, 03:31:12 AM
Well there isn't anything to try since that is empty too, isn't it?
No, it's not necessarily empty.
If during you last visit you didn't read one of the new topics/posts then it's not displayed when you see the "unread posts since your last visit", but is displayed when you are looking at all the unread posts. :)
Title: Re: Unread Replies & Posts Empty Message
Post by: Hj Ahmad Rasyid Hj Ismail on August 04, 2011, 06:54:13 PM
Empty means there is no new posts / topics. Thus, it is necessarily empty to get that message.

Have you tested them before you post. I have tried them several times. So it is as I said.
Title: Re: Unread Replies & Posts Empty Message
Post by: emanuele on August 05, 2011, 04:44:47 AM
Yes, I tested it, but to be sure I tested it again right now on both SMF 1.1.14 and 2.0.

"Show unread posts since last visit."
"Click here to try all unread topics."
These are two different things, and if the first one is empty doesn't mean the second one is empty too.
I agree that there could be a case when they are both empty: if you have read all the topics in the forum, but they are two different things and return different results. :)
Title: Re: Unread Replies & Posts Empty Message
Post by: Illori on November 18, 2011, 09:58:14 AM
then do we consider this not a bug?
Title: Re: Unread Replies & Posts Empty Message
Post by: emanuele on March 08, 2012, 04:05:39 AM
From time to time it seems that my brain simply stop to work...sorry ahrasis, I completely misunderstood your report... :-[

Yes, you are right.
Title: Re: Unread Replies & Posts Empty Message
Post by: Arantor on January 09, 2014, 10:23:16 PM
Hmm, need to check this more thoroughly but if memory serves, unread replies is not bound to last visit, meaning it's *all* unread replies for ever and ever.

But yes, the suggested change of wording from topics to posts does make some sense (even if it is topics with unread posts that are presented :P)
Title: Re: Unread Replies & Posts Empty Message
Post by: shawnb61 on November 25, 2022, 05:38:39 PM
Closing old 2.0 bugs - 2.0 is in security fixes-only at this point.