Simple Machines Community Forum

SMF Development => Feature Requests => Next SMF Discussion => Topic started by: Illori on September 19, 2011, 06:09:07 AM

Title: Menu handling
Post by: Illori on September 19, 2011, 06:09:07 AM
The development team is considering ways to better handle the menu in future versions. Some have suggested
What do you all think?
Title: Re: Menu handling
Post by: Robert. on September 19, 2011, 10:48:41 AM
I don't use menu editors a lot, but it would be a great feature though. Especially because 10% of the support requests are how to create a new tab
Title: Re: Menu handling
Post by: Joker™ on September 20, 2011, 04:13:31 PM
storing the menu in the database where custom changes to the menu will not be overridden during upgrades
But won't it be placing more pressure and queries on DB and specially when server is down, i.e when site is lagging and you are calling menu from database.

Also calling menu for everyone including guests from database doesn't sound good to me performance wise :P.


Also they are considering some type of menu editor built into SMF
That sounds like some cool feature to have.
Title: Re: Menu handling
Post by: lurkalot on September 20, 2011, 05:22:05 PM
I love the idea of a menu manager as core feature.  To be honest I asked about this over a year ago, Add menu button function (http://www.simplemachines.org/community/index.php?topic=378869.0)
Title: Re: Menu handling
Post by: Antechinus on September 20, 2011, 05:27:17 PM
The development team is considering ways to better handle the menu in future versions. Some have suggested
  • storing the menu in the database where custom changes to the menu will not be overridden during upgrades
  • Also they are considering some type of menu editor built into SMF
What do you all think?

We had this discussion in the team/beta boards already, and it was pointed out that calling the menu directly from the db would be very bad for large sites. For good scalability, any editor would have to write to a flat file.
Title: Re: Menu handling
Post by: Joker™ on September 20, 2011, 05:44:52 PM
We had this discussion in the team/beta boards already, and it was pointed out that calling the menu directly from the db would be very bad for large sites. For good scalability, any editor would have to write to a flat file.
Just a thought -- what if some mod has made the edit to the file already?
Title: Re: Menu handling
Post by: Matthew K. on September 20, 2011, 05:48:50 PM
Every time the menu is modified from the provided admin interface, the file is wiped and re-populated from the database menu table. This is already in the feature-set of my Menu Editor, not the lite version, but the full version.
We had this discussion in the team/beta boards already, and it was pointed out that calling the menu directly from the db would be very bad for large sites. For good scalability, any editor would have to write to a flat file.
Just a thought -- what if some mod has made the edit to the file already?
Title: Re: Menu handling
Post by: live627 on September 20, 2011, 06:53:16 PM
Every time the menu is modified from the provided admin interface, the file is wiped and re-populated from the database menu table.
That's called the cache. :p
Title: Re: Menu handling
Post by: Matthew K. on September 20, 2011, 07:00:22 PM
Except it's not the same...
Every time the menu is modified from the provided admin interface, the file is wiped and re-populated from the database menu table.
That's called the cache. :p
Title: Re: Menu handling
Post by: live627 on September 20, 2011, 07:33:47 PM
Ok, now I'm curious... how does it differ?
Title: Re: Menu handling
Post by: Matthew K. on September 20, 2011, 07:39:06 PM
It doesn't really, except for the fact it's not in /cache. It's not "SMF's cache" if you will.
Title: Re: Menu handling
Post by: live627 on September 20, 2011, 07:40:33 PM
You mean it doesn't expire?
Title: Re: Menu handling
Post by: Matthew K. on September 20, 2011, 07:54:19 PM
It's a flat file...with a menu array that is only re-populated when the menu is modified.
You mean it doesn't expire?
Title: Re: Menu handling
Post by: 青山 素子 on September 30, 2011, 11:37:01 AM
Couldn't you just set a different expiration time on individual cache files? If you're going to cache data, you might as well keep that all in one place. Some cache files would expire much sooner, others would be nearly static.
Title: Re: Menu handling
Post by: Xarcell on October 05, 2011, 01:10:54 PM
It's a flat file...with a menu array that is only re-populated when the menu is modified.
You mean it doesn't expire?

+1
Title: Re: Menu handling
Post by: JohnWayne999 on October 13, 2011, 05:28:40 PM
1) Menu Editor sounds excellent. Be sure to have a feature that lets you choose whether a button when pressed will open up in current window or will open up a new window. That'll be very good. For example I have a Chatroom button and I'd like it to open into a new window, rather than steering the user away from current.

2) Have the menus, buttons settings all in one central file so people don't need to apply changes to every single theme. The problem now is if you install new themes, the new themes won't have all the changes you've made to date. Having a centralised menu/button registry makes things a lot neater and flexible.
Title: Re: Menu handling
Post by: Antechinus on October 13, 2011, 05:31:23 PM
You're obviously still using 1.1.x.  SMF 2.0.x has all menus called from the same file. :)
Title: Re: Menu handling
Post by: Matthew K. on October 13, 2011, 05:41:15 PM
The target variable is already an option for SMF 2.0, as is the flat file in the logic end of things, so it's loaded the exact same way into each theme.

But yes, Menu Editor would allow you to select a target through the interface.
1) Menu Editor sounds excellent. Be sure to have a feature that lets you choose whether a button when pressed will open up in current window or will open up a new window. That'll be very good. For example I have a Chatroom button and I'd like it to open into a new window, rather than steering the user away from current.

2) Have the menus, buttons settings all in one central file so people don't need to apply changes to every single theme. The problem now is if you install new themes, the new themes won't have all the changes you've made to date. Having a centralised menu/button registry makes things a lot neater and flexible.
Title: Re: Menu handling
Post by: Account Abandoned on October 25, 2011, 01:37:56 PM
Menu editing like being where I can add menus to the main navigation? If that is the case, I would LOVE a feature like that :) Make it internal too or I mean make it where I can add custom menus to the ACP as well!
Title: Re: Menu handling
Post by: kat on October 25, 2011, 01:42:04 PM
How difficult would it be, to do this in the way that Bloc did it, with Helios?
Title: Re: Menu handling
Post by: Matthew K. on October 25, 2011, 02:07:21 PM
Oh, I already have Menu Editor developed. It's essentially ready.
How difficult would it be, to do this in the way that Bloc did it, with Helios?