Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: djoos5 on October 11, 2011, 01:13:27 AM

Title: Not returning to the Post
Post by: djoos5 on October 11, 2011, 01:13:27 AM
Not sure if this is a bug with the new release 2.01, and if it has already been reported, but when we post on our boards, it returns to the top of the topic, not to the post just made. How can I correct this, or is it needing fixed?

Thanks in advance!
Title: Re: Not returning to the Post
Post by: Kermit on October 11, 2011, 04:55:18 AM
I tried now,and it worked as it should,it doesn't seem to be something with new version,please attach your Post.php file to your next post,so we can have a look
Title: Re: Not returning to the Post
Post by: djoos5 on October 11, 2011, 01:14:17 PM
Here is a copy of the file.
Title: Re: Not returning to the Post
Post by: MK4A52 on October 11, 2011, 04:25:42 PM
Works for me. I'm using 2.0.1
Title: Re: Not returning to the Post
Post by: djoos5 on October 12, 2011, 06:28:53 PM
If it is any help, I have applied the following mods to my boards:

Custom View of attachments
which affects the following -
/boards/sources/manageattachments.php
/boards/sources/display.php
/boards/Themes/default/display.template.php
/boards/Themes/default/languages/modifications.english.php

Dice Roller code files
/boards/Sources/subs-editor.php
/boards/sources/subs.php
/boards/sources/subs-post.php
/boards/Themes/default/languages/modifications.english.php
Move the included file "dice_warn.gif" to "./Themes/default/images"
Move the included file "roll.gif" to "./Themes/default/images/bbc"

Justify code files
/boards/Sources/subs-editor.php
/boards/sources/subs.php
/boards/Themes/default/languages/modifications.english.php
Move the included file "justify.gif" to "./Themes/default/images"

Admin Notepad code files
/boards/Themes/default/languages/modifications.english.php
/boards/index.php
/boards/Themes/default/admin.template.php
Move the included file "Notepad2.php" to "./Sources"

I also edit my Subs.php file to change my Menu selection across the top so it looks like the attached.
Title: Re: Not returning to the Post
Post by: djoos5 on October 12, 2011, 06:33:46 PM
All right, forget most of this post, as I just realized that when I post on the SMF forums it does the same thing.

Is there an issue with SMF 2.01 and the new Internet Explorer 9? Do I need to have something turned on when I go to my boards?

It is not that this is a major issue, it just is nicer when you his Post and it immediately reveals your post, instead of returning to the top of the particular Topic.

Thanks in advance for the help.
Title: Re: Not returning to the Post
Post by: djoos5 on October 12, 2011, 06:34:02 PM
Test
Title: Re: Not returning to the Post
Post by: djoos5 on October 12, 2011, 06:35:34 PM
Okay... with the Compatibility View option activated in my IE9 browser, the forum reacts how it should.

Not sure if that is something the programmers want to know, but that is what's happening... at least for me.

Thanks for the help.
Title: Re: Not returning to the Post
Post by: Michael Pfaff on October 14, 2011, 02:37:38 PM
Hey djoos5,

What dice roller mod are you using? I'm looking to install one for my 2.0.1 SMF.

Thanks!

Mike
Title: Re: Not returning to the Post
Post by: djoos5 on October 14, 2011, 02:46:11 PM
I actually have two:

I use the Dice Roller mod that you can get on the SMF site under Modifications, which allows you to roll inside the post. It is a good roller, but it will not allow you to go back and edit the post, if there were any errors. I understand why because it keeps the dice roll from being questioned, but it can sometimes be an inconvenience when GM'ing.

I also have a java-based roller that I downloaded from Wizards of the Coast site a long time ago. It is simple java and html that opens a separate window for rolling. The only problem with it is that you can't keep record of the rolls, all you can do is cut and paste the results. This roller has to keep players on the honor system. Still, it is a convenient tool. I have no problem zipping the files up if you want them. PM me with an address you'd wna the files to go to. You will just have to tweak your SMF software to open the roller.

Title: Re: Not returning to the Post
Post by: Joker™ on October 14, 2011, 03:12:18 PM
Issue tracked -- http://dev.simplemachines.org/mantis/view.php?id=4850
Title: Re: Not returning to the Post
Post by: djoos5 on October 14, 2011, 03:59:22 PM
I just read through the attached link. Is there something I need to do to my Load.php file, or is that a bug tracker? I am still a newbie on these boards and I am not sure if that was for me or for the programmers.  ;)

Thanks
Title: Re: Not returning to the Post
Post by: Joker™ on October 14, 2011, 04:26:10 PM
Quote from: djoos5 on October 14, 2011, 03:59:22 PM
I just read through the attached link. Is there something I need to do to my Load.php file, or is that a bug tracker? I am still a newbie on these boards and I am not sure if that was for me or for the programmers.  ;)

Thanks
I've updated this issue as a bug in the bug tracker for our developers to work on it.
Title: Re: Not returning to the Post
Post by: djoos5 on October 14, 2011, 04:31:37 PM
Thanks for helping me out with this.

Do you want me to mark this topic as solved, or will you guys take care of that?
Title: Re: Not returning to the Post
Post by: Joker™ on October 14, 2011, 05:26:36 PM
Quote from: djoos5 on October 14, 2011, 04:31:37 PM
Thanks for helping me out with this.

Do you want me to mark this topic as solved, or will you guys take care of that?
For now you can leave it as it is.

I've already made a quick fix for it. I'll try to test/debug/re-debug it after landing in home :P.
Title: Re: Not returning to the Post
Post by: emanuele on January 17, 2012, 09:06:39 AM
Digging around... :P

Quote from: djoos5 on October 12, 2011, 06:33:46 PM
Is there an issue with SMF 2.01 and the new Internet Explorer 9?
More or less: IE9 is not recognized and so it is not working as expected in few cases (see issue 4850 (http://dev.simplemachines.org/mantis/view.php?id=4850), but also 4887 (http://dev.simplemachines.org/mantis/view.php?id=4887)).

A possible fix would be to change:
Code (find) Select
$context['browser']['is_ie'] = $context['browser']['is_ie4'] || $context['browser']['is_ie5'] || $context['browser']['is_ie5.5'] || $context['browser']['is_ie6'] || $context['browser']['is_ie7'] || $context['browser']['is_ie8'];
Code (replace with) Select
$context['browser']['is_ie'] = !$context['browser']['is_opera'] && !$context['browser']['is_gecko'] && !$context['browser']['is_web_tv'] && preg_match('~MSIE \d~', $_SERVER['HTTP_USER_AGENT']) == 1;
...even if I wonder why all the !$contex...the preg_match at the end should be enough...or not?

and
Code (find) Select
$context['browser']['ie_standards_fix'] = !$context['browser']['is_ie8'];
Code (replace with) Select
$context['browser']['ie_standards_fix'] = $context['browser']['is_ie4'] || $context['browser']['is_ie5'] || $context['browser']['is_ie5.5'] || $context['browser']['is_ie6'] || $context['browser']['is_ie7'];

in Load.php.
Title: Re: Not returning to the Post
Post by: Joker™ on January 17, 2012, 09:26:25 AM
emanuele, some said somewhere (meh memory loss) that the whole browser function is going to be a re-write. Looking forward to it with the fix you have provided ;).
Title: Re: Not returning to the Post
Post by: Arantor on January 17, 2012, 12:01:37 PM
The reason for doing that like that is because a bunch of browsers, especially older ones, used to stuff MS IE into their user agent. Kind of like how every browser out there indicates it's Mozilla compatible.
Title: Re: Not returning to the Post
Post by: Joker™ on January 17, 2012, 12:32:36 PM
detectBrowser() should be rewritten (http://dev.simplemachines.org/mantis/view.php?id=4643)
Title: Re: Not returning to the Post
Post by: emanuele on January 17, 2012, 02:39:36 PM
I know it will be rewritten.
But at the moment there are issues with browser detection and IE9 and this is a workaround that could be useful. ;)

/me is just throwing few php lines all around. :P
Title: Re: Not returning to the Post
Post by: Joker™ on January 17, 2012, 02:42:01 PM
Quote from: emanuele on January 17, 2012, 02:39:36 PM
I know it will be rewritten.
But at the moment there are issues with browser detection and IE9 and this is a workaround that could be useful. ;)
Yes, for sure the fix can be the remedy of the moment.

/me  wonders, why this post is still in support board

Moving it to bugs boards.
Title: Re: Not returning to the Post
Post by: emanuele on January 20, 2012, 10:41:31 AM
Quote from: Joker™ on January 17, 2012, 02:42:01 PM
/me  wonders, why this post is still in support board
Well, it's tracked it can stay in any place. :P
Title: Re: Not returning to the Post
Post by: Dave J on August 27, 2012, 08:44:21 AM
Just a point I have found out about this fix.

It is OK as fix for one or two of the mods but when the fix is applied to a clean install it throws out the template for the calendar.

Using IE9 version 9.0.8112.16421

See images attached.

Before

(http://www.davejohnson.co.uk/calendarscr1.jpg)

After

(http://www.davejohnson.co.uk/calendarscr2.jpg)


If you want to see the effects first hand go to my test site below


Test site (http://www.cdcollect.co.uk/forum/index.php?action=calendar)