Simple Machines Community Forum

Archived Boards and Threads... => Archived Boards => Install and Upgrade Help => Topic started by: FinsandFur on December 23, 2011, 10:41:59 AM

Title: 2.02 default templates / not upgrading
Post by: FinsandFur on December 23, 2011, 10:41:59 AM
I've noticed that after upgrading from 2.01 to 2.02 there's still out of date files in the default templates.
After further research, I see it's because of the PersonalMessagetemplate.php
One is being installed for the Core template but there is not one for the default Curve template.
Can we use the one packaged with Core to fix this?
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 23, 2011, 10:43:36 AM
there are no template changes in the default theme from the 2.0.1 to 2.0.1 upgrade.
Title: Re: 2.02 default templates / not upgrading
Post by: FinsandFur on December 23, 2011, 11:21:48 AM
According to the file it was changed on 12-21-2011
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 23, 2011, 11:23:38 AM
according to what file?

if you look here http://custom.simplemachines.org/upgrades/index.php?action=upgrade;file=smf_patch_2.0.2.tar.gz;smf_version=2.0.1 there are NO template changes for the default theme
Title: Re: 2.02 default templates / not upgrading
Post by: FinsandFur on December 23, 2011, 11:32:43 AM
Thanks Lori.
Yah, I seen the changelog before I posted, but thats actually what made me post.
The change might not be part of the actual intended upgrade, but it is being included with this release.


Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 23, 2011, 11:36:00 AM
let me say it one more time THERE ARE NO CHANGES TO THE DEFAULT TEMPLATES. end of story.
Title: Re: 2.02 default templates / not upgrading
Post by: FinsandFur on December 23, 2011, 12:00:18 PM
Ok, end of story.
I apologize for having a file in my downloaded zip that contains this changed file then. ???

Different story, can you tell me why my default PersonalMessage.template.php is out of date now that I upgraded?
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 23, 2011, 12:27:02 PM
the core theme had a problem in that file it was fixed, it should NOT affect anything else.
Title: Re: 2.02 default templates / not upgrading
Post by: FinsandFur on December 23, 2011, 12:45:30 PM
(sigh) :-\ I think thats exactly what I said right before you got short with me.
The file isnt part of the actual upgrade but the changed file IS being included with the upgrade package.

I upgraded 9 different installs this morning, every one of them now say they have out of date default template files, because of this file. Is there a way to fix this...or are we telling people to ignore it, it doesnt effect anything?
I'm not trying to be sarcastic or difficult. Just asking what we are to do about this.
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 23, 2011, 12:46:51 PM
the default theme has NO changes in the upgrade at all, just the core theme.
Title: Re: 2.02 default templates / not upgrading
Post by: FinsandFur on December 24, 2011, 12:59:15 AM
You said that three times. ???
So I'm going to end the story again and just assume that since the files didn't change they are suppose to be out of date.  ::)
Everyones default template files will be out of date as indicated in the admin section. We just live with it and ignore it.

I hope you have a better day tomorrow
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 24, 2011, 06:50:25 AM
in my installs none of the default themes templates are outdated, so no idea how yours could be as they get the information from the same source.
Title: Re: 2.02 default templates / not upgrading
Post by: LT07 on December 24, 2011, 07:01:50 AM
This thread is hilarious, I have nothing to add I just want to be part of it :D


Wait yes I do, I just did a file check and I get the exact same error, don't have a cow man he spoke the truth lol

result of version check

PersonalMessage.template.php    2.0    2.0.2
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 24, 2011, 07:30:31 AM
for some reason my forum had not updated the files from sm.org, after doing so it does show the default theme has having one outdated file, BUT it is incorrect. i have asked the site team to look into fixing this.
Title: Re: 2.02 default templates / not upgrading
Post by: norepli on December 24, 2011, 06:21:05 PM
Hello,

The detailed version check after upgrading is failing as follows:
PersonalMessage.template.php  2.0  2.0.2

I'm guessing that the detailed version check is looking at the "default" theme rather than the "core" theme when doing this check. I can confirm that I do have version 2.0.2 in the core theme and version 2.0 in the default theme.

FYI,

norepli
Title: Re: 2.02 default templates / not upgrading
Post by: Skhilled on December 25, 2011, 09:33:37 AM
Have you all upgraded via the upgrade link in admin? If so, you can have issues with that, especially file versions and database upgrade issues where the db has not been upgrade properly.

It is always best to upload the filesvia ftp and run upgrade.php.
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 25, 2011, 10:06:23 AM
no it is not always best to upload files via ftp and run upgrade.php, this is why we have the package manager upgrades. and their are no database upgrade issues as i stated above and this is not related to the database at all.
Title: Re: 2.02 default templates / not upgrading
Post by: Skhilled on December 25, 2011, 12:42:54 PM
Again, that is an old issue with smf...look it up and the countless issues with it. I've been admin and setup tons of sites and have helped many .many people upgrade. If you upgrade via the admin link (may depend on the server or permissions) you may end up with that problem. and every time you upgrade or install a mod you will possibly get that error, if the mod checks for the current db version.

This is especially true with users who have upgraded from much older versions of SMF.
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 25, 2011, 02:27:43 PM
no mod will check for the version in the database, it checks for the version in the files where it should anyway. if users run into issues with the version we will tell them when they need to upgrade and when they dont.

in this case the MESSAGE has nothing to do with the version in the database.
Title: Re: 2.02 default templates / not upgrading
Post by: norepli on December 26, 2011, 12:34:14 PM
Hello Illori,

for some reason my forum had not updated the files from sm.org, after doing so it does show the default theme has having one outdated file, BUT it is incorrect. i have asked the site team to look into fixing this.

Is this still on track for a fix? I'm a bit confused about the posts after your discovery.

Thank you,

norepli
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on December 26, 2011, 12:46:12 PM
as i said the site team is looking into it, remember we are all volunteers and this is not going to cause your forum to break if it is not fixed right now.
Title: Re: 2.02 default templates / not upgrading
Post by: norepli on December 27, 2011, 08:52:40 AM
Hello Illori,

We are very lucky to have people like yourself (and other SMF support personnel) available to assist us with our issues and I, for one, am very appreciative of that fact. Thank you for being there for all of us!

Best regards,

norepli
Title: Re: 2.02 default templates / not upgrading
Post by: JimM on January 01, 2012, 07:53:36 PM
as i said the site team is looking into it, remember we are all volunteers and this is not going to cause your forum to break if it is not fixed right now.

And most likely it will be fixed along with the next security release along with any other issues that have been identified.

As this has been addressed, I am marking it as solved to remove it from our support queue.
Title: Re: 2.02 default templates / not upgrading
Post by: FinsandFur on January 02, 2012, 10:01:24 AM

Boy it sure took a lot of convincing to show there was an issue. Whewwwww :-\
Title: Re: 2.02 default templates / not upgrading
Post by: BigJacko on January 03, 2012, 12:01:32 PM
Two points arising... well maybe three... ;)

1 - Illori's last post says: "this is not going to cause your forum to break if it is not fixed right now" - which is a relief. That's the main thing which was concerning me most, when I came across this problem (reported by the Administration Center when looking in the detailed view).

2 - Illori's earlier comment "it is not always best to upload files via ftp and run upgrade.php, this is why we have the package manager upgrades" is all well and good, but it needs to be remembered that not everybody can use the Package Manager successfully. In Windows, it's a nightmare (due to the differences in the permissions system) and it is neither simple to temporarily override the perms on an IIS-based environment, nor is it even a guarantee that the Package Manager will work even then! Thus, the manual-update-by-zip method is all that is realistically open to us, and of course, that's where this problem rears its ugly head. Presumably there's some kind of manifest which SMF relies upon to know which files are current, and for some reason, in the zip distro, this still thinks that Themes/default/PersonalMessage.template.php should be 2.0.2 (or rather, it thinks it knows that 2.0 is 'wrong', so barfs). This is presumably what's being fixed, I hope.

3 - I'd like to thank Illori for his help, but I would also really like to thank FinsandFur for his persistence! From reading this thread, it did look like he was banging his head against the wall for a fair bit until it was conceded that there is a problem. I'm very grateful to him that wasn't the one who had to go through the headbanging myself! ;)

Regards
Neil
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on January 03, 2012, 12:04:05 PM
i am not a he....

also the package manager does work on windows servers given they are configured correctly to allow the package manager to write to the required files.

and yes the team will look into fixing the version when they get a chance.
Title: Re: 2.02 default templates / not upgrading
Post by: rootuid on January 15, 2012, 05:18:13 PM
same issue here. After upgrading from 1.1.16 to 2.0.2 I can't install mods as all the default templates are at 2.0. Can I just upload the 2.0.2 templates and the mods should work?

Thanks.
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on January 15, 2012, 05:20:10 PM
there are no changes, so uploading the files from the large upgrade package would make no difference.
Title: Re: 2.02 default templates / not upgrading
Post by: rootuid on January 15, 2012, 05:50:48 PM
OK. Thanks.

All mods are failing to install. Any suggestions how to fix this?
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on January 15, 2012, 06:02:10 PM
try posting in the mods support thread and asking the author why.
Title: Re: 2.02 default templates / not upgrading
Post by: rootuid on January 15, 2012, 06:57:16 PM
thanks
Title: Re: 2.02 default templates / not upgrading
Post by: Celia N. Foster on February 12, 2012, 10:22:00 PM
Having very same issues as everyone else in this thread. I will wait for the next security update.
Title: Re: 2.02 default templates / not upgrading
Post by: Jasnick on February 24, 2012, 09:25:48 PM
Same here! 
Title: Re: 2.02 default templates / not upgrading
Post by: successcoach on March 11, 2012, 11:27:35 PM
Hello everyone.
Read through the posts looking to solve this problem and not wanting to wait for a future release to solve it so I uploaded /Themes/core/PersonalMessage.template.php and overwrote the current file in /Themes/default/PersonalMessage.template.php which seems to fix the error and all is well on first blush unless someone points out that I did wrong and I am not aware of it yet... please give me a heads up if this is so.
Title: Re: 2.02 default templates / not upgrading
Post by: Illori on March 12, 2012, 05:37:17 AM
you should NOT override the default personalmessage.template.php with the one from the core theme, they are not the same file, and could have some code variation which could cause errors. there is NOTHING you need to do.
Title: Re: 2.02 default templates / not upgrading
Post by: Gambo916 on May 23, 2012, 09:55:50 AM
I'm here because of the same 'issue' as others are experiencing.....good to know it is not going to break anything....and I too will wait for a future release.
Title: Re: 2.02 default templates / not upgrading
Post by: 10 on June 08, 2012, 04:58:33 AM
Better to edit PersonalMessage.template.php in the default theme
and change line

 * @version 2.0
то

 * @version 2.0.2

and forget about "nothing to changes"
Title: Re: 2.02 default templates / not upgrading
Post by: UndiFineD on July 27, 2012, 12:50:25 PM
10 is right, just edit the file

- * @version 2.0
+ * @version 2.0.2
Title: Re: 2.02 default templates / not upgrading
Post by: Pete Penguin on July 31, 2012, 08:22:15 AM
Clearly this is still an issue. I have had it for quite some time now (at least a year), and I would hope for a fix, not a file edit.
Title: Re: 2.02 default templates / not upgrading
Post by: emanuele on July 31, 2012, 08:29:59 AM
Better to edit PersonalMessage.template.php in the default theme
and change line

 * @version 2.0
то

 * @version 2.0.2

and forget about "nothing to changes"
In the remote case the next security update will try to fix this issue this could cause you a bit of problems (i.e. packages will not potentially show you an error), eve though I'd expect that such change will not be made mandatory in the package.

Clearly this is still an issue. I have had it for quite some time now (at least a year), and I would hope for a fix, not a file edit.
You have it since the moment SMF has been update to 2.0.2 (December 23rd 2011), and you will have it until SMF will receive a new security patch (and remember these are released only if a security problem is identified) or when you will upgrade to 2.1 (the moment it will be ready). So nothing new. ;)
Title: Re: 2.02 default templates / not upgrading
Post by: Lady Seershuh on October 17, 2012, 11:56:22 PM

I'm having same problem, so I guess issue still not resolved......
Title: Re: 2.02 default templates / not upgrading
Post by: TejasKat on November 18, 2012, 01:04:55 PM
Here it is, nearly 1 yr later from the original post, & MY Core Theme version, installed about ONE WEEK ago, states it's out of date, too.


SMF FileYour Version    Current Version
SMF PackageSMF 2.0.2SMF 2.0.2
Default Templates2.02.0.2
PersonalMessage.template.php    2.02.0.2

Title: Re: 2.02 default templates / not upgrading
Post by: emanuele on November 18, 2012, 03:00:28 PM
And TejasKat the answer is always the same: no security updates in that period and the "bug" is still there...