Simple Machines Community Forum

SMF Development => Bug Reports => Topic started by: skaero on March 20, 2012, 06:54:13 AM

Title: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: skaero on March 20, 2012, 06:54:13 AM
I searched forum and didn't find anyone else who had reported the problem so I decided to post it here. The title basically says it all, if you have multiple pages of posts on the "Show new replies to your posts." page and you hit the "Mark ALL messages as read" button it only marks the posts on the current page as read. This happened on two SMF 2.0.2 installs on different servers with caching set to 1 on both, one was a fresh SMF install no mods. Let me know if I can provide any further details to help narrow down the problem.
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: kat on March 20, 2012, 07:32:46 AM
(http://www.katzy.dsl.pipex.com/SMF/welcome.gif)

I don't think that's a bug. I believe that it's meant to work that way.

Odd, I agree, but...

Maybe the text should be changed to read "Mark ALL messages on this page as read".

(Unless I've misunderstood, that is)
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: skaero on March 20, 2012, 08:20:48 AM
Hmm I guess that could make sense, we noticed it after a import from vB so users have 50x pages of unread posts. If the functionality doesn't change then the label should as it can be confused.
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: kat on March 20, 2012, 08:22:32 AM
I'll check, though, in case I've boobed. ;)
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: emanuele on March 20, 2012, 08:25:07 AM
There is already a mark all messages as read at the end of the board index.

I'd change it to "Mark messages as read", it's a button, we cannot let it fill half screen... ;)
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: kat on March 20, 2012, 04:47:35 PM
Quote from: emanuele on March 20, 2012, 08:25:07 AMwe cannot let it fill half screen... ;)

[panto mode]

Oh yes we can!!!

[/panto mode]
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: Angelina Belle on March 21, 2012, 02:54:41 PM
Perhaps "Mark these 25 messages as read"
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: kat on March 21, 2012, 05:57:55 PM
That'd work!
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: Arantor on January 26, 2014, 10:15:50 PM
Thing is, I just tested this by unignoring the Spanish boards (since I knew that'd be a big source of messages), viewing all unread (to make sure I had a ton of them, and there were, 9 pages) - though both view latest unread and view all unread both take me to the same place, so that's not a factor.

And sure enough... mark all messages as read marked all nine pages as read. I've used this before to mark multiple pages, so I'm not sure there is a bug here :/
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: margarett on January 27, 2014, 05:30:16 AM
What the OP claims is more than 1 page of unread REPLIES. And I don't think I ever had more than 1 page of unread replies and, for sure, I didn't marked those as read without actually read them...

edit: confirmed in my test board. Not sure if it is intentional or not, but the fact is, it only marks current page as read
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: Arantor on January 27, 2014, 09:54:25 AM
Ah, that might explain it. Hmm.
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: Arantor on January 27, 2014, 12:19:34 PM
Yup, it does explain it - they call different parts of markasread. The question then, having established what it is doing, is whether it should be changed.
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: Angelina Belle on January 27, 2014, 02:42:10 PM
Or at least made clear that it is doing something different, because it seems that the current behavior is confusing.
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: margarett on January 27, 2014, 02:43:16 PM
I'd say it should mark everything as read. It's what all other similar functions do *and* that's what the button says ;)
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: Arantor on January 27, 2014, 04:43:31 PM
This is where it gets incredibly complicated. All unread is not necessarily all unread.

If you click on the board icon you get taken to the unread page - but only for that board, where marking it unread will only touch that board's unread items. But I believe the text string is different.

Yeesh this is a complicated tangle of code.
Title: Re: Mark as read on "Show new replies to your posts" only marking one page as read
Post by: Arantor on February 02, 2014, 03:58:45 PM
There's a separate problem... if you rely mostly on unreadreplies, selecting 'mark all messages as read' to actually *mean* all, could mean that you miss some unless you go via unread first.

Perhaps the correct course of action is not to make it force clear all unreadreplies as the code currently does but change the text instead.