Title: Yabb Classic update
Post by: IchBin™ on April 25, 2012, 09:52:35 PM
Post by: IchBin™ on April 25, 2012, 09:52:35 PM
I worked on this quite a while ago, but never got around to having anyone look at it. Basically all I've done is to change the index.template to remove all the tables that weren't really necessary. Added in a bit of CSS to make the rounded corners for the reply, quote, new topic buttons etc. Tried to modify as little templates as possible to keep it possible for mods to work. Please feel free to take it for a test drive and post back with any problems or suggestions. I'll be committing these changes to our repositories but would like some feedback before I release to the public on our site.
Title: Re: Yabb Classic update
Post by: Gary on April 25, 2012, 10:39:41 PM
Post by: Gary on April 25, 2012, 10:39:41 PM
It's a start. Though there would still be plenty to work on. But that's my opinion.
Two bugs I noticed, one being blatantly obvious.
The other is that Redirect boards don't position themselves properly in MessageIndex. I could assume the same for BoardIndex, but I haven't properly looked.
Also, now that Started by is in it's own Column again, there's no point in having it below the Subject itself. :P
Two bugs I noticed, one being blatantly obvious.
The other is that Redirect boards don't position themselves properly in MessageIndex. I could assume the same for BoardIndex, but I haven't properly looked.
Also, now that Started by is in it's own Column again, there's no point in having it below the Subject itself. :P
Title: Re: Yabb Classic update
Post by: IchBin™ on April 26, 2012, 12:13:22 PM
Post by: IchBin™ on April 26, 2012, 12:13:22 PM
ah thx for that! I didn't notice the duplicate started by. I'll remove that. Fixed the column layout on the redirect childboard too.
ETA: Yep it was screwed up on board index too for redirect boards. I'll attach a new package here in just a bit.
ETA: Yep it was screwed up on board index too for redirect boards. I'll attach a new package here in just a bit.
Title: Re: Yabb Classic update
Post by: IchBin™ on April 30, 2012, 02:44:54 PM
Post by: IchBin™ on April 30, 2012, 02:44:54 PM
Gary, would you mind if I moved this to the themes board to get public input before putting it up on the theme site?
Title: Re: Yabb Classic update
Post by: Gary on May 01, 2012, 01:21:18 AM
Post by: Gary on May 01, 2012, 01:21:18 AM
Nah, go for it.
Title: Re: Yabb Classic update
Post by: IchBin™ on May 13, 2012, 11:19:16 PM
Post by: IchBin™ on May 13, 2012, 11:19:16 PM
Nobody? I guess maybe this place doesn't get seen too well. Was hoping for any feedback. I guess I'll take one last look and commit the thing if nobody pipes up.
Title: Re: Yabb Classic update
Post by: Deaks on May 14, 2012, 07:36:10 AM
Post by: Deaks on May 14, 2012, 07:36:10 AM
firstly do you need to repeat:
There is an issue with some titlebgs, look at the pic titled Classic1 this issue also happens in stats.
You need an updated Settings.template.php as you not got slogan feature in the theme :P
Thumbnail needs updated, maybe get rid of the curve images you not using from images/themes, I would include a Settings.english.php file and update the data in that aswell.
New Posts
No New Posts
Redirect Board
There is an issue with some titlebgs, look at the pic titled Classic1 this issue also happens in stats.
You need an updated Settings.template.php as you not got slogan feature in the theme :P
Thumbnail needs updated, maybe get rid of the curve images you not using from images/themes, I would include a Settings.english.php file and update the data in that aswell.
Title: Re: Yabb Classic update
Post by: Robert. on May 14, 2012, 07:43:08 AM
Post by: Robert. on May 14, 2012, 07:43:08 AM
I think it's really nice, but I'd like to see titlebg a bit smaller, like it is in the original classic theme :)
Title: Re: Yabb Classic update
Post by: IchBin™ on May 14, 2012, 10:44:36 AM
Post by: IchBin™ on May 14, 2012, 10:44:36 AM
Quote from: Runic on May 14, 2012, 07:36:10 AM
firstly do you need to repeat:
under every category, original didnt do that :/
There is an issue with some titlebgs, look at the pic titled Classic1 this issue also happens in stats.
You need an updated Settings.template.php as you not got slogan feature in the theme :P
Thumbnail needs updated, maybe get rid of the curve images you not using from images/themes, I would include a Settings.english.php file and update the data in that aswell.
It actually wasn't doing that, and no I did not intend it to do that. Must of been something I've changed recently. Thanks for pointing it out, as it wasn't showing on my last install. Just reinstalled it and I see the problem.
Deejay,
You sure about that? I don't recall them looking that much different. I'll have to install the old one and check it out again.
Title: Re: Yabb Classic update
Post by: Deaks on May 14, 2012, 11:53:53 AM
Post by: Deaks on May 14, 2012, 11:53:53 AM
happy to pint issues out :)
Title: Re: Yabb Classic update
Post by: Gary on May 14, 2012, 01:59:02 PM
Post by: Gary on May 14, 2012, 01:59:02 PM
"Pint"? Have you been drinking? :P
Title: Re: Yabb Classic update
Post by: IchBin™ on May 14, 2012, 01:59:56 PM
Post by: IchBin™ on May 14, 2012, 01:59:56 PM
Probably something he's just wishing he had. ;)
Title: Re: Yabb Classic update
Post by: Deaks on May 14, 2012, 02:04:09 PM
Post by: Deaks on May 14, 2012, 02:04:09 PM
exactly cant afford a pint atm :(