Simple Machines Community Forum

Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=3373)

Overview

This modification enhances polling to allow voters to be displayed for those needing to organize and record the results of polls.  For example, when organizing a group event, friends are often curious about how other friends voted.  Likewise, the secretary of an organization might need to be able to record the results of certain polls (who voted for what).  In addition, some polls might want to allow (or require) comments for certain responses.  With this modification, each poll can be configured to allow various levels of voter visibility and comment requirements, and then the voter log can be viewed by those who are allowed to see them based on the configured voter visibility.

This mod has been well received and well tested in several very active forums.  Anyone who needs these features cannot imagine life without it.  If you install it and do not like something, please take a few minutes and tell me why in the support forum.  I will most certainly pay attention to your feedback.


Main Features

• Voter Visibility and Comment Requirements can be specified when creating a new poll.
• Voter Visibility can be set to:
  
  
  • PUBLIC - Everyone can see the voter log for the poll.
  • DISCREET - Only the creator and admins can see the voter log for the poll.
  • PRIVATE - Only admins can see the voter log for the poll.
• Comments can be optional or required depending upon the vote choice or option selected.

Other Notes

• This mod is most likely not compatible with other mods that significantly change poll behavior (e.g., multiple polls mods).
• Visibility cannot be changed once the poll is created because that is too sensitive an operation.  Members may vote differently if they know their vote will be PUBLIC versus PRIVATE and changing visibility without their consent would be a violation of the trust communicated when they first voted.
• Guests that are allowed to post polls cannot specify DISCREET voter visibility because there is no originating account associated with the poll.
• When comments are available, there is only one comment block available for the vote because that is sufficient most users.
• The Vote Log results table is a javascript sortable table created by Christian Bach and known as tablesorter 2.0 (http://tablesorter.com/).

Release Notes

• 1.00 - The initial release candidate.
• 1.01 - Small bug fixes discovered during the mod approval process.
  
  • Addressed feedback provided by the mod approval team.
  • Fixed a bug relating to guest voting features.
• 1.02 - Bugs fixes for issues reported by users in the support forum.
  
  • Fixed errors being reported relating to polls that do not allow comments.
  • Fixed add polls so that the visibility can be set when adding a poll to an existing topic.
  • Upgraded tablesorter and jQuery to latest stable releases.
• 2.0 - Redefining version labeling scheme so package manager can see the updates.
• 2.1 - Updated to be compatible with latest SMF and other minor updates
  
  • Added support for 2.0.9-2.0.11 (only verified against 2.0.11).
  • Updated jQuery library to latest stable release.
  • Corrected visibility label from "DISCRETE" to "DISCREET".
  • Changed default visibility level to PUBLIC based on user feedback.

License agreement

• By using this software, you agree to be bound by the license agreement.
• A copy of the license is included in the license.txt file at the root of the installation package.
• Simple Machines^® is authorized to distribute this modification on SimpleMachines.org and any other medium.

Donationware Notice - Support Local Roller Derby

   
• This modification was created by Ray Cardillo (aka Mr. Mighty) of Cardillo's Creations LLC (http://cardilloscreations.com) and Mr. Mightys Fine Designs (http://mrmightysfinedesigns.com) in the spirit of helping the Roller Derby community in general, and more specifically The Quadfathers (http://www.quadfathers.com) men's roller derby league and the Men's Roller Derby Association (http://www.mensrollerderbyassociation.com).
• The suggested contribution is $20 to each but any donation is better than nothing.  Go see a game, or help a local league, but please try to contribute something.  These modifications take time to create, improve, and support.  Anything you donate will help motivate future development and will be greatly appreciated by the leagues.

Make A Contribution Using These Links

• Contribute to The Quadfathers (http://quadfathers.blogspot.com/p/mr-mightys-smf-voting-mod.html)
  The Quadfathers are a league from the Mohawk Valley area of Central New York (my home town and my initial foray into the world of Roller Derby).  It's not a big city so fund-raising can be difficult.  Anything you send will be greatly appreciated!
• Contribute to the Men's Roller Derby Association (http://www.mensrollerderbyassociation.com)
  The Roller Derby community is very open and accepting, promotes volunteerism, and inspires grass roots efforts with strong community ties.  Send a few dollars their way if that's the type of world you want to live in!  :)

very nice mod

german(-utf8). translation

// Begin Poll Vote Visibility Display strings
$txt['poll_vv_opt'] = 'Abstimmungsergebnisse anzeigen';
$txt['poll_vv_opt_ro'] = '(nur lesen)';
$txt['poll_vv_opt_public'] = 'ÖFFENTLICH';
$txt['poll_vv_opt_discrete'] = 'DISKRET';
$txt['poll_vv_opt_private'] = 'PRIVAT';
$txt['poll_vv_opt_public_txt'] = 'Jedem Benutzer ist es möglich die Abstimmungsergebnisse aufzurufen';
$txt['poll_vv_opt_discrete_txt'] = 'Nur der Ersteller kann die Abstimmungsergebnisse aufrufen (Administratoren natürlich auch)';
$txt['poll_vv_opt_private_txt'] = 'Nur Administratoren können die Abstimmungsergebnisse aufrufen';
$txt['poll_vv_vlog_empty'] = 'Auf diese Umfrage wurde noch nicht abgestimmt.';
$txt['poll_vv_vlog_title'] = 'Abstimmungslog';
$txt['poll_vv_vlog_button'] = 'zeige Abstimmungen';
$txt['poll_vv_vlog_for'] = 'Antworten auf %1$se Umfrage:';
$txt['poll_vv_vlog_th_tstamp'] = 'Datumsstempel';
$txt['poll_vv_vlog_th_member'] = 'Mitglied';
$txt['poll_vv_vlog_th_choicenum'] = 'Auswahl';
$txt['poll_vv_vlog_th_choicelbl'] = 'Auswahllabel';
$txt['poll_vv_vlog_th_comment'] = 'Kommentar';
$txt['poll_vv_vlog_err_discrete'] = 'Die Abstimmungsergebnisse sind nicht sichtbar, da die Umfrage im Status DISKRET läuft. Da Du nicht der Ersteller der Umfrage bist, hast Du nicht die Möglichkeit die Abstimmungsergebnisse zu sehen (oder Du benötigst Administratorrechte).';
$txt['poll_vv_vlog_err_private'] = 'Die Abstimmungsergebnisse stehen nur den Administratoren zur Verfügung. Die Umfrage hat den Status PRIVAT.';
$txt['poll_vv_vlog_vote_warning'] = 'Status der Umfrage: %1$s; %2$s';
$txt['poll_vv_vlog_guest_or_unknown'] = '(Gast oder Ex-Mitglied)';
$txt['poll_vv_shwcmt_opt'] = 'Erlaube Kommentare zu dieser Umfrage';
$txt['poll_vv_reqcmt_opt'] = 'benötigt Kommentar für';
$txt['poll_vv_reqcmt_warn'] = '(Kommentar erforderlich)';
$txt['poll_vv_cmt_label'] = 'Kommentar';
$txt['poll_vv_cmt_missing_required'] = 'Du musst einen Kommentar zur Auswahloption %1$d: "%2$s" schreiben.';
// End Poll Vote Visibility Display strings


Nice mod :)

Thanks for the positive feedback!  Please help me try to "spread the word" and tell people about this mod.  I think every SMF admin would want to install it once they see it in action.  Everyone can benefit from it, but I would think that these features are absolutely essential for any admin who is running a forum for a local organization, volunteer group, sports team, etc.  For example, a secretary must be able to easily record official committee votes without everyone seeing them, sometimes members want to publicly plan a group event and see who else is attending, comments can be used to provide more info or maybe to state what you are bringing to a party, and the list goes on.

Even though there aren't any other mods that provide all of these features I think it's difficult to get visibility.  I tried cross posting to a few relevant threads, but I don't really want to start spamming.  So I'm hoping interest will grow organically by word of mouth.  :)

@ Ray the one way you have forgotten for getting word out regarding the mod is by placing a link in your signature.

Yes indeed.   :)  Good suggestion.  Done.

I installed this... the new options appear when i make a poll... the comment box appears when I make a poll... but no VIEW VOTES button comes up on the results...

Appears to be not compatible with the multi-poll mod I have installed.  Bummer.

Quote from: FrizzleFried on May 11, 2012, 08:02:05 PM
Appears to be not compatible with the multi-poll mod I have installed.  Bummer.

May be a good idea to request compatability between the two mods for the next version.

;)

Quote from: FrizzleFried on May 11, 2012, 08:02:05 PM
Appears to be not compatible with the multi-poll mod I have installed.  Bummer.

Ah, yeah, I can't speak for the other mod, but I tried to follow the new SMF mod coding guidelines very carefully (and that mod may have also) but the way the mod system works can make it difficult to ensure compatibility sometimes.  In particular, if two mods touch the same section, and change SMF behavior enough, it can be difficult or impossible for them to be compatible without special workarounds, etc.

Out of curiosity, did you happen to get any errors when you performed the install of this mod?  If it had trouble finding the insertion point, then that would be the obvious source of the problem.  If there were no messages in RED on the pre-install check, then the other mod must have changed the way the polling works in a way that effected my mod.  If the other mod creator has time to diagnose and there's a simple solution, I would be willing to spend some time on that.  Otherwise, I would have to spend some time digging deep, understanding the other mod, etc, so will only do that if it's a common request.

Yes... I for 4 errors... and manually installed those sections...

Let see if I can remember...

Display.php

edits 1 and 4.... I believe edit 4 is where the issue is as the mod that is already installed changed the code to include ['poll'] prior to each other [] in the line...

Display.template.pho

edit 3

post.php

edit 6

Most of the manual edits were simply because something else was added to the line it was looking for... but edit 4 of the DISPLAY.PHP file there was considerable difference in the code it was looking for to place the new code after and the code I found.

RE: That one edit...

It's looking for:

$context['show_view_results_button'] = $context['allow_vote'] && (!$context['allow_poll_view'] || !$context['poll']['show_results'] || !$context['poll']['has_voted']);

But what is there is:

$context['poll']['show_view_results_button'] = $context['poll']['allow_vote'] && (!$context['poll']['allow_poll_view'] || !$context['poll']['show_results'] || !$context['poll']['has_voted']);

Dropping what it wants to add after the above code in place below the modified code does not work.

Yeah, when you reported that the other mod is a "multi poll" mod I automatically assumed that the other mod is changing the default behavior of one poll per topic and touching all the places required to reference/dereference each poll that might be associated with the topic.  If that's the case, I think this would always have to be a "manual" edit by the installer because you would have to make sure the references to the "poll" that my mod makes also accounts for the possibility of multiple polls per topic.

So that's what you would have to do (unfortunately)... review all of the edits my mod makes... and make sure they're using that other mods style of poll referencing to make sure each operation is happening for the correct poll.  If you're a dev, it's doable (but painful), otherwise it sounds like the kinda thing that is just going to have to be incompatible since it sounds like that mod is changing the storage model slightly to account for the possibility of multiple polls being present.

Quote from: Ray Cardillo on May 11, 2012, 08:42:56 PM
Yeah, when you reported that the other mod is a "multi poll" mod I automatically assumed that the other mod is changing the default behavior of one poll per topic and touching all the places required to reference/dereference each poll that might be associated with the topic.  If that's the case, I think this would always have to be a "manual" edit by the installer because you would have to make sure the references to the "poll" that my mod makes also accounts for the possibility of multiple polls per topic.

So that's what you would have to do (unfortunately)... review all of the edits my mod makes... and make sure they're using that other mods style of poll indexing to make sure each operation is happening for the correct poll.  If you're a dev, it's doable (but painful), otherwise it sounds like the kinda thing that is just going to have to be incompatible since it sounds like that mod is changing the storage model slightly to account for the possibility of multiple polls being present.

Yeah... being that I am a "hack" at best... I think it comes down to deciding which mod is preferable.

:)

Quote from: FrizzleFried on May 11, 2012, 08:44:35 PM
Yeah... being that I am a "hack" at best... I think it comes down to deciding which mod is preferable.

Sorry about that... wish there was an easier way.   :-\

In the community of folks I help out, I know that multiple polls per topic would cause way too much confusion, and they wouldn't want that capability at all (or could live without it for the rare cases they thought it might be useful)... whereas they absolutely require the Voter Visibility features.  So like you said, it's just a matter of determining what your members need more... or will derive more benefit from... even if they don't realize it at first.  :)

Just in case others find this thread, here is a list of "off label" usages that our members started doing with the Voter Visibility mod even though I didn't explicitly design for these cases:

• Public polls for parties help people determine if their click of friends are going or not (and help decide if they are going or not) and comments can be used as a task or food signup because everyone sees the results in a public poll.
• Aside from league secretaries using discrete votes, other regular members can use them (e.g., team captain or other representatives) as a way of collecting honest feedback in a semi-private way that they can use to follow up on issues privately.
• Not only can comments be used to justify a certain answer, or provide some other info, but they can also be used as an "other" poll option.  I try to advise against this practice for the most part, but it can be convenient in some cases.

Ironically... I put up a poll...   8)

Quote from: FrizzleFried on May 11, 2012, 09:25:56 PM
Ironically... I put up a poll...   8)

LOL!!!  A poll preference poll.  That's awesome.  :)  If you have the time, I always setup a test instance by restoring a backup onto another test sub-domain, and then invite key members to "kick the tires" before making a decision that gets rolled out to the live site.

Membership decided on your mod.  I pulled the multi-poll mod and installed yours without error.  It works great... but it is throwing the occassional error (24 in the last 5 days...nothing huge but I want to track it down)...

These are the errors being thrown:

http://www.xxxx.com/index.php?action=vote;topic=1410.0;poll=66
8: Undefined index: voteComment
File: /home/ahaforum/public_html/Sources/Poll.php
Line: 208

EDIT: The above code stands on it's own ... and the following errors were generated at the same time.

http://www.xxxx.com/index.php?action=editpoll2;topic=1407.0
8: Undefined index: reqcmts
File: /home/ahaforum/public_html/Sources/Poll.php
Line: 844

http://www.xxxx.com/index.php?action=editpoll2;topic=1407.0
8: Undefined index: poll_vvis
File: /home/ahaforum/public_html/Sources/Poll.php
Line: 719

http://www.xxxx.com/index.php?action=editpoll;topic=1407.0
8: Undefined variable: row
File: /home/ahaforum/public_html/Sources/Poll.php
Line: 553

The TOP ERROR stands on it's own... the following 3 were generated at the same time.  The bottom 3 have something to do with POSTING a poll as that user had posted a poll at that time and the top error has something to do with viewing the poll.

I will try to take a look soon... but problems like you are reporting usually only happen when something in the install gets FUBAR and the variable is never set from the UI template side, etc.  We did have some things I had to fix regarding Guest polling with this feature, so can you confirm if this is happening to any particular certain type of user?  If it doesnt happen consistently for the same user then it might be caching of some sort.  Does it happen to people using a certain theme?  Did you install to core and curve theme?  Are the users who experience this using another theme?

Basically, tell me anything you can determine regarding the type of user, when/how it happens, and if there is a correlation to what theme (or other config) that might be at play.  I have to be able to debug it or reproduce it to understand what's going on so tell me any details that seem to go together (e.g., lead to the failure case).

Quote from: Ray Cardillo on May 17, 2012, 02:38:08 PM
I will try to take a look soon... but problems like you are reporting usually only happen when something in the install gets FUBAR and the variable is never set from the UI template side, etc.  We did have some things I had to fix regarding Guest polling with this feature, so can you confirm if this is happening to any particular certain type of user?  If it doesnt happen consistently for the same user then it might be caching of some sort.  Does it happen to people using a certain theme?  Did you install to core and curve theme?  Are the users who experience this using another theme?

Basically, tell me anything you can determine regarding the type of user, when/how it happens, and if there is a correlation to what theme (or other config) that might be at play.  I have to be able to debug it or reproduce it to understand what's going on so tell me any details that seem to go together (e.g., lead to the failure case).

FWIW... I have no guests on my forum (it's a private/invite only forum)...

If you can even give me some clues where to look I can poke around.  The PACKAGE MANAGER install wen without a hitch.

EDIT: Oh... and there doesn't appear to be any negative impact on the users experience...nothing is "breaking" or not working from their perspective.

Also... the top error... which I click the top error URL I get:

QuoteAn Error Has Occurred!
Either that poll doesn't exist, the poll has been locked, or you tried to vote twice.

So perhaps it's not an error exactly?

Clicking on the others take me to the CREATE A POLL screen... and when I check the logs sure enough an error pops up with my user name being I dropped in to that page.

Quote from: FrizzleFried on May 17, 2012, 02:42:18 PM
EDIT: Oh... and there doesn't appear to be any negative impact on the users experience...nothing is "breaking" or not working from their perspective.

Oh, alright, where are you seeing this exactly (so I can look the same place you're looking)?  If you can tell me how to reproduce, then I can try for myself and see what's up.  Even if I cannot reproduce it, once you can reproduce it, I can review the code and play an educated guessing game.

If it's only happening on that other error you mentioned, perhaps I wasn't careful enough checking all the variables in the rest of that flow when the error happens... but nobody ever sees it.  Would still like to clean it up if you can document the use case while reproducing the error.

Thanks!

Quote from: Ray Cardillo on May 17, 2012, 02:52:21 PM

Quote from: FrizzleFried on May 17, 2012, 02:42:18 PM
EDIT: Oh... and there doesn't appear to be any negative impact on the users experience...nothing is "breaking" or not working from their perspective.

Oh, alright, where are you seeing this exactly (so I can look the same place you're looking)?  If you can tell me how to reproduce, then I can try for myself and see what's up.  Even if I cannot reproduce it, once you can reproduce it, I can review the code and play an educated guessing game.

If it's only happening on that other error you mentioned, perhaps I wasn't careful enough checking all the variables in the rest of that flow when the error happens... but nobody ever sees it.  Would still like to clean it up if you can document the use case while reproducing the error.

Thanks!

The errors posted are from my ERROR LOG in the Admin...

When i click on one of the errors it takes me to one of my users POLLS he set up.  When I click back to the admin error log and refresh... the 8: Undefined variable: row error shows up with my user name (so the error is being thrown just looking at that screen).

I may be overlooking this, but cannot seem to find the "Voter Log" - assuming this should be somewhere in the admin area?

When enabled the voter log button appears under the poll in question at the left (standard theme).

looks like it is all theme related, how do I modify the theme?
what files do I put where?

Quote from: dredman on May 18, 2012, 02:16:28 PM
looks like it is all theme related, how do I modify the theme?
what files do I put where?

No, but due to the way SMF words internally, there are some updates to the theme files that are required.  This mod is compatible with 2.0.2 so you can just install it using the standard Package Manager (http://wiki.simplemachines.org/smf/Package_manager) procedures.  Most people simply use Package Manager to download and install to both the Curve and Core themes since both are supported out of the box.

If you want to install this mod to any other themes, then you have to be able to do an advanced Manual Install (http://wiki.simplemachines.org/smf/Manual_installation_of_mods) and you are on your own at that point (that Wiki article explains why).  It's not rocket science, but it requires more knowledge of how SMF and mods work, and is a lot more work than most people are willing to commit to.

I think my comments will make more sense once you read the Wiki articles I've referenced above.  ;)

Quote from: FrizzleFried on May 17, 2012, 03:12:54 PM
The errors posted are from my ERROR LOG in the Admin...

When i click on one of the errors it takes me to one of my users POLLS he set up.  When I click back to the admin error log and refresh... the 8: Undefined variable: row error shows up with my user name (so the error is being thrown just looking at that screen).

Alright, just to make sure you know this didn't fall on deaf ears, I wanted to respond quickly.  I reviewed quickly and it looks like a small cosmetic problem causing some errors to be logged that are harmless.  Since it's not causing any serious problems I'm going to defer this for now, and I will review in more detail when I make my next round of updates.  I have a lot going on right now and I'm trying to prioritize carefully.  So when everything settles down, I'll review this along with any other misc issues that may be reported and consider any feedback or special requests as well.

Things will probably not settle down until August or September, so unless someone notices a high severity problem, I will not be making any updates for a few months.  I'm still going to try to be responsive to inquiries and be helpful, etc, but the time it takes to debug, make updates, test the package install against multiple configurations, etc, is just too much of a burden right now since it's basically just resulting in a cosmetic issue in the admin log.  :)

Glad to see it's not an isolated issue with me (well,  sort of... I guess misery loves company).  Since this is now generating about 50 errors a day I may just uninstall it until the issue is addressed... I am a bit anal and can't stand a "dirty log"...

(that sounds vaguely dirty, huh?)...

Thanks for the work... and I hope to see the fix when you have time.

Quote from: FrizzleFried on May 21, 2012, 10:12:03 PM
Glad to see it's not an isolated issue with me (well,  sort of... I guess misery loves company).  Since this is now generating about 50 errors a day I may just uninstall it until the issue is addressed... I am a bit anal and can't stand a "dirty log"...

Yikes, 50 errors a day, that sucks.  Alright, tell you what, if you can confirm that everyone loves the mod and will be upset if you remove it... then I'll honestly try to squeeze in the time to fix, test, release, an update.  I just don't want to go through all that if it's not going to matter anyways... but I would hate to loose a user due to something silly like that.  :)

QuoteI just don't want to go through all that if it's not going to matter anyways... but I would hate to loose a user due to something silly like that. 

Considering the mod has been downloaded 133 I think it may be worth doing.

Quote from: Old Fossil on May 21, 2012, 10:50:24 PM

QuoteI just don't want to go through all that if it's not going to matter anyways... but I would hate to loose a user due to something silly like that. 

Considering the mod has been downloaded 133 I think it may be worth doing.

Oh, it's definitely getting fixed... In fact, I'm kind of embarrassed that nobody caught this before now.  Just trying to prioritize this in comparison to other activities going on right now... and I'm inclined to leave it for another month or two since it's a low severity problem.  The features all behave correctly, no actual failures, etc, just an unintended log file annoyance.  :-\

RL comes first no matter what.

Unless of course ya see me approach with a frying pan.

;)

It'll wait until you can get time to get it done... :)

Just please don't forget us and leave us hanging... as my users DO use and DO like this mod over the multi-poll mod I had running.

Thanks!

Quote from: FrizzleFried on May 22, 2012, 12:06:45 AM
It'll wait until you can get time to get it done... :)

Just please don't forget us and leave us hanging... as my users DO use and DO like this mod over the multi-poll mod I had running.

Thanks!

Borrow my frying pan if ya want.

Quote from: Ray Cardillo on May 11, 2012, 08:19:50 PM
I tried to follow the new SMF mod coding guidelines very carefully (and that mod may have also)

Why did you use hardcoded tables prefixes?
It will make errors if forum have tables prefix other then 'smf_'.

Any news on this?   I just deleted over 1500 errors from my log from this mod... and the user polls are getting more popular.

:o

Thanks!

Bummer ... author has not been on since May 21st...

:(

EDIT: I got a PM from the author... when he has time he will update.  :)

Am I missing something?  Even when creating a poll, my voter visibility is set to read only and won't allow me to modify it to anything other than Only forum admins can see votes.  I want everyone to see the votes!

Ah, this seems to be when adding a poll to an existing thread!  I can set the option if I hit "New Poll" to start a new topic.  Please can anyone tell me how to add a poll to an existing topic and set the voter visibility to public?  Is this possible?

I just had to create a new poll, so I could set the VV to public, (luckily Lazarus completed the fields for me, the little star!) then merge the poll topic with the existing topic that I wanted the poll to be on.  It was a bit of a faff....

Hi when i installed this mod, i get a few errors in the download manager, but when i installed it, it didnt add a button under the poll, though we have a multipoll feature called "Additional Polls" could you add support for this mod if this is the issue? :/ or add your own multipoll in this plugin? :/

Quote from: Sabrinova on August 14, 2012, 05:02:30 PM
Am I missing something?  Even when creating a poll, my voter visibility is set to read only and won't allow me to modify it to anything other than Only forum admins can see votes.  I want everyone to see the votes!

Ah, this seems to be when adding a poll to an existing thread!  I can set the option if I hit "New Poll" to start a new topic.  Please can anyone tell me how to add a poll to an existing topic and set the voter visibility to public?  Is this possible?

I just had to create a new poll, so I could set the VV to public, (luckily Lazarus completed the fields for me, the little star!) then merge the poll topic with the existing topic that I wanted the poll to be on.  It was a bit of a faff....

Dear Ray, thanks for picking up the who voted what package and put it to SMF 2.0.

BUT: I have the absolutely same problem as explained above. E.g. I'm creating a calendar event and want to determine the participants. If I start merging it becomes really annoying. Is there a way to prevent the read-only restriction?

Thanks a lot

Jochen

Dear All,

I have another short question:

When I create a poll I actually never can see the voters. Instead I get some error like:
Database error:
sql_name.smf_log_polls doesn't exist.

That is simply because my data prefix is not smf_ but smf_tco. So in my MySQL database I actually do have the entry smf_tcolog_polls. In what variable is the database prefix stored? One should change that in the source code to the correct variable...

Cheers

Jochen

Ok,

I did the quick google search myself.

Just replace smf_ with {db_prefix} in VoteLog.php

Cheers

Is it possible to use this feature when i want to add a new poll to an existing thread?
Because currently doesnt work, just when i create poll with thread, but alone no :(

I hope the author or somebody add this feature in the future.

Edit: Nevermind i edited it for myself :)

we get databaseerror "Unknown column 'p.timestamp' in 'field list'"

based on file smf/Sources/VoteLog.php line 116

whats this about? i don´t have coding skills =)

same here

Quote from: polit-talker on September 23, 2012, 03:00:00 PM
Ok,

I did the quick google search myself.

Just replace smf_ with {db_prefix} in VoteLog.php

Cheers

Quote from: FrizzleFried on May 17, 2012, 02:20:19 PM

Code Select Expand

http://www.xxxx.com/index.php?action=editpoll;topic=1407.0
8: Undefined variable: row
File: /home/ahaforum/public_html/Sources/Poll.php
Line: 553

same here... fix is to add "$row," at line 343... the function misses the variable-definition..
so it should look like this:

global $row, $txt, $user_info, $context, $topic, $board, $smcFunc, $sourcedir, $scripturl;


also in function "vote" at line 74..
and function "EditPoll2" at line 632..

or is the problem somewhere else? im not a coder..

You,  sir,  are awesome.

I went from 4 errors per member voting each and every time they voted down to 1...

This is the one remaining error I am getting:


http://www.x.com/index.php?action=vote;topic=5069.0;poll=423
8: Undefined index: voteComment
File: /home/ahaforum/public_html/Sources/Poll.php
Line: 208


You've made my live 75% better!  :)  THANKS AGAIN!

"Undefined variable" means.. the variable is not defined... easy, he? =)
so just define it... this works in every php file where you get "Undefined variable" error.. (i think so)

since im still not a coder.. i don´t know what "Undefined index" is..

Quote from: GodKnightX on November 08, 2012, 02:39:10 PM
Is it possible to use this feature when i want to add a new poll to an existing thread?
Because currently doesnt work, just when i create poll with thread, but alone no :(

I hope the author or somebody add this feature in the future.

Edit: Nevermind i edited it for myself :)

How did you fix?? as I'm sure other's would love to know (like myself :3)

I know, its realy realy old. But i cant found a "better" Plugin.
http://www.x.com/index.php?action=vote;topic=5069.0;poll=423
8: Undefined index: voteComment
File: /home/ahaforum/public_html/Sources/Poll.php
Line: 208

You can set all errors to "0". This message is a indexfailure because "voteComment" ist not set. Thats what i know, but i dont know how to set it empty and correct "shouldbe something with "isset" but i cant get it to work).

I you set in the beginning of "poll.php" this -> "error_reporting(0);" you should not see this index-message again.

Hey folks, glad to see community activity on this mod... I was in the midst of resettling after a relocation.  I am going to work on a maintenance release over the next few weeks.  I will incorporate all community contributed fixes also and I will try to address any feedback that is submitted.  So if you have anything more, or any feedback, now is the time!

Quote from: Ray Cardillo on January 26, 2013, 03:51:28 PM
Hey folks, glad to see community activity on this mod... I was in the midst of resettling after a relocation.  I am going to work on a maintenance release over the next few weeks.  I will incorporate all community contributed fixes also and I will try to address any feedback that is submitted.  So if you have anything more, or any feedback, now is the time!

Seems to work pretty good.... background errors aside.  I have noticed that the comments area will sometime now include the date...(I am guessing causing or the effect of one of the errors that are thrown).

One suggestion... allow visibility to be changed during edit... currently once you post a poll... if you,  say,  forget to turn ON visibility (so people can see the actual votes, etc).... too bad... the option to turn on/off is grayed out while editing.

Another suggestion:  It would be freakin' KILLER if you incorporated the SMF Graphs capabilities in to polls.  Perhaps that would be for a different mod as that is beyond the specific focus of this one... but a nice selectable pie/bar graph of the current votes would be awesome...

I have just published a maintenance release and I will consider any new features in the future.  However, it's unlikely that I will do anything other than basic support if nobody donates to the organizations that this mod was created to benefit.


The (1.02) maintenance release includes:


Bug Fixes:

• Full support for alternative database prefixes.  Apparently I had missed three database table references that were hard-coded as "smf_" instead of using the config variable... so that was really easy to hunt down and resolve.
• Errors first reported by FrizzleFried (in the error log) are all resolved.  The errors being reported were minor bugs mostly having to do with voting or editing polls that were configured not to allow any comments.  The fixes suggested previously were not technically correct (although they would appear to eliminate errors).  I hunted down each one, reproduced, corrected, and tested.
• Could not change visibility when adding a new poll to an existing topics.  This is now fixed.  This ended up being a bug in the code that prohibits changing visibility after the poll is created.  See notes below for more details.

Updates:

• Verified to work with SMF 2.0.2 and the latest SMF 2.0.3 update.
• jQuery updated to the latest stable release (1.9.0).
• tablesorter updated to the latest stable release (2.0.5).

Languages:

• German UTF8 Translation (provided by Inti31).
• Polish UTF8 Translation (provided by Greybrow).

Important Notes:

• I have no intention to implement or support integration with multi poll mods.  The way mods work would make it difficult (but not impossible) and the folks I did this for aren't seeing any donations yet, so I have no motivation to work on features like that until SMF itself supports that feature... if it ever does... because most people are fine with having one per thread.
• The mod purposely disables changing voter visibility after a poll is created because people might vote differently if they know their results are going to be PUBLIC, DISCRETE, or PRIVATE.  I don't want to create a mod that would allow people to violate that implicit trust so easily.
• I have not yet been able to reproduce the problem reported where a date appears in the comment field.  If anyone notices this in the future, please try to provide as many details as possible.  Otherwise, the only thing I can think of is that one of the "manual modifications" caused this, or perhaps someone put a date in the comment field when they voted.

Thank you for tackling these issues!

Thanks man - thats great


Hm? How to update? Install via package manager ?

Quote from: sun-man on February 04, 2013, 03:58:59 AM
Hm? How to update? Install via package manager ?

Installing or upgrading via package manager is the easiest approach.  The readme will provide full instructions for install and/or upgrade.  Read them carefully and follow them completely and it should be really easy to do.

The only complication would be if something was modified by hand after the previous install, but even then, I provided some advice for that situation as well.

Ray this is a nice mod but there's one little thing missing for us to be able to use it.  We need the administrators to be able to change the visibility setting after a poll is posted.

Is this something I can change with simple changes in the code ?

I doubt it would be a simple change; it was specifically written not to allow that.

Quote from: EricGagne on March 10, 2013, 10:39:55 AM
We need the administrators to be able to change the visibility setting after a poll is posted.

This is something people ask about every now and then but I've refused to provide this feature because of what it implies.  I state this limitation in the details for the mod, but maybe explaining the use case a little more would help (see scenarios below).  What it comes down to is that it's a really bad practice once you think about what it implies, so my answer to this request has always been that it's better to delete the poll and ask people to vote again.  This assumes you're asking for the feature to help someone correct a mistake.  In that case, the visibility is either going from more public to less, or from less public to more, and in either case, the voters deserve to have a chance to vote again knowing what the new visibility is (because people often vote differently based on the visibility setting).

Here are the two most relevant scenarios I was faced with when doing usability testing with the community I developed this for...

Scenario #1 (Less Visible -> More Visible):
People who voted in confidence were really upset that their votes were suddenly made available to a larger audience than they originally intended.  They felt that their privacy (or anonymity) on a sensitive topic was violated.  In some cases, they would have voted differently based on the visibility.  When I realized the problem this presented, I came to the conclusion that I wasn't even going to allow this capability as an optional feature, because I didn't want people to have their trust in this mod being so easily violated by an admin.

Scenario #2 (More Visible -> Less Visible):
I considered allowing this case because it's not as dangerous as the former case, but the problem is, that we just have a different spin on a similar problem.  It's again the case that people vote differently based on the visibility of the vote.  The only difference is that in this case, they don't get particularly upset that their vote was revealed, but rather, upset that they would have voted differently if they knew the visibility was more restricted.

So basically, after thinking about these two cases, I came to the decision that I wasn't going to try to support any variant of a feature like that because it would be difficult to do in a way that doesn't introduce complexity or make it easy to violate voter's trust.  Again, a feature like that would have very little value overall (because a better solution is to just republish the vote with the new visibility setting)... so I would encourage you (and anyone else reading this) not to hack the mod or suggest how to hack the mod to implement the feature.  It's not terribly difficult... it's just wrong to do and people will hate you for it (or hate an admin for doing it).  ;)

Hope that explains this issue better for all who have asked about it.

One last thing...
I would consider implementing this in a way that just wipes out all the votes (and warns first)... just for convenience... but that's not really what people are asking for.  I'm also not feeling particularly motivated to be working on new features lately because I don't think anyone who has downloaded the mod has actually donated to the organizations I created this for the benefit of.  ;)

Ray I had a very good reason for asking this.  We run a private forum for board members of a sport federation.  Once a week we have a period of 24 hours where board members can propose resolutions on which we vote.

We need to account for who voted or note because there's consequences for those who miss too many votes.  Since any member of the board can post a poll, I need to make sure that the vote visibility setting is always the same.

It's really not such a big deal since our secretary is an admin on the forum and will always be able to view who voted.   I would just have liked to ensure consistency.

Okay, I appreciate the input, because understanding the use case helps me figure out what features people want to see in the future.  I kinda see where you are coming from, but for now, you will just have to educate everyone on what they should be doing (and why).

From your use case though, I can see a need for a feature that allows you to lock or limit visibility settings somehow.  For example, you might be better served by a feature that allows an admin to "lock" the visibility for a particular board by setting it to a certain value.

That should be good enough to satisfy what your use case is right?  That way all posts to that particular board would always have a certain (admin selected) visibility setting.  I can see a feature like that being somewhat useful to some folks.  However, I will not have time to implement that anytime soon... too much going on... and I'm gathering up details on a few other requests that have been made.

Perhaps you could change it so that visibility is turned ON by default rather than OFF?  My users complain when it's turned off ... which being by default ... happens a lot.

I am still seeing this error once in a while...

Quote
http://www.<removed>.com/index.php?action=votelog;topic=2011
8: Undefined index: poll
File: /home/ahaforum/public_html/Sources/VoteLog.php
Line: 79

Just a FYI...

I'd also like very much if this mod was compatible with this (http://custom.simplemachines.org/mods/index.php?mod=1586) mod.

Another suggestion: It would be nice to be able to pre-configure a poll and set the exact date and time the polling starts and ends. In my organization we do democratic decisions by using these polls and we would need a way to specify those exact times. The results should of course stay visible also after the end time.

Hello,

I just installed this mod, and have a slight issue.

The mod seems to be working perfectly, but i have a black background forum with White font.

When i look at the mod results, the font is all in white, and so is the window that opens to show who voted what, so i cant see the results, unless i highlight the names in the fields.

Is there any way to change the background colour of the tables at all? Or the colour of the font for just that page?

Thank you

Doc

I will have to see what I can do about that in the next release.  In the meantime, you will have to hand edit the CSS for that table to match the style on the rest of your site.

The vote results table uses a special component (jQuery Tablesorter) and the CSS that I created as part of this mod will be located in the Themes directory (...\Themes\default\css\votelog.css).  That's what you'll need to hand edit (make sure you CTRL-F5 refresh to force browser to see the changes).

I'm not entirely sure about all the colors you will need to change, but a quick review of their documentation (http://tablesorter.com/docs/) should put you in complete control of getting all of the colors exactly as you would like.

Also take a look at the CSS examples they have on that documentation page (look for the "Themes" section) and then look at the CSS on the theme you're using on your SMF site if you want to match color codes perfectly.

That should do the trick.  Hope this helps!!

That is awesome, thank you for that.

I finally got the time to look at this, sorry for the delay in responding.

I finally found what to edit.

You will need to manually search for the first line for these, do not copy and paste that into your find / search window, as i have changed it from the default settings, and / or the line you need is a few lines down in the code.


The code below edits the background colour of the Table Headings:

Search for:

table.votelog thead tr th, table.votelog tfoot tr th {


Find after, and change to desired colour:

background-color: #




The code below edits the background colour of the rest of the table:

Search for:

table.votelog tbody td {


Find after, and change to desired colour:

background-color: #




The code below edits the font colour of the rest of the table font:

Search for:

table.votelog tbody td {


Find after, and change to desired colour:

color: #




Thank you for pointing me in the right direction.

I hope this also helps others out that might be in the same boat :)

Have a problem with SMF 2.0.4, Default Theme, no errors during installation:

Inside the Log i can see only the date from the user who was voting at this day, when the Poll was publishing.

All other votes (from other days) i can read only "not available"

Somebody an Idea?

Hi

Im sorry, newbie question: How can I access the Vote Log results once I started the poll?

Ok from what I have read, there seems to be a button at the left of the poll which I can´t see. Therefore I cant have access to the voting log.

Im running the core theme, with SimplePortal. And the language is Spanish es.  May this be the problem? I mean the language?

Any help? ???

Hi,

im note sure where to ask and get an answer.

I have installed that mod and in 5 oder 10 times the "visibility" in the database is set to "private poll" (Voter visibilty in Database set to "0" instead of "2").

Any ideas about that?

After installing I get this error when I attempt to create a poll:

QuoteThe database value you're trying to insert does not exist: show_voters

So I jumped into the database, and what do you know but it does actually exist as a value but apparently doesn't recognize it. Tried a reinstall without errors, problem persists. Any idea how I can resolve it?

Ok, additional error found. Silly and nitpicky sure, but it is an error none the less.

The wrong word is used to describe the hidden nature. Discrete (http://www.merriam-webster.com/dictionary/discrete) is defined as separate and different from each other, discreet (http://www.merriam-webster.com/dictionary/discreet) is the one meaning not likely to be seen or noticed by many people.

I've been trying to find where it places the displayed text in the code to edit the word on my own site at least without success. Pouring through the mod files isn't helping me find it either. Where is that line of displayed text hiding?

I do not have the button that's supposed to show up so I can see who voted on what. Everything else seems to be working fine. Does anyone have any ideas? I am using a custom theme and am not opposed to manually changing things if need be.

in a fresh 2.0.9. install this mod does not install..

you have to edit mods-common.xml

$context['show_view_results_button'] = $context['allow_vote'] && (!$context['allow_poll_view'] || !$context['poll']['show_results'] || !$context['poll']['has_voted']);]]></search>

should be replaced by:
$context['show_view_results_button'] = $context['allow_vote'] && $context['allow_poll_view'] && !$context['poll']['show_results'];</search>

i tried to install the mod today (thanks for your hard work)
but there was an error with the display.php file and I cannot see who voted 

The voting and everything else works fine (2.0.9). Btw. Where can I find the mods-common.xml?

Thanks for this Mod,

but i can´t install it on a new 2.0.10 instalation. I got some failure:

./Sources/Display.php


Code: (Search) [Auswählen]

$context['show_view_results_button'] = $context['allow_vote'] && (!$context['allow_poll_view'] || !$context['poll']['show_results'] || !$context['poll']['has_voted']);



Code: (after add) [Auswählen]


// only show the view voters button if there is something worth showing that will not throw an error
$context['show_view_votelog_button'] =
$context['allow_poll_view'] &&
( allowedTo('admin_forum') ||
($pollinfo['vote_visibility'] == 2) ||
($pollinfo['vote_visibility'] == 1 && $user_info['id'] == $pollinfo['id_member'])
);


It is possible to update the mod?

Quote from: Rachelisit? on June 20, 2014, 09:36:52 PM
I've been trying to find where it places the displayed text in the code to edit the word on my own site at least without success. Pouring through the mod files isn't helping me find it either. Where is that line of displayed text hiding?

OMG... this is a great catch!!  My Computer Science mind made me type DISCRETE automatically.  Unfortunately this will not be an easy fix, because it involved DB tables, etc.  However, I do agree that it's important.  I'm going to be updating this mod soon to be compatible with 2.0.9+ so I'll test this upgrade also.

I'll have a fair amount of testing between all the little things though.  Regarding that other problem, I would assume it was DB permissions since you confirmed that all else was well.

I just uploaded a new release.  See release notes below.

• 2.1 - Updated to be compatible with latest SMF and other minor updates
  
  • Added support for SMF 2.0.9-2.0.11 (only verified against 2.0.11).
  • Updated jQuery library to latest stable release.
  • Corrected visibility label from "DISCRETE" to "DISCREET".
  • Changed default visibility level to PUBLIC based on user feedback.

Quote from: azirion on August 12, 2013, 02:23:50 PM
Im sorry, newbie question: How can I access the Vote Log results once I started the poll?

It's probably too late for this reply, but just in case someone else stumbles upon it, please read the release notes carefully.  This mod was fully tested against most releases from SMF 2.0.2-2.0.11 and I cannot reproduce any of the weird problems people have reported (and I've tried).

Some quick notes to review:

• If you have a custom theme or another mod that changes anything around polling features, that could interfere with this mod (or any other mod for that matter).
• The View Votes button is not always displayed.  Only some people are allowed to see who voted for what (the vote log) depending on permissions.  Nobody can see the vote log for a PRIVATE poll, (except an admin - who can always see the vote log).  Next, if it's a DISCREET poll then only the creator can see the vote log (no others can).  Finally, if it's a PUBLIC poll, everyone is allowed to see the vote log.  The button is not displayed if you don't have the right permission according to this logic (and it's protected at the database layer as well).

Is it possible to get the comments to show up as a regular post?

Hello. It is there any way to can see just who voted, not how voted a member? To be just the member name not which option he voted for ? Or to can choose between those 2 options ? Most of the time it si ok to see how someone voted, but sometimes that should be secret.
Thank you.

Hi, this mod gives me a HTTP 500 error and it's definitely caused by this mod - any idea why ?

it happens when adding a new topic or creating a poll.

EDIT: caused because of the coexistence with the "Vote polls with points" mod so i removed it and it's now fine !

I like this mod and the features it offers.
But why in the world has SMF such basic functions not implemented? That is so stupid.

Anyhow, I tried to install this mod and I need a helping hand now, because it clashes with my theme:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fabload.de%2Fimg%2Ferror1yzudx.png&hash=ce3699d9b31ba49c0ece6a757f4288b8e1d563ea)

I clicked on the edit icon and it shows me what it could not perform:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fabload.de%2Fimg%2Ferror2cus0j.png&hash=90e471819d0b62488c57e6dd34063785e8b03dca)

I took a look and all the lines read #edit_poll ul.poll_options

What shall I do now to get this mod working?
Simply overwrite and ignore?

Well, for one, we disagree with this being a basic, or even a desirable function...  imo, this should never be used on any site that I am a member of... and even if it was desirable, we can not and do not implement everything that everyone wants into the core. That is the whole purpose of mods.

However, to answer your question, it's CSS, so possibly not critical. But yes, as you not, your theme uses lists instead of dl o, apply it to the list, if you must

Quote from: Kindred on March 15, 2017, 10:29:30 PM
Well, for one, we disagree with this being a basic, or even a desirable function...  imo, this should never be used on any site that I am a member of... and even if it was desirable, we can not and do not implement everything that everyone wants into the core. That is the whole purpose of mods.

Right, this is a good point. There was a valid use case however. I was involved with a few communities that wanted this mod because there were many cases where the members wanted to be able to conduct closed polling of various sorts that were not entirely anonymous. So everyone participating in using this feature were always aware of the fact that they were doing something that was not completely anonymous but would only be visible to those who were granted access.

Regarding the original question, the way SMF mods are created can make it difficult to ensure compatibility when other mods or themes are installed because it's just based on pattern based insertions. In such cases, you just have to roll up your sleeves and work through it, and customize as needed.

Any chance of a drop in mod of this package for 1.1.21? Looks like a great app! On my site polls MUST be anonymous, but verified. This would really help the voting process and eliminate the need for members watching the polls 24/7 in order to try to extrapolate who is actually voting. This would really help!

Thanks in advance for any help you may be able to offer.

1.1.x is really only barely supported at this point. Instead, you should be looking to upgrade asap

Hi,
Anyone here to help me? i like this mod. but getting this error when users click on the view poll option.

https://name.org/index.php?action=votelog;topic=1258
8: Undefined index: poll
[b]Only show the errors from this file File:[/b] /home/tautalk/public_html/Sources/VoteLog.php
Line: 79


Please help. thanks

Hi folks. I recently wanted to install this mod on my version 2.0.15 forum, but found it errored out and would not install. Turns out it's pretty simple to fix, if you don't mind making minor changes to the mod's zip package. I now have it installed and working. It's pretty darn good.

I'd like to pass the changes on to the mod's author but from the dates on this forum, I'm not sure he's still around. Or, indeed, if the mod is still in use. Any pointers, folks? I can post the changes here if it's of value to anyone.

You cannot post a modified version of the mod.
However, you can post and share the changes you've made to make it work

I am trying to set up a small forum using SMF (2.0.15) and attempted to install this mod but on running the test got errors as attached.

Are these the same errors that you got, glassjaw?  If so, yes, I should be very interested in how you got it to work.

Many thanks.

John.

Quote from: JohnfromhereI should be very interested in how you got it to work.

https://wiki.simplemachines.org/smf/Error_in_mod_installation

Many thanks, Shambles.

I'll work my way through that and report back.

Cheers.

John.

Johnfromhere, yes those are the same errors. My apologies for not replying before now, I didn't see your post! I can take you through it if you're still interested

My question is also still unanswered, almost 3 years later :-/
https://www.simplemachines.org/community/index.php?topic=475722.msg3918584#msg3918584
Reply#84

your question *WAS* answered 5 1.2 hours after you posted it.

Quote from: Kindred on March 15, 2017, 10:29:30 PM
Well, for one, we disagree with this being a basic, or even a desirable function...  imo, this should never be used on any site that I am a member of... and even if it was desirable, we can not and do not implement everything that everyone wants into the core. That is the whole purpose of mods.

However, to answer your question, it's CSS, so possibly not critical. But yes, as you not, your theme uses lists instead of dl o, apply it to the list, if you must

Quote from: Kindred on March 25, 2020, 12:43:01 AM
apply it to the list, if you must

Apply what to which list?

the css list object....   

core SMF uses dl....   your theme apparently uses ul/li

So, since your theme is using non-standard layouts, you are going to have to manually apply changes -- definitely in the CSS regarding how polls are displayed and possibly in several places, even despite the success of the other code tests.

Oh, yes, that may actually be.

It is a very old theme that I like sooo very much: DarkModern by Crip
I doubt there are any updates to his themes anymore... for obvious reasons. He was a great guy!

Question:

At one time, you were able to sort the votes by any number of columns (example: I could sort by the poll choice results or by the voter).

Now, it appears that's no longer available. I'm presuming that is/was a function of this mod; but, somewhere in the upgrades that simple functionality went missing?

When you go to download it says Database error. Please contact the administrator.

https://custom.simplemachines.org/index.php?action=download;mod=3373;attach=245311

Quote from: KittyGalore on October 18, 2021, 10:51:21 AMWhen you go to download it says Database error. Please contact the administrator.

https://custom.simplemachines.org/index.php?action=download;mod=3373;attach=245311

Hmm...I just tried it and it worked for me! ???

Quote from: Shades. on October 18, 2021, 10:58:24 AM

Quote from: KittyGalore on October 18, 2021, 10:51:21 AMWhen you go to download it says Database error. Please contact the administrator.

https://custom.simplemachines.org/index.php?action=download;mod=3373;attach=245311

Hmm...I just tried it and it worked for me! ???

I have tried other browsers and it works but doesn't for Chrome.

Ok hmm wierd! I just tried it in FF, Opera, Chrome & Edge and the download worked for all of those browsers. May have to clear out your cookies or update your browser maybe? Maybe somebody will chime in here in a minute that knows how to help! ;)

...any way this mod could be updated for 2.1.1?  I doubt the original author will be doing it though since his last post was from 5 years ago.


Like many features that we got used to in the 2.0.x version of our forum (thanks to mods!),  this functionality we find we miss (at least the ability to see who voted).

Checking back...  Even my management team is lamenting the lack of ability to see who voted or to make comments...

Mod author last posted here in August 2017. I would not hold my breath waiting for an update...

Hoping someone else would perhaps mimic/improve on the mod for 2.1.1... it's quite a nice addition for forums who use the poll option often.

Here is an attempt to modify this package to work on SMF2.1.1.

I have not extensively tested it, as I have no experience with how this package is supposed to work.

Those who had/have this package on SMF20x, please try this adaptation for SMF211.

(Make a backup of your site, of course.)

OK... first off... AWESOME!  Thank you for attempting this!

I followed the instructions...

The GOOD:

Everything about setting the poll up with the additional options appears to be there.

You can select whether to require a comment or allow a comment, etc.  All good.


The BAD:

When the poll displays... it displays as stock... there should be a VIEW VOTES button that allows you to see the additional fields (comment and who voted) etc... from my recollection.

OK I did notice that I failed to delete the .js file from the package.  So I did.  I then uninstalled the prior package... deleted... then attempted to install the updated package with the .js file removed.

I got this error:

Database Error
Invalid default value for 'timestamp'
File: /home/ahaforum/public_html/testsite/Packages/temp/database.php
Line: 44

You made mention of the "VIEW VOTES button" issue in post #6. I can try to troubleshoot (from the original package) why you don't have permission to see this button.

The package file 'database.php' is unchanged (from the original package).

Please examine your database directly, at the table log_polls, and determine the schema details for the column 'timestamp'.

It seems that table is the COMMENTS table that is generated when you add a comment...

It includes the two comments I made.

ScreenHunter 330.jpg

As you can see... timestamp is just a series of numbers. 

There is a change between SMF20 and SMF21 in how a package's 'database.php' file gets parsed.

One change I discovered is in the $column parameter array. Of particular note, the parameter 'null' is no longer recognized. It must now be
'not_null' => true-like, // the database engine defaults NULL
I'll work on the package adaptation, but you may want to compare your database schema with the column parameters in the package file 'database.php'.

I'm none-too-skilled at this stuff.  Just enough to get myself in to trouble.

This is a test site.  It may be simpler to just re-install.

:)

Something to keep in mind however is that my site was updated from 2.0.x where I had this mod installed.  That means that the current database that I am running has tables for this mod already established ...

...as to whether or not that is going to be a problem,  I have no idea.  I just figured I better put it out there.

:)

Here is a slightly changed adaptation. (Cannot edit my previous post to detach the file.)

Having these columns already present -- I see no worries as the SMF code handles that scenario.

Will I need to re-install SMF to test or will these changes allow me to install with the current database?

FWIW I won't be able to test for a couple hours regardless as dinner is coming up and I we have a guest coming over.

Based on your response when I return I'll either make the necessary changes and install or remove the current SMF test site I have and install a new one THEN install the new version of the mod.

:)

Thank you again for tackling this...

Examining your database directly, look at the table details for the table 'polls'. The columns 'vote_visibility' and 'allow_comments' should have Allow NULL not checked and have a default value of '0'.

Then look at 'poll_choices'. The column 'requires_comment' should have Allow NULL not checked and have a default value of '0'.

If these columns are not already set this way, these incorrect settings may have existed from the first time this package was installed.

(phpMyAdmin may show NOT NULL instead of Allow NULL.)

Nope. This one. (I wish I could edit my previous post.)

I think I caught them all. (Hope?)

OK... used last change above...

...and I get this error when I attempt to install:

1. Adapt Database database_211.php File not found

EDIT: Wait... I just followed the txt file which didn't mention the database.211.php file that i noticed was sitting there so I just moved it over and included it int eh package...trying again.

:)

Yeah... I am doing something wrong or have done something wrong as I am getting a HTTP error 500 every time I attempt to install the mod.  It simply will not install.

I figure I just might not quite know enough about WTF I am doing to be of service.  If anyone else who knows more than I willing to step up and help this guy out... that would be fantastic!!

:)

Oh My! I thought I was being smart.

I did not remove the original array element:
'null' => 'false',
which then causes problems in smf_db_change_column().

So, again...

Same situation.  I keep getting an error 500 when I attempt to install the package.
FWIW ... I just installed a fresh install of 2.1.1 and I am still getting that 500 error.

If the PHP processor is tied to the web server, then the web server could be sending a 500 ISE because PHP crashed (as well as something the web server didn't like when going about doing it's job - which might be logged somewhere else).

Still, if the error is actually a PHP error, there should be an error logged somewhere.

If not SMF's admin, Maintenance, Logs, Error Log, then maybe PHP is logging errors in a file named 'error_log' in the root directory of this site.

FrizzleFried got the adaptation installation straightened out, and reports that the Voter Visibility package is operating as remembered when having used it with SMF20.

(If a moderator would please delete all of my prior file uploads.)

This one, I believe, will be the gold version to get the Voter Visibility package, originally for SMF2.0, to be adapted for SMF2.1.

(There *might* still be an issue when the package is uninstalled, but the databased data is retained, then an attempt is made to re-install, but I've tracked the code and can confidently place the blame on SMF code. There are some Github issues that discuss this.)

this is one reason why we do not usually allow (and never encourage) mods to be uploaded as attachments.

Technically the user is only uploading the instructions, not the mod itself :P (for anyone not following the disc)

Quote from: Diego Andrés on March 29, 2022, 04:14:24 PMTechnically the user is only uploading the instructions, not the mod itself :P (for anyone not following the disc)

true... but the same issue applies (???)  attachments of multiple versions

OK... following bsmithers instructions I have this mod up and running about 99%.  Everything seems to work as it is supposed to EXCEPT I am getting these errors (which seem to have no affect on the user side)...

https://www.NOFOLLOW.com/index.php?action=votelog;topic=35166
 /home/ahaforum/public_html/Sources/VoteLog.php (Line 65)  Backtrace information

Type of error: General
Error messageSelect
8: Trying to access array offset on value of type null
Backtrace info:

#0: smf_error_handler()
Called from /home/ahaforum/public_html/Sources/VoteLog.php on line 65
#1: VoteLog()
Called from /home/ahaforum/public_html/index.php on line 187
https://www.NOFOLLOW.com/index.php?action=votelog;topic=35166
 /home/ahaforum/public_html/Sources/VoteLog.php (Line 65)  Backtrace information

Type of error: Undefined
Error messageSelect
8: Undefined index: poll
Backtrace:

#0: smf_error_handler()
Called from /home/ahaforum/public_html/Sources/VoteLog.php on line 65
#1: VoteLog()
Called from /home/ahaforum/public_html/index.php on line 187
Seem related being both are generated at the same time.  Both also are related to viewing the Vote Log (part of the mod).   I BELIEVE they are related to permissions for viewing said vote log... as the error is NOT generated if I choose the option to make the vote log available to all.

bsmithers has done so much to get this mod working with 2.1.x ... and this is just a very tiny things that pops up semi-rarely on the log... but it would be nice to track down,  squash,  and be able to say "Follow these directions and you can get this mod running 100% on 2.1.1...)

Oh... here is the code in question...

// This is almost the same as the code in Display.php because you should not see voters if you cannot see the poll
60: // You're allowed to view the results if:
61: // 1. you're just a super-nice-guy, or
62: // 2. anyone can see them (hide_results == 0), or
63: // 3. you can see them after you voted (hide_results == 1), or
64: // 4. you've waited long enough for the poll to expire. (whether hide_results is 1 or 2.)
==>65: $context['allow_poll_view'] = allowedTo('moderate_board') || $pollinfo['hide_results'] == 0 || ($pollinfo['hide_results'] == 1 && $context['poll']['has_voted']) || $context['poll']['is_expired'];
66: $context['poll']['show_results'] = $context['allow_poll_view'] && (isset($_REQUEST['viewresults']) || isset($_REQUEST['viewResults']));
67: $context['poll']['question'] = $pollinfo['question'];
68: $context['poll']['is_locked'] = !empty($pollinfo['voting_locked']);
69: $context['poll']['vvis'] = $pollinfo['vote_visibility'];

What's line 65 of that file? The error references an undefined index error. Which means there needs to be a slight change in the code. Most likely, if it works as expected, there just needs to be a check to make sure it's set.

The script is trying to access $someVar['poll'] with poll being the index. May just need a isset($someVar['poll']) but it's hard to say without seeing it.

Quote from: Joey Smith™ on April 27, 2022, 11:59:29 AMWhat's line 65 of that file? The error references an undefined index error. Which means there needs to be a slight change in the code. Most likely, if it works as expected, there just needs to be a check to make sure it's set.

The script is trying to access $someVar['poll'] with poll being the index. May just need a isset($someVar['poll']) but it's hard to say without seeing it.

I posted the code above.  The specific line in question (65) reads:

==>65:      $context['allow_poll_view'] = allowedTo('moderate_board') || $pollinfo['hide_results'] == 0 || ($pollinfo['hide_results'] == 1 && $context['poll']['has_voted']) || $context['poll']['is_expired'];

so, the problem would appear to be this...

$context['poll']['has_voted']) || $context['poll']['is_expired'];

I figured it was close to that.  As to how to FIX said problem... err...

I wonder what happens if I simply REMOVE that code (being I can't find what it's doing negative to the mod anyway to be honest... again,  I think it has something to do with whether or not to allow someone to see that page.)

Can you attach that file to your next post please. The more important question at the moment is "why" is $context['poll'] undefined? Because if $context['poll'] is undefined then so is the conditions that the mod author is trying to check against in that series of checks. I got an idea of how to fix it  but I would like to check on something else before I suggest it.

Quote from: FrizzleFried on April 27, 2022, 01:41:48 PMI figured it was close to that.  As to how to FIX said problem... err...

I wonder what happens if I simply REMOVE that code (being I can't find what it's doing negative to the mod anyway to be honest... again,  I think it has something to do with whether or not to allow someone to see that page.)

Its checking, or should I say its actually setting the value of which will be used to determine whether its displayed or not.

I am happy to report that between bsmithers work (posted earlier) and some work by Joey Smith... the Voter Visibility mod is up and working 100% (dare I say) on my live forum.  I am working on complete instructions to get this mod to work for you.

Want Voter Visibility to work with your 2.1.x forum?  Follow these instructions...

I have at least nine different edits of this mod... and I am not the most organized of individuals so after some internal debate I've decided to list all the edit differences between the version available here and the final version that I have working on multiple forums.  I figured that would be the best way to make sure you get the correct edits, etc.  These edits include work primarily from bsmither (there is a post above with his edits attached),  but member Joey Smith also jumped in and helped out with a few edits to get the final errors the mod was generating handled.

I've tested this mod pretty thoroughly on both a sandbox and live site with success... I am not sure what the legality issue is with my offering up the already edited files people could simply drop in to their current installations is... but if it's at all possible,  please let me know and I'd be happy to either post here or even host said files with said edits already done.  If that can't happen... it's been demonstrated that posted edits are OK... so here you go:


(1) Download the votervisibility-2.1.zip file from the packages tab here: https://custom.simplemachines.org/index.php?mod=3373

(2) Unzip the file.  It will create a folder called votervisibility-2.1.  Within that folder you will find a Sources folder,  a Themes folder and some files.  We'll start from top and work our way down.

(3) Load up Notepad ++ (or whatever editor you use) and make the following edits:


FILE: Sources/VoteLog.php

    // the table needs some special sauce
    $context['html_headers'] .= '
    <link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/css/votelog.css" />
    <script language="javascript" type="text/javascript">
    if (typeof jQuery == "undefined" || jQuery.fn.jquery != "1.11.3") {
        // if we do not already have jQuery 1.11.3 loaded then load using Google CDN (better for caching, less bandwidth, etc).
        document.write(unescape("%3Cscript language=\'javascript\' type=\'text/javascript\' src=\'http://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js\'%3E%3C/script%3E"));
    }
    </script>
    <script language="javascript" type="text/javascript">
    if (typeof jQuery == "undefined" || jQuery.fn.jquery != "1.11.3") {
        // if we still do not have jQuery 1.11.3 loaded then load the locally deployed version as a backup.
        document.write(unescape("%3Cscript language=\'javascript\' type=\'text/javascript\' src=\'' . $settings['default_theme_url'] . '/scripts/jquery-1.11.3.min.js\'%3E%3C/script%3E"));
    }
    </script>
    <script language="javascript" type="text/javascript" src="' . $settings['default_theme_url'] . '/scripts/jquery-tablesorter-2.0.5.min.js"></script>';   
    loadCSSFile('votelog.css');
    loadJavaScriptFile('jquery-tablesorter-2.0.5.min.js');
    addInlineJavascript('$(document).ready(function(){$("#voteLogTable").tablesorter({sortList:[[0,0],[2,0]]});});',true);

    $context['allow_poll_view'] = allowedTo('moderate_board') || $pollinfo['hide_results'] == 0 || ($pollinfo['hide_results'] == 1 && $context['poll']['has_voted']) || $context['poll']['is_expired'];   
    $context['allow_poll_view'] = allowedTo('moderate_board') || $pollinfo['hide_results'] == 0 || ($pollinfo['hide_results'] == 1 && isset($context['poll']['has_voted']) ? $context['poll']['has_voted'] : 0)  || ( isset($context['poll']['is_expired']) ? $context['poll']['is_expired'] : 1);

FILE: Themes\default\css\votelog.css

#edit_poll dl.poll_options dd {
    padding: 0 0 .25em 0;
}


REMOVE THE FILE: Themes\default\scripts\jquery-1.11.3.min.js


FILE: Themes\default\VoteLog.template.php

    <th style="text-align:center; halign:center; width:5em;">', $txt['poll_vv_vlog_th_choicenum'], '</th>                   
    <th style="text-align:left;  halign:left;  width:3em;">', $txt['poll_vv_vlog_th_choicenum'], '</th>   
    <td style="text-align:left;  halign:left;"><a href="', $memberurl, '" title="', $txt['profile_of'], ' ', $votelog['member_name'], '">', $votelog['member_name'], '</a></td>   
    <td style="text-align:left;  halign:left;"><a href="', $memberurl, '" title="' . sprintf($txt['view_profile_of_username'], $votelog['member_name']) . '">', $votelog['member_name'], '</a></td>
            <script language="javascript" type="text/javascript"><!-- // --><![CDATA[
                $(document).ready(function() {
                    $("#voteLogTable").tablesorter( {sortList: [[0,0], [2,0]]} );
                });
            // ]]></script>
Create a new file in your editor and post the following code then save it as database_211.php in the root folder of the Voter Visibility mod (same folder that has the license.txt and readme.txt, etc.)

<?php

global $db_prefix, $smcFunc;

$smcFunc['db_add_column'](
    '{db_prefix}polls',
    array(
        'name'    => 'vote_visibility',
        'type'    => 'tinyint',
        'size'    => 1,
        'not_null' => true,
        'default'  => 0,
        'unsigned' => true
    )
);

$smcFunc['db_add_column'](
    '{db_prefix}polls',
    array(
        'name'    => 'allow_comments',
        'type'    => 'tinyint',
        'size'    => 1,
        'not_null' => true,
        'default'  => 0,
        'unsigned' => true
    )
);

$smcFunc['db_add_column'](
    '{db_prefix}poll_choices',
    array(
        'name'    => 'requires_comment',
        'type'    => 'tinyint',
        'size'    => 1,
        'not_null' => true,
        'default'  => 0,
        'unsigned' => true
    )
);

$smcFunc['db_add_column'](
    '{db_prefix}log_polls',
    array(
        'name'    => 'timestamp',
        'type'    => 'int',
        'size'    => 11,
        'not_null' => false,
        'unsigned' => true
    )
);

$smcFunc['db_add_column'](
    '{db_prefix}log_polls',
    array(
        'name'    => 'comments',
        'type'    => 'text',
        'not_null' => false,
    )
);

?>       
       
FILE: package-info.xml

</uninstall>   

</package-info>
</uninstall>   

    <install for="2.1.1 - 2.1.9">
        <readme type="file" parsebbc="true" lang="english">readme.txt</readme>
        <database type="file">database_211.php</database>       
        <require-dir name="Sources" destination="$boarddir" />
        <require-dir name="Themes" destination="$boarddir" />
        <modification format="xml" type="file">mods-2.1.1.xml</modification>
        <modification format="xml" type="file">mods-translations.xml</modification>
    </install>
   
    <uninstall for="2.1.1 - 2.1.9">
        <modification format="xml" type="file" reverse="true">mods-2.1.1.xml</modification>
        <modification format="xml" type="file" reverse="true">mods-translations.xml</modification>
        <remove-file name="$sourcedir/VoteLog.php" />
        <remove-file name="$themedir/VoteLog.template.php" />
        <remove-file name="$themedir/css/votelog.css" />
        <remove-file name="$themedir/scripts/jquery-tablesorter-2.0.5.min.js" />
        <remove-dir name="$themedir/images/votelog" />
    </uninstall>   

</package-info>
That should be it!  It looks like more work than it actually is to convert.  Please note that once you do convert that the mod will no longer be compatible with the 2.0.x version of SMF.  I would like to thank @bsmither for his hard work getting this mod to work with 2.1.x and for @Joey Smith™ for his work purging the final buggers remaining!  You both ROCK and my users and I appreciate the help!!


       

@FrizzleFried, thank you for your work. I acted according to the instructions, I received an error during installation "mods-2.1.1.xml - File not found" and the absence of a button to view the vote. I took this file from the attachment in the answer No. 130 of this topic and everything worked as it should.

I should like to install this mod on my 2.1.3 forum.
I am a little(!) confused by the last two postings (143 & 144) above.

Could someone out there tell me how to install it, ie do I have to edit with all the bits in 143 above - and is it the original package that I download from https://custom.simplemachines.org/index.php?mod=3373 and install?

Any help to this somewhat struggling bloke would be gratefully received.

Many thanks.

John.

I have now upgraded to 2.1.4

I attempted to install the mod as modified in posting 143 above and got the following:-

    1.    Adapt Database    database_211.php   
    2.    Extract Tree    ./Sources   
    3.    Extract Tree    ./Themes   
    4.    Execute Modification    mods-2.1.1.xml    File not found
    5.    Execute Modification    ./Themes/default/languages/Modifications.english.php    Test successful
    6.    Execute Modification    ./Themes/default/languages/Modifications.english-utf8.php    Skipping file
    7.    Execute Modification    ./Themes/default/languages/Modifications.german-utf8.php    Skipping file
    8.    Execute Modification    ./Themes/default/languages/Modifications.polish-utf8.php    Skipping file

Nevertheless, I continued with the install (on a test forum) and it appeared to install OK – however :-

It does not show the voters, simply the number and percentage of the votes cast.

I run a band and I set up polls to see who is available on a given date.  The overall number is pretty useless when I can't work out what instruments are available/unavailable!!

Has anyone any ideas please about how to get this mod running?

Many thanks in anticipation.

Cheers.

John.

well, I think this says it all...

Execute Modification    mods-2.1.1.xml    File not found

the xml to apply the mod in 2.1.x was not found in the package and so, was not applied

Quote from: Kira_ on December 13, 2022, 02:48:32 PMI took this file from the attachment in the answer No. 130 of this topic and everything worked as it should.

Thanks, Tyrsson.

I looked for the file (mods-2.1.1.xml) in post #130 on this thread but couldn't find anything.
(and I'd had a bad day!).

Having read it #130 again, do I uderstand it correctly that as it was an attachment to a post it got deleted?
If so, any idea how I can recover it?

Or have I got it all confused and wrong ::) ?

Thanks again.

Cheers.

John.

https://www.simplemachines.org/community/index.php?msg=4118133
still has an attachment

Thanks for that - it WAS a bad day ::) !

I think I must have been just reading this thread without being logged in - when, for some reason, the attachment doesn't show.

Anyway, thanks again and I'll try it again.

Cheers.

John.

I have installed it and it appears to be working fine.

Apologies for being a little bit thick!

Many thanks.

Cheers.

John.

Quote from: Johnfromhere on July 05, 2023, 04:39:05 PMI have installed it and it appears to be working fine.

Apologies for being a little bit thick!

Many thanks.

Cheers.

John.

We all have bad days ;)

As stated - I installed the Voter Visibility mod and it appeared to be working fine when I tested it.

I a now trying to use it and it still appears to be working OK but I am getting errors written to the Error log as under.

Any ideas please?

Many thanks.

John.

Quotexxxxxx
xxx.xxx.xx.xxx
ba566005bc498b5d261d911fd38a1371
https://xxxxxxxxxx.xx.xx/smf/index.php?action=votelog;topic=36
/home/xxxxxxx/public_html/smf/Sources/VoteLog.php (Line 79)
Backtrace information

Type of error: General
Error message Select
8: Trying to access array offset on value of type null
3
 
Sep 25, 2023, 06:01 PM
________________________________________
xxxxxx
xxx.xxx.xx.xxx
ba566005bc498b5d261d911fd38a1371
https://xxxxxxxx.xx.xx/smf/index.php?action=votelog;topic=36
/home/xxxxxxxx/public_html/smf/Sources/VoteLog.php (Line 79)
Backtrace information

Type of error: Undefined
Error message Select
8: Undefined index: poll
2
 
Sep 25, 2023, 06:01 PM