Simple Machines Community Forum

SMF Development => Feature Requests => Topic started by: Arantor on September 03, 2013, 07:16:27 PM

Title: Profile > View Posts > even in boards you can't see
Post by: Arantor on September 03, 2013, 07:16:27 PM
It always irked me that showing you posts in your profile was limited to boards you could see.

I propose the following change:
* if you are viewing someone else's profile, restrict it as normal to boards you can see (and thus you see the posts they made in the boards you can see, no privacy issues)

* if you are viewing your own profile, ignore the normal restriction, perhaps excluding only the recycle bin.

You wrote the posts, you should be able to see them as far as I'm concerned. The only thing you'd have to clean up would be the links at the top of the page where it lists board > topic, just make them non-links and add a message to the effect that they're in a board you cannot currently access.

You'd have to fix the search as well to be mindful of this (and that's no big feat) but at least showing you all your own posts would be nice.
Title: Re: Profile > View Posts > even in boards you can't see
Post by: live627 on September 03, 2013, 10:36:42 PM
I think someone did this (minus the search) to SMF 2.1 a while back. But I could be remembering wrongly.
Title: Re: Profile > View Posts > even in boards you can't see
Post by: Arantor on September 03, 2013, 10:38:44 PM
Nope, release-2.1 at least still has the old query in it for showing posts, i.e. checking query_see_boards unless the user is an admin. Maybe one of the other branches has it, I dunno, never entirely sure what's supposed to be in what branch because the descriptions don't really conform to what's actually going on with them...
Title: Re: Profile > View Posts > even in boards you can't see
Post by: emanuele on September 04, 2013, 04:57:58 AM
https://github.com/SimpleMachines/SMF2.1/pull/97

It was not included due to (in fact valid) concerns on how people (could) use posts in hidden boards (see last comment by Norv).
Title: Re: Profile > View Posts > even in boards you can't see
Post by: Kindred on September 04, 2013, 11:05:39 AM
hmmm.....

I understand Norv's comment (especially how we use some sticky posts in the team boards)
I'm not sure I agree though...     it seems simple enough --   if it's that sort of post, when a person has access removed, then either lock and unsticky the post or delete it (and make a new sticky, either way)
Title: Re: Profile > View Posts > even in boards you can't see
Post by: Arantor on September 04, 2013, 05:57:12 PM
Oh, I understand Norv's comments but I disagree.

If you made the post, you should be able to access it. If it's being modified, those modifying it should be aware that the person who wrote that post can still see *that* post.
Title: Re: Profile > View Posts > even in boards you can't see
Post by: emanuele on September 04, 2013, 06:03:00 PM
Yups.

And I think Norv agrees too, though it's probably more safe to do it in a major release and not in a minor (at least that was my interpretation).
Title: Re: Profile > View Posts > even in boards you can't see
Post by: ѕησω on September 08, 2013, 01:21:37 AM
Sounds good, but since the mixed reactions in this topic alone a setting should be available to be turned on or off.