Simple Machines Community Forum

SMF Development => Feature Requests => Applied or Declined Requests => Topic started by: Arantor on September 03, 2013, 07:24:19 PM

Title: Editing someone else's post
Post by: Arantor on September 03, 2013, 07:24:19 PM
There is a person around here that I have bawled at for editing my posts when they meant to press the quote button. (Accidentally, yeah, it happens. But repeatedly? It shouldn't happen.)

Anyway, when it last happened, I suggested a solution: if you're editing someone else's post, put a banner above the post editor to show that you're editing someone else's post rather than quoting, in the hopes that someone would notice it.
Title: Re: Editing someone else's post
Post by: kat on September 04, 2013, 08:58:38 AM
Done it, myself. (http://www.katzy.dsl.pipex.com/Smileys/blush2.gif)

Might even be good to have an "Are you sure you want..." popup...
Title: Re: Editing someone else's post
Post by: Suki on September 04, 2013, 11:00:33 AM
I implemented that option or a similar one, but I always thought it was somehow isolated, it felt that I was adding code for a single purpose and that it couldn't be used for anything else. I end up creating a small layer system but it was still pretty limited.

I thought about putting a PR for it but my code felt pretty much like a patch or just adding some code on top of another rather than felt like been part of the whole system.

Ultimately, I know I will end up re-writing the whole template system to either increment the layer system or at least add hotspots to "hook" code to it.

As for the quote / edit button, I prob would separate them, make them different from each other, maybe use a different combination of color for different buttons, associating a specific color to a specific action does wonders with people that somehow have problems with very similar options. Sadly, colors are traditionally left for themers which of course could simply decide to ignore the color combination.

And also I would put the delete button far away from the rest.
Title: Re: Editing someone else's post
Post by: Arantor on September 04, 2013, 05:59:29 PM
It really doesn't need to be a layer, it just needs to be a single echo statement, nothing more. At least in SMF's structure.

QuoteUltimately, I know I will end up re-writing the whole template system to either increment the layer system or at least add hotspots to "hook" code to it.

Do it. It needs it. The entire structure of SMF being monolithic templates is very bad. Make every content unit a template and display a list of them and then this becomes a template block too.

Using colour for splitting actions is usually bad, because pure colour recognition doesn't work for colour blindness, but sticking different icons works there.

It's also fine for the core thing to be changed up by themers. I'm advocating what I believe the core should do.
Title: Re: Editing someone else's post
Post by: kat on September 05, 2013, 07:54:11 AM
Approved. (Hopefully) ;)
Title: Re: Editing someone else's post
Post by: Antechinus on September 05, 2013, 06:30:38 PM
You do realise that the 2.1 theme buttons were deliberately redesigned to get around this whole edit-instead-of-quote problem? I've been talking about it for years, which is why I decided to do something about it as soon as I was able to.

Applying similar changes to 2.0.x themes would be equally easy. TBH I'm not sure why nobody does it.
Title: Re: Editing someone else's post
Post by: Arantor on September 05, 2013, 06:35:21 PM
Huh, I didn't actually look at that in 2.1 yet.

I did, however, notice that main posting buttons were reversed in order, icky icky icky forcing muscle relearning like that.
Title: Re: Editing someone else's post
Post by: emanuele on September 05, 2013, 07:02:33 PM
Quote from: Arantor on September 05, 2013, 06:35:21 PM
I did, however, notice that main posting buttons were reversed in order, icky icky icky forcing muscle relearning like that.
Tab is the way! :P
Title: Re: Editing someone else's post
Post by: Antechinus on September 06, 2013, 12:35:33 AM
Quote from: Arantor on September 05, 2013, 06:35:21 PM
Huh, I didn't actually look at that in 2.1 yet.

I did, however, notice that main posting buttons were reversed in order, icky icky icky forcing muscle relearning like that.

I didn't do that bit. That was someone else.
Title: Re: Editing someone else's post
Post by: emanuele on September 06, 2013, 12:29:47 PM
The other discussion is here: http://www.simplemachines.org/community/index.php?topic=510771.0
Title: Re: Editing someone else's post
Post by: Spuds on September 06, 2013, 06:15:54 PM
QuoteI didn't do that bit. That was someone else.
Since when were you afraid to throw anyone under the bus ... hell that was me  :P   Bwahhhhhahahahah, move da buttons, bwahhhahhahah
Title: Re: Editing someone else's post
Post by: Arantor on September 06, 2013, 06:26:31 PM
I don't really care who did, just someone please fix it!
Title: Re: Editing someone else's post
Post by: Arantor on November 10, 2013, 05:40:54 PM
So anyway, the main issue about posts getting edited unnecessarily has been rectified by way of making full edit (which looks the same as full post) harder to get at by accident.

I'm moving this to solved, as a result.