Link to Mod (https://custom.simplemachines.org/mods/index.php?mod=3904)
BETTER PROFILE MENU v2.8
By Dougiefresh (http://www.simplemachines.org/community/index.php?action=profile;u=253913) -> Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=3904)
IntroductionThis mod alters the main menu's Profile menu to bring all the functionality of the profile area to the main forum's menu bar.
This mod was inspired by tip provided by snow (http://www.simplemachines.org/community/index.php?action=profile;u=152526) in Lazy Admin Menu (http://www.simplemachines.org/community/index.php?topic=400767.msg2785613#msg2785613) in order to make it easier for the admin to navigate straight to where they want to go.
The only difference is that this mod built dynamically, so that any changes to the profile menu are shown immediately.
Security Issue NoticeIf you are running either
VERSION 2.0 or
VERSION 2.1, you are
STRONGLY URGED to stop using the mod immediately and upgrade to the latest version, which addresses a
MAJOR SECURITY ISSUE that has been resolved. All version 1.x and version 2.2+ mods are not affected by this security issue!
User SettingsUnder
Profile =>
Modify Profile =>
Look and Layout, there is a new option:
o
Better Profiles Menu settingEach user can set it to one of the following:
o
Completely Disabled => Exactly like this mod isn't installed :p
o
Enabled => Exactly like this mod before version 2.4.
o
Enabled with NoClick => Like Enabled, but clicking profile menu item only opens dropdown.
Translatorso Spanish Latin: Rock Lee (https://www.simplemachines.org/community/index.php?action=profile;u=322597)
Compatibility NotesThis mod was tested on SMF 2.0.12, but should work on any version of SMF 2.0.x. SMF 1.x and SMF 2.1 is not and will not be supported.
Evidentally, there was an error in the
SMF 2.0.11 to 2.0.12 that prevents the forum from properly caching serialized stuff longer than 4096 bytes long. This update fixes this problem, if it is present in your forum.
ChangelogThe changelog has been removed and can be seen at XPtsp.com (http://www.xptsp.com/board/index.php?topic=6.msg130#msg130).
LicenseCopyright (c) 2016, Douglas Orend
All rights reserved.
Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Awesome dude. Thanks for this. :)
Glad that my work on 2.1 inspired something good :)
I'd suggest backporting what 2.1 actually does but that would be hell for theme support.
Ask and thou shalt receive, eh?
Canine's gonads. :)
Apparently this mod and SMFPacks Shoutbox don't play nice together. Each time the shoutbox refreshes a bunch of errors are generated.
Care to share the error(s) so that they can be looked into?
Um, I'm not sure how to screenshot the errors without my board url and my IP showing. I'm willing to pm the screenshot to staff or the author if that would help.
Copy/paste would work too, then you can edit it out before posting.
Does this help? These errors just repeat over and over each time the shoutbox refreshes.
That seems like a bug in this mod because it probably should avoid running when $_GET['xml'] is defined.
Uploaded v1.1 - August 1st, 2014o Fixed errors generated by not having the Profiles language file loaded.
Thank you for the bug report, Steve!
Quote from: ‽ on August 01, 2014, 02:05:16 PM
That seems like a bug in this mod because it probably should avoid running when $_GET['xml'] is defined.
This mod makes direct modifications to the Subs.php file in order to affect the Profiles menu changes.
You betcha. :D
Edit: just installed it and it works a treat. :D
Hrm, I am not a fan of additional performance hit. :(
I'd use integrate_pre_include to add the file, the integrate_menu_buttons hook to run, and only do anything if !isset($_GET['xml']) to limit the workload.
There's still a problem. With this installed, then going into board view or whatever the view is called that list the topics you'll see this for the last post times:
Grammatical error edit.
Need to preserve $txt['time_format'] before loading Profile.<language>.php.
v1.2 - August 2nd, 2014
o Rewrote mod so that menu replacement takes place in Subs-BetterProfileMenu.php....
o Added in code to preserve the original language text during the hook call...
Cool beans. That fixed the timestamp issue and seems to be working hunky-dory. :)
Then again ...
If I hover over 'Profile' and go down to 'Look and Layout' and click it, I get these two errors without even doing anything:
I don't know why it says anything about wysiwyg since I have it disabled ...
That would appear to be the WYSIWYG Quick Reply mod since those are not present in a default installation.
You're probably right since I do have that mod installed. There are errors when I wanted to uninstall it so I'll have to do that manually which won't be tonight. :P
Manual (un)installation is never fun. Neither, FWIW, is building a large mod because of all the repackaging.
To uninstall, follow the installation sequence but do it backward. That way you won't get errors.
Just looked at WYSIWYG Quick Reply v2 (http://custom.simplemachines.org/mods/index.php?mod=1299) and I don't see how my mod has any relation to the errors you reported.....
So I started over with a completely clean install and installed ONLY that mod on the test forum. I found those errors as well. So it's not my mod doing them.... You probably wanna report them in the correct thread.... O:) Hope this helps....
Now I'm confused. You put only the wysiwyg mod and your mod on a test forum and got the errors. I don't see how that eliminates your mod as the one causing the errors. It just seems like a conflict between the two ... I have the wysiwyg mod with 41 other mods on my board and there are no problems. Putting yours on causes the errors.
I'm not trying to cast blame on who's right or who's wrong, I'm just trying to understand what you are saying. I use Firefox with a number of addons so I fully understand that there are going to be times when mods just won't work together and to me, this seems to be one of those times.
Sooo ... as the wysiwyg get was last updated 3 years ago, it seems to me that any newer mod that doesn't work with it should be designed to OR it should be noted what happens if a person has the other mod installed.
I can live with the errors if I want to, it's not a big deal. :)
Sure it does. If (SMF + mod + this mod) generates errors and (SMF + mod - this mod) also generates the errors, this mod is likely not the cause.
Mind you, the profile code is a labyrinthine mess.
Quote from: ‽ on August 03, 2014, 09:19:55 AMthis mod is likely not the cause
Most of the time, you're right. But if a mod is written so that it doesn't work seamlessly with another established mod, which is at fault?
It's never a simple answer. Sometimes it's one, sometimes it's another. Most mods are written in a vacuum and thus don't care about anything outside their realm.
In this case it's absolutely the other mod's bug. Since if you look at its parsing instructions, it declares multiple options:
0 => $txt['wysiwyg_quick_reply0'],
1 => $txt['wysiwyg_quick_reply1'],
2 => $txt['wysiwyg_quick_reply2'],
3 => $txt['wysiwyg_quick_reply3'],
4 => $txt['wysiwyg_quick_reply4'],
5 => $txt['wysiwyg_quick_reply5'],
6 => $txt['wysiwyg_quick_reply6'],
7 => $txt['wysiwyg_quick_reply7'],
But you'll notice some of those missing from the modifications language file:
$txt['wysiwyg_quick_reply'] = 'Choose Quick Reply Type';
$txt['wysiwyg_quick_reply0'] = 'WYSIWYG (with bbc buttons and smilies)';
$txt['wysiwyg_quick_reply2'] = 'WYSIWYG (with smilies only)';
$txt['wysiwyg_quick_reply3'] = 'WYSIWYG Only';
$txt['wysiwyg_quick_reply4'] = 'Non-WYSIWYG (with bbc buttons and smilies)';
$txt['wysiwyg_quick_reply6'] = 'Non-WYSIWYG (with smilies only)';
$txt['wysiwyg_quick_reply7'] = 'Non-WYSIWYG (standard)';
1 and 5 missing, same as the errors...?
Ah! Now I understand why in this case. Seems fixable ... or maybe not lol ...
@ dougiefresh - as I said, I wasn't trying to lay blame or disparage your coding or anything like that. Was just trying to understand the situation which Arantor explained so that I could.
For anyone else who runs into this problem, it can be gotten around as per:
http://www.simplemachines.org/community/index.php?topic=251436.msg3567423#msg3567423
Actually, my test case was only SMF + WYSIWYG Quick Reply v2 (http://custom.simplemachines.org/mods/index.php?mod=1299) mod, which resulted in errors. Better Profile Menu had not been installed on the test forum....
Quote from: ‽ on August 03, 2014, 09:19:55 AM
Mind you, the profile code is a labyrinthine mess.
Actually, this mod doesn't touch the profile code, only the
Subs.php section that deals with the Profile top menu....
Ah, I see. The profile code is still a labyrinthine mess though ;D There be dragons.
Awesome, always swearing at that menu for not having the look and layout option selectable without browsing another page. Huge thanks!
As an aside, should you happen to have BK's TopMenu (http://custom.simplemachines.org/mods/index.php?mod=3788) mod installed, this seems to work, with that, which is kinda groovy. :)
Quote from: Ninja ZX-10RR on August 06, 2014, 12:32:26 AM
Awesome, always swearing at that menu for not having the look and layout option selectable without browsing another page. Huge thanks!
I know, right? You're welcome!
Quote from: K@ on August 12, 2014, 06:47:21 AM
As an aside, should you happen to have BK's TopMenu (http://custom.simplemachines.org/mods/index.php?mod=3788) mod installed, this seems to work, with that, which is kinda groovy. :)
Awesome, even better! Although it would be very cool to have something like 2.1's bar with the profile and stuff on it, TopMenu seems to have it pretty much covered.... (Maybe someone should suggest it to the author ;D )
Doing what 2.1 does is evil voodoo. Could not recommend >:D
Quote from: ‽ on August 12, 2014, 05:35:41 PM
Doing what 2.1 does is evil voodoo. Could not recommend >:D
Well, it's just a thought.... I know: major pain to do so....
Yup, there's an AJAX call and a template and some utter wrangling inside the profile permissions area, not least because I changed certain things in the heart of 2.1 about the profile.
Is this compatible with the Ultimate Profile mod? It would be nice if it added in a link to the UP settings directly into the menu.
I'm nervous to test installing this because I don't want to end up manually uninstalling anything...
At least TRY to do it before complaining?
Quote from: [email protected] on October 15, 2014, 12:49:27 PM
Is this compatible with the Ultimate Profile mod? It would be nice if it added in a link to the UP settings directly into the menu.
With version 1.3 of the Better Profile Menu, it will be....
Quote from: [email protected] on October 15, 2014, 12:49:27 PM
I'm nervous to test installing this because I don't want to end up manually uninstalling anything...
No worries. This mod is completely hook-based, meaning no alterations are made to the source files...
Uploaded v1.3 - October 15th, 2014
o Added support for Ultimate Profile (http://custom.simplemachines.org/mods/index.php?mod=1675) mod
Can you tell me the edits you have done? I have severely customized this mod and I wouldn't really like to uninstall/reinstall it >_<
thanks in advance dougie, as always. :)
Send me your copy of Subs-BetterProfileMenu.php and lemme see what I can do.....
*attached* thanks again for your kindness dougie, as always. :)
I assume the changes regarding Bookmarks in the profile supports this Bookmarks (http://custom.simplemachines.org/mods/index.php?mod=864) mod, right?
Yes, that's a custom snippet (and furtherly fixed by me) originally made by br360 in the relative support thread :)
Uploaded v1.4 - October 15th, 2014
o Added support for the Bookmarks (http://custom.simplemachines.org/mods/index.php?mod=864) mod.
o Minor Profiles menu changes made, originally done by Ninja ZX-10RR (http://www.simplemachines.org/community/index.php?action=profile;u=394309)
@♦ Ninja ZX-10RR ♦: Thanks for confirming the mod. I liked the reorganization of the Profiles menu that you did in Subs-BetterProfileMenu.php, so I integrated the changes into the mod, with a few more changes to make sure that the bookmarks text string is present because trying to use it. Thank you!
Oh, cool! :D so can I just uninstall it and reinstall it back with the latest version? :D
Very glad that you liked them!
Do note though that the custom snippet is NOT added by default with the my bookmarks mod, it's custom and it needs another piece of code (regarding that other mod) to be edited in order to work like that ;) I reiterated just to be sure :)
Except it doesn't work to me, even editing it I can't get it to work again without restoring the previous file >_<
@Ninja: Damn.... I don't understand why it doesn't work. I'll try to fix it, but can you point me to the relevant post in the thread? Thanks!
Thanks very much for the updates! I will be giving this a test-drive...
Quote from: ♦ Ninja ZX-10RR ♦ on October 15, 2014, 02:10:17 PM
At least TRY to do it before complaining?
I usually do, but when people in the thread are talking about needing to manually uninstall I tread cautiously... Especially because I have done quite a bit of editing to UP, and needing to reinstall it would be a pain...
I wasn't aware that asking a question was considered complaining around here...
Quote from: dougiefresh on October 16, 2014, 05:17:42 PM
@Ninja: Damn.... I don't understand why it doesn't work. I'll try to fix it, but can you point me to the relevant post in the thread? Thanks!
Sure I can! --> http://www.simplemachines.org/community/index.php?topic=182923.msg3753227#msg3753227 this is the custom edit I had done there, and actually looking at the code I can't understand why it doesn't work either. I tried to reinstall the Bookmarks mod but with no luck, the only thing I could do is to just place the custom code back, the snippet you added seems to do absolutely nothing, which is weird to me. ???
Quote from: [email protected] on October 16, 2014, 05:24:13 PM
Thanks very much for the updates! I will be giving this a test-drive...
Quote from: ♦ Ninja ZX-10RR ♦ on October 15, 2014, 02:10:17 PM
At least TRY to do it before complaining?
I usually do, but when people in the thread are talking about needing to manually uninstall I tread cautiously... Especially because I have done quite a bit of editing to UP, and needing to reinstall it would be a pain...
I wasn't aware that asking a question was considered complaining around here...
We don't serve answers on a golden plate here, at least TRY to do things and if you encounter problems then we are glad to help but if you don't even try to do a thing then the message that we (and I mean "we" as a community) get is "I don't bother trying to install this, will it work? I won't provide any details of my forum configuration but I expect you to have mind-reading mod installed and to already know if it will work or not, and with which consequences."
Hope it clears things out a little bit dude ;)
Btw I really discourage you use your real email as a nickname because if some spammer bot manages to crawl it you will VERY much likely get seriously spammed in your inbox. And I don't think you would like it. The correct way to let other people know about your email address would be putting it in your signature in a similar way: mario[dot]rossi[at]youremailprovider[dot]com or something like that ;)
First off, thanks very much dougiefresh for the quick update! I have UP mod installed and it is working great with your mod. I did a little tweaking to adjust the sort order.
I also added the bookmarks mod, and for some reason the 'if' statement you implemented doesn't work. It was pretty simple to move the array definition out of the if statement, getting it to show up. The Ultimate Profile bit works fine though, so I'm pretty certain the issue is regarding (isset($txt['bookmarks']) is not returning a '1' or 'true'...
Ninja, chill out then go back and read my original post. Notice how I specifically stated: 'I'm nervous to test installing this because I don't want to end up manually uninstalling anything...', with regards to the post prior in which another member ended up with a mess he had to uninstall from this being incompatible with another mod.
I provided enough information about my forum to be relevant to my questions, which were quickly and precisely answered politely and without rudeness. I'm not sure where you are getting the 'mind-reading' or 'crazy expectations' bit from, lay off the drama, I asked about compatibility with a very commonly used mod.
Obviously dougiefresh wasn't so offended, he quickly implemented support for the ultimate profile mod and verified the mod was only hook-based. I am not sure what the prior posts were about regarding manually uninstalling edits.
Anyways, Thanks for the suggestion on removing my email...
Meh... I don't bother replying. Dougie you got any updates by chance? I ended up in editing it and putting the bookmarks array back in again XD also this gave me the insane idea to mess around with the menu and now I'm seriously freaking out with subs.php changing the order of the arrays every 5 minutes on average :rofl:
Uploaded v1.5 - October 17th, 2014
o Fixed stupid array mistake in Subs-BetterProfileMenu.php code....
o Removes Bookmarks tab from main menu and places it in the Profile menu....
@Ninja: Yeah, I figured it out. Turns out SMF doesn't like arrays within arrays for sub-buttons :P Found the bug when I outputted the array and looked at it in my browser's web developer mode.... I also implemented removal of the original Bookmarks menu from the menu bar.... I wonder if I should add an option to do this, though.....
@thelastlokean: You're welcome! I'm glad to hear that the UP modification works for ya! I think the prior posts about manual install were about a conflict between two mods. It was determined that my mod was not "at fault" for the conflict/errors....
As always
It worked :D I will have a look at what's the difference between the files because I backed it up before installing the latest version, it works like a charm ^^
About the my bookmarks option idk either... To me like this is just fine, it was already fine but I wanted to help you hunting the bug until you finally squashed it :D and with this update my to-do list here on sm.org gets even smaller. Thanks for the fix dougie it's always appreciated never forget it ;)
@Ninja: Thanks for the feedback.
@thelastlokean: The manual uninstall discussion actually had nothing to do with this mod, since the other mod was producing the errors. It often helps to read the entire thread to answer some of these questions :P
In case anyone is interested, version 1.0 of this mod was a direct integration into Sources/Subs.php. I can't speak about v1.1 because I lost my copy. v1.2 and above is a hook-based mod....
Had an idea and I actually implemented into my forum already, just wanted to share it with you since you have always been very kind to me :D
It is a little bit more complicated than it looks since the strings for the Drafts were already all in use (that's why I have set "draftsninja" as string-name XD) but I will show you my subs-betterprofilemenu.php maybe you will like it even more :D if not well I just share it, maybe someone is interested into it ;) I will add that edit to the relative support thread too (EDIT: just posted --> http://www.simplemachines.org/community/index.php?topic=246151.msg3757966#msg3757966). It is an interesting edit to me.
I will show you a screenshot of it, too.
You need to add the string to the relative drafts language file too, though, otherwise it would throw an undefined index and it wouldn't work properly with other languages.
Like this: /languages/drafts.{language}.php
?>
$txt['draftsninja'] = 'Drafts';
If you like it feel free to get inspired :) oh besides since there are 2 drafts mods, it's the most recent one.
Uploaded v1.6 - November 1st, 2014o Adds a few items to the Profiles instead just blindly replacing it.
Quote from: ♦ Ninja ZX-10RR ♦ on October 26, 2014, 11:21:22 PM
Had an idea and I actually implemented into my forum already, just wanted to share it with you since you have always been very kind to me :D
It is a little bit more complicated than it looks since the strings for the Drafts were already all in use (that's why I have set "draftsninja" as string-name XD) but I will show you my subs-betterprofilemenu.php maybe you will like it even more :D if not well I just share it, maybe someone is interested into it ;) I will add that edit to the relative support thread too (EDIT: just posted --> http://www.simplemachines.org/community/index.php?topic=246151.msg3757966#msg3757966). It is an interesting edit to me.
I will show you a screenshot of it, too.
You need to add the string to the relative drafts language file too, though, otherwise it would throw an undefined index and it wouldn't work properly with other languages.
Like this: /languages/drafts.{language}.php
?>
$txt['draftsninja'] = 'Drafts';
If you like it feel free to get inspired :) oh besides since there are 2 drafts mods, it's the most recent one.
I wish I saw that before I released v1.6.... I'll alter the mod later today....
Quote from: dougiefresh on November 02, 2014, 03:49:03 AM
I wish I saw that before I released v1.6.... I'll alter the mod later today....
Glad that you liked it :D
Uploaded v1.7 - November 2nd, 2014
o Added support for the Drafts (http://custom.simplemachines.org/mods/index.php?mod=1264) mod.
@Ninja: I found that the Drafts mod has a language file, and it's from there that I got the string to represent that mod....
Hmm I just noticed a little annoying thing.
If you use SimpleDesk then the previous versions were completely hiding the Helpdesk button in the profile view, in the newer ones it's just set in between the normal ones... I used this to get rid of it since I didn't want it - https://www.simpledesk.net/community/index.php?topic=1115.msg10695#msg10695 also because I wasn't able to reorder it...
So would an option to reorder the Profile menu and hide items in the Profile menu be helpful?
You can do it via code quite easily... The annoying thing was SimpleDesk in this case because it totally bypasses the arrays in the file ;)
Since nobody asked for it yet I think that the majority of users could go with editing the stuff via code but if you want to make a whole menu for that I guess it will be fine anyway, it just adds more chances to create unwanted bugs to me though, compared to the pros. An hide option... Lol again to me is quite easy to comment out or delete snippets, but I'm speaking for myself. Perhaps if there will be some people asking for it you could think about it...
This, all IMHO. :)
QuoteThe annoying thing was SimpleDesk in this case because it totally bypasses the arrays in the file
Hooks are a thing and more mods should use them. LevGal will do the same thing in the profile area though I don't plan to touch the main menu area for that one.
Don't get me wrong it's not a complaint it's that in this case it's not easy to tweak ;) you can deactivate it (like I did) or either leave it but in the place he wants to be in :P
Sure it's a complaint. People don't toss out the word 'annoying' for things they *like*.
I already stated that it's not a complaint to me, if you know better the way I feel about it then it's your call... This topic is for dougie's mod, not Simpledesk, if I have complaints about SimpleDesk I will post on the relative site (just the way I already did a few times - my only 2 complaints about it are the missing time query and the urgency stuff).
Quote from: ♦ Ninja ZX-10RR ♦ on November 09, 2014, 08:00:25 PM
You can do it via code quite easily... The annoying thing was SimpleDesk in this case because it totally bypasses the arrays in the file ;)
Since nobody asked for it yet I think that the majority of users could go with editing the stuff via code but if you want to make a whole menu for that I guess it will be fine anyway, it just adds more chances to create unwanted bugs to me though, compared to the pros. An hide option... Lol again to me is quite easy to comment out or delete snippets, but I'm speaking for myself. Perhaps if there will be some people asking for it you could think about it...
This, all IMHO. :)
Well, the reason that I changed the mod to add items to the Profile menu was that I found items added in my "upcoming-forum" site that were completely left out. So just adding the new lines fixes that problem. So if you don't need the sorting and/or selection feature(s), I won't bother with it.... (Honestly, those features would be a probably total *itch to write anyways.....)
I wouldn't bother either... Pretty sure you have much more important stuff to do ;) for instance I'm extremely busy with tweaking the themes :P I might redistribute some of them but I'm not sure about putting them on this site, I'm not fine with what happened and what happens here so perhaps I will stick to BurkeKnight site for that, still undecided. If anyone has suggestions is not just free, is invited to pm me :)
v1.8 - January 16th, 2015
o License change to Simplified BSD. No functionality change.
Hey Dougie, any chance of adding 'Show Topics' or 'My Topics' to this so it shows the threads a member has started?
Have we lost you Dougie?
Uploaded March 5th, 2015:
o Added some code to add "Topics" after "Show Posts" entry in the Profile menu
Life has been busy lately. Last week, I worked 90 hours over 8 days....
You're awesome dude. Thanks. :D
Edit: There's a serious problem. Got this error:
Parse error: syntax error, unexpected ''title'' (T_CONSTANT_ENCAPSED_STRING), expecting '(' in /home/steve/public_html/forums/Sources/Subs-BetterProfileMenu.php on line 51
And I didn't mean to sound pushy. That's a lot of hours. :o
Please redownload the mod. I've fixed the issue and don't feel like changing the version number. :-\ Thanks for the bug report, Steve!
@Steve: You can just replace the Sources/Subs-BetterProfileMenu.php with the one in the newest v1.9 copy of the mod. That'll fix the problem....
EDIT: No worries.... Just been away from the puter for a while :P
Works a treat now. Thanks Dougie. :D
You're welcome!
Uploaded v1.10 - June 12, 2015
o Fixed Sources/Load.php to properly deal with language reloading.
Installed without errors in 2.0.10
Thanks
THANK YOU SO MUCH FOR THIS NICE THING + the "better" Admin menu!
Greatly appreciated!
One request though: Can you include a sub-option "Show threads" (that the user created) WITHOUT listing the first post as SMF does by default?
That would make it perfect!
Quote from: SMiFFER on October 18, 2016, 02:39:15 AM
THANK YOU SO MUCH FOR THIS NICE THING + the "better" Admin menu!
Greatly appreciated!
One request though: Can you include a sub-option "Show threads" (that the user created) WITHOUT listing the first post as SMF does by default?
That would make it perfect!
Thank you! I believe that that feature was implemented in
version 1.9.... Does it not work?
a little late for me but i think that this type of mod makes the Admin interface more intuitive, a good mod bro' !
Quote from: dougiefresh on October 18, 2016, 06:18:07 PM
Quote from: SMiFFER on October 18, 2016, 02:39:15 AM
THANK YOU SO MUCH FOR THIS NICE THING + the "better" Admin menu!
Greatly appreciated!
One request though: Can you include a sub-option "Show threads" (that the user created) WITHOUT listing the first post as SMF does by default?
That would make it perfect!
Thank you! I believe that that feature was implemented in version 1.9.... Does it not work?
Errr read carefully what my actual question was. I wrote:
Can you include a sub-option "Show threads" (that the user created)
WITHOUT listing the first post as SMF does by default?
Quote from: SMiFFER on October 19, 2016, 02:17:47 AM
Errr read carefully what my actual question was. I wrote:
Can you include a sub-option "Show threads" (that the user created) WITHOUT listing the first post as SMF does by default?
Whoops..... You're right. I didn't read carefully. After thinking about this particular request, I'm not sure that this falls within the stated function of this mod, as this mod's function has been to alter the top menu's
Profile menu to expand upon it. However, it sounds like an easy mod to build, considering almost all the work has already been done within the profile source code. All that would really be left for writing such a mod is the new template and a minor function addition....
UPDATE: Try my new Threads Participated In (https://github.com/douglasorend/Threads_Participated_In) mod I just wrote..... I'll add support to this mod for that other one....
Uploaded v1.11 - October 19th, 2016
o Added support for my new "Threads Participated In" mod. (Mentioned in previous post)
Quote from: dougiefresh on October 19, 2016, 08:22:31 PM
...it sounds like an easy mod to build, considering almost all the work has already been done within the profile source code. All that would really be left for writing such a mod is the new template and a minor function addition....
Looking forward to that then
Quote from: SMiFFER on October 24, 2016, 12:13:07 PM
Quote from: dougiefresh on October 19, 2016, 08:22:31 PM
...it sounds like an easy mod to build, considering almost all the work has already been done within the profile source code. All that would really be left for writing such a mod is the new template and a minor function addition....
Looking forward to that then
It's been approved and is available here (http://custom.simplemachines.org/mods/index.php?mod=4121).
Sorry for pointing back to what I actiually wrote once more, but apparently I have to:
QuoteErrr read carefully what my actual question was. I wrote:
Can you include a sub-option "Show threads" (that the user created) WITHOUT listing the first post as SMF does by default?
So from the beginning my question was about showing the threads
THAT THE USER CREATED and not those where he participated.
Quote from: SMiFFER on October 30, 2016, 08:23:35 AM
Sorry for pointing back to what I actiually wrote once more, but apparently I have to:
QuoteErrr read carefully what my actual question was. I wrote:
Can you include a sub-option "Show threads" (that the user created) WITHOUT listing the first post as SMF does by default?
So from the beginning my question was about showing the threads THAT THE USER CREATED and not those where he participated.
(Sigh) Dammit, I wish I could read.... ::) O:)
Uploaded v2.0 - November 2nd, 2016
o Rewritten to use only hooks in order to gather the required information.
@Everybody: This update resolves several issues that I felt were easier to address with the mod being entirely hook-based, than how the current situation was.
Uploaded v2.1 - November 3rd, 2016
o Rewrote mod to better capture all profile items available to the user.
o Added hook to clear cached profile menu when Core Settings change.
@Everybody: Sorry about the quick update. I noticed that the profile menu wasn't showing as everything available to the user in the profile area, so I fixed it. Also added the hook (as mentioned) so that all profile menus are updated when Core Settings change....
if anyone is interested, this mod installs successfully even if the "My Posts" mod is on but remains inactive until you uninstall "My Posts".
this mod makes me wonder why SMF doesn't do this to all menu options by default.
again, a good mod indeed.
I can't seem to get this to work. After installation, hovering over 'Profile' just gives me 'Summary', 'Account Settings' and 'Forum Profile'. :(
Edit: In addition, in my SMFPacks shoutbox everyone's name becomes mine. No matter who shouts, it shows my name.
Quote from: aegersz on November 05, 2016, 04:43:22 PM
this mod makes me wonder why SMF doesn't do this to all menu options by default.
because crowding the main menu is a really poor user experience.
URGENT!!! STOP USING VERSION 2.0/2.1 RIGHT NOW!!!
I just got a report of a reproducible
MAJOR security issue, and it's a doozie:
Quote
Wanted to let you know I appreciate all the time you took to make the Better Profile Menu mod. I installed it (SMF 2.0.12) and it worked good. It was nice having the drop down in the profile fly out. But after I installed it I could not logout. Went to a different computer (my wife's) and logged in under a different normal user name and MY admin name and access came up! And then I could not log out of either account. Here's what I did to try and fix it....
* Renaming the Cookies on the forum
* Switched from Local storage of cookies to subdomain independent cookies
* Changed the default login cookie length from 60 minutes to 1 minute
* Changed the unused session timeout from 2880 seconds to 30
* Cleared all the cookies on my wifes computer
but it still shows her logged in as me and the moderator options available
* Emptied the File Cache in the Forum Maintenance
* Cleared the cookies from my computer
None of that fixed the logout issue. So I started uninstalling the last few mods I installed in the order I installed them. I had just installed your mod, Add Join Date, and Mention members. Removing them one at a time (Mention Members, Join Date and then the Better Profile menu), Each time I removed one I would try to logout. It wasn't until I removed the Better Profile Menu that I could logout. I reinstalled Mention Members & Join Date and the logout is still working. So I'm guessing it was a conflict in some of those mods and the Better Profile menu. Either way, I wanted to let you know what happened. This is in no way a knock on your mod. I think it was really cool and if it worked with my set up I would be running. Thank you for making the mod and have a great day.
The mod has been pulled from the Customization Site until the issue has been straightened out!
I'm at 1.7 (lol, pretty much customized all of it), is it affected as well?
Quote from: Ninja ZX-10RR on November 06, 2016, 08:52:17 PM
I'm at 1.7 (lol, pretty much customized all of it), is it affected as well?
No, just version 2.0 and 2.1!
Off-Topic: Mind attaching your
Sources/Subs-BetterProfileMenu.php? I'm curious to see what you did.... O:)
Attaching also Subs.php, by the size of it, it should already tell you something ;D I can't remember myself how much code I changed of that thing O:) I just know that it'd be a major pain to uninstall it, because of the way it works it's just part of the system.
And thanks, I guess I won't have to uninstall it :)
Thanks, got them. If you want, you can remove the attachments :)
Nope, because of the "funny" edit time limitations :D It's ok anyway.
Uploaded v2.2 - November 7th, 2016
o Fixed bug report that damaged proper user verification functionality.
@Kindred: Thank you for removing the attachments from the post 3 posts ago!
@Everybody: This update addresses the MAJOR security issue found and reported to me yesterday....
I'm so confused. I'm still getting this:
Quote from: Steve on November 05, 2016, 07:23:49 PM
I can't seem to get this to work. After installation, hovering over 'Profile' just gives me 'Summary', 'Account Settings' and 'Forum Profile'. :(
Hmmm.... I'm getting the same thing on my website, but not on my localhost test forum.... For some reason, the cache isn't being read. I've confirmed the existance of the cache file, but it won't read on my website....
Uploaded v2.3 - November 8th, 2016
o Fixed SMF update bug that prevents unserializing strings longer than 4096 bytes.
@Everybody: I figured out what is going on with the SMF cache in the upgrade from 2.0.11 to 2.0.12. In Sources/Subs.php in the _safe_unserialize function, you should removing these lines out:
// Input exceeds 4096.
if(strlen($str) > 4096)
return false;
Version 2.3 makes this change automatically, so that the cache works again....
UPDATED: This post has been rewritten to say "remove" instead of "remove or comment out", as the official SMF 2.0.12 download itself does not have those lines in the Sources/Subs.php file....
Ummmm... that is going to conflict with the official fix...
Quote from: Kindred on November 08, 2016, 08:36:17 AM
Ummmm... that is going to conflict with the official fix...
What would you suggest then?EDIT: That post has been rewritten to say "remove" instead of "remove or comment out", as the official SMF 2.0.12 download itself does not have those lines in the
Sources/Subs.php file....
*sigh* I guess I'm just destined not to have this mod. I still have the same issue. :(
yes... that bug exists only in the PATCHED versions...
Quote from: Steve on November 08, 2016, 09:49:28 AM
*sigh* I guess I'm just destined not to have this mod. I still have the same issue. :(
(Sigh....) Attach your
Sources/Subs.php, please....
Attached.
Try it now with this file....
No change Dougie. And I did clear browser cache.
Sorry for the double post.
I just reinstalled v1.9 and it works perfectly. Same with the Lazy Admin Menu mod. Installing v1.15 makes it work correctly for me.
Uploaded v2.4 - November 12th, 2016
o Fixed issue where menu wasn't changed because no caching of menu could be done.
o Added code to stop bans from Forum Hard Hit mod while using this mod.
@Steve: Under 2.0.12, the get cache function wasn't returning the results I had stuffed into the cache, and since the mod couldn't retrieve the cached menu, it didn't update the top menu. This version fixes this issue by doing what the version 1.x did: trying to pull the cached version, and failing that, rebuilding the menu by calling the necessary functions, version 2.x-style.....
Woot! Works a treat! Thanks dougie!
Now, if the Lazy Admin menu would work ... :P
Quote from: dougiefresh on October 28, 2016, 07:29:13 PM
Quote from: SMiFFER on October 24, 2016, 12:13:07 PM
Quote from: dougiefresh on October 19, 2016, 08:22:31 PM
...it sounds like an easy mod to build, considering almost all the work has already been done within the profile source code. All that would really be left for writing such a mod is the new template and a minor function addition....
Looking forward to that then
It's been approved and is available here (http://custom.simplemachines.org/mods/index.php?mod=4121).
Sorry about the delay in responding.... That mod overhauled for functionality, with Participation and User Created topics are now available in that mod.
Many thanks.
Greatly appreciated.
Will take a look right now.
Uploaded v2.5 - February 17th, 2018
o Now uses safe_serialize/safe_unserialize functions when available.
o Added dropdown box in Profile => Look and Layout to control mod per user.
@Everybody: This is a security update. Version 2.4 shall remain available to download through the mod page until I get confirmation from one user that it works (or not) for him/her.
I think I missed nothing but do not hesitate to talk to me O:)
Regards!
Hi Dougie don't know whether or not this will help you figure out what's going on with BetterMessages and BetterProfile (neither work for me), but read this thread (https://www.simplemachines.org/community/index.php?topic=558993.msg3962873#msg3962873). The unistaller left me a nasty gift!
Uploaded v2.6 - Februuary 26th, 2018
o Added Spanish Latin translation, courtsey of Rock Lee (https://www.simplemachines.org/community/index.php?action=profile;u=322597)!
@Rock Lee: Thank you for the translation! It's been included in this version!
I have a new forum using SMF 2.0.15 with only English installed and I tried installing this mod but I got this error. I did not know if it was safe to finish the install.
unless you use spanish, yes, it is safe
Quote from: Kindred on April 06, 2018, 04:55:16 PM
unless you use spanish, yes, it is safe
Thank you very kindly for the reply :)
Uploaded v2.7 - April 7th, 2018
o Fixed Spanish Latin translation XML file to properly skip operations.
@chyyyone: Thank you for reporting the bug! It's been fixed for this version!
@Kindred: One question: How is it unsafe if one uses Spanish? O:)
Quote from: dougiefresh on April 07, 2018, 10:55:49 AM
Uploaded v2.7 - April 7th, 2018
o Fixed Spanish Latin translation XML file to properly skip operations.
@chyyyone: Thank you for reporting the bug! It's been fixed for this version!
@Kindred: One question: How is it unsafe if one uses Spanish? O:)
Your welcome. You should probably do the same for Better Messages mod. It did the same when I installed it :)
Quote from: chyyyone on April 07, 2018, 11:11:11 AM
Your welcome. You should probably do the same for Better Messages mod. It did the same when I installed it :)
Done. Thanks again!
Wow ... I didn't realize I was a few versions behind (2.4) ...
Installed the latest and it works a treat! ;D
Uploaded v2.8 - October 11h, 2018
o No functionality change.
o Updated documentation to point to new website.
I don't think this mod is the issue, not sure... maybe you can help?
2 errors in my logs
/index.php?action=profile;area=betterprofile_ucp;u=1
8: Undefined index: BuyMeIcon
File: /Sources/Load.php
Line: 1289
/index.php?action=profile;area=betterprofile_ucp;u=1
8: Undefined index: additional_groups
File: /Sources/Load.php
Line: 1091
I'm assuming it's the 2 mods conflicting with this one? or needs to be added somewhere for them to work together?
You mark the variables not defined, did you have problems installing it? What appears on the lines marks this error?
Regards!
there's a typo in the install
language_spanish_latin.xml
<file name="$languagedir/Profile.spanish_latin-utf8" error="skip">
should be
<file name="$languagedir/Profile.spanish_latin-utf8.php" error="skip">