Simple Machines Community Forum

SMF Development => Feature Requests => Next SMF Discussion => Topic started by: live627 on September 12, 2014, 07:30:13 AM

Title: Unifying templates
Post by: live627 on September 12, 2014, 07:30:13 AM
While I was making my custom theme (using Bootstrap), I combined several templates, for ease of coding. I'm thinking of porting my changes to the default theme.


Thoughts? Do you think that maybe this will help themers?
(maybe I should make this public to get the opinions of the community...)
Title: Re: Unifying templates
Post by: Illori on September 12, 2014, 07:36:25 AM
you mean the mini profile? that could be useful, but then we need to make sure things like the ip address in the pm view gets moved elsewhere. [if a pr has not done that already]
Title: Re: Unifying templates
Post by: Bigguy on September 12, 2014, 09:05:11 AM
Getting public opinion sounds like a great way to go.
Title: Re: Unifying templates
Post by: live627 on September 12, 2014, 10:07:17 AM
Yeah. More themers.
Title: Re: Unifying templates
Post by: Arantor on September 12, 2014, 10:20:08 AM
Because I totally didn't start getting things lined up for doing that or anything by separating the per-post template out of the main message template and I didn't have the unread areas also call the message index for the legend :P

On the one hand it sounds like a good idea. On the other... Display and Message index are likely to be amongst the places customised along with the Board index, and unifying them can actually limit customisation down the road.
Title: Re: Unifying templates
Post by: Kindred on September 12, 2014, 10:22:08 AM
Actually, I could argue the other way

combining templates would prevent the theme from customizing the view... For example,  i don't want the boardindex and messageindex to have the same layouts and styling...

some combining,  post and pm, js a good idea.. but not indexes,  imo
Title: Re: Unifying templates
Post by: Arantor on September 12, 2014, 10:24:50 AM
Even though the message index has the same styling currently for child boards? And uses an almost exact copy of the code?
Title: Re: Unifying templates
Post by: Kindred on September 12, 2014, 10:33:11 AM
Except  child boards are just additonal message inexes...
Title: Re: Unifying templates
Post by: live627 on September 12, 2014, 10:35:28 AM
Quote from: Kindred on September 12, 2014, 10:33:11 AM
Except  child boards are just additonal message inexes...
huh?
Title: Re: Unifying templates
Post by: Arantor on September 12, 2014, 10:36:56 AM
No, they use a copy of the board index code above the list of messages.

Source: http://www.simplemachines.org/community/index.php?board=3.0
Title: Re: Unifying templates
Post by: Gary on September 13, 2014, 07:51:40 AM
I think Kindred's probably just getting himself mixed up again. He's probably talking about the actual lists of topics, rather than the boardlisting of child boards within the message view.




Anyway merging areas where code is duplicated would be a good idea, lord knows it'd save me a lot of hassle.
Title: Re: Unifying templates
Post by: Hj Ahmad Rasyid Hj Ismail on September 13, 2014, 02:05:48 PM
Quote from: live627 on September 12, 2014, 07:30:13 AM

       
  • Postbit - same style in topic display, PM, and search
  • Topic lists - same style in message index and unread areas
  • Board list - same style in board index and message index
The first one is good except current search has no postbit at all unless you want to add that. If that is so, might as well add the same in recent posts too.