Simple Machines Community Forum

SMF Development => Bug Reports => Topic started by: Burke ♞ Knight on October 02, 2014, 07:58:26 PM

Title: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 02, 2014, 07:58:26 PM
After update, the package manager seems a little messed up in the Latest Packages section.
Seems that can not click the packages for more info and to install them.
Also, there may be some code issues in one part of it:

QuotePackage of the Moment:
+
Page Number 2.0   
Title: Re: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 02, 2014, 08:07:18 PM
Also, when try to run the installer for 2.0.9 install package, get this:

QuoteWarning!
This install script is out of date! The current version of SMF is 2.0.9 but this install script is for 2.0.8.

It is recommended that you visit the Simple Machines website to ensure you are installing the latest version.

The copyright on installer footer shows: SMF © 2013, Simple Machines

/**
* Simple Machines Forum (SMF)
*
* @package SMF
* @author Simple Machines http://www.simplemachines.org
* @copyright 2011 Simple Machines
* @license http://www.simplemachines.org/about/smf/license.php BSD
*
* @version 2.0.8
*/

$GLOBALS['current_smf_version'] = '2.0.8';
$GLOBALS['db_script_version'] = '2-0';

$GLOBALS['required_php_version'] = '4.1.0';
Title: Re: 2.0.9 Package Manager issue
Post by: Kindred on October 02, 2014, 08:09:19 PM
What?   That last thing made no sense at all. You alreayd installed it and want to install it again?

The installer worked just fine on my systems...
Title: Re: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 02, 2014, 08:11:34 PM
Gee, every hear of making a test site, to see if the first issue is an issue on a clean install???
Title: Re: 2.0.9 Package Manager issue
Post by: Kindred on October 02, 2014, 08:11:58 PM
Gee... Ever think that I did just that?
Title: Re: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 02, 2014, 08:15:52 PM
Gee, that was in reply of your uncalled for remark before.

Now, I pasted what it said, and what the install.php file has in it.
So, you tell me, how is it I found this, yet yours does not have this issue?
Title: Re: 2.0.9 Package Manager issue
Post by: Arantor on October 02, 2014, 08:24:57 PM
Because most people don't test the installer which has to be changed manually IIRC - or the build script is acting up again. Bigger hammer required.

I don't think most people have any idea what is involved in building a package and the many many multitudes of what's required to *actually* test it. Namely the fact that the current build process pretty much can't build packages unless they're shortly about to go live.
Title: Re: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 02, 2014, 08:28:59 PM
Well, checking the dates, the last time install.php was modified, was on 6/16/14 1:23 PM
So, maybe the updated one did not get copied into the zip file?

Do note, I use the zip file, not the tar.gz or tar.bz2 files.
Title: Re: 2.0.9 Package Manager issue
Post by: Arantor on October 02, 2014, 08:31:52 PM
If only it were that simple, which it isn't.
Title: Re: 2.0.9 Package Manager issue
Post by: margarett on October 02, 2014, 08:32:31 PM
The patch is fine. The installer/upgrades do have some issues :(
Quote from: BurkeKnight on October 02, 2014, 07:58:26 PM
After update, the package manager seems a little messed up in the Latest Packages section.
Seems that can not click the packages for more info and to install them.
Also, there may be some code issues in one part of it:

QuotePackage of the Moment:
+
Page Number 2.0   
Well this is embarrassing :P A lot of team members tested the patch before it went "live" and none of us actually seen something that obvious :(
Title: Re: 2.0.9 Package Manager issue
Post by: Illori on October 02, 2014, 08:34:25 PM
Quote from: margarett on October 02, 2014, 08:32:31 PM
The patch is fine. The installer/upgrades do have some issues :(
Quote from: BurkeKnight on October 02, 2014, 07:58:26 PM
After update, the package manager seems a little messed up in the Latest Packages section.
Seems that can not click the packages for more info and to install them.
Also, there may be some code issues in one part of it:

QuotePackage of the Moment:
+
Page Number 2.0   
Well this is embarrassing :P A lot of team members tested the patch before it went "live" and none of us actually seen something that obvious :(

if your forum has not fetched files since the release was made that does not show, so something changed after release to show that issue.
Title: Re: 2.0.9 Package Manager issue
Post by: Arantor on October 02, 2014, 08:34:45 PM
That would be because it's not in the patch.

That particular data is obtained from the server and was rewritten recently - on the server - for other reasons.
Title: Re: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 02, 2014, 08:41:07 PM
Quote from: Illori on October 02, 2014, 08:34:25 PM
if your forum has not fetched files since the release was made that does not show, so something changed after release to show that issue.

I tested on sites that fetched, and ones that did not.
This issue shows on all, even the install, which even with it's error, seemed to install with no other issues. Yet, the package manager issue is there, too.
Title: Re: 2.0.9 Package Manager issue
Post by: Illori on October 02, 2014, 08:46:44 PM
Quote from: BurkeKnight on October 02, 2014, 08:41:07 PM
I tested on sites that fetched, and ones that did not.
This issue shows on all, even the install, which even with it's error, seemed to install with no other issues. Yet, the package manager issue is there, too.

my forum that has not fetched files does not show that issue.
Title: Re: 2.0.9 Package Manager issue
Post by: Chen Zhen on October 02, 2014, 08:48:58 PM
When I test the upgrade script of SMF 2.0.9 on a local installation of SMF 2.0.8, I receive this message:
Quote
The upgrader found some old or outdated files.

Please make certain you uploaded the new versions of all the files included in the package.

I also receive many undefined errors in the upgrade template for the following $txt variables (which I had to add manually to the template_upgrade_above function)

$txt['upgrade_step'] 
$txt['upgrade_progress']
$txt['upgrade_overall_progress']
$txt['upgrade_time_elapsed']
$txt['upgrade_time_mins']
$txt['upgrade_time_secs']
$txt['upgrade_upgrade_utility']


Regards.
Title: Re: 2.0.9 Package Manager issue
Post by: Oldiesmann on October 02, 2014, 09:39:58 PM
Install and upgrade version issues will be fixed soon. I'm rebuilding those packages at the moment, so give it 15 or 20 minutes and those should be fixed.

I have no idea why there would be missing language strings in the upgrade language file as that didn't change at all this time around. Will look into that when I have time.

Which JS file is messed up exactly?
Title: Re: 2.0.9 Package Manager issue
Post by: Chen Zhen on October 02, 2014, 09:41:33 PM
For me to get the upgrade package to work properly, I had to define those $txt variables I mentioned at the onset of the template_upgrade_above function, change the version numbers at the onset of the upgrade.php file and also change the version reference (to 2.0.9) at the onset of index.english.php
After those changes the upgrade script worked correctly for me.

ie.

../upgrade.php

// Version information...
define('SMF_VERSION', '2.0.9');
define('SMF_LANG_VERSION', '2.0.9');


(can be added to ie. Admin.english.php but for testing I put it directly in the upgrade.php file)

function template_upgrade_above()
{
global $modSettings, $txt, $smfsite, $settings, $upcontext, $upgradeurl;

$txt['upgrade_step'] = 'Step';
$txt['upgrade_progress'] = 'Progress';
$txt['upgrade_overall_progress'] = 'Overall Progress';
$txt['upgrade_time_elapsed'] = 'Elapsed';
$txt['upgrade_time_mins'] = 'minutes';
$txt['upgrade_time_secs'] = 'seconds';
$txt['upgrade_upgrade_utility'] = 'Upgrade Utility';


../Themes/default/languages/index.english.php

// Version: 2.0.9; index

Title: Re: 2.0.9 Package Manager issue
Post by: margarett on October 02, 2014, 09:44:58 PM
Those are in Install.english.php and I actually see the file there...
Title: Re: 2.0.9 Package Manager issue
Post by: Oldiesmann on October 02, 2014, 09:55:32 PM
You don't need to change the language version in upgrade.php or the index language file. As long as the value of SMF_LANG_FILE in upgrade.php matches what's in index.english.php you'll be fine.
Title: Re: 2.0.9 Package Manager issue
Post by: Chen Zhen on October 02, 2014, 10:05:39 PM
I did some more testing and found that after changing the version numbers at the onset of upgrade.php the undefined errors ceased.
When those were set at 2.0.8 (in error), it was displaying those undefined errors.

Now the issue I see is the package manager as BurkeKnight had mentioned.
None of the links work for what is showing in New Packages and Package of the Moment displays as he described.
(ref. db: admin_info_files.latest-packages.js)
Title: Re: 2.0.9 Package Manager issue
Post by: Oldiesmann on October 02, 2014, 11:04:24 PM
Further updates here...

1. 2.0.9 packages have been rebuilt and the 1.1.20 packages should be done within the next 10-15 minutes.

2. Issues with latest-packages.js have been fixed now. Just re-run the Fetch Simple Machines Files task to get the latest version.
Title: Re: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 03, 2014, 05:22:24 AM
Quote from: Oldiesmann on October 02, 2014, 11:04:24 PM
2. Issues with latest-packages.js have been fixed now. Just re-run the Fetch Simple Machines Files task to get the latest version.

So this can be fixed by fetching only, and without uninstalling the patch, then reinstalling, right?
Title: Re: 2.0.9 Package Manager issue
Post by: Illori on October 03, 2014, 05:39:41 AM
correct as it does not have any relation to the patch that was released.
Title: Re: 2.0.9 Package Manager issue
Post by: mashby on October 03, 2014, 06:23:13 PM
Thank you, BurkeKnight, for bringing the Package Manager links to our attention as well as the issues that happened with the downloads. I personally appreciate the topic you made here. Rock on, dude.  8)
Title: Re: 2.0.9 Package Manager issue
Post by: Burke ♞ Knight on October 03, 2014, 07:03:04 PM
You're welcome.
I only found the installer issue, due to setting up new test site.
That was called for, to see if package manager links were issue in new install, as well as it was time to re-do my test sites, anyway.
One was used as a way to make new theme compatible with one of my sites, installing all mods from site to test site with theme, so it needed to be re-done. ;)