Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: live627 on October 05, 2014, 12:45:11 PM

Title: Ultimate Menu
Post by: live627 on October 05, 2014, 12:45:11 PM
[Link to the mod](https://custom.simplemachines.org/index.php?mod=3674)

# Ultimate Menu
[![Tests](https://github.com/live627/smf-ultimate-menu/actions/workflows/php.yml/badge.svg)](https://github.com/live627/smf-ultimate-menu/actions/workflows/php.yml)
[![Code Coverage](https://scrutinizer-ci.com/g/live627/smf-ultimate-menu/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/live627/smf-ultimate-menu/?branch=master)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/live627/smf-ultimate-menu/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/live627/smf-ultimate-menu/?branch=master)
[![MIT license](http://img.shields.io/badge/license-MIT-009999.svg)](http://opensource.org/licenses/MIT)
[![Latest Version](https://img.shields.io/github/release/live627/smf-ultimate-menu.svg)](https://github.com/live627/smf-ultimate-menu/releases) [![Support](http://img.shields.io/badge/PayPal-$-009966.svg)](https://www.paypal.me/JohnRayes)

Package name | SMF version | Minimmum PHP version
--- | --- | ---
Ultimate Menu 1.1.4 | SMF 2.0.x | PHP 5.3
Ultimate Menu 2.0.0 | SMF 2.1.x | PHP 7.4

[View changelog](https://github.com/live627/smf-ultimate-menu/blob/master/CHANGELOG.md)

Add custom buttons to the main menu within SMF
## Introduction:
This is a tool for configuring the main menu within SMF, allowing custom buttons to be added at will, complete with children and grandchildren menus (so, a main menu item, a dropdown and a follow-on dropdown)

- Setup this mod at Administration Center » Configuration » Ultimate Menu.
- Should "just work" with all other mods that add their own buttons, such as portals.
- Dynamic by design—any menu button can change its text without a problem—no special code required.
   - Does not remove the unread PM counter from the "PM" menu item.
## Compatibility notes
*   Incompatible with [Menu Editor Lite / Pro](http://custom.simplemachines.org/mods/index.php?mod=3310).
*   Plays very nicely with [Add or Remove buttons](http://custom.simplemachines.org/mods/index.php?mod=2650).
Title: Re: Ultimate Menu
Post by: Masterd on October 05, 2014, 04:46:38 PM
Nice. Perhaps too simple to use. :P
Title: Re: Ultimate Menu
Post by: Shambles on October 05, 2014, 05:09:51 PM
What does it do?

Description doesn't give much away...

(http://i.imgur.com/EuaK8cL.png)
Title: Re: Ultimate Menu
Post by: Burke ♞ Knight on October 05, 2014, 05:47:44 PM
Great job!
I love the ability to set which groups can see which buttons. :)

However, would be nice to be able to edit and/or remove the default menu items.
Title: Re: Ultimate Menu
Post by: Rumpa on October 05, 2014, 05:53:25 PM
very nice mod
Title: Re: Ultimate Menu
Post by: Gryzor on October 06, 2014, 01:54:47 AM
Indeed - what does it do??
Title: Re: Ultimate Menu
Post by: Hj Ahmad Rasyid Hj Ismail on October 06, 2014, 01:59:28 AM
Nice but not really ultimate as it has the ability to add / edit custom menu but not default menu. But I like the idea of menu placement. I might steal this idea. Heh heh heh...
Title: Re: Ultimate Menu
Post by: Rumpa on October 06, 2014, 03:29:57 AM
Quote from: ahrasis on October 06, 2014, 01:59:28 AM
Nice but not really ultimate as it has the ability to add / edit custom menu but not default menu. But I like the idea of menu placement. I might steal this idea. Heh heh heh...

You mean edit default menu. that is nice idea
Title: Re: Ultimate Menu
Post by: Burke ♞ Knight on October 06, 2014, 05:38:20 AM
Quote from: ahrasis on October 06, 2014, 01:59:28 AM
Nice but not really ultimate as it has the ability to add / edit custom menu but not default menu.

Quote from: Rumpa on October 06, 2014, 03:29:57 AM
You mean edit default menu. that is nice idea

Isn't that what I said in reply #3? LOL :P
Title: Re: Ultimate Menu
Post by: Branko. on October 06, 2014, 05:40:58 AM
Yeah, something like Menu Button Manager (Kays) but this is bit different
Title: Re: Ultimate Menu
Post by: Burke ♞ Knight on October 06, 2014, 05:46:38 AM
Like I said, the one part that makes this menu "ultimate" in my eyes, is the permissions. :)
Title: Re: Ultimate Menu
Post by: Hj Ahmad Rasyid Hj Ismail on October 06, 2014, 10:02:54 AM
Permission is not that difficult at all. I was wondering why permission to menu button is necessary since if you wanna protect access, you protect the action, sub-action or the template itself. If that are protected, that you can just extend it to the menu button. Not the other way around.
Title: Re: Ultimate Menu
Post by: Arantor on October 06, 2014, 10:03:34 AM
Yes but actually doing it in the menu is actually quite important too.
Title: Re: Ultimate Menu
Post by: Hj Ahmad Rasyid Hj Ismail on October 06, 2014, 10:04:52 AM
Will give that a thought then.
Title: Re: Ultimate Menu
Post by: Arantor on October 06, 2014, 10:10:22 AM
Consider the equivalent: showing the admin button to everyone, that wouldn't look good, would it?
Title: Re: Ultimate Menu
Post by: Hj Ahmad Rasyid Hj Ismail on October 06, 2014, 10:15:05 AM
Aah, but that wouldn't require permission actually except a simple hide to certain group.
Title: Re: Ultimate Menu
Post by: Arantor on October 06, 2014, 10:17:58 AM
If only there were true, which it isn't.

The menu button out of the box is declared visible based on $context['allow_admin']. If you think this is 'user is admin' or even allowedTo('admin_forum'), you'd be rather surprised to note that it in fact is declared as follows:
$context['allow_admin'] = allowedTo(array('admin_forum', 'manage_boards', 'manage_permissions', 'moderate_forum', 'manage_membergroups', 'manage_bans', 'send_mail', 'edit_news', 'manage_attachments', 'manage_smileys'));
Title: Re: Ultimate Menu
Post by: Hj Ahmad Rasyid Hj Ismail on October 06, 2014, 10:20:33 AM
Quote from: ahrasis on October 06, 2014, 10:15:05 AM
Aah, but that wouldn't require permission actually except a simple hide to certain group.
I forgot. This is permission. :)
Title: Re: Ultimate Menu
Post by: Blue-Suit on May 17, 2015, 04:45:57 PM
QuoteIf you currently have any version of any menu editor installed, make sure to uninstall it first!! If you don't do it, Ultimate Menu simply will not work. Or all would appear to be normal on the surface and the conflicts lurk in the shadows waiting to roar. rOAr! And eat you.

This actually works very well with this mod

http://custom.simplemachines.org/mods/index.php?mod=2650 (http://custom.simplemachines.org/mods/index.php?mod=2650)

I have had these mods running on a localhost server connected via a static IP for two weeks now and there are no conflicts and my error logs including my Apache and php logs are clean.

I noticed a discussion about permissions but this is no issue to me as I use SMF as a dedicated forum and WP for everything else so all my menu links feed back and forth from SMF to WP, So even when I am signed out of SMF the menu just feeds back to wp.. Horses for courses I would say.

By using these two mods together I removed  all the buttons and re did my menu with your mod.  This has allowed me to seamlessly integrate WP and SMF with (WP2SMF) to make it look like AS ONE! Onc I decide which header to use and what colour

Simple it may be, permissions it may not have, but it does the job for me!!

All I have to do now is sort out my mail system and I can go live

Thank you!


Title: Re: Ultimate Menu
Post by: live627 on May 17, 2015, 06:50:27 PM
Permissions are labelled as 'Allowed Groups'.
Title: Re: Ultimate Menu
Post by: Blue-Suit on May 18, 2015, 05:29:16 AM
Oh yeah I never saw this apologies
Title: Re: Ultimate Menu
Post by: Lord_Rius on May 25, 2015, 02:26:36 PM
Great plugin. Can you implement any way to insert icons (images) before button label? The only way i know is with html code before like this "<img align="absMiddle" src="imagelink"/> button label" but is a weird way and shortens the button text label.

You can't move same level child buttons.

Other thing, the plugin image in the admin > configuration drop down menu is missing and links to Themes/default/images/admin/umen.png.

And last thing, you can't use only numbers in button label (for example try to name a button with 1).

Sorry for my english.

Thanks.
Title: Re: Ultimate Menu
Post by: FireDitto on May 31, 2015, 04:24:02 AM
This modification would be outstanding if it allowed edit and removal of the default menu, and those buttons added by other mods. Would you please consider adding this ability?
Title: Re: Ultimate Menu
Post by: live627 on June 01, 2015, 02:25:25 AM
Such is on my agenda but I won't get to it for a while. Meanwhile, there is hope... (I checked, and that mod appears to play nicely)

Quote from: Blue-Suit on May 17, 2015, 04:45:57 PM
This actually works very well with this mod

http://custom.simplemachines.org/mods/index.php?mod=2650 (http://custom.simplemachines.org/mods/index.php?mod=2650)

I have had these mods running on a localhost server connected via a static IP for two weeks now and there are no conflicts and my error logs including my Apache and php logs are clean.[...]
Title: Re: Ultimate Menu
Post by: stormr on June 02, 2015, 12:13:25 PM
trying to figure something out here. I need this mod, and would like to use it, but I cant find it. I look under configuration, but theres nothing listed ultimate menu, in fact I looked in everything and no were is there an ultimate menu listed. I am using 2.0.7 and it said the package installed fine. Any ideas? it's not listed as something else right?
Title: Re: Ultimate Menu
Post by: The Wizard on November 19, 2015, 07:34:03 AM
I just tried this mod on 2.0.11 and it works great.  :) :) :) :) :)
I even have simple portal installed and there is no problem.

Someone should add this to SMF itself as it is a very useful mod! - Hint Hint...

Title: Re: Ultimate Menu
Post by: Kindred on November 19, 2015, 09:24:15 AM
not sure how well this works with a responsive theme, however....
Title: Re: Ultimate Menu
Post by: live627 on November 27, 2015, 07:32:54 PM
The menu interface or the admin backend or both? Which do you refer to?
Title: Re: Ultimate Menu
Post by: Kindred on November 27, 2015, 09:16:51 PM
The menu display converting to images or even shrinking down appropriately...
Title: Re: Ultimate Menu
Post by: live627 on November 29, 2015, 12:22:48 AM
what?
Title: Re: Ultimate Menu
Post by: Kindred on November 29, 2015, 11:25:01 AM
Quote from: Kindred on November 19, 2015, 09:24:15 AM
not sure how well this works with a responsive theme, however....
Quote from: live627 on November 27, 2015, 07:32:54 PM
The menu interface or the admin backend or both? Which do you refer to?
Quote from: Kindred on November 27, 2015, 09:16:51 PM
The menu display converting to images or even shrinking down appropriately...
Title: Re: Ultimate Menu
Post by: live627 on November 29, 2015, 05:52:21 PM
Still unsure....

oh, you ask how it reactants t o the responsive mod when the window is small?
Title: Re: Ultimate Menu
Post by: Kindred on November 29, 2015, 06:44:14 PM
Yep... ;)
Title: Re: Ultimate Menu
Post by: Antes on November 29, 2015, 07:29:06 PM
Its weird actually button's class is
<span class="responsive_menu 43eea8e8ea25503a477a5443ff8292af-1448842693"></span>

But you can target it with
.responsive_menu.\34 3eea8e8ea25503a477a5443ff8292af-1448842693

Why you are using something like this to name its act ? Instead something like "um_<name-of-button>" or "ultmenu_<id-of-button>"
Title: Re: Ultimate Menu
Post by: live627 on November 29, 2015, 11:11:39 PM
I had to remove diacritics somehow.
Title: Re: Ultimate Menu
Post by: OCJ on January 27, 2016, 09:12:02 AM
Does this show sub-menu items on mobile devices?
I had to change from 'another' menu editor that wasn't displaying them.  I  only have pc access so quicker to ask here maybe.

Wondering if its theme related though - Redsy.
Andy
Title: Re: Ultimate Menu
Post by: live627 on January 27, 2016, 07:23:14 PM
Theme issue--Redsy might use its  own  menu which doesn't follow the standard. I  haven't checked.

Have a chat with the theme's author.
Title: Re: Ultimate Menu
Post by: OCJ on January 27, 2016, 10:42:56 PM
I installed the mod and added an extra menu item with the default theme set as Redsy. That seems to work ok. I just do not have a mobile device to see if the menu is working correctly (displaying submenu items on touch).
Title: Re: Ultimate Menu
Post by: live627 on January 29, 2016, 04:28:30 AM
Me neither

If it's like Reseller, then it's the same menu with a different style.
Title: Re: Ultimate Menu
Post by: OCJ on January 29, 2016, 11:54:11 PM
Redsy is a nice theme except for menu problems - other things with the menu are not working as they should. Not many decent looking themes that are responsive though.
Title: Re: Ultimate Menu
Post by: roza on January 31, 2016, 07:06:02 PM
Thanks for this mod. I've just installed it in my forum. It would be great if there is a option to use for names of buttons in forums with another languages than English. I mean the ability to add language strings instead of actual name.
Title: Re: Ultimate Menu
Post by: OCJ on February 02, 2016, 04:28:07 AM
FYI - might be useful to consider.

After problems with some of the new responsive themes - menus, I decided to dump them and go back to boring horrible curve theme.
Just keep things simple, so I thought....

I used this great (ultimate) menu mod but have you seen what the 'official' responsive default theme mod does to it?

All new menu items are replaced with question mark icons.

>:(

I think the S should be dropped from SMF. Its anything but simple these days.
Title: Re: Ultimate Menu
Post by: aegersz on February 21, 2016, 01:35:19 PM
my apache error log is as follows:

File does not exist: /var/www/html/Themes/default/images/admin/umen.png, referer: http://forum.drugs-and-users.org/index.php?action=admin;area=packages;sa=install2;package=optv0.1.1.zip;pid=0

what and where is umne.png please ?
Title: Re: Ultimate Menu
Post by: Snrj on April 07, 2016, 05:32:47 PM
turkish translate pack
Title: Re: Ultimate Menu
Post by: -Rock Lee- on April 07, 2016, 08:45:59 PM
Very good work @live627 Here I leave the translation to the Latin Spanish I hope will be useful and can add!


Regards!
Title: Re: Ultimate Menu
Post by: badon on May 19, 2016, 05:55:45 AM
What do the "Active" and "Not Active" options for "Button Status" do?
Title: Re: Ultimate Menu
Post by: live627 on May 22, 2016, 03:42:57 AM
Active is enabled.
Title: Re: Ultimate Menu
Post by: aegersz on September 26, 2016, 05:43:54 AM
still can't find umen.png, this is a typical error in the apache log:

[Mon Sep 26 16:11:11 2016] [error] [client xxx.xxx.xxx.xxx] File does not exist: /var/www/html/Themes/default/images/admin/umen.png, referer: http://forum.drugs-and-users.org/index.php?action=admin

can anyone please attach it for me ? it's been bugging me for ages.
Title: Re: Ultimate Menu
Post by: skb on September 26, 2016, 06:12:17 AM
Here it is.
Title: Re: Ultimate Menu
Post by: aegersz on September 26, 2016, 06:23:20 AM
Wonderful ! Thank you, heaps  :)
Title: Re: Ultimate Menu
Post by: Xpresskonami on October 06, 2016, 01:47:52 AM
This mod actually work well. but I got an error


Strict Standards : Only variables should be passed by reference in /home/theweb/public_html/Sources/Subs-UltimateMenu.php on line 19


This error appear in a page. where I create any new file in my File manager name (Docs.php or promote.php) so I include the SSI into the page to show the Theme Header & Footer. Any solution plz
Title: Re: Ultimate Menu
Post by: OCJ on November 22, 2016, 08:42:59 AM
I think there is a bug with the permissions.

Some new groups cannot see menu items. They are allowed to see them and even checking all options does not display the menu item for that group.
Same in my theme and curve.

Title: Re: Ultimate Menu
Post by: wintstar on November 22, 2016, 09:28:10 AM
Is not a bug with the permissions.

open
Sources\Subs-UltimateMenu.php

find
Code (php) Select
    if (end(explode(',', $modSettings['integrate_menu_buttons'])) != 'um_load_menu')
replace with
Code (php) Select
    If ($array = explode(',', $modSettings['integrate_menu_buttons']) != 'um_load_menu')
Title: Re: Ultimate Menu
Post by: OCJ on November 22, 2016, 06:56:58 PM
If the mod does not work as it should - mod permissions set to display but no display - then it is not working as intended and is a bug.

Whats the point of your code changes if the mod is working correctly?

Anyway, it does not work as it os supposed to when correctly installed on the latest version of SMF. I am now using another menu mod.
Title: Re: Ultimate Menu
Post by: Kindred on November 22, 2016, 08:44:52 PM
I don't think you read or understood what was posted.

Wintstar did not say that there was no bug... nor did he say that the mod worked correctly --- he indicated that the bug was not in the permissions and the code fix indicates what the issue actually was (or if you can't read code, just apply the fix and it all works, even without you understanding)
Title: Re: Ultimate Menu
Post by: wintstar on November 23, 2016, 01:50:42 AM
@Kindred, thats right. There is no problem with the permissions, but an error in the file Subs-UltimateMenu.php. The fix of the error I wrote in my above post. This is the only, I know, bug in this mod. This Bug always fill the error log, but does not make itself felt in the function.
Title: Re: Ultimate Menu
Post by: OCJ on November 23, 2016, 12:23:59 PM
Fact
The permissions dont work in this mod...

wintstar
QuoteIs not a bug with the permissions.

Fine, if the problem is elsewhere... the permissions still dont work in the mod - statement.



Title: Re: Ultimate Menu
Post by: wintstar on November 23, 2016, 03:24:46 PM
The error message, reported by you, has nothing to do with a bug of the permissions. I have so far no problems with the permissions. Have you assigned the menu point to the allowed groups, under "Allowed Groups: [Select permissions for each group]" in the area of Menu Settings?
Title: Re: Ultimate Menu
Post by: live627 on November 23, 2016, 04:04:29 PM
Try te fix in https://github.com/live627/smf-ultimate-menu/commit/524682f58d8ccabe017b698f608a7f511503cfce

I have no idea if this will even address the issue at hand...
Title: Re: Ultimate Menu
Post by: Alpay on March 02, 2017, 06:32:13 AM
Thanks for this mod.
Title: Re: Ultimate Menu
Post by: Westwegoman on October 03, 2017, 10:41:20 PM
I get the following at the top of my forum when installed.

Strict Standards: Only variables should be passed by reference in /Sources/Subs-UltimateMenu.php on line 19

It also changes the text on the portal page. Makes it larger in Simple Portal.
Title: Re: Ultimate Menu
Post by: petewadey on November 10, 2017, 05:20:14 AM
I'm looking to run an online shop that I would like to link to from my smf forum. I would like a button on the forum linking to my shop that only members can see. Would this mod do that for me?
Thanks
Pete
Title: Re: Ultimate Menu
Post by: BellGab.com on January 11, 2018, 09:22:24 PM
Quote from: Westwegoman on October 03, 2017, 10:41:20 PM
I get the following at the top of my forum when installed.

Strict Standards: Only variables should be passed by reference in /Sources/Subs-UltimateMenu.php on line 19

It also changes the text on the portal page. Makes it larger in Simple Portal.

I also have this error in my log.
Title: Re: Ultimate Menu
Post by: live627 on January 12, 2018, 02:35:43 AM
v1.0.1 has just been released which fixes the standards warning.
Title: Re: Ultimate Menu
Post by: Parmaster on January 12, 2018, 10:43:56 AM
 I get this error with the new version:

Parse error: syntax error, unexpected end of file in /www/Sources/Subs-UltimateMenu.php on line 205
Title: Re: Ultimate Menu
Post by: Aleksi "Lex" Kilpinen on January 12, 2018, 12:09:06 PM
Quote from: Parmaster on January 12, 2018, 10:43:56 AM
I get this error with the new version:

Parse error: syntax error, unexpected end of file in /www/Sources/Subs-UltimateMenu.php on line 205
Same. Would seem like there's a problem with the package.
Title: Re: Ultimate Menu
Post by: Shambles on January 12, 2018, 12:17:20 PM
Yeah, Subs-UltimateMenu.php has a superfluous {

Code (find) Select
if (strpos($hook, 'um_load_menu') !== false) {
{
remove_integration_function('integrate_menu_buttons', 'um_load_menu');
add_integration_function('integrate_menu_buttons', 'um_load_menu');
}


Code (replace) Select
if (strpos($hook, 'um_load_menu') !== false)
{
remove_integration_function('integrate_menu_buttons', 'um_load_menu');
add_integration_function('integrate_menu_buttons', 'um_load_menu');
}



Title: Re: Ultimate Menu
Post by: BellGab.com on January 12, 2018, 09:26:23 PM
I got an HTTP 500 error with the new package.
Title: Re: Ultimate Menu
Post by: BellGab.com on January 13, 2018, 12:57:51 AM
anybody have a copy of the 1.0 package until the new one is fixed?
Title: Re: Ultimate Menu
Post by: SaltedWeb on January 13, 2018, 09:28:52 PM
Quote from: BellGab.com on January 13, 2018, 12:57:51 AM
anybody have a copy of the 1.0 package until the new one is fixed?
I have 1.0 if you want to PM me...
Title: Re: Ultimate Menu
Post by: BellGab.com on January 13, 2018, 09:57:02 PM
Quote from: SaltedWeb on January 13, 2018, 09:28:52 PM
Quote from: BellGab.com on January 13, 2018, 12:57:51 AM
anybody have a copy of the 1.0 package until the new one is fixed?
I have 1.0 if you want to PM me...

will do...
Title: Re: Ultimate Menu
Post by: live627 on January 16, 2018, 10:05:42 PM
v1.0.2 fixes the parse error


All releases are public https://github.com/live627/smf-ultimate-menu/releases
Title: Re: Ultimate Menu
Post by: BellGab.com on January 19, 2018, 08:05:29 PM
Quote from: live627 on January 16, 2018, 10:05:42 PM
v1.0.2 fixes the parse error


All releases are public https://github.com/live627/smf-ultimate-menu/releases

thanks.
Title: Re: Ultimate Menu
Post by: Tenebroso_MW on January 20, 2018, 04:39:48 PM
In responsive menu, the subforums do not work. Only the main button is activated, in case of sub menu, there are no options. therefore on mobile only the main menu. It is important because the responsive is necessary.


On the other hand my most sincere congratulations. Thank you very much. A great job.


Tenebroso
Saludos
Title: Re: Ultimate Menu
Post by: live627 on January 23, 2018, 03:19:53 AM
Do you mean the drop menus? Ultimate Menu isn't doing anything to the templates.
Title: Re: Ultimate Menu
Post by: Tenebroso_MW on January 23, 2018, 01:47:30 PM
Quote from: live627 on January 23, 2018, 03:19:53 AM
Do you mean the drop menus? Ultimate Menu isn't doing anything to the templates.

Yes, I mean the drop-down menus, they work very well on the desktop. On the mobile, it does not open


Thanks for comment. In the mobile, only the main button works, it does not give options to open the submenu window. In desktop version it works great.


(https://k60.kn3.net/D/A/6/A/D/C/535.png)

(https://k60.kn3.net/F/E/6/4/6/F/A90.png)
Title: Re: Ultimate Menu
Post by: SaltedWeb on February 21, 2018, 01:41:47 PM
 I am not getting any errors and the menus can be created but the box for options is not there. Just a bank box. Creating a menu single items work just the options don't show up ??
I cant tell if any mods are interfering as it installs, can be completely uninstalled and can create a limit button for the menu that will work but no option.  Tried also removing all back ups from server as well as package folder no luck.
Title: Re: Ultimate Menu
Post by: aegersz on October 03, 2018, 09:03:29 PM
This mod simply stopped working so i uninstalled and reinstalled it to fix it.

weird ... any thoughts as to why this would happen ?
Title: Re: Ultimate Menu
Post by: Kindred on October 04, 2018, 10:49:40 AM
Well, things dont "just suddenly stop working"
That's not how computers work.

So, obviously, something changed... either you changed something that affected this mod or your host did.
Title: Re: Ultimate Menu
Post by: DavidA2 on October 12, 2018, 08:54:58 AM
I just installed this mod. It's very easy to use and does just what I needed it to. However, I have been notified by a few members that they cannot see the buttons that have been added. I added two buttons and have double checked the "Allowed Groups". Both buttons are allowed to ALL groups in my forum. The members that cannot see the buttons are members of one of those groups.

What else could it be?

Update...I just had one user tell me that they can see the buttons in Firefox, but not in IE.
Title: Re: Ultimate Menu
Post by: aegersz on October 12, 2018, 06:14:31 PM
Quote from: Kindred on October 04, 2018, 10:49:40 AM
Well, things dont "just suddenly stop working"
That's not how computers work.

So, obviously, something changed... either you changed something that affected this mod or your host did.

nothing that i can recall that i hadn't done before except some manual HTML additions to another directory.

Ha, you wouldn't believe the strange things that happen on my systems  ???
Title: Re: Ultimate Menu
Post by: live627 on October 16, 2018, 11:46:07 PM
Quote from: DavidA2 on October 12, 2018, 08:54:58 AM
I just installed this mod. It's very easy to use and does just what I needed it to. However, I have been notified by a few members that they cannot see the buttons that have been added. I added two buttons and have double checked the "Allowed Groups". Both buttons are allowed to ALL groups in my forum. The members that cannot see the buttons are members of one of those groups.

What else could it be?

Update...I just had one user tell me that they can see the buttons in Firefox, but not in IE.
Site link please? Would I be able to see those buttons if I look as a guest?
Title: Re: Ultimate Menu
Post by: DavidA2 on October 17, 2018, 08:41:47 AM
Quote from: live627 on October 16, 2018, 11:46:07 PM
Quote from: DavidA2 on October 12, 2018, 08:54:58 AM
I just installed this mod. It's very easy to use and does just what I needed it to. However, I have been notified by a few members that they cannot see the buttons that have been added. I added two buttons and have double checked the "Allowed Groups". Both buttons are allowed to ALL groups in my forum. The members that cannot see the buttons are members of one of those groups.

What else could it be?

Update...I just had one user tell me that they can see the buttons in Firefox, but not in IE.
Site link please? Would I be able to see those buttons if I look as a guest?

Sorry. I know you don't sit by waiting to answer questions. But after not hearing anything for a few days, I bought and installed another menu mod that is working.
Title: Re: Ultimate Menu
Post by: live627 on October 17, 2018, 10:39:55 PM
as long as your problem is solved, it's all good.

:)
Title: Re: Ultimate Menu
Post by: Black Tiger on November 07, 2018, 09:42:37 PM
Just a little question. Is it possible to upgrade this mod to php 7.2 compatibility please?
It's working, but it's throwing this error in the logs:
8192: The each() function is deprecated. This message will be suppressed on further calls
on line 33 of SubsUltimateMenu.php.

It's only on that line, so maybe it can be easily fixed?

Or maybe by a temp fix I can do myself? This is line 33:
while (list ($key, $row) = each($db_buttons))
I read that each() should be swapped out by foreach() but I can't just simply do that in this line otherwise the forum will turn blank. And I'm no coder.

So a mod upgrade or a little how to change this line would be very helpfull!
Title: Re: Ultimate Menu
Post by: live627 on November 07, 2018, 10:14:30 PM
Did you try

foreach ($db_buttons as list ($key, $row))

(I haven't tested this)
Title: Re: Ultimate Menu
Post by: Black Tiger on November 07, 2018, 10:31:52 PM
Thank you for the quick reply.

No I did not try that because I don't know anything about coding, I can just read it a tiny bit. :)

Unfortunately it did not work, when changing to the suggested line, the following error occurs:
Undefined offset: 1
on line 33 also.
and the menu is not visible anymore.
Title: Re: Ultimate Menu
Post by: live627 on November 07, 2018, 10:55:15 PM
It's been so long since I wrote this that i forgot hew it works. :-[

Can you please try

foreach ($db_buttons as $key => $row)
Title: Re: Ultimate Menu
Post by: Black Tiger on November 08, 2018, 08:22:15 AM
Oh that's no problem, i also tend to forget how certain things work after a certain time. :)

It seems that this new line has done the trick, at this moment I don't see errors anymore and the menu is still working.

Thank you very much!!
Title: Re: Ultimate Menu
Post by: live627 on November 08, 2018, 02:35:06 PM
Excellent! I'll make a new release with this change.
Title: Re: Ultimate Menu
Post by: jsx on April 13, 2019, 09:25:38 AM
Hi live627

Where exactly can I see these lines in modification management?

$txt['admin_menu_desc'] = 'This page allows you to add and edit custom menu buttons.';

$txt['unchanged'] = 'Unchanged';

$txt['um_menu_edit_title'] = 'Edit Button';
Title: Re: Ultimate Menu
Post by: Kindred on April 13, 2019, 10:13:21 AM
one of the language files... probably modifications.english.php
Title: Re: Ultimate Menu
Post by: jsx on April 13, 2019, 02:20:09 PM
I know that these lines are in the file, but I can not see them in the modification settings.

(https://i.imgur.com/7ZtCS9r.png)
Title: Re: Ultimate Menu
Post by: Kiriakos GR on April 15, 2019, 06:24:21 AM
Quote from: Black Tiger on November 07, 2018, 09:42:37 PM
Just a little question. Is it possible to upgrade this mod to php 7.2 compatibility please?
It's working, but it's throwing this error in the logs:
8192: The each() function is deprecated. This message will be suppressed on further calls
on line 33 of SubsUltimateMenu.php.

Identical situation here too, my web-hosting provider updated to php 7.2  :(

Additionally I am also getting several log alerts about Subs.php lines, which I do not know if these are also related to this mod.
My forum this is unmodified since 2017 and up to date (regarding mod files or new settings)

Title: Re: Ultimate Menu
Post by: live627 on April 15, 2019, 08:09:33 PM
The latest is v1.0.3 which was supposed to fix that error about each().

Your extra logs are provably unrelated since this mod does not edit Subs.php. But I can still help  you.  Can you post them? I suspect that if you go  to php 7.1 they'll  go away.
Title: Re: Ultimate Menu
Post by: Kindred on April 15, 2019, 10:33:41 PM
Well, SMF itself is not compatible with 7 2
Title: Re: Ultimate Menu
Post by: Kiriakos GR on April 16, 2019, 03:59:14 AM
Solution which worked for me and advice which came from my web hosting provider =>  Any one using cPanel for web site management,  he may use MultiPHP manager module and select PHP 5.6  as default PHP engine for his website.

By that adjustment, entire SMF code and mod files, they do return in a lets called it as normality, and there is no more error logs. 
Title: Re: Ultimate Menu
Post by: Kiriakos GR on April 16, 2019, 04:28:57 AM
Quote from: live627 on April 15, 2019, 08:09:33 PM
Your extra logs are provably unrelated since this mod does not edit Subs.php. But I can still help  you.  Can you post them? I suspect that if you go  to php 7.1 they'll  go away.

Thanks for you willingness to help.
My SMF installation this is in good standing position, but I will mention a small issue, possibly this could become a new idea for a new next mod.
At Package Manager -> Browse Packages   some installed mod packages, they appear as not installed.
I am now assuming that cleaning of database logs which I did a year ago, this caused the problem.

Therefore what it would help, this is a mod finding active installed packages and to register them back at Browse Packages   list as installed ones.

For now I am handling this problem by closing my eyes  :) 
All mod files I am using were tested back in 2017, and I do not install anything new since then.

Title: Re: Ultimate Menu
Post by: live627 on April 16, 2019, 07:38:19 AM
Manually clearing the log tables is a bad idea. The package log is only one of the possible symptoms. Another one is the unread lists. That might annoy your users.

That mod idea actually isn't feasible. The only way that SMF even remotely knows which packages are installed is through  log_packages. There's no other tracked system; mods can do anything and are quite different across authors. You could compare code from a mod package and your codebase and recompile your lists that way, but that is very brittle and unreliable for a machine because another mod might change the code. If using integration hooks: reverse compiling is easier because things do not change much; the list of functions to call is just that: lists. But a mod in practice usually stores several hooks. Best guesses would need to be made, and user input would be required every step of the way.

In short: don't  delete the package  log!

To illustrate: I have 90 mods installed and most of them won't uninstall, many dating back to 2011. Updating to  2.0.14/2.0.15 required me to manually move code. I even had to uninstall a mod. Maintaining a site through updates is hard.
Title: Re: Ultimate Menu
Post by: Kiriakos GR on April 16, 2019, 01:01:10 PM
Quote from: live627 on April 16, 2019, 07:38:19 AM
To illustrate: I have 90 mods installed and most of them won't uninstall, many dating back to 2011. Updating to  2.0.14/2.0.15 required me to manually move code. I even had to uninstall a mod. Maintaining a site through updates is hard.

My SMF forum this is standing since may 2012 up to date, and I did manage to recover a scrabbled SMF omelette three times,  in the positive side of things all mod packages I am using they are useful and uninstall does not required.

I am using Ultimate Menu 1.0 and now I need to ask if there is any risk at activating this installer another one time, so this to register it self as installed mod?
Is there any risk of double entries ? 
Title: Re: Ultimate Menu
Post by: Kindred on April 16, 2019, 01:02:51 PM
yes. running the installer a second time almost definitely WILL result in duplicate code in a multitude of places.

this is why you don't ever do direct edits to the database.....
Title: Re: Ultimate Menu
Post by: Kiriakos GR on April 16, 2019, 01:13:40 PM
Editing (cleaning) of database manually this is unavoidable.

Some one forgot to implement even a setting this cleaning the database from what Users typed in the keyword search field, and many more.
   
Title: Re: Ultimate Menu
Post by: Arantor on April 16, 2019, 06:01:16 PM
Quote from: Kiriakos GR on April 16, 2019, 01:13:40 PM
Editing (cleaning) of database manually this is unavoidable.

Some one forgot to implement even a setting this cleaning the database from what Users typed in the keyword search field, and many more.
   

I haven't cleaned my databases manually ever. Never had any problems.
Title: Re: Ultimate Menu
Post by: Kindred on April 16, 2019, 10:36:31 PM
Nor have i.

Kiriakos
Once again,  you have described some bizarre belief in something that is not backed by any reality.
Title: Re: Ultimate Menu
Post by: jsx on April 18, 2019, 03:04:16 AM
Polish translation.

@live627

Please put this translation in a modification. :)

I set the ManageUltimateMenu.polish.php file to ISO-8859-2, but Notepad++ detects the encoding as ANSI. Translation in this format is displayed correctly on the forum with ISO coding.
Title: Re: Ultimate Menu
Post by: Kiriakos GR on April 19, 2019, 12:52:58 PM
Quote from: Kindred on April 16, 2019, 10:36:31 PM
Nor have i.

Kiriakos
Once again,  you have described some bizarre belief in something that is not backed by any reality.

My reality explained with words will cost you 500 Euro paid upfront.
Title: Re: Ultimate Menu
Post by: Kindred on April 19, 2019, 03:42:57 PM
Sorry, Kiriakos -- If I want hallucinations, I can buy some drugs on the threes for 50 bucks.
Title: Re: Ultimate Menu
Post by: Arantor on April 19, 2019, 03:57:15 PM
Also, an evening out to see a world-famous comedian is cheaper than that.
Title: Re: Ultimate Menu
Post by: njtweb on May 21, 2019, 08:23:26 AM
Hopefully this is still supported.

How can you make the 1st level not do anything?

First level <-- Do nothing
- Second level <-- Link
- Third level <-- Link
etc.....
Title: Re: Ultimate Menu
Post by: Kindred on May 21, 2019, 03:41:12 PM
Why?

Having the first level do nothing is wasted space
Title: Re: Ultimate Menu
Post by: jsx on October 07, 2020, 01:30:41 PM
live627,

In this modification I have added one menu with several sub-links. Every time I uninstall the old version of TinyPortal, this my menu always disappears from the bar. Then when I want to recreate this menu, I can not do that. The menu is not displayed on the bar. So I uninstalled this modification using the "Remove all data associated with this modification" function and reinstalled this modification, but unfortunately the menu still was not added to the bar. The menu does not appear on the bar when an external link is added.
Title: Re: Ultimate Menu
Post by: jsx on October 08, 2020, 03:07:46 PM
I always added my menu (button) after the Forum button. Now when I want to add my menu after the Forum button, unfortunately my menu will not be displayed. However, if I add my menu, e.g. after the Help button, the menu displays and works properly. So why is this happening? After all, I installed the modification clean, without previous settings.



Title: Re: Ultimate Menu
Post by: jjfeenix on November 05, 2020, 11:34:33 PM
I am currently using ver. 1.0 of this mod on SMF ver. 2.0.15.  I am trying to fix tons of "Only variables should be passed by reference" errors (4603 since Nov. 2).

I found ver. 1.0.3 on Github and Uploaded it. In the Package Manager, ver. 1.0.3 is marked as older version (red circle) and there is no [Install] option.

Do I have to [Uninstall] ver. 1.0 before I'm able to install ver. 1.0.3? If so, will my custom buttons be retained?

Thanks
Title: Re: Ultimate Menu
Post by: live627 on November 08, 2020, 05:46:27 AM
Quote from: njtweb on May 21, 2019, 08:23:26 AM
How can you make the 1st level not do anything?
Try external link javascript:void(0)

Quote from: jjfeenix on November 05, 2020, 11:34:33 PM
I am currently using ver. 1.0 of this mod on SMF ver. 2.0.15.  I am trying to fix tons of "Only variables should be passed by reference" errors (4603 since Nov. 2).

I found ver. 1.0.3 on Github and Uploaded it. In the Package Manager, ver. 1.0.3 is marked as older version (red circle) and there is no [Install] option.

Do I have to [Uninstall] ver. 1.0 before I'm able to install ver. 1.0.3? If so, will my custom buttons be retained?

Thanks
You can ignore  those  circles as they aren't telling the right story.

Uninstall the old; I believe it even has a readme indicating how to keep or remove data.
Title: Re: Ultimate Menu
Post by: jjfeenix on November 08, 2020, 06:34:28 PM
live627:

QuoteYou can ignore  those  circles as they aren't telling the right story.

Uninstall the old; I believe it even has a readme indicating how to keep or remove data.

This worked out great. All the errors have disappeared!
Title: Re: Ultimate Menu
Post by: live627 on November 08, 2020, 08:15:35 PM
good to hear 
Title: Re: Ultimate Menu
Post by: Shades. on March 07, 2021, 09:51:20 PM
Just a future request for this mod is the ability to change the icon for each link/button instead of just having a bunch of question mark icons for every one but this is a great mod and this is just a suggestion! ;)
Title: Re: Ultimate Menu
Post by: live627 on March 08, 2021, 03:18:37 PM
Thanks. Is this request on 2.1?  What would be a good way t o input  icons? Should it be similar to the membergroup icons input ?
Title: Re: Ultimate Menu
Post by: Shades. on March 08, 2021, 03:54:39 PM
Yes for 2.1
QuoteShould it be similar to the membergroup icons input ?
Yes something like that would probably be good!
Title: Re: Ultimate Menu
Post by: MaxxD on April 15, 2021, 09:46:13 PM
I have custom member groups that general members who would be "Regular Members" are defaulted to instead, and the custom member groups inherit permissions from Regular Members.
My custom member groups aren't listed under the Allowed Groups in the new buttons, so I can't enable it for most of my members.

Would it be possible to show/add custom member groups for Allowed Groups please? Or should I go about enabling it another way? I can't find anything specific to Ultimate Menu in the permissions so I'm a little at a loss, haha.

I enjoy how user-friendly and clean it is, so I'm hoping to stick with this mod if possible. Thanks for reading!
Title: Re: Ultimate Menu
Post by: live627 on April 16, 2021, 01:20:12 AM
I think it excludes inherited groups.

Find in ./Sources/ManageUltimateMenu.php (https://github.com/live627/smf-ultimate-menu/blob/be0978bbdfa049bba06cc379f17298cdd1e9e0b5/Subs-UltimateMenu.php#L87)
function list_groups($checked, $disallowed = '', $inherited = false, $permission = null, $board_id = null)

Replace with
function list_groups($checked, $disallowed = '', $inherited = true, $permission = null, $board_id = null)
Title: Re: Ultimate Menu
Post by: MaxxD on April 16, 2021, 02:36:33 PM
That worked great, thanks a ton!
Title: Re: Ultimate Menu
Post by: Shades. on August 22, 2021, 10:00:23 PM
I'm using the "SMF Store" mod and trying to create sub menus under the "Store" button and it creates the link in admin but it won't add it to the button. I don't have any problems with other mod buttons so I was wondering what would cause this? Or how to fix it? ???  :)
Title: Re: Ultimate Menu
Post by: live627 on August 23, 2021, 06:14:30 AM
Are you trying to add a child button using either 'before' or after'?
Title: Re: Ultimate Menu
Post by: Shades. on August 23, 2021, 11:31:48 AM
No I'm using Sub-board of Store
QuoteStore Search    Forum Link    Sub-board of Store    action=store;sa=search

It works on all other buttons just not on that "Store" button! ???
Title: Re: Ultimate Menu
Post by: Shades. on August 31, 2021, 10:45:50 PM
Quote from: Shades. on August 23, 2021, 11:31:48 AMNo I'm using Sub-board of Store
QuoteStore Search    Forum Link    Sub-board of Store    action=store;sa=search

It works on all other buttons just not on that "Store" button! ???

Oops! Just realized this mod is for 2.0 and my site in question is 2.1 although it does emulate and works fine on 2.1! ;)
Title: Re: Ultimate Menu
Post by: live627 on September 01, 2021, 03:57:56 AM
Oh it'll work on 2.1 since the basic menu handling routine did not change.

There are multiple shop mods so can you link it?
Title: Re: Ultimate Menu
Post by: Shades. on September 01, 2021, 05:19:15 AM
Quote from: live627 on September 01, 2021, 03:57:56 AMOh it'll work on 2.1 since the basic menu handling routine did not change.

There are multiple shop mods so can you link it?

I'm using the SMF Store mod by SMFHacks (https://www.smfhacks.com/smf-store.php).
Title: Re: Ultimate Menu
Post by: Shades. on September 01, 2021, 05:33:48 AM
I just installed the latest Ultimate Menu update and now it's working fine thanks! 8)
Title: Re: Ultimate Menu
Post by: live627 on September 01, 2021, 05:35:39 AM
oh v1.1.0?
Title: Re: Ultimate Menu
Post by: Shades. on September 01, 2021, 06:43:11 AM
v1.0.3

Wait? Theres a 1.1.0?
Title: Re: Ultimate Menu
Post by: live627 on September 01, 2021, 09:50:19 AM
on github https://github.com/live627/smf-ultimate-menu/releases
Title: Re: Ultimate Menu
Post by: peter_mein on September 01, 2021, 10:52:02 AM
Hello
The Buttom position is after login.
If i log in the forum the new buttom is after login.
But if i logout the buttom is between login and registartion
not at the end of the menue.

Peter.
Title: Re: Ultimate Menu
Post by: live627 on September 01, 2021, 12:26:26 PM
then move it to after register
Title: Re: Ultimate Menu
Post by: peter_mein on September 01, 2021, 01:47:13 PM
In the button list is not registration.
If i visit this forum as guest, then i see sign up button.
if i sign up i don´t see sign up. and in the button list from
this mod i don´t see sign up.
Title: Re: Ultimate Menu
Post by: live627 on September 02, 2021, 12:23:47 AM
do you see it in the list of positions when editing the button?
Title: Re: Ultimate Menu
Post by: peter_mein on September 02, 2021, 04:53:13 AM
Hello
No in this list i don´t see it.
Title: Re: Ultimate Menu
Post by: live627 on September 04, 2021, 05:01:17 PM
1.1.2 (2021-09-04)

Bug Fixes
Download tarball now (https://github.com/live627/smf-ultimate-menu/releases/download/v1.1.2/ultimate-menu_1-1-2.tgz)
Title: Re: Ultimate Menu
Post by: Shades. on September 04, 2021, 11:40:44 PM
1.1.1 & 1.1.2 won't load admin page but I have no problems with 1.0.3 in 2.1RC4 ;)
Title: Re: Ultimate Menu
Post by: peter_mein on September 05, 2021, 05:44:59 AM
Hello
Thank´s now are all correct.
Title: Re: Ultimate Menu
Post by: live627 on October 13, 2021, 04:00:27 AM
2.0.0 (2021-10-11)
⚠ BREAKING CHANGES
Title: Re: Ultimate Menu
Post by: Shades. on October 15, 2021, 09:53:58 AM
2.1RC4

After uploading 2.0.0 and click on install I get this error:

An error has occurred
Database error, given array of string values is empty. (settings)

Backtrace Info:
QuoteError
Type of error
Critical
Error message
Database error, given array of string values is empty. (settings)
Function: require
File
/home2/xxxxxx/public_html/Packages/temp/install.php
Line
135
URL of page causing the error
https://xxxxxx.com/index.php?action=admin;area=packages;sa=install2;package=ultimate-menu_2-0-0.tgz;pid=0
Backtrace information
#0: smf_db_error_backtrace()
Called from /home2/xxxxxx/public_html/Sources/Subs-Db-mysql.php on line 240
#1: smf_db_replacement__callback()
Called from unknown on line -1
#2: preg_replace_callback()
Called from /home2/xxxxxx/public_html/Sources/Subs-Db-mysql.php on line 406
#3: smf_db_query()
Called from /home2/xxxxxx/public_html/Packages/temp/install.php on line 135
#4: require()
Called from /home2/xxxxxx/public_html/Sources/Packages.php on line 1064
#5: PackageInstall()
Called from /home2/xxxxxx/public_html/Sources/Subs.php on line 5694
#6: call_helper()
Called from /home2/xxxxxx/public_html/Sources/Packages.php on line 91
#7: Packages()
Called from /home2/xxxxxx/public_html/Sources/Admin.php on line 500
#8: AdminMain()
Called from /home2/xxxxxx/public_html/index.php on line 187

Also when I go back to the package list page the "Install" link is gone!?
Title: Re: Ultimate Menu
Post by: live627 on October 16, 2021, 01:55:45 AM
Any buttons? (Or if you don't know you can check for rows in the smf_um_menu table)
Title: Re: Ultimate Menu
Post by: Donovan Cane on October 17, 2021, 12:36:03 AM
hey,

I'm having an issue when i add a menu link to an external site it tries to go to my website and then the external link for an example - i have it going to elcewhere.com but it shows up as fearasylum.com/elcewhere.com

thanks.
Title: Re: Ultimate Menu
Post by: live627 on October 17, 2021, 12:45:49 AM
try a well-formed liknk—https://elcewhere.com/
Title: Re: Ultimate Menu
Post by: Donovan Cane on October 17, 2021, 01:05:37 AM
Quote from: live627 on October 17, 2021, 12:45:49 AMtry a well-formed liknk—https://elcewhere.com/

Thanks buddy that worked :)
Title: Re: Ultimate Menu
Post by: Senkusha on November 30, 2021, 05:58:50 AM
Quote from: Burke ♞ Knight on October 06, 2014, 05:46:38 AMLike I said, the one part that makes this menu "ultimate" in my eyes, is the permissions. :)

However, I don't know if I'm just blind, but it seems that custom member-groups (non-post count) are not included.
Title: Re: Ultimate Menu
Post by: User Andrey on December 09, 2021, 04:14:35 PM
Hello!

Added buttons are not highlighted after click. Why? How to workaround?

Also it would be useful to provide icons for new buttons because all buttons in SMF 2.1 have icons.

I use SMF 2.1 RC4.

Thanks!
Title: Re: Ultimate Menu
Post by: Strannik64 on January 05, 2022, 01:11:38 PM
Hello, how can I replace the icon next to the menu item, is always displayed always the first standard?
Title: Re: Ultimate Menu
Post by: Shades. on March 15, 2022, 08:58:43 PM
SMF 2.1.1
Ultimate Menu 2.0.1

I have this installed on two separate sites but when adding buttons both sites have different "permission" settings.

ultimate1.jpeg
ultimate2.jpeg

One just has:
Guests
Regular Members
Global Moderator
Forum Leader

And the other has:
Guests
Regular Members
Global Moderator
Newbie
Jr. Member
Full Member
Sr. Member
Hero Member
Did I miss a setting somewhere? :o

Thanks,
Shades 8)   
Title: Re: Ultimate Menu
Post by: Kindred on March 16, 2022, 02:39:56 AM
The second one has post count based permissions activated
Title: Re: Ultimate Menu
Post by: Shades. on March 16, 2022, 11:23:42 AM
Quote from: Kindred on March 16, 2022, 02:39:56 AMThe second one has post count based permissions activated
Ok thank you! 8)
Title: Re: Ultimate Menu
Post by: alex_cipher on March 19, 2022, 04:42:36 AM
Hi!

I want to install the mod but I always get an error if I press "Install now".
This is the error:
You have an error in your SQL syntax; check the manual that corresponds
to your MySQL server version for the right syntax to use near ',,,,,,,,)

SELECT ,,,,,,,,

FROM smf_um_menu_old' at line 1
File: /.../.../Packages/temp/install.php
Line: 89

I have checked the databse and deleted an old entry, but the install error still appears.
Title: Re: Ultimate Menu
Post by: Shades. on March 19, 2022, 02:09:44 PM
What version of SMF are you using?
Title: Re: Ultimate Menu
Post by: alex_cipher on March 19, 2022, 03:07:13 PM
I use SMF 2.1.1 and PHP 7.4.x.
Title: Re: Ultimate Menu
Post by: live627 on March 20, 2022, 03:11:14 AM
Might be a bug in SMF.  I pushed a new update which works around it.
Title: Re: Ultimate Menu
Post by: alex_cipher on March 20, 2022, 04:51:24 AM
Yes, thanky ou, now it works!

Is it possible to add or change the icons?

I have added a button to the forms and the icon is a question mark. How to change it and/or where did it come from? Did you pre-select the icons?
Title: Re: Ultimate Menu
Post by: Kindred on March 20, 2022, 09:44:51 AM
Every menu action not defined with a css image/icon gets a question mark
Title: Re: Ultimate Menu
Post by: alex_cipher on March 20, 2022, 01:16:35 PM
Quote from: Kindred on March 20, 2022, 09:44:51 AMEvery menu action not defined with a css image/icon gets a question mark
Ok, thank you!
Title: Re: Ultimate Menu
Post by: live627 on March 21, 2022, 01:27:29 AM
the fallback for the icons is the question mark. The icon set is a sprite defined by .main_icons in the CSS (https://github.com/SimpleMachines/SMF2.1/blob/863ab1dec7f1aeb23b2e8faa48d18ff414a9c067/Themes/default/css/index.css#L1742-L1749).

Each button defined by Ultimate Menu is enumerated and is prefixed with um_button_. To add your own icon, append the following code to index.css.main_icons.um_button_1::before {
background: url(../images/my-image) no-repeat;
}
the icon should be 16x16 pixels
Title: Re: Ultimate Menu
Post by: alex_cipher on March 21, 2022, 03:33:04 AM
Thank you!

So I have to append the index.css with either icons from the sprite or with my own. :)
Title: Re: Ultimate Menu
Post by: Panoulis64 on April 02, 2022, 10:59:50 AM
Suddenly, I started having problems with the forum, with UltimateMenu.
(It worked properly with two submenus)
Initially I had like this with the ultimate-menu_2-0-1 version
index.php? action = admin; area = umen; eff6bab = e4979542d84845c782cc92d86d14dfd4
  /home/triglian/public_html/Sources/Class-UltimateMenu.php (Line 401) Retrospective Information

Error type: Unspecified
Error message [Select]
8: Undefined index: replayed_menu_buttons

I uninstalled and installed the ultimate-menu_2-0-2 version, because I am in smf 2.1.1
I'm getting an error now
index.php? action = admin; area = umen
  /home/triglian/public_html/Sources/Class-UltimateMenu.php (Line 401) Retrospective Information

Error type: Unspecified
Error message [Select]
8: Undefined index: replayed_menu_buttons

and when I go to the admin to define my options, I get this error by clicking the admin link's ultimate-menu
Fatal error: Uncaught TypeError: Argument 1 passed to UltimateMenu::flatten() must be of the type array, null given, called in /home/triglian/public_html/Sources/Class-UltimateMenu.php on line 401 and defined in /home/triglian/public_html/Sources/Class-UltimateMenu.php:404 Stack trace: #0 /home/triglian/public_html/Sources/Class-UltimateMenu.php(401): UltimateMenu->flatten(NULL) #1 /home/triglian/public_html/Sources/ManageUltimateMenu.php(83): UltimateMenu->getButtonNames() #2 /home/triglian/public_html/Sources/ManageUltimateMenu.php(76): ManageUltimateMenu->listButtons() #3 /home/triglian/public_html/Sources/ManageUltimateMenu.php(43): ManageUltimateMenu->ManageMenu() #4 /home/triglian/public_html/Sources/Subs-UltimateMenu.php(96): ManageUltimateMenu->__construct('') #5 /home/triglian/public_html/Sources/Admin.php(499): {closure}() #6 /home/triglian/public_html/index.php(187): AdminMain() #7 {main} thrown in /home/triglian/public_html/Sources/Class-UltimateMenu.php on line 404

What could be wrong?

Because, he had never caused me problems before.
Thanks.
Title: Re: Ultimate Menu
Post by: live627 on April 02, 2022, 05:21:51 PM
Are those the only errors you get?

The menu cache may have gotten corrupt. Run this query to clear it
   DELETE FROM smf_settings
   WHERE variable = 'um_menu'
      OR variable = 'um_count'
      OR variable LIKE 'um_button%'

Can you show the contents of smf_um_menu? (Database table in phpMyAdmin)
Title: Re: Ultimate Menu
Post by: Panoulis64 on April 03, 2022, 12:05:12 AM
I uninstalled the application, so as not to constantly receive errors.
I also looked at smf_um_menu I do not think it exists.
The code you wrote, I have to copy it and in which file. I will do it from ftp
Title: Re: Ultimate Menu
Post by: Doug Heffernan on April 03, 2022, 07:00:06 AM
Quote from: Panoulis64 on April 03, 2022, 12:05:12 AMI uninstalled the application, so as not to constantly receive errors.
I also looked at smf_um_menu I do not think it exists.
The code you wrote, I have to copy it and in which file. I will do it from ftp

That code is a sql query and you can run it at the Sql box at your phpmyadmin.
Title: Re: Ultimate Menu
Post by: Panoulis64 on April 03, 2022, 09:26:16 AM
Thanks for the explanation, but I do not know how to do that. I will talk to the server administrator to do this as soon as possible.
Title: Re: Ultimate Menu
Post by: Doug Heffernan on April 03, 2022, 09:46:23 AM
Quote from: Panoulis64 on April 03, 2022, 09:26:16 AMThanks for the explanation, but I do not know how to do that. I will talk to the server administrator to do this as soon as possible.

It is very easy. Copy the query, then go to phpmyadmin, select the database that you have used to install your smf forum, click the SQL tab, paste the query and run it.
Title: Re: Ultimate Menu
Post by: Panoulis64 on April 03, 2022, 10:31:08 AM
I did it and nothing changed.
Finally we turned the server back 48 hours and the problem was solved.
Thanks for your time.
Title: Re: Ultimate Menu
Post by: Doug Heffernan on April 03, 2022, 11:12:53 AM
Quote from: Panoulis64 on April 03, 2022, 10:31:08 AMI did it and nothing changed.
Finally we turned the server back 48 hours and the problem was solved.
Thanks for your time.

No problem :)


Title: Re: Ultimate Menu
Post by: Shades. on April 15, 2022, 05:24:46 PM
SMF 2.1.1
Ultimate Menu 2.0.2

I found a little bug I think! When creating a new menu button and setting the permissions where only admin should be able to view the button by unselecting all member groups then click save it defaults back to the Regular Member group.

To re-create this:

1. Create a button
2. Unselect all membergroups in the permissions for that button
3. Make the button Active
4. Click save then
5. Go back into edit the button

and you will see under "Permissions" the Regular membergroup is selected.
Title: Re: Ultimate Menu
Post by: mickjav on June 19, 2022, 08:47:36 AM
I want to be able to create a Admin only link but the option of administrator is not in the list of groups. If I try and create a link without any group options I get the following message

2022-06-19.png
Title: Re: Ultimate Menu
Post by: mickjav on June 19, 2022, 10:09:28 AM
As A Thought would it be possible to add a option so it could call a function like "smfgallery_manage")

Which is part of
show' => allowedTo('smfgallery_manage'),
I've only just started with php so don't know if it would work but do understand the script would need to be loaded that contains the function for it to work.

All the best mick
Title: Re: Ultimate Menu
Post by: live627 on June 20, 2022, 03:19:53 AM
The column slug in smf_um_menu needs a default value. Either a blank string or null will work.
Title: Re: Ultimate Menu
Post by: Raffoz on September 21, 2022, 12:38:45 AM
Quote from: live627 on March 21, 2022, 01:27:29 AMthe fallback for the icons is the question mark. The icon set is a sprite defined by .main_icons in the CSS (https://github.com/SimpleMachines/SMF2.1/blob/863ab1dec7f1aeb23b2e8faa48d18ff414a9c067/Themes/default/css/index.css#L1742-L1749).

Each button defined by Ultimate Menu is enumerated and is prefixed with um_button_. To add your own icon, append the following code to index.css
.main_icons.um_button_1::before {
background: url(../images/my-image) no-repeat;
}
the icon should be 16x16 pixels

Tks @live627, I added icons with your guide 🤓

But 16x16 appears super little compared to others.
Is there another way or trick to do it?
Title: Re: Ultimate Menu
Post by: jsx on February 28, 2023, 02:01:12 PM
@live627

After removing the button, the following errors appeared:

(https://i.imgur.com/vgdt0fo.png)

(https://i.imgur.com/O4SyIbF.png)
Title: Re: Ultimate Menu
Post by: user58389239 on May 18, 2023, 04:35:20 PM
Thank you for making this Plugin work for 2.1.X! Quick question: Is there a way to backup/restore the menu items I added with this plugin? I'm installing this plugin on Dev, and I'd like to add the same menu items to Production once we upgrade to 2.1.3. Since I don't have the plugin on Prod, not sure if there is an easy/simple way to backup and restore the "list"?
Title: Re: Ultimate Menu
Post by: Diego Andrés on May 18, 2023, 06:42:31 PM
Probably backing up the um_menu table in your db.
Title: Re: Ultimate Menu
Post by: user58389239 on June 02, 2023, 05:23:22 PM
I wanted to call out this post I just created in the 2.1 support, there is a claim in there that the error is because of Ultimate Menu. Does that seem possible? If so, any suggestions for a fix without removing UM? We rely pretty heavily on it so I'm not crazy about the idea of removing it:

https://www.simplemachines.org/community/index.php?topic=586017.0
Title: Re: Ultimate Menu
Post by: glasschalice on June 09, 2023, 03:07:41 AM
Quote from: live627 on March 21, 2022, 01:27:29 AMthe fallback for the icons is the question mark. The icon set is a sprite defined by .main_icons in the CSS (https://github.com/SimpleMachines/SMF2.1/blob/863ab1dec7f1aeb23b2e8faa48d18ff414a9c067/Themes/default/css/index.css#L1742-L1749).

Each button defined by Ultimate Menu is enumerated and is prefixed with um_button_. To add your own icon, append the following code to index.css.main_icons.um_button_1::before {
background: url(../images/my-image) no-repeat;
}
the icon should be 16x16 pixels

Could you help me out with this since I'm not very familiar with coding?  What folder is index.css in?  I found them in each individual themes css folder but that would mean this would need to be changed for each theme?   And is "my-image" above the name of the actual image file I'd want the question mark changed to?  TIA
Title: Re: Ultimate Menu
Post by: Diego Andrés on June 09, 2023, 10:17:19 AM
It only needs to be changed for the theme you are currently using.
Themes/{your_theme}/css/index.css.

And yes, you need to use the name of your file. Could also target the icons folder so that it's along the rest of the icons.
.main_icons.um_button_1::before {
background: url(../images/icons/newicon.png) no-repeat;
}
Title: Re: Ultimate Menu
Post by: jsx on June 09, 2023, 10:21:58 AM
Quote from: glasschalice on June 09, 2023, 03:07:41 AMCould you help me out with this since I'm not very familiar with coding?  What folder is index.css in?  I found them in each individual themes css folder but that would mean this would need to be changed for each theme?  And is "my-image" above the name of the actual image file I'd want the question mark changed to?  TIA

See this post of mine in the NameX theme thread, you will understand how to add these icons to Ultimate Menu in the theme you are using:

https://www.simplemachines.org/community/index.php?topic=583206.msg4146927#msg4146927
Title: Re: Ultimate Menu
Post by: live627 on June 12, 2023, 02:04:16 AM
Quote from: user58389239 on June 02, 2023, 05:23:22 PMI wanted to call out this post I just created in the 2.1 support, there is a claim in there that the error is because of Ultimate Menu. Does that seem possible? If so, any suggestions for a fix without removing UM? We rely pretty heavily on it so I'm not crazy about the idea of removing it:

https://www.simplemachines.org/community/index.php?topic=586017.0
This menu mod does not affect any security features including the questionnaire or anything related to topics
Title: Re: Ultimate Menu
Post by: user58389239 on June 16, 2023, 12:06:54 PM
That's what I was thinking...I think this is just a coincidence and unrelated. "Correlation does not equal causation"
Title: Re: Ultimate Menu
Post by: user58389239 on July 14, 2023, 10:55:37 AM
I'm getting this error when trying to add a menu item. I'm wondering if I screwed something up, as I imported the table entries from my Dev site.

Field 'id_button' doesn't have a default value
File: /home/site/public_html/forum/Sources/Class-UltimateMenu.php
Line: 327

Database Error: Field 'id_button' doesn't have a default value


Any ideas of a quick fix?
Title: Re: Ultimate Menu
Post by: Kindred on July 14, 2023, 01:25:14 PM
So?  Set the field to have a default value (usually null)

This has been an issue for so many old mods and has been answered dozens,  if not hundreds of times, that I am disappointed in any user who did not bother to use a basic search first....
Title: Re: Ultimate Menu
Post by: live627 on July 14, 2023, 06:56:09 PM
Quote from: user58389239 on July 14, 2023, 10:55:37 AMDatabase Error: Field 'id_button' doesn't have a default value
Is that field auto increment? It should be.

Quote from: Kindred on July 14, 2023, 01:25:14 PMm disappointed in any user who did not bother to use a basic search first....
Prepare to be continually disappointed. If Google keeps getting worse at returning relevant and helpful results, how do you expect users to think that the forum search will fare any better?

The art of carefully crafting keyword-rich Boolean search queries is dead. Google killed that a very long time ago.
Title: Re: Ultimate Menu
Post by: user58389239 on July 17, 2023, 11:45:20 AM
That comment seemed uncalled for, Kindred. I DID do a Google search on this forum (I do that every time before I post a new post). I know how to create keyword-rich Boolean search queries.

What I did not know is that the same error for other mods applies to UltimateMenu. I saw posts about this error, but only for other mods. I was searching mainly centered around this particular mod. It did not occur to me that the same solution would apply. I'm not a developer, I'm just trying to do the best I can as a volunteer Admin for a forum I am passionate about. I don't know enough about databases to know if applying the same solution for another mod would break this particular mod. I'm a bit out of my depth here.

I will go ahead and apply the solution suggested on other posts.
Title: Re: Ultimate Menu
Post by: live627 on July 17, 2023, 06:30:51 PM
But is it auto increment? It should be.[/quote]
Title: Re: Ultimate Menu
Post by: CreativeITWorld.com on August 03, 2023, 08:46:33 AM
Very good. Works well in SMF2.1.4.

Only one issue. I'm sure someone has mentioned it by now, but just in case ...

Once you get beyond 20 entries, the risk of failure worsens. When one entry fails, it effects other entries in a cascade. The answer is to Activate all of the failed entries, but the problem is that they are now on two pages and it becomes impossible to activate them all. Try one at a time? Works for a bit and then another failure.

I gave up, read through the files in the Zip, and I solved the problem:

Sources/ManageUltimateMenu.php
Line 48: 'items_per_page' => 20,


Change it to 'items_per_page' => 100,

Then just activate everything and it all works again without fail.



Other Manual Edits I found useful are removing the Calendar and TinyPortal Menu Buttons using /* and */ so that I can re-add them later in Home and Admin:

Disabled - Menu Calendar
Sources/Subs.php Line 5534 to 5552

/*
            'calendar' => array(
                'title' => $txt['calendar'],
                'href' => $scripturl . '?action=calendar',
                'show' => $context['allow_calendar'],
                'sub_buttons' => array(
                    'view' => array(
                        'title' => $txt['calendar_menu'],
                        'href' => $scripturl . '?action=calendar',
                        'show' => $context['allow_calendar_event'],
                    ),
                    'post' => array(
                        'title' => $txt['calendar_post_event'],
                        'href' => $scripturl . '?action=calendar;sa=post',
                        'show' => $context['allow_calendar_event'],
                        'is_last' => true,
                    ),
                ),
            ),*/
           
           
Disabled - Menu TinyPortal
TinyPortal/Integrate.php Line 468 to 482

        /*if(allowedTo('tp_settings')) {
            $buttons = array_merge(
                    array_slice($buttons, 0, array_search('calendar', array_keys($buttons), true) + 1),
                    array (
                        'tpadmin' => array (
                            'icon' => 'tinyportal/menu_tp.png',
                            'title' => $txt['tp-tphelp'],
                            'href' => $scripturl.'?action=tpadmin',
                            'show' =>  TPcheckAdminAreas(),
                            'sub_buttons' => tp_getbuttons(),
                        ),
                    ),
                    $buttons
            );
        }*/


Please use the code tags when posting code. ~ Steve
Title: Re: Ultimate Menu
Post by: live627 on August 08, 2023, 07:08:09 PM
Can you clarify those failures? Those might be possible bugs that I'll need to fix. Do the menu entries just disappear from the menu? Does some text not render correctly in the table?
Title: Re: Ultimate Menu
Post by: live627 on August 08, 2023, 07:19:12 PM
I feel like this is déjà vu and that I might have already fixed this. Which version of the menu mod is this?
Title: Re: Ultimate Menu
Post by: user58389239 on September 22, 2023, 09:55:39 AM
I am not certain that this issue is related to Ultimate Menu, but since we have it installed I thought I would start here.

We are on the latest SMF version 2.1.4.

We consistently get these errors for one user who is an Admin, and only this one user:

https://www.site.com/forum/index.php?action=profile;area=tracking;sa=ip;u=xxxxx;searchip=xxx.xxx.xxx.xxx
 /home/site/public_html/forum/Themes/default/GenericMenu.template.php (Line 269) 
2: foreach() argument must be of type array|object, null given


https://www.site.com/forum/index.php?action=profile;area=tracking;sa=ip;u=xxxxx;searchip=xxx.xxx.xxx.xxx
 /home/site/public_html/forum/Themes/default/GenericMenu.template.php (Line 261)
2: Trying to access array offset on value of type null

https://www.site.com/forum/index.php?action=profile;area=tracking;sa=ip;u=xxxxx;searchip=xxx.xxx.xxx.xxx
 /home/site/public_html/forum/Themes/default/GenericMenu.template.php (Line 255)
2: Trying to access array offset on value of type null
Title: Re: Ultimate Menu
Post by: Kindred on September 22, 2023, 10:36:55 AM
That's not a problem with the menu at all.... it's a problem that something (a mod?) is not adding the correct values to the menu arguments
Title: Re: Ultimate Menu
Post by: live627 on September 22, 2023, 09:11:05 PM
but it IS from a menu. Might be the menu bug that will be fixed in SMF 2.1.5.

Remove menu item if all submenu items are disabled (https://github.com/SimpleMachines/SMF/pull/7733)
Title: Re: Ultimate Menu
Post by: user58389239 on September 23, 2023, 02:27:20 PM
The only Mod we have installed is Ultimate Menu, so if it is related to a Mod it must be this one.

I'll keep an eye out for the release of 2.1.5 and see if it fixes it. Thanks!
Title: Re: Ultimate Menu
Post by: user2020 on October 05, 2023, 04:39:36 PM
On some themes the icon is missing on custom links. How to fix this or add my own icons to them? I'm using the Steyle-V4 theme.
Title: Re: Ultimate Menu
Post by: VE3JOC on October 31, 2023, 01:58:40 PM
I installed the Ultimate Menu mod ans set it up along with permissions.  I created a category and then tried to upload a file for download.  I entered a title, selected the category, added a description and then clicked the Browse button and selected a file.  Then I clicked the "Add Download" button.  It appeared to be uploading but the stopped and said that there was an error. It said "You need to enter a Title."

I went back and entered a title again, even though I had entered one the first time, and tried again but go the same error again.  How do I correct this or is it s bug in the mod?

Title: Re: Ultimate Menu
Post by: live627 on October 31, 2023, 04:12:37 PM
Can you add a screenshot?
Title: Re: Ultimate Menu
Post by: VE3JOC on November 01, 2023, 10:40:53 AM
Sorry, I decided to make it simple and just use attachments instead.  Thank you for responding anyway.

Cheers
Title: Re: Ultimate Menu
Post by: manudevil on February 14, 2024, 05:50:56 PM
Hello !

I used Ultimate Menu on my forum, SMF 2.1.4. Last week, it stopped working. No additional button anymore...
When I try to add a button, I got a message :
Field 'slug' doesn't have a default value
Fichier: /homepages/XXXXX/forum/Sources/Class-UltimateMenu.php
Ligne: 327

What can be done ?

Thank you.
Title: Re: Ultimate Menu
Post by: manudevil on February 18, 2024, 05:16:03 AM
I uninstalled the plugin, keeping data, and reinstalled it. The buttons reappeared.
Title: Re: Ultimate Menu
Post by: live627 on February 19, 2024, 02:01:16 AM
Quote from: manudevil on February 14, 2024, 05:50:56 PMHello !

I used Ultimate Menu on my forum, SMF 2.1.4. Last week, it stopped working. No additional button anymore...
When I try to add a button, I got a message :
Field 'slug' doesn't have a default value
Fichier: /homepages/XXXXX/forum/Sources/Class-UltimateMenu.php
Ligne: 327

What can be done ?

Thank you.
that's a field left from older version
Title: Re: Ultimate Menu
Post by: Kindred on February 19, 2024, 08:46:40 AM
Quote from: manudevil on February 14, 2024, 05:50:56 PMHello !

I used Ultimate Menu on my forum, SMF 2.1.4. Last week, it stopped working. No additional button anymore...
When I try to add a button, I got a message :
Field 'slug' doesn't have a default value
Fichier: /homepages/XXXXX/forum/Sources/Class-UltimateMenu.php
Ligne: 327

What can be done ?

Thank you.

Do. Give it a default value... that error has been asked and answered about a thousand times since mysql started requiring a default years ago
Title: Re: Ultimate Menu
Post by: CreativeITWorld.com on March 07, 2024, 06:13:58 PM
Quote from: CreativeITWorld.com on August 03, 2023, 08:46:33 AMOnce you get beyond 20 entries, the risk of failure worsens. When one entry fails, it effects other entries in a cascade. The answer is to Activate all of the failed entries, but the problem is that they are now on two pages and it becomes impossible to activate them all. Try one at a time? Works for a bit and then another failure.

I gave up, read through the files in the Zip, and I solved the problem:

Sources/ManageUltimateMenu.php
Line 48: 'items_per_page' => 20,


Change it to 'items_per_page' => 100,

Then just activate everything and it all works again without fail.

Quote from: live627 on August 08, 2023, 07:19:12 PMI feel like this is déjà vu and that I might have already fixed this. Which version of the menu mod is this?

Using the latest version, which at this moment is Ultimate Menu v2.0.2.

Even if this wasn't an issue, having all the menu entries on a single page would still make it easier to manage.
Title: Re: Ultimate Menu
Post by: live627 on March 08, 2024, 12:06:42 AM
Where are the failures? How do they occur? Can you post a screenshot?
Title: Re: Ultimate Menu
Post by: grega on March 08, 2024, 01:46:19 AM
Can one specify custom icons for each entry?
Title: Re: Ultimate Menu
Post by: davo88 on March 19, 2024, 02:51:51 AM
Quote from: gregaCan one specify custom icons for each entry?
gega - see here (https://www.simplemachines.org/community/index.php?msg=4117026). I tried it and it works fine.
Title: Re: Ultimate Menu
Post by: davo88 on March 19, 2024, 02:54:22 AM
v2.1.4
I am getting just to know UM and notice there are some menu items that appear in the configuration dropdown that do not appear on the SMF main menu - 'Log In', 'Log Out' and 'Sign Up'.

2024-03-19_11-04-29.jpg
Are these hidden menu items able to be turned on anywhere? Or removed from this dropdown?

As I plan to add 'Log In' and 'Log Out' buttons using UM, it gets a bit confusing with two sets of buttons with the same name.
If I pick the wrong one as a reference position (before, after), it generates errors. So any information that can help me understand these three buttons appearing in the dropdown much appreciated.