Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: qICEp on November 24, 2014, 03:25:09 PM

Title: 2.1 Tokens
Post by: qICEp on November 24, 2014, 03:25:09 PM
Just found time to play with 2.1 after a long time and i noticed that tokens fields in templates.
I know about these since the 2.1 hit github and i was thinking its a experiment to see if the system is working and that it will be converted to some kind of form helper that would handle tokens. But i see i was wrong...

May i ask why someone bothered to add all that tokens hidden input to each form when it was way better to handle with some kind of form helper (generator)?
Whole form validation process could be more secure against human error and still being easier to implement (not to mention making life easier for people that will make mods). Was these overlooked or i dont get some point?
Title: Re: 2.1 Tokens
Post by: Arantor on November 24, 2014, 03:26:55 PM
Because rewriting everything to use form helpers is actually much, much more work than adding tokens actually was.
Title: Re: 2.1 Tokens
Post by: live627 on November 24, 2014, 09:23:32 PM
2.1 won't get any new unified form helpers.
Title: Re: 2.1 Tokens
Post by: Suki on November 24, 2014, 09:41:51 PM
There is some code buried somewhere on SVN and I actually thought about adding it, I have some code I can adapt for it however, its too late to modify every form to use it and it will be kinda weird to provide a form builder without actually using it.
Title: Re: 2.1 Tokens
Post by: qICEp on November 25, 2014, 03:57:35 PM
Well if someone went to every form to add that input field i dont think it would make much difference if he actually converted forms instead... Simply said i can not understand that 2.1 had such active development, great idea, and it was given allot of time but some things like these were never planed (i expected that someone just forgot to commit changes)

I understand that 2.1 has hit its first beta and that now there is nothing to do about these. (Thats what you get for being lazy to ask when its time  :'( )

Anyway thanks for answers guys.
Title: Re: 2.1 Tokens
Post by: Arantor on November 25, 2014, 04:00:47 PM
Adding tokens is like a 2 line job for each form - adding a form handler means a complete rewrite of every form.
Title: Re: 2.1 Tokens
Post by: Dragooon on November 25, 2014, 04:02:52 PM
Quote from: qICEp on November 25, 2014, 03:57:35 PM
Well if someone went to every form to add that input field i dont think it would make much difference if he actually converted forms instead... Simply said i can not understand that 2.1 had such active development, great idea, and it was given allot of time but some things like these were never planed (i expected that someone just forgot to commit changes)
Using a form builder would require converting all the form templates into using the form builder class, that's a lot of work.
Title: Re: 2.1 Tokens
Post by: Kindred on November 25, 2014, 05:30:24 PM
And it was never part of the 2.1 plan either, because of the amount of work.