Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: Rumpa on January 03, 2015, 01:46:44 PM

Title: Show Topic Start Time in Topic List
Post by: Rumpa on January 03, 2015, 01:46:44 PM
Link to the mod (https://custom.simplemachines.org/index.php?mod=4011)

About

This modification simply Show Topic Start Time in Topic List Without Enter the Topic before Topic Creater Link.

Version

V-2.0 for SMF 2.0.19 and 2.1.2

Author

Rumpa

License

This modification is licensed under BSD License

http://www.opensource.org/licenses/bsd-license.php

                        Copyright (c) 2014, Rumpa
                         All rights reserved.
Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

* Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

* Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on April 27, 2015, 08:46:48 AM
V1.1 released
Title: Re: Show Topic Start Time in Topic List
Post by: Steve on April 27, 2015, 09:20:31 AM
What changes were there? :)
Title: Re: Show Topic Start Time in Topic List
Post by: Empire KickAss on April 27, 2015, 09:24:36 AM
This looks good. But it looks busy. It makes the site to much. I like it as simple and quince
Title: Re: Show Topic Start Time in Topic List
Post by: Steve on April 27, 2015, 09:30:06 AM
Then don't use it. ;) :P

Personally, having switched from IPB, I missed not knowing when the topic was started by looking at the topic index.

The ultimate for me would be the start date would only show as a tooltip when you hover over the topic title. That way, the topic index wouldn't look so busy as you say. :)
Title: Re: Show Topic Start Time in Topic List
Post by: Steve on May 05, 2015, 06:05:28 PM
Quote from: Steve on April 27, 2015, 09:20:31 AM
What changes were there? :)

Do you not have notifications turned on for your mods, Rumpa?
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on May 08, 2015, 01:23:57 AM
Quote from: Steve on May 05, 2015, 06:05:28 PM
Quote from: Steve on April 27, 2015, 09:20:31 AM
What changes were there? :)

Do you not have notifications turned on for your mods, Rumpa?

oops sorry I forgot
Title: Re: Show Topic Start Time in Topic List
Post by: brynn on July 19, 2015, 11:52:21 PM
Well, I was looking forward to installing this mod, because I think the start time/date of topics is important. 

But when I tried to install on SMF 2.0.10 with Tiny Portal 1.107, every single test failed!  Every one!
Title: Re: Show Topic Start Time in Topic List
Post by: br360 on July 20, 2015, 01:16:26 AM
Every single test? From what I can see, this mod only requires one small edit in only one file. Did you download the v1.1.zip?
Title: Re: Show Topic Start Time in Topic List
Post by: brynn on July 20, 2015, 05:09:34 AM
Yes, STSTTL-v1.1.zip.  Thanks for replying.  One alternate theme didn't show red failed, but all else is red.

It's possible that there is a way to install this mod.  I don't know anything about coding or editing mod files.  If they install right through without problems, I can use them.  If they show any errors, either I can't use them; or if I want the mod bad enough, I ask someone else to help me.

So coming from this place where I'm unable to edit files without help, if I see all those lines of red failed tests, it looks to me like it's nowhere close to stable.  Maybe it does only need one edit, but I can't figure that out myself.

I just wanted to share my experience, in case the author wants to know about it.  I'll make a decision (after I finish installing all the mods I found) about how  bad I want it, and whether I want to ask for help.  But for now, I just wanted to report it.   :)

(slightly off topic - it seems to me like this should be a default feature of SMF, rather than an optional mod - but that's another story)
Title: Re: Show Topic Start Time in Topic List
Post by: margarett on July 20, 2015, 05:46:11 AM
Does it fail in default theme?

Unfortunately there is no good way to do it. If it doesn't work automatically from Package Manager you have to do it manually (or don't use it at all)
Manual Installation of Mods (http://wiki.simplemachines.org/smf/Manual_installation_of_mods)
Title: Re: Show Topic Start Time in Topic List
Post by: brynn on July 20, 2015, 05:52:45 AM
Yes, it fails in the default theme.  Also fails in Core theme.

Thanks for the info for manual installation.  I'm not sure if I understand, but I'll study and try to learn   :)
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on July 20, 2015, 10:13:17 AM
It's might be tiny portal problem. try it without that.
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on July 20, 2015, 10:15:37 AM
Quote from: brynn on July 20, 2015, 05:52:45 AM
Yes, it fails in the default theme.
no way
Title: Re: Show Topic Start Time in Topic List
Post by: Steve on July 20, 2015, 05:03:01 PM
Quote from: Rumpa on July 20, 2015, 10:15:37 AM
Quote from: brynn on July 20, 2015, 05:52:45 AM
Yes, it fails in the default theme.
no way

If her default theme is heavily modified I suppose it's possible, though I find it surprising as well.

And brynn, I or mikey can walk you through manually installing this if you want. It's pretty easy, especially for a mod like this. :)
Title: Re: Show Topic Start Time in Topic List
Post by: brynn on July 21, 2015, 08:09:22 AM
Quote from: Rumpa on July 20, 2015, 10:15:37 AM
Quote from: brynn on July 20, 2015, 05:52:45 AM
Yes, it fails in the default theme.
no way

Yes way!  See screenshot.

My default theme is Aqua Style.  And you can see that Core theme fails too.  (I'm never quite sure what people mean when they refer to the default theme - but it's one or the other of those 2.)

I'm not very inclined to uninstall my portal, just to test this mod.  I'd probably want to go into Maintenance mode to try it.
Title: Re: Show Topic Start Time in Topic List
Post by: Kindred on July 21, 2015, 08:29:26 AM
YOUR default theme may be the Aqua - but "THE DEFAULT THEME" (also known as CURVE) is the one in the Themes/default directory -- and that is the only theme which mods are required to install cleanly on...

Based on your errors, it would suggest that you have some OTHER mod which has already edited/changed the section of code which this on targets.

Which means, as always, that, if you want this mod, you will have to MANUALLY parse the changes and figure out how to combine it with the changes that are already present
http://wiki.simplemachines.org/smf/Error_in_mod_installation
Title: Re: Show Topic Start Time in Topic List
Post by: brynn on July 21, 2015, 08:44:12 AM
Well I don't even use Curve theme.  So I don't know if it installs on that or not.

But thanks for the info.  Likely I won't be able to figure it out.  But I'll try.

Thanks again.
Title: Re: Show Topic Start Time in Topic List
Post by: Kindred on July 21, 2015, 08:48:48 AM
yes, actually you *DO* use the Curve theme -- and it **HAS TO** install into that -- because if it does not, then 90% of your other themes won't work (and the mod would never have been approved)

custom themes, in SMF, do not completely redefine every template...   they only define the templates which are significantly different from the default (curve)
Any template file which is NOT specifically included/defined in the custom theme will automatically use the default (curve) theme version of that template.

This is why you can never, ever ever ever ever delete the default theme directory.... even if you have "disabled" the user's option to select the default (curve) theme as a theme choice - you MUST have the FILES present and the theme DEFINED in your SMF admin.
Title: Re: Show Topic Start Time in Topic List
Post by: margarett on July 21, 2015, 09:31:15 AM
FWIW, the edit that this MOD puts in place is really, really small and can easily be manually added.

You just need to search:
', $txt['started_by'], ' ', $topic['first_post']['member']['link'], '
And replace with
', $txt['on'], ' ', $topic['first_post']['time'],' ', $txt['started_by'], ' ', $topic['first_post']['member']['link'], '
Which can also be said: add
', $txt['on'], ' ', $topic['first_post']['time'],'
Before the first code.

If it fails to install, as Kindred said, it's because other MOD probably changed the "original" code and PackMan can't find the exact string it's looking for. But such small modification should be easily doable by hand ;)
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on July 21, 2015, 10:00:55 AM
Hey @brynn if you upload MessageIndex.template.php in here I will do it for you.
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on September 30, 2015, 03:01:51 AM
V1.2 Released for SMF 2.0.11
Title: Re: Show Topic Start Time in Topic List
Post by: DSystem on October 01, 2015, 12:43:50 PM
I made this change and got a clean look

from:
', $txt['on'], ' ', $topic['first_post']['time'],' ', $txt['started_by'], ' ', $topic['first_post']['member']['link'], '

to:
', $txt['started_by'], ' ', $topic['first_post']['member']['link'], ', ', $topic['first_post']['time'], '

before:
on December 15, 2014, 05:23:26  AM Starded by Rumpa

After:
Starded by Rumpa, December 15, 2014, 05:23:26
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on October 02, 2015, 03:35:36 AM
Quote from: DSystem on October 01, 2015, 12:43:50 PM
I made this change and got a clean look

from:
', $txt['on'], ' ', $topic['first_post']['time'],' ', $txt['started_by'], ' ', $topic['first_post']['member']['link'], '

to:
', $txt['started_by'], ' ', $topic['first_post']['member']['link'], ', ', $topic['first_post']['time'], '

before:
on December 15, 2014, 05:23:26  AM Starded by Rumpa

After:
Starded by Rumpa, December 15, 2014, 05:23:26

Good work I will update it.
Title: Re: Show Topic Start Time in Topic List
Post by: Rumpa on October 22, 2022, 05:33:18 PM
v2.0 is working fine both SMF 2.0.19 and  2.1.2