Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: Palloy on June 13, 2015, 09:13:23 PM

Title: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 13, 2015, 09:13:23 PM
I am just doing my first SMF update,
2.0.7 to 2.0.8 worked OK
2.0.8 to 2.0.9 worked OK
2.0.9 to 2.0.10 uploaded OK, and then failed during the testing process pre-install:
*    2.    Execute Modification    ./Themes/default/languages/index.english.php    Test failed
      1.    Replace    ./Themes/default/languages/index.english.php    Test failed
      2.    Replace    ./Themes/default/languages/index.english.php    Test successful

All the other tests were successful.

I notice that 2.0.7+ needs PHP 5.5 and was running 5.4, so I updated PHP to 5.5
and tried 2.0.9 to 2.0.10 again, same fail.

It doesn't look all that serious, but then it says it is serious.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Steve on June 13, 2015, 09:53:31 PM
What is the actual fail? Is it looking for a version number and the one in your file is one off of the one it's looking for?

If so, you can go ahead and install the update and just make that change manually.

http://www.simplemachines.org/community/index.php?topic=536161.msg3809804#msg3809804
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 13, 2015, 10:25:55 PM
Not sure what the fail is.
I have copy-pasted all I can see.
I don't understand the significance of
1.    Replace    ./Themes/default/languages/index.english.php    Test failed
2.    Replace    ./Themes/default/languages/index.english.php    Test successful

Does that mean it tried to check something twice and failed on the first time only?
In that case the overall result of the test should have been "successful", but it was "failed".

./smf/Themes/default/languages/index.php contains
<?php
// Version: 2.0.7; index

and

./smf/Themes/default/languages/index.php~ contains
<?php
// Version: 2.0.7; index

both files modified today.

I can do the automatic install and then FTP the /index.php if I can find the v2.0.10 version, but where?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Kindred on June 13, 2015, 10:36:51 PM
Read the FAQ/wiki article on what to do if a mod install shows errors...
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 13, 2015, 11:27:38 PM
Ah I see, by clicking on the icon to the left of the error, it tells me what it was looking for - which was version 2.0.8.
Now I have just completed the update from 2.0.7 to 2.0.8, and 2.0.8 to 2.0.9 successfully, but 2.0.9 to 2.0.10 says it was expecting
./Themes/default/languages/index.english.php to be 2.0.8 and found it was 2.0.7 .

I'm assuming I can go ahead and do the installation, so long as afterwards I check that ./Themes/default/languages/index.english.php ends up v2.0.10.

Trying that.

Well the install proceeded OK, but the version is still 2.0.7

Detailled Version Check shows:
SMF File         Your Version    Current Version
SMF Package    SMF 2.0.10    SMF 2.0.10
Sources          2.0.8             2.0.10
Default Templates    2.0.10    2.0.10
Language Files    2.0.7            2.0.10

Expanding "Sources" there is only one in red:
Subs-Post.php     2.0.8      2.0.10

Expanding "Language Files" there is only one in red:
index.english.php  2.0.7   2.0.10
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 13, 2015, 11:47:28 PM
So I downloaded the whole SMF 2.0.10 to my PC, extracted those two files, and FTP'd them, overwritings the old version,
and re-ran the Detailled Version Check, which said everything is now OK.

Those two file errors must have happened on the 2.0.7 to 2.0.8 update, without being reported.

Thanks for your help.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Steve on June 14, 2015, 07:56:19 AM
It was a known event which is why I linked to the post I did.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 14, 2015, 05:48:35 PM
Fair enough, I didn't read the link properly.   :-[

But didn't whatever caused the problem in the first place get FIXED once it was found, so that other people didn't blunder into the "known event"?
I am taking over maintenance of a site that hasn't had any patches ever.  I've got another SMF on the site and that is still at version 2.0.3 .
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Steve on June 14, 2015, 05:53:11 PM
The 'problem' doesn't affect everyone though. There's a thread here somewhere that explains exactly what's happening but it would take me forever to find it. Maybe one of the support team knows which one it is off the top of their heads.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: margarett on June 14, 2015, 06:08:33 PM
The problem is with the version headers in each file.
index.template.php is a "known" issue, which we were able to trace back. Basically you did the right thing: install the patch and fix the version numbers.

The issue in Subs-Post.php is not expected and might indicate outdated code... Could you please attach that file?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 14, 2015, 07:25:00 PM
These are the two versions I have (attached).  I had to rename Subs-Post.php~ to old.Subs-Post.php to get Attach>Browse to pick it up.  They are 2.0.9 and 2.0.10, which is probably not very helpful, but things were apparently working at that point.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 14, 2015, 07:26:56 PM
Sorry, attached is 2.0.10
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Steve on June 14, 2015, 07:27:14 PM
Just an FYI, the file with the ~ is just a backup file. You would normally attach the one without the tilde.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 14, 2015, 07:36:28 PM
Yes, but that one (2.0.9) was the current one at the time the patch failed.

I guess what would be more interesting is what I had at 2.0.7 to 2.0.8, but those are gone now.
I could probably dig 2.0.7 out of a backup if it is important.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Kindred on June 14, 2015, 08:59:14 PM
What?

You can't just randomly replace files...
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 14, 2015, 11:59:07 PM
I didn't randomly do anything.
When the package version was 2.0.9, the version number in Subs-Post.php was 2.0.8.
When I tried the update to 2.0.10 it complained.
I went ahead anyway and afterwards did a File Version Check, and it reported Subs-Post.php as 2.0.8 not 2.0.10
I then FTP'd Subs-Post.php 2.0.10 overwriting 2.0.8, and File Version Check reported OK.

That may turn out to have been the wrong thing to do, but it must be better than having File Version Check reporting an error, surely?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Kindred on June 15, 2015, 06:40:52 AM
that is not what our instructions said to do....  and that is not the proper action.

The proper action would have been to manually CHANGE the one line that was causing the error.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 15, 2015, 09:04:18 AM
How could that possibly produce a different result from uploading the latest file from the 2.0.10 package?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Kindred on June 15, 2015, 09:04:57 AM
had you ever applied any mods to the previous versions?

If so, then you may have just removed some of the mod code
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 15, 2015, 09:33:12 AM
I'm struggling to understand you.
Are you saying that there could be two version 2.0.10s of the same file, that are different, one arrived at by editing a previously moded version, and the other extracted from the 2.0.10 package?
I don't see how SMF could keep control of that, no, they can't be different.

I can see why editing the file would be the easiest way to achieve THE 2.0.10 file given the circumstances, but the other way must produce the same result too.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Kindred on June 15, 2015, 09:58:44 AM
1- mods applied to your system often modify the SOURCE FILES.   - yes.
2- yes, this means that your system files may differ from the released/default files.
3- this is why we release PATCH updates instead of forcing everyone  to just load a clean set of files every time.

So, yes...  if you replaced your files with copies from the distribution archive, you MAY have removed code which was inserted by previously applied mods. (depending on what mods you have previously installed)
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 15, 2015, 09:51:21 PM
By "mods" do you mean changes I have made to the code, or SMF has made?

I have diff'd old.Subs-Post.php and Subs-Post.php and the only difference apart from the version number is
the old version has an extra blank line at line 3247.
So am I good to go now?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Kindred on June 15, 2015, 11:47:55 PM
By mods, I mean, typically, mod packages...   But that could also include manually modifications that you made.

Subs-post should be ok, as you checked...  And you lucked out...  But doing what you did is not the way to go about it in the future.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 16, 2015, 09:13:23 PM
Thank you, getting clearer now.

This might be put in a new thread:
The site has 3 SMF packages that will be split into 3 sites soon, two are now updated to 2.0.10, and I'm about to start on the third which is at 2.0.3 - backups in progress.

Unlike the other 2, when I hover over "Admin" I don't get a dropdown list, so I can't go to Package Manager.
Is this an indication of an error somewhere, or did Package Manager come in later?
Can I add Package Manager now?

Else should I do the manual edits at
http://custom.simplemachines.org/upgrades/index.php?action=upgrade;file=smf_patch_2.0.4.tar.gz;smf_version=2.0.3

Else what.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Illori on June 17, 2015, 05:20:24 AM
package manager has been a default feature since before 2.0 was released. it sounds like your theme does not support the drop down menus.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Kindred on June 17, 2015, 06:45:03 AM
just click on the admin link, and then, under main, in the admin secondary menu go to the package manager....
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 17, 2015, 09:42:03 AM
There's no secondary drop-down menu.
Clicking Administration Center brings up the same page.
Screenshot attached.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Illori on June 17, 2015, 09:47:53 AM
are you a full admin?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 17, 2015, 10:03:35 AM
As far as I know, yes.  How can I check?
I'm not a moderator.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Illori on June 17, 2015, 10:06:42 AM
did you create the forum or someone else? do you know if you are in the administrators group or some other group?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 17, 2015, 05:25:39 PM
No, I didn't create the forum.
I am in the admin group, otherwise I wouldn't see Admin on the menu bar.
I'm not sure what meant by "full admin" earlier - are there different grades of admin? How do I tell?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Illori on June 17, 2015, 05:27:18 PM
there are permissions that can mimi administrator permissions but not have them all. it seems like you have some but not all.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 17, 2015, 06:33:57 PM
There is a subtle difference between the 3 forums - I was already a user of the one giving trouble and Admin privileges were added.
For the other two, a new user with Admin privileges was created for me.
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: margarett on June 17, 2015, 06:47:01 PM
Unless this mod is installed
http://custom.simplemachines.org/mods/index.php?mod=3919
(For which you should see a warning in the admin panel)

You are not an administrator. Can you access the membergroup configuration? If so you should be able to see yourself in the group with ID 1
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Illori on June 17, 2015, 06:47:17 PM
can you view the groups and their permissions in the admin panel?
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 17, 2015, 10:11:19 PM
No, I can't see membergroup permissions or anything like that.
I'm going to have to ask the owner to give me permissions properly.
Can you give me idiotproof directions on how to do that?
(he is more of an idiot than I am)
Title: Re: ./Themes/default/languages/index.english.php Test failed
Post by: Palloy on June 18, 2015, 04:20:31 AM
OK, that's all fixed up now, thanks.