Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: Sir Osis of Liver on May 31, 2016, 04:25:17 PM

Title: GoDaddy mod_security
Post by: Sir Osis of Liver on May 31, 2016, 04:25:17 PM
Did anyone ever come up with a fix for this?

Fatal error: require_once() [function.require]: Failed opening required '/home/content/43/12872143/html/forum/Sources/Subs-Auth.php' (include_path='.:/usr/local/php5_3/lib/php') in /home/content/43/12872143/html/forum/Sources/Security.php on line 543

Has it been addressed in 2.1?
Title: Re: GoDaddy mod_security
Post by: Arantor on May 31, 2016, 04:44:01 PM
How can we resolve "the host removed the file because it tripped a really obscure, hard to diagnose security scan where it uses a function that malicious people use therefore it must be bad" problem?
Title: Re: GoDaddy mod_security
Post by: Sir Osis of Liver on May 31, 2016, 05:02:27 PM
Wonder what they're scanning for.  File uploads, shows up for a fraction of a second, then disappears.  Forum owner will ask GD to disable it, don't know if they will.
Title: Re: GoDaddy mod_security
Post by: Illori on May 31, 2016, 05:03:44 PM
if you upload the file with the file manager it will not disappear. we have tried to find out why files go missing but they dont tell us why.
Title: Re: GoDaddy mod_security
Post by: Sir Osis of Liver on May 31, 2016, 05:16:41 PM
It's being triggered by this -



$_REQUEST['search'] = $smcFunc['htmlspecialchars']($_REQUEST['search']) . '*';
$_REQUEST['search'] = trim($smcFunc['strtolower']($_REQUEST['search']));



Title: Re: GoDaddy mod_security
Post by: Sir Osis of Liver on May 31, 2016, 05:30:23 PM
Quote from: Illori on May 31, 2016, 05:03:44 PM
if you upload the file with the file manager it will not disappear.

That works, thanks.  Forum is running.  Must be something specific to ftp server.
Title: Re: GoDaddy mod_security
Post by: Sir Osis of Liver on June 01, 2016, 12:58:36 PM
If you change this -



$_REQUEST['search'] = $smcFunc['htmlspecialchars']($_REQUEST['search']) . '*';
$_REQUEST['search'] = trim($smcFunc['strtolower']($_REQUEST['search']));



to this -



$_REQUEST['search'] = $smcFunc['htmlspecialchars']($_REQUEST['']) . '*';
$_REQUEST['search'] = trim($smcFunc['strtolower']($_REQUEST['']));



Subs-Auth.php uploads normally.  If you put anything in the brackets in $_REQUEST[''] -



$_REQUEST['search'] = $smcFunc['htmlspecialchars']($_REQUEST['test']) . '*';
$_REQUEST['search'] = trim($smcFunc['strtolower']($_REQUEST['test']));



it fails.

The third line in that code block -



$_REQUEST['search'] = strtr($_REQUEST['search'], array('%' => '\%', '_' => '\_', '*' => '%', '?' => '_', '&' => '&'));



does not trigger the problem. (https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.thekrashsite.com%2Fpics%2Fidk.gif&hash=9ac7acf13f4cfaa1b58390444a38dea11e5473d2)

Title: Re: GoDaddy mod_security
Post by: Arantor on June 01, 2016, 01:40:45 PM
WTF GoDaddy.
Title: Re: GoDaddy mod_security
Post by: nend on June 01, 2016, 11:59:25 PM
I haven't notice this issue, using SSH.
Title: Re: GoDaddy mod_security
Post by: vbgamer45 on September 15, 2019, 09:14:54 PM
Quote from: Sir Osis of Liver on June 01, 2016, 12:58:36 PM
If you change this -



$_REQUEST['search'] = $smcFunc['htmlspecialchars']($_REQUEST['search']) . '*';
$_REQUEST['search'] = trim($smcFunc['strtolower']($_REQUEST['search']));



to this -



$_REQUEST['search'] = $smcFunc['htmlspecialchars']($_REQUEST['']) . '*';
$_REQUEST['search'] = trim($smcFunc['strtolower']($_REQUEST['']));



Subs-Auth.php uploads normally.  If you put anything in the brackets in $_REQUEST[''] -



$_REQUEST['search'] = $smcFunc['htmlspecialchars']($_REQUEST['test']) . '*';
$_REQUEST['search'] = trim($smcFunc['strtolower']($_REQUEST['test']));



it fails.

The third line in that code block -



$_REQUEST['search'] = strtr($_REQUEST['search'], array('%' => '\%', '_' => '\_', '*' => '%', '?' => '_', '&' => '&'));



does not trigger the problem. (https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.thekrashsite.com%2Fpics%2Fidk.gif&hash=9ac7acf13f4cfaa1b58390444a38dea11e5473d2)



I ended up running into this I changed the code to make it more hidden

eval(base64_decode('JF9SRVFVRVNUWydzZWFyY2gnXSA9ICRzbWNGdW5jWydodG1sc3BlY2lhbGNoYXJzJ10oJF9SRVFVRVNUWydzZWFyY2gnXSkgLiAnKic7CgkkX1JFUVVFU1RbJ3NlYXJjaCddID0gdHJpbSgkc21jRnVuY1snc3RydG9sb3dlciddKCRfUkVRVUVTVFsnc2VhcmNoJ10pKTs='));

Title: Re: GoDaddy mod_security
Post by: Arantor on September 16, 2019, 02:32:37 AM
Suspect that will get flagged for looking like malware.
Title: Re: GoDaddy mod_security
Post by: vbgamer45 on September 16, 2019, 09:03:23 AM
I did it for one file. Then realized godaddy flagged also
Post.php
PersonalMessage.php
Subs-Auth.php
ModerationCenter.ph
Subs-Post.php
LogInOut.php
Subs-Editor.php
Register.php
Reminder.php

Then wrote a script to upload the file and that works. Seems like they just delete/scan the files on ftp upload..
Title: Re: GoDaddy mod_security
Post by: Aleksi "Lex" Kilpinen on September 16, 2019, 11:54:54 AM
Yup, we've seen that alot. And always without exception the solution has been to upload the missing files using another method. Sucks, but that's how it is.
Title: Re: GoDaddy mod_security
Post by: Sir Osis of Liver on September 16, 2019, 12:43:51 PM
Most files I've ever seen blocked was an even dozen, but hasn't happened recently.  GoDaddy has so many different server configurations, you never know what you're working with (neither do they).