Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: ApplianceJunk on June 04, 2016, 06:33:56 PM

Title: External links no longer open in a new tab.
Post by: ApplianceJunk on June 04, 2016, 06:33:56 PM
I don't recall making any changes for sometime now, but just noticed today that our affiliate links no longer open up in a new tab.
It's been so long I don't remember if external links always opened in a new tab or if I had to select some option for that to happen.

Here is a post with external links along with links at the bottom to "washer parts", "dryer parts" and so on so you can see for yourself how the links are currently opening up in the same window.

http://appliancejunk.com/forums/index.php?topic=18772.0

I'm almost 100% sure that yesterday when I posted a reply to the topic I posted the link to the "video" link opened up in a new tab, but today it no longer does.

How do I get the external links to open up in a new tab?

Thanks,
Title: Re: External links no longer open in a new tab.
Post by: Kindred on June 04, 2016, 06:38:13 PM
you must have changed something...   

by default all links using the URL BBC tag open in a new window, links using the IURL BBC tag do not.
If your URL links are not opening, then you changed the BBC or you changed your browser settings.
Title: Re: External links no longer open in a new tab.
Post by: Illori on June 04, 2016, 07:11:11 PM
how are the affiliated links added? a mod? if so ask the author of that mod for support. affiliated links is not a default part of SMF.
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 04, 2016, 09:21:54 PM
Quote from: Illori on June 04, 2016, 07:11:11 PM
how are the affiliated links added? a mod? if so ask the author of that mod for support. affiliated links is not a default part of SMF.

Just like any other link. I put the http://... between the URL tags.
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 04, 2016, 09:26:16 PM
Quote from: Kindred on June 04, 2016, 06:38:13 PM
you must have changed something...   

by default all links using the URL BBC tag open in a new window, links using the IURL BBC tag do not.
If your URL links are not opening, then you changed the BBC or you changed your browser settings.

Nope, I have not changed anything for months.
The only thing that has changed was our hosting package and I think maybe we got moved to a different server. I don't see how anything with my host would effect how links open.

So if by default all links open in a new window and I wanted to change it what would I do to change it?
Maybe knowing that will give me something to look into because I don't recall ever changing anything for many months.
Title: Re: External links no longer open in a new tab.
Post by: Kindred on June 04, 2016, 10:09:24 PM
URL demonstrating the issue?
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 04, 2016, 10:28:08 PM
Quote from: Kindred on June 04, 2016, 10:09:24 PM
URL demonstrating the issue?

Any of the link posted in this topic (or any other topic on our site) along with the links at the bottom that say, washer parts, dryer parts...

http://appliancejunk.com/forums/index.php?topic=18772.0
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 04, 2016, 10:39:38 PM
Even if I post a simple URL to google like this http://google.com it opens in the same window on my site, unlike here where it opens in a new tab.
Title: Re: External links no longer open in a new tab.
Post by: Kindred on June 04, 2016, 11:25:27 PM
Yup... Soemthing hasd definitely been changed on your site to affect links.

The bus array is in subs.php... But it's a complicated mess...
Title: Re: External links no longer open in a new tab.
Post by: Shambles on June 05, 2016, 04:43:08 AM
Try temporarily removing / disabling Google Analytics.
Title: Re: External links no longer open in a new tab.
Post by: Illori on June 05, 2016, 06:33:09 AM
Quote from: Shambles on June 05, 2016, 04:43:08 AM
Try temporarily removing / disabling Google Analytics.

i bet that is part of it, with a blocker that includes analytics the links open in a new tab for me on the page that was linked.
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 06, 2016, 09:19:34 AM
Quote from: Shambles on June 05, 2016, 04:43:08 AM
Try temporarily removing / disabling Google Analytics.

I'm using the Google Analytics mod, so I removed my Google Analytics Code the other day by going to  Configeration>Features & Options.
Today I see Google Analytics shows no stats for me from yesterday, so guess it's disabled, but I still have the same problem with my links.

Even links in my "News" section in the top right corner that have  target="_blank" still open in the same window.

This is now driving me crazy.

Quotei bet that is part of it, with a blocker that includes analytics the links open in a new tab for me on the page that was linked.

What blocker is that. I would like to try and see for myself. I run chrome with a blocker, but I don't see any difference with or without the blocker.

Thanks,

Title: Re: External links no longer open in a new tab.
Post by: Illori on June 06, 2016, 09:24:30 AM
ghostery. i think you may need to uninstall that mod completely.
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 06, 2016, 11:04:57 AM
Using ghostery now, thanks!
So ghostery detect http://tcr.tynt.com/ti.js
I have no idea what it is, but when I flip the switch in ghostery to block it my links start working just fine again.

Is http://tcr.tynt.com/ti.js even anything to do with  Google Analytics or the  Google Analytics mod?

Thanks,
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 06, 2016, 11:20:08 AM
Just google tynt and think I recall what it is now.
Was something I added for if something is copied & pasted from our site it adds a link back to our site in the copy and paste.

Seems they have moved.
http://tynt.com/

After finding this I remembered.
http://www.cnet.com/news/tynt-breaks-copy-and-paste-but-only-if-you-let-it/

Will have to try and find the code and remove it now.
Title: Re: External links no longer open in a new tab.
Post by: Illori on June 06, 2016, 11:40:00 AM
glad you figured it out.
Title: Re: External links no longer open in a new tab.
Post by: ApplianceJunk on June 06, 2016, 04:17:02 PM
Would have never figured it out without the help I received here, thanks!

For future reference here is the code I had in index.template.php that was causing the problem.


<!-- BEGIN Tynt Script -->
<script type="text/javascript">
if(document.location.protocol=="http:"){
var Tynt=Tynt||[];Tynt.push("bYgXyUPTyr4yWfacwqm_6l");Tynt.i={"ap":"Read more:"};
(function(){var s=document.createElement("script");s.async="async";s.type="text/javascript";s.src="http://tcr.tynt.com/ti.js";var h=document.getElementsByTagName("script")[0];h.parentNode.insertBefore(s,h);})();
}
</script>
<!-- END Tynt Script -->



Just removed the code and my links seem to be working like they should be now.


Thanks again,