Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: assemblytube on September 28, 2016, 02:48:32 PM

Title: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: assemblytube on September 28, 2016, 02:48:32 PM
Just did an upgrade from SMF 2.0.11 to 2.1.12 by clicking on the link that appeared in the admin centre.

It said all the tests were successful so I went ahead.

As soon as the update completed, all of the menus at the top of my forum disappeared completely.

I uninstalled and they all came back.

Any ideas on where I should look for a solution?

Thanks
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Kindred on September 28, 2016, 03:13:18 PM
What theme are you using?
What is your site URL?
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: d3vcho on September 28, 2016, 04:40:00 PM
Hello!

Were you using any Mods for the menu?

Regards :)
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Matthew K. on September 28, 2016, 05:19:22 PM
This actually happened to me last night as well. The site had about 20 modifications and I couldn't isolate very quickly which one was causing it and I didn't have the time necessary to full figure it out. Definitely looks like a commonly installed modification is breaking the navigation.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: swordsman1 on September 28, 2016, 08:00:30 PM
Happens here also.


Theme: SMF Default Theme - Curve

Mods:
Regbar Warning 1.0.5
Ad Managment   3.0.1
Anti-Spam Links   1.0.1
CloudFlare   1.1
Recent Topics On Board Index   1.03
Global Headers Footers   2.0.1
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: assemblytube on September 29, 2016, 07:38:01 AM
Hi Kindred,
My theme is Dark Modern and my site is http://assemblytube.com/forum/index.php

I have a very large number of mods installed (70+) and have done for a long time without problems.

2 mods in common with swordsman1 are
Ad Managment   3.2
Global Headers Footers   2.0

A mod that I use that directly works with the menu is
6 Custom buttons / tabs with Sub Menus (4) 0.5

Thanks for any clues to a fix.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Illori on September 29, 2016, 07:39:55 AM
can you try to uninstall that custom buttons mod and see if the menu works?
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Matthew K. on September 29, 2016, 10:16:25 AM
It happens on two sites of mine with no custom menu mod. Do you have caching on, by chance? Check Admin -> Configuration -> Server -> Caching
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Matthew K. on September 29, 2016, 10:20:15 AM
One of the forums I manage that was having this issue had caching on. I turned it off and now the menu doesn't disappear. Seems to be a bug with the new serialise method and the length.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: aegersz on September 30, 2016, 03:32:37 AM
... which maybe why SimplePortal's Shoutbox doesn't load shouts (see http://simpleportal.net/index.php?topic=14380) !

can i assume that the bug lies with SMF and that is affecting the Shoutbox, too ?

perhaps with the change: Fixed vulnerable unserialize() code by converting all instances to safe_unserialize() ?
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: assemblytube on September 30, 2016, 05:59:21 AM
Thanks Matthew K.
I turned off server caching and the update worked fine. My top menus did not disappear.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: aegersz on September 30, 2016, 06:09:38 AM
yeah BUT you want caching on, don't you ?

I backed off the Upgrade thinking that it will be updated.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: assemblytube on September 30, 2016, 06:45:16 AM
Hi aegerszm
I upgraded because there is something in the upgrade about PayPal compatibility and I was concerned that my paid subscriptions might not go through if I did not upgrade.
I have no idea if the upgrade would have an effect there because I do not understand it enough, but I know something in PayPal changes today 30th September 2016.

I agree that a fix that allows the cache to work with the upgrade would be the best option. I guess it will be affecting a lot of SMF websites if it is not fixed.

Best wishes.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: shawnb61 on October 01, 2016, 11:32:51 AM

I was nervous about the patch due to these threads.

After applying the 2.0.12 patch in my test environment, my top menus disappeared.  But they returned after a while as I logged off my admin account & logged back on as a regular user to take a look around. 

So, for me, the issue was fleeting. 

I applied the patch to my prod site, and there were no issues whatsoever.   

Notes on my caching setting & notifications, in case folks are exploring the idea it may be a caching issue:
     Both my test & prod site have caching set to Level 1.
     Both sites do, however, report this: "SMF has not been able to detect a compatible accelerator on your server."

Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Arantor on October 01, 2016, 12:55:53 PM
If you have no compatible accelerator, it will fall back to the file cache. Which is where the problem is due to the serialise routine used by the cache and specifically the (new) unserialise routine deciding that there's too much data and just dropping it.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: butchs on October 01, 2016, 01:10:34 PM
I am not using those mods; however, I have custom menus.  I was able to see the menus as a regular user using another browser but when I logged in they disappeared.  I removed upgrade for now by adding "action=admin" to the end of the string.

I have cache and I do not disagree that may be the issue.  But I want to  review the code before reinstalling.

Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: butchs on October 01, 2016, 01:27:41 PM
It appears to be the editor.js changes are affecting the menu script via cache.  I will try again during off hours and reset the cache.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: aegersz on October 01, 2016, 07:02:48 PM
it was reported in another post to remove the length test for exceeding 4096 in Subs. php (search: 'exceeds') but despite this, my issues with Simple Portal still persist.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Burt on October 02, 2016, 07:53:45 AM
I'm also not able to upgrade to 2.0.12 as the entire menu disappear after upgrading. I do however use Menu Editor Lite...


Regards




Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: 4LP3RUZ1 on October 05, 2016, 12:37:06 PM
same problem on my site: http://www.toyotaclubtr.com/

had to revert back to 2.0.11
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Burt on October 07, 2016, 04:58:01 AM
Quote from: Arantor on October 01, 2016, 12:55:53 PM
If you have no compatible accelerator, it will fall back to the file cache. Which is where the problem is due to the serialise routine used by the cache and specifically the (new) unserialise routine deciding that there's too much data and just dropping it.


This is a screenshot of my SMF acknowledging that it has detected Memcached.


If I select any level of caching the main menu disappear with 2.0.12.


Am I supposed to insert some code in Memcache setting?

Am I doing something wrong or version 2.0.12 is not supposed to be used?


If you could help, it would be appreciated...
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Arantor on October 07, 2016, 08:46:11 AM
It detects that you have the library available for it. It doesn't (and can't) detect that you have memcache running and if you did, you'd probably know what the settings were that you had to put in there (since SMF needs to know the IP address and port number of the memcache server)

Since you didn't give it any details, it falls back to the file cache with the broken code.

As for what to do, that's up to the team to decide whether to pull 2.0.12 or publish a fix for it.

In the interim turn off the cache entirely.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Kindred on October 07, 2016, 09:21:12 AM
we will be publishing a 2.0.13 fix soon
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Burt on October 08, 2016, 07:43:26 AM
Thanks guys


@Arantor


Since day one I always had the cache set to the level 1. I never play with it and I don't know much at all about memcache.


As you can see from the picture, I have turned off the cache. This was also the only way for me to install 2.0.12.


Just to learn something, the Ip address and port number, are they supposed to be input in the second empty field? (the one below the cache level?) Is anywhere I can read to learn a bit more about this topic?


@Kindred


Great news... Thanks
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Arantor on October 08, 2016, 08:35:35 AM
You had it set to level 1 because that's the default.

memcache is a type of server. You have to put the server's details into SMF for it to work - an empty input guarantees you were not using memcache.

I don't unfortunately have documentation for memcache that would be useful but unless you're using a VPS or better, I'm almost certain you won't have memcache installed on your server anyway.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Burt on October 18, 2016, 10:28:01 AM
Quote from: Arantor on October 08, 2016, 08:35:35 AM
You had it set to level 1 because that's the default.

memcache is a type of server. You have to put the server's details into SMF for it to work - an empty input guarantees you were not using memcache.

I don't unfortunately have documentation for memcache that would be useful but unless you're using a VPS or better, I'm almost certain you won't have memcache installed on your server anyway.


Sorry for the delay...



I always had it set to level 1, as when I tried Level 2 or Level 3 it just crashed...(well I haven't tried again since 2.0.6)


I don't get it... If I don't have memcache installed on my server, why then SMF says the opposite (as per picture in my above post)? Is this a bug?


Cheers
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Arantor on October 18, 2016, 10:51:07 AM
No, it's not a bug at all.

You need two things for memcache, the memcache server and the memcache client. PHP is telling you that you have the memcache client available. Unless you also have the server part installed, it won't work, but PHP doesn't know if there is a server there or not, only presence of the client.

If you're on shared hosting, you don't have the server part.
If you're on a VPS or better, either you or the server administrator would know what the details are.

Since it doesn't have server details, it falls back to the file cache, which is what broke in 2.0.12.
Title: Re: Upgraded from 2.0.11 to 2.0.12 and top menus disappeared
Post by: Burt on November 01, 2016, 07:22:51 PM
Thank Arantor...


I'm on a share hosting, so it is all good... I'll wait for the 2.0.13


Keep up the good work guys...