Simple Machines Community Forum

SMF Development => Bug Reports => Topic started by: GL700Wing on May 29, 2017, 07:51:29 PM

Title: SMF 2.0.14 - Showing statistics on Board Index
Post by: GL700Wing on May 29, 2017, 07:51:29 PM
As per the attached images when the checkbox for Admin -> Current Theme -> Show statistics on board index is empty the statistics are shown on the board index and when it is selected they are not.

As far as I can tell the following code in ./Themes/default/BoardIndex.template.php controls this behaviour.
function template_main()
{
    global $context, $settings, $options, $txt, $scripturl, $modSettings;

    // Show some statistics if stat info is off.
    if (!$settings['show_stats_index'])


The comment and code indicate that statistics should be shown when 'stat info/show_stats_index' are off.

However, given the description of the option is to 'Show statistics on board index' I thinks the comment and code in ./Themes/default/BoardIndex.template.php should be as follows:
function template_main()
{
    global $context, $settings, $options, $txt, $scripturl, $modSettings;

    // Show some statistics if stat info is on.
    if ($settings['show_stats_index'])
Title: Re: SMF 2.0.14 - Showing statistics on Board Index
Post by: Arantor on May 30, 2017, 02:26:44 AM
There is some behaviour about this also affecting what is shown in the info centre lower down, and that the option has been misleading for so long that through simple inertia it won't be changed in 2.0 at least.
Title: Re: SMF 2.0.14 - Showing statistics on Board Index
Post by: GL700Wing on May 30, 2017, 05:37:56 AM
Quote from: Arantor on May 30, 2017, 02:26:44 AM
There is some behaviour about this also affecting what is shown in the info centre lower down, and that the option has been misleading for so long that through simple inertia it won't be changed in 2.0 at least.
OK - thanks for letting me know.
Title: Re: SMF 2.0.14 - Showing statistics on Board Index
Post by: Deaks on May 30, 2017, 08:22:04 AM
in honesty its simple case of changing a text string.
Title: Re: SMF 2.0.14 - Showing statistics on Board Index
Post by: Arantor on May 30, 2017, 12:48:34 PM
Quote from: BryanD on May 30, 2017, 08:22:04 AM
in honesty its simple case of changing a text string.

Not entirely. If you have it on, you get one set of statistics, if you have it off you get a different set of statistics. I never figured out how to appropriately word it.
Title: Re: SMF 2.0.14 - Showing statistics on Board Index
Post by: Deaks on May 30, 2017, 02:12:37 PM
Quote from: Arantor on May 30, 2017, 12:48:34 PM
Not entirely. If you have it on, you get one set of statistics, if you have it off you get a different set of statistics. I never figured out how to appropriately word it.

Still a text string that needs updated and expanded ...