Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: spiros on May 31, 2017, 10:24:59 AM

Title: Strange highlight class in search results subjects - even after 2.0.14
Post by: spiros on May 31, 2017, 10:24:59 AM
Strange highlight class in search results subjects - even after 2.0.14

I was checking whether this was solved with 2.0.14

Quote
! Fix search highlighting to not mangle/expose some HTML

But it sill applies, see here https://www.simplemachines.org/community/index.php?topic=492817.msg3856236#msg3856236

or search for "move on" here https://www.translatum.gr/forum/index.php
Title: Re: Strange highlight class in search results subjects - even after 2.0.14
Post by: Illori on May 31, 2017, 10:26:30 AM
there were other issues, that were fixed/reverted the actual issue has not  been resolved.
Title: Re: Strange highlight class in search results subjects - even after 2.0.14
Post by: spiros on May 31, 2017, 12:56:36 PM
Thanks, Illori. Looks like it is a pretty resilient bug :)
Title: Re: Strange highlight class in search results subjects - even after 2.0.14
Post by: SleePy on May 31, 2017, 08:00:09 PM
That fix was breaking a bunch of search stuff and initially caused a delay of 2.0.14 while we tried to track down what broke search as we thought it was related to the proxy.  We reverted that fix for the 2.0.14 release as without that change it worked better, at least in our testing.  I'm not sure when/if this change will make the next 2.0 release.  I think it has a better shot at being fixed in 2.1 were we can investigate it better.  I haven't tried to reproduce this issue yet myself in 2.1.
Title: Re: Strange highlight class in search results subjects - even after 2.0.14
Post by: Colin on June 01, 2017, 01:01:08 AM
Sorry forgot to fix changelog.
Title: Re: Strange highlight class in search results subjects - even after 2.0.14
Post by: spiros on June 04, 2017, 11:23:02 AM
Well, I guess if one finds the reason why it happens, then it would be easy to apply in either 2.1 or 2.x given the amount of code that both versions share.