Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: aegersz on September 12, 2017, 11:06:19 AM

Title: Help ! I broke my forum ...
Post by: aegersz on September 12, 2017, 11:06:19 AM
i get this error after i made some code changes. this worked in test and i reversed the changes but i still get this error ?

https://forum.drugs-and-users.org/index.php?/topic%2C1609.msg12283.html
Undefined index: txt_reg_links_login
var/www/html/Sources/Subs.php
Line: 2585

but txt_reg_links_login is defined in Subs.php !

could something be cached somewhere and my code restores arent working ?
Title: Re: Help ! I broke my forum ...
Post by: Shambles on September 12, 2017, 11:43:40 AM
This sounds more like a coding issue rather than a request for SMF support.

It's likely that your $variable['txt_reg_links_login'] is not in scope when you try to access it.
Title: Re: Help ! I broke my forum ...
Post by: aegersz on September 12, 2017, 12:09:39 PM
i don't get it though. i undid my 3 changes and i can't get it back to where it was.

but i turned on some php logging and i get this:

Parse error: syntax error, unexpected ';', expecting ')' in /var/www/html/Sources/Display.php on line 1665

any ideas ? sorry to bother ...
Title: Re: Help ! I broke my forum ...
Post by: aegersz on September 12, 2017, 12:15:29 PM
it was dougies mod that broke my system - Automatic Attachment Rotation !

finally !
Title: Re: Help ! I broke my forum ...
Post by: Kindred on September 12, 2017, 10:07:28 PM
also, turn off that stupid "SEF URLs" setting... adding .html to the end of your urls just confuses matters and serves no useful purpose for search engines these days
Title: Re: Help ! I broke my forum ...
Post by: dougiefresh on September 12, 2017, 11:41:55 PM
Seriously, I'm having a difficult time getting rid of typos....  :-[
Title: Re: Help ! I broke my forum ...
Post by: aegersz on September 13, 2017, 01:45:34 AM
Quote from: Kindred on September 12, 2017, 10:07:28 PM
also, turn off that stupid "SEF URLs" setting... adding .html to the end of your urls just confuses matters and serves no useful purpose for search engines these days

... sorry but i have no idea about how to do that. I have no idea how .html gets appended and never gave it any thought until this post of yours.

how do i turn it off, please ?
Title: Re: Help ! I broke my forum ...
Post by: aegersz on September 13, 2017, 02:08:04 AM
as usual, i forgot to do my research ... i found this mod (Advance SEF URLs) at http://custom.simplemachines.org/mods/index.php?mod=986

QuoteJust add the following to your Settings.php if your site fails to load or work after changing SEF options to disable them:

$disable_sef = true;
Title: Re: Help ! I broke my forum ...
Post by: Kindred on September 13, 2017, 06:44:49 AM
https://wiki.simplemachines.org/smf/SMF2.0:Features_and_Options#General

Quote
Search engine friendly URLs - When enabled, queryless URLs are used for forum pages. This means they look like ../index.php/topic,1.0.html instead of ../index.php?topic=1.0. This option was introduced in order to help search engines index forum pages, but there is no longer any reason to use it, as search engines are now capable of indexing both formats. The queryless URL format only works for Apache and Lighttpd.
Title: Re: Help ! I broke my forum ...
Post by: aegersz on September 13, 2017, 08:11:22 AM
thank you ... I was wondering if there was a downside to it. I will try it.

building an impenetrable server and such a feature rich forum on SMF has been a rewarding experience ... in fact, I got a Linux Level 2 Support job because of it !

and we all do it for free ... that's the best part ! you guys are great but I hope you have "day jobs" to pay the bills  :) :) :)
Title: Re: Help ! I broke my forum ...
Post by: aegersz on September 23, 2017, 08:54:03 AM
finally i have done this to Settings.php:

$disable_sef = true;