Simple Machines Community Forum

SMF Development => Bug Reports => Topic started by: Yariksat on December 03, 2017, 05:41:27 AM

Title: Proxying images SMF 2.0.15
Post by: Yariksat on December 03, 2017, 05:41:27 AM
Such a problem was revealed.If you open the message for the first time, where the image is first proxy (or look through the preview), the image is displayed only on the second time you refresh the page.I thought at first that this was my modifications, but yesterday's clean test setup confirmed the problem.I accidentally saved the old file, the proxy, which I manually edited when I had 2.0.14.I do not remember where I took these edits, but with this file, everything is working fine for me
Title: Re: Proxying images SMF 2.0.15
Post by: vbgamer45 on December 03, 2017, 09:18:27 AM
Can you post your proxy.php would like to see it.
Title: Re: Proxying images SMF 2.0.15
Post by: Shambles on December 03, 2017, 09:45:44 AM
Yariksat manually applied a fix I created:

https://www.simplemachines.org/community/index.php?topic=553914.msg3926081#msg3926081

I think what he's now saying is that the replacement {official} fix for proxy.php doesn't quite cut it, as a couple of other members have since reported.
Title: Re: Proxying images SMF 2.0.15
Post by: Yariksat on December 03, 2017, 10:44:46 AM
Can you post your proxy.php would like to see it.
In the attachment
Yariksat manually applied a fix I created:

https://www.simplemachines.org/community/index.php?topic=553914.msg3926081#msg3926081

I think what he's now saying is that the replacement {official} fix for proxy.php doesn't quite cut it, as a couple of other members have since reported.
I here took - https://download.simplemachines.org - and installed. As a result, the problem is as above
Title: Re: Proxying images SMF 2.0.15
Post by: Shambles on December 03, 2017, 10:51:28 AM
^ the file you attached - is that the working one?
Title: Re: Proxying images SMF 2.0.15
Post by: Yariksat on December 03, 2017, 10:56:57 AM
^ the file you attached - is that the working one?
Yes.
This one does not work normally. The problem is as above
Title: Re: Proxying images SMF 2.0.15
Post by: Shambles on December 03, 2017, 11:00:46 AM
Yariksat manually applied a fix I created:

https://www.simplemachines.org/community/index.php?topic=553914.msg3926081#msg3926081

And that's the fix I recommend, as opposed to that which the patch developers issued with 2.0.15
Title: Re: Proxying images SMF 2.0.15
Post by: Yariksat on December 03, 2017, 11:07:52 AM
Yariksat manually applied a fix I created:

https://www.simplemachines.org/community/index.php?topic=553914.msg3926081#msg3926081

And that's the fix I recommend, as opposed to that which the patch developers issued with 2.0.15
I already forgot. Yes, this fix works well
The patch itself in 2.0.15 does not work properly
Title: Re: Proxying images SMF 2.0.15
Post by: Shambles on December 03, 2017, 11:22:34 AM
Maybe this topic should be converted into a bug report.
Title: Re: Proxying images SMF 2.0.15
Post by: Yariksat on December 03, 2017, 11:31:45 AM
It seems to me it is necessary to do this
Title: Re: Proxying images SMF 2.0.15
Post by: tinoest on December 03, 2017, 06:00:11 PM
What version of php are you using?

Ignore that, it’s due to the other change to remove is_int and the other code never being changed to suit.

Shambles fix with the checking to false is now correct. So the 1 : null should be changed
Title: Re: Proxying images SMF 2.0.15
Post by: Yariksat on December 03, 2017, 10:47:36 PM
What version of php are you using?

Ignore that, it’s due to the other change to remove is_int and the other code never being changed to suit.

Shambles fix with the checking to false is now correct. So the 1 : null should be changed
PHP: 5.6.30
The problem exists at least one more person - https://www.simplemachines.ru/index.php?topic=20138.msg172040#msg172040
Title: Re: Proxying images SMF 2.0.15
Post by: Aleksi "Lex" Kilpinen on December 21, 2017, 10:54:26 AM
What version of php are you using?

Ignore that, it’s due to the other change to remove is_int and the other code never being changed to suit.

Shambles fix with the checking to false is now correct. So the 1 : null should be changed
So... Should this be in bug reports, rather than support?
I did not quite follow, so thought to ask.
Title: Re: Proxying images SMF 2.0.15
Post by: Shambles on December 22, 2017, 06:21:47 PM
What version of php are you using?

Ignore that, it’s due to the other change to remove is_int and the other code never being changed to suit.

Shambles fix with the checking to false is now correct. So the 1 : null should be changed
So... Should this be in bug reports, rather than support?
I did not quite follow, so thought to ask.

Bug report.