Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: JohnA on January 03, 2018, 04:01:04 AM

Title: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: JohnA on January 03, 2018, 04:01:04 AM
As admin if I select "Forum or Board Default" as my theme choice the settings revert to "SMF Default Theme - Curve" instead.  I have Curve as my default theme, but I am running a modified curve as the default theme for a few sub-boards.  If I log in as a regular user I am able to choose Forum or Board Default and it works properly.  It is only when logged into the forum as Admin that I have this issue.  As Admin if I select a specific theme other than  "Forum or Board Default" the settings change seems to work properly. 

I am not sure if this is a bug, or if there is some Admin only setting that would keep this feature from working...


Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 04:11:19 AM
Admin -> Boards -> Modify Boards -> ( Modify the board with custom theme ) -> Override Member's Theme (Checkbox setting)
This setting makes the board override any user set theme, and will also work for admin.

For some reason, I can also replicate the behavior that without that setting admin view is not affected even if using the forum defaults.
I am unsure however if this by design or a bug.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: JohnA on January 03, 2018, 04:29:10 AM
Thanks, I saw that setting and if I force override it works for admin too, but I didn't want to do that because I have members that prefer to use a theme other than the default (some users have vision issues and want a high contrast theme for instance).
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 05:14:32 AM
i am not sure what exactly your issue is, you want to reset everyone to the default theme? or you do not but you want to change the default theme for your users?
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 05:18:16 AM
Quote from: Illori on January 03, 2018, 05:14:32 AM
i am not sure what exactly your issue is, you want to reset everyone to the default theme? or you do not but you want to change the default theme for your users?
They as admin want to be able to see their set board specific theme, without playing hard ball and forcing the board to change the theme to everyone. Strictly speaking, the settings should allow for this but alas they do not.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 05:56:53 AM
i dont think SMF has ever done that. you have to force the change for everyone to get it changed.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 06:04:37 AM
Quote from: Illori on January 03, 2018, 05:56:53 AM
i dont think SMF has ever done that. you have to force the change for everyone to get it changed.

No you don't understand.

Let's say Forum default theme is set to Curve.
Your profile is set to use the Forum or board default.
Boards are all set to use the Forum default.

This way, anywhere you go on the forum, you see Curve.

Now create a board, set it to use Core.

That board ( for any regular user with the same settings ) will show Core. But Admin is still stuck with Curve.
The settings, by their wording, should actually allow for Admin to see Core on that one board alone too.

Now those who have selected a specific theme in their profile, will see their selected theme on that board too,
unless you force the setting mentioned, but this way the board will override any user specific selection for everyone - this time admin included. And for reasons like enhanced accessibility themes, this might be a problem.

Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 06:10:42 AM
that is how it works the board theme overrides everything. that is unless a mod broke something.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 06:17:17 AM
Quote from: Illori on January 03, 2018, 06:10:42 AM
that is how it works the board theme overrides everything. that is unless a mod broke something.
Simpler: Why does not the theme selection "Forum or board default" work for admin?
That is the point. The admin is always stuck with only Forum default, not seeing board defaults.

EDIT: Sorry for the typos, I was on my phone.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 06:30:31 AM
i have never seen this issue. re-reading the op i am still not clear on what their issue is and where the fix may be. the phrase they use "Forum or Board Default" i dont see in the admin panel. i see similar forum default but not that phrase so i am still confused as to what exactly the op is doing and what is not working. in SMF by default i dont see the issue they are saying may happen.

can the op provide step by step instructions for duplicating the issue?

i just tried the option to change the theme per board and when i use the override member's theme option the board shows the different theme to the admin.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 06:44:08 AM
The step where this seems to fail, is that as admin I cannot choose to use the Forum or Board default. It will only select the exact theme currently set as Forum default. For some reason.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 07:23:32 AM
you mean if you have the default theme as your default and set a different theme for the board you as admin cant see the different theme? i tried it and it worked fine for me but i selected the force override option to force the board theme to show for everyone.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 07:25:00 AM
Quote from: Illori on January 03, 2018, 07:23:32 AM
you mean if you have the default theme as your default and set a different theme for the board you as admin cant see the different theme? i tried it and it worked fine for me but i selected the force override option to force the board theme to show for everyone.
Yes, admin can not choose to see board default themes. It is not possible. Only way to see them, is to force the board specific theme on everyone.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 07:27:17 AM
so if you dont force it for everyone can a normal user view the theme? maybe the force option has the text incorrect but i dont recall anyone else having this issue.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 07:31:41 AM
No problems as a regular user. It is just that where any regular user can choose "Forum or Board default" as their theme, an Admin can not.
If an admin chooses this, it will not stay and will be replaced by the current Forum default.

I tested this on 3 different SMF 2.0 installs.
Try, you will not be able to see this in your admin profile:
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 07:36:57 AM
but i do see that in my profile for the admin user.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 07:38:21 AM
I tried on 3 different installs, one pretty much a fresh 2.0.15 and was unable to choose that. I can select it, but it will be replaced by whatever theme was currently selected for Forum default. :o
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Illori on January 03, 2018, 07:41:57 AM
ah, you did not say you had to select it in your last reply. yes if i choose the use this theme for the forum or board default then yes it changes to curve as the option selected. now i see the issue, if you dont force the theme change for the board it does not show. can you duplicate this in SMF 2.1? if so we can submit a bug for it. i dont see another fix other then forcing it in SMF 2.0 as i doubt it would be bug fixed if it is considered a bug.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 07:45:38 AM
I'll check - I have a fresh 2.1 handy too :)

EDIT:

Seems to do this on 2.1 as well.

I have only one theme installed on my 2.1 though, the SMF Default Theme - Curve2,
but as admin, if I select the "Forum or Board default" theme, it will be switched to "SMF Default Theme - Curve2 ".
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: JohnA on January 03, 2018, 02:24:12 PM
Lex, thank you for going to bat so much on this topic.  It can be very confusing to express how this bug seems to work.  I appreciate your efforts to get the information across to Illori. 
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 03, 2018, 02:29:38 PM
No problem :)

The admin / end user functionality built in SMF is really familiar to me, as I've been using SMF since 2005 continuously and bug hunting like this is something I'm way better at than actually trying to understand the code side of it all. :)
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 04, 2018, 03:44:11 PM
Opened a topic in the bugs section [2.0][2.1] Selecting "Forum or Board Default" theme as Admin impossible (https://www.simplemachines.org/community/index.php?topic=558121.0)
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: JohnA on January 04, 2018, 08:25:00 PM
Thank you.  I'll be watching the bug's progress.
Title: Re: Selecting "Forum or Board Default" theme as Admin seems to be not working
Post by: Aleksi "Lex" Kilpinen on January 08, 2018, 06:13:20 AM
In the meantime, I will mark this topic solved for now. :)