Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: bahgheera on January 14, 2018, 04:16:19 PM

Title: Problems with upgrading using package manager
Post by: bahgheera on January 14, 2018, 04:16:19 PM
Hi all. I have SMF 2.0.7 running, and I really need to upgrade it. I managed to get it up to 2.0.9, but when it was at 2.0.8 and I tried to update, it said there were errors. I looked at the files and lo and behold, some of them were already upgraded to 2.0.9. I installed the 2.0.9 update, and now I am working on 2.0.10, but now there are files that already say 2.0.14. What is going on here? Any help would be appreciated - this forum is about twelve years old now and I *really* don't want to trash it. Thanks for any info!
Title: Re: Problems with upgrading using package manager
Post by: Aleksi "Lex" Kilpinen on January 14, 2018, 05:01:48 PM
What edits give errors when you try to update?
What files are showing 2.0.14?
Title: Re: Problems with upgrading using package manager
Post by: bahgheera on January 14, 2018, 05:34:24 PM
Thanks for the response.

./Themes/default/languages/index.english.php, the package is looking for '2.0.8 to replace it with 2.0.10'. But the file itself contains the line '// Version: 2.0.14; index'.

Upon further investigation, I see that some of the files that return Test Succesful actually contain an error if you expand the header. For example, ./Sources/ManageServer.php says test succesful but when you expand it, there are two items - one says test succesful, the other says test failed (ignore errors). Also, ./Sources/Subs-Post.php says test successful but both items in it have test failed (ignore errors). I wonder now if the previous upgrade packages had errors that I didn't even notice because of this?
Title: Re: Problems with upgrading using package manager
Post by: bahgheera on January 14, 2018, 05:38:57 PM
I've gone through a lot of the errors and all of them so far are showing that they've already been updated to the new version. I think I can probably go ahead and install the package, ignoring the errors.
Title: Re: Problems with upgrading using package manager
Post by: Sir Osis of Liver on January 14, 2018, 09:44:17 PM
Do you have a lot of mods or customizations running?  If not, you'd be better off uploading 2.0.15 upgrade package, that will give you a clean install.  Your content is in the database, it's not affected by version updates.
Title: Re: Problems with upgrading using package manager
Post by: Aleksi "Lex" Kilpinen on January 15, 2018, 01:19:10 AM
Quote from: bahgheera on January 14, 2018, 05:34:24 PM
Thanks for the response.

./Themes/default/languages/index.english.php, the package is looking for '2.0.8 to replace it with 2.0.10'. But the file itself contains the line '// Version: 2.0.14; index'.
Language file, this update only changes the version number and the copyright year. Not a problem, you can ignore this.

Quote from: bahgheera on January 14, 2018, 05:34:24 PM
Upon further investigation, I see that some of the files that return Test Succesful actually contain an error if you expand the header. For example, ./Sources/ManageServer.php says test succesful but when you expand it, there are two items - one says test succesful, the other says test failed (ignore errors). Also, ./Sources/Subs-Post.php says test successful but both items in it have test failed (ignore errors). I wonder now if the previous upgrade packages had errors that I didn't even notice because of this?
You may want to take a look at the edits to see for yourself what the update is doing, and if the changes are in fact already there or if they fail for some other reason. https://custom.simplemachines.org/upgrades/index.php?action=upgrade;file=smf_patch_1.1.21_2.0.10.zip;smf_version=2.0.9

Quote from: Sir Osis of Liver on January 14, 2018, 09:44:17 PM
Do you have a lot of mods or customizations running?  If not, you'd be better off uploading 2.0.15 upgrade package, that will give you a clean install.  Your content is in the database, it's not affected by version updates.
If you do not have many mods installed, this could be a good idea - use the Large upgrade, then reinstall mods you need.
( Do note, any modifications done to custom themes will remain in them, but all custom code done to the default theme will be removed. )
Title: Re: Problems with upgrading using package manager
Post by: bahgheera on January 15, 2018, 10:08:52 PM
So I guess at this point, my question is *why* are the changes already there? And secondary, why does it say test successful even though it has failed some things but those failures say ignore errors? I am so confused. Thanks for the responses!
Title: Re: Problems with upgrading using package manager
Post by: Sir Osis of Liver on January 15, 2018, 10:11:48 PM
Did you use a host installer to set up the forum?  Some of them do auto updates.
Title: Re: Problems with upgrading using package manager
Post by: bahgheera on January 16, 2018, 12:02:22 AM
No. Everything is manual. I have downloaded the themes and sources dirs for backup, I'm gonna go for it.
Title: Re: Problems with upgrading using package manager
Post by: Kindred on January 16, 2018, 06:36:44 AM
it says "ignore errors" because that's what we told it to do.
Some people have one version of a previous upgrade... some people have another -- that's why the errors are ignored.
Title: Re: Problems with upgrading using package manager
Post by: bahgheera on January 16, 2018, 07:39:33 PM
Quote from: Kindredit says "ignore errors" because that's what we told it to do.

So what does that mean? Does that mean *I* ignore the error?
Title: Re: Problems with upgrading using package manager
Post by: Kindred on January 16, 2018, 11:23:33 PM
It means that the system can ignore the errors therefore you can ignore them
Title: Re: Problems with upgrading using package manager
Post by: bahgheera on January 17, 2018, 01:26:03 AM
Ok, thanks for the reply. I pulled the trigger and now I'm upgraded to 2.0.15. Thank God that's over.