Simple Machines Community Forum

Customizing SMF => Graphics and Templates => Topic started by: legaziofunk on January 18, 2018, 09:35:19 AM

Title: Startaza: Theme negates protected boards
Post by: legaziofunk on January 18, 2018, 09:35:19 AM
Dear SMF-people,

(stats see signature)

after installing STARTAZA, two new boxes appeared on screen on the right-hand side:

1. Neue Beiträge ("new posts" - th forum is in German)
2. Popular Topics (yup, no translation there! ;-)

After a new post has been done in a protected/hidden board or there is huge traffic in a protected/hidden board, this very post pops up in one or both of these boxes giving access to any user to this very post and therefre the protected board, even the user has no permission to do so.

When clicking on that post, the user even has the possibility to reply and cite the aforementioned post, thus (e.g. some user has quoted the entire conversation) can look into the entire post or even the board - though only punctually.

How can this be fixed?

By fixing, I am specifically referring to the fact of NOT FEEDING qualified posts ("new" or "lots of traffic") into these boxes.

Just making them disappear is not what I am looking for. I want the connection of what is showing up be selective in dependency of the user's admissions/group memberships.

Thanx fpr your help!

P.S.: I am sorry if this is the wrong board. But since these boxes popped up AFTER I installed Startaza, I figuered this to be a theme related issue. Grazie!
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 18, 2018, 09:40:13 AM
If I understood you correctly, this should not be possible. Themes ( at least ones available here ) do not change core functionality. Do you have a link to the theme download?
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 18, 2018, 09:47:32 AM
Quote from: Aleksi "Lex" Kilpinen on January 18, 2018, 09:40:13 AM
If I understood you correctly, this should not be possible. Themes ( at least ones available here ) do not change core functionality. Do you have a link to the theme download?

Hmmm.... I saw this accidentally on the SMF main page somewhere. It's a fairly new theme, I recall.

Maybe here: https://custom.simplemachines.org/themes/index.php?lemma=2895

In fact, I am pretty sure that this is the place I got it from...
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 18, 2018, 09:54:46 AM
Thanks, I'll take a look at it.
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 18, 2018, 10:15:11 AM
Quote from: Aleksi "Lex" Kilpinen on January 18, 2018, 09:54:46 AM
Thanks, I'll take a look at it.
I installed the theme on 2.0.15, created 2 test topics in a board limited only to certain membergroups, and was unable to reproduce the behavior you describe. The new posts don't show the topics even to admin for some reason, and the popular posts shows them only to users with access otherwise too. Both seem to be using SSI functions, so normal SMF permissions should be enforced here as well.
Title: Re: Startaza: Theme negates protected boards
Post by: Kindred on January 18, 2018, 02:40:26 PM
you do realize that - if you install a new theme, after you already have mods installed - you will have to MANUALLY apply mod changes to every new theme?
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 09:00:35 AM
Quote from: Kindred on January 18, 2018, 02:40:26 PM
you do realize that - if you install a new theme, after you already have mods installed - you will have to MANUALLY apply mod changes to every new theme?

What is a mod?
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 09:04:20 AM
Quote from: Aleksi "Lex" Kilpinen on January 18, 2018, 10:15:11 AM
Quote from: Aleksi "Lex" Kilpinen on January 18, 2018, 09:54:46 AM
Thanks, I'll take a look at it.
I installed the theme on 2.0.15, created 2 test topics in a board limited only to certain membergroups, and was unable to reproduce the behavior you describe. The new posts don't show the topics even to admin for some reason, and the popular posts shows them only to users with access otherwise too. Both seem to be using SSI functions, so normal SMF permissions should be enforced here as well.

Thanx!

I have no clue, how this happened.

The user, I added - as a test user - was newly added. And "he" "saw" this entry.

Do you have any suggestion how to proceed in order to produce a status "from scratch", so that any newly added user will not see this hidden entry?
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 09:30:16 AM
It might be a cache playing tricks on you. Who are you hosted with?
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 10:12:04 AM
Quote from: Aleksi "Lex" Kilpinen on January 19, 2018, 09:30:16 AM
It might be a cache playing tricks on you. Who are you hosted with?

Host Europe
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 10:28:00 AM
Unless I'm mistaken, that is as of 2017 under the same roof with GoDaddy - so I wouldn't be all too surprised to see them having a cache that would misbehave like that. Though, I am unfamiliar with Host Europe, and so can't really say for sure.

Before making any too far reaching conclusions, you have made sure the user can not access the topic in question "legally"?
Could you give me a link to your forum, and to the topic in question?
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 10:44:15 AM
Quote from: Aleksi "Lex" Kilpinen on January 19, 2018, 10:28:00 AM
Unless I'm mistaken, that is as of 2017 under the same roof with GoDaddy - so I wouldn't be all too surprised to see them having a cache that would misbehave like that. Though, I am unfamiliar with Host Europe, and so can't really say for sure.

I have no clue, what you are referring to when mentioning GoDaddy... ;-)
I am slightly assuming what you are trying to depict with that cache issue though... slightly!!!

QuoteBefore making any too far reaching conclusions, you have made sure the user can not access the topic in question "legally"?
Could you give me a link to your forum, and to the topic in question?

Sure!

Forum:
http://wp12922522.server-he.de/simplemachine/smf_2-0-15_install/index.php

Topic in question:
http://wp12922522.server-he.de/simplemachine/smf_2-0-15_install/index.php?board=3.0

Will you have to become a member of this forum?
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 10:49:09 AM
Both of those links show the widgets, and there is no content on either of them ( just like it should be since you are closed from guests ).
Also, the recent topics function "index.php?action=recent" is ruled out of guest view.
This at least shows that permissions for guests seem to be OK, and the widgets work there.

Could you allow guest browsing for a while?
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 12:03:12 PM
Quote from: Aleksi "Lex" Kilpinen on January 19, 2018, 10:49:09 AM
Both of those links show the widgets, and there is no content on either of them ( just like it should be since you are closed from guests ).
Also, the recent topics function "index.php?action=recent" is ruled out of guest view.
This at least shows that permissions for guests seem to be OK, and the widgets work there.

Could you allow guest browsing for a while?

Guest browsing: Sure! It's still pretty empty the whole thing...

I set it up - and hiope I manged to do it correctly...
Please, let me know asap when you're done...
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 12:16:09 PM
Quote from: Aleksi "Lex" Kilpinen on January 18, 2018, 10:15:11 AM
The new posts don't show the topics even to admin for some reason
I found out why it did this to me.

The theme has this in place for some reason or another

$array = ssi_recentPosts(5.0, 7, null, 250, 'array');

My test was in board 7, which would be an excluded board in that if I'm not mistaken.

I think it should be


$array =  ssi_recentPosts(5, null, null, 'array');


Quote from: Aleksi "Lex" Kilpinen on January 18, 2018, 10:15:11 AM
and the popular posts shows them only to users with access otherwise too.
This one is OK, it's


$array = ssi_topTopicsViews(6, 'array');


I can't see a reason in either of those that would clearly explain what you are describing though.  ???
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 12:18:51 PM
Quote from: legaziofunk on January 19, 2018, 12:03:12 PM
Guest browsing: Sure! It's still pretty empty the whole thing...

I set it up - and hiope I manged to do it correctly...
Please, let me know asap when you're done...
Not able to see it yet :)

Admin -> configuration -> Features and options -> General -> Allow guests to browse the forum

Title: Re: Startaza: Theme negates protected boards
Post by: Illori on January 19, 2018, 12:19:33 PM
i dont think it should be using SSI in the first place. this really should be an issue the theme author should take a look at .
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 12:26:14 PM
Well, yeah there are probably better ways to achieve the same end result - and that one is oddly formed.
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 12:39:59 PM
Quote from: Aleksi "Lex" Kilpinen on January 19, 2018, 12:18:51 PM
Quote from: legaziofunk on January 19, 2018, 12:03:12 PM
Guest browsing: Sure! It's still pretty empty the whole thing...

I set it up - and hiope I manged to do it correctly...
Please, let me know asap when you're done...
Not able to see it yet :)

Admin -> configuration -> Features and options -> General -> Allow guests to browse the forum

Thanx!

Changed it!

I must say: the structure of admin functions, I find a bit confusing and not "logic"... just my 5 cents ;-)
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 12:44:27 PM
Quote from: legaziofunk on January 19, 2018, 12:39:59 PM
Quote from: Aleksi "Lex" Kilpinen on January 19, 2018, 12:18:51 PM
Quote from: legaziofunk on January 19, 2018, 12:03:12 PM
Guest browsing: Sure! It's still pretty empty the whole thing...

I set it up - and hiope I manged to do it correctly...
Please, let me know asap when you're done...
Not able to see it yet :)

Admin -> configuration -> Features and options -> General -> Allow guests to browse the forum

Thanx!

Changed it!

I must say: the structure of admin functions, I find a bit confusing and not "logic"... just my 5 cents ;-)
Thank you. The widgets still behave, and I can't see any boards at all, and can't access the topic you linked. That's good.
And this leads me to suggest you should go through your boards again, and make sure you have set access for groups correctly.
Any group having access to a board, will be able to access them, and see posts from them in the widgets.
You can turn off the guest access now if you want. :)

Oh, and I feel you - it takes a bit of getting used to, the Admin side of SMF. :)

Admin -> Forum -> Boards -> (select a board) -> Modify
Go through all boards, and make sure you have "Allowed Groups" set correctly. :)
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 01:13:50 PM
Quote from: Aleksi "Lex" Kilpinen on January 19, 2018, 12:44:27 PM
Thank you. The widgets still behave, and I can't see any boards at all, and can't access the topic you linked. That's good.
And this leads me to suggest you should go through your boards again, and make sure you have set access for groups correctly.
Any group having access to a board, will be able to access them, and see posts from them in the widgets.
You can turn off the guest access now if you want. :)

I did... ;-)
Thank you!

QuoteOh, and I feel you - it takes a bit of getting used to, the Admin side of SMF. :)

Glad I'm not the only one... It partly is absolutely counterintuitive... sort of... ;-)

[/quote]Admin -> Forum -> Boards -> (select a board) -> Modify
Go through all boards, and make sure you have "Allowed Groups" set correctly. :)[/quote]

I wanted to do this, but there is virtually nothing to be set.
Why? I practically only have two groups set up so far:
Standard Users
Members of the board (this might be confusing, because here "board" is not referred to as FORUM boards, but it means more like CEOs, board of directors of the club, to give you an idea).

The board in question - board members (CEOs) - is only "assigned" to "members of the board".

BUT: I (and I am just trying to figure out where - remember this confusion of the admin structure? LOL) did see a setting somewhere, where the "borad member"-group is apparently set up as a child group of the standard group.

I believe, therefore the "board members" somehow inherit upward some rights to the standard member..??
And therefore thsi one standard member which I did set up for test purposes, can see the hidden "board member"-board?
Is that possible?
Title: Re: Startaza: Theme negates protected boards
Post by: legaziofunk on January 19, 2018, 01:18:14 PM
Quote from: Illori on January 19, 2018, 12:19:33 PM
i dont think it should be using SSI in the first place. this really should be an issue the theme author should take a look at .

Are you saying, you'd recommend not to use this theme at all?
(although I am having not the slightest clu of what you're talking about...)
Title: Re: Startaza: Theme negates protected boards
Post by: Aleksi "Lex" Kilpinen on January 19, 2018, 01:38:27 PM
Quote from: legaziofunk on January 19, 2018, 01:13:50 PM
QuoteAdmin -> Forum -> Boards -> (select a board) -> Modify
Go through all boards, and make sure you have "Allowed Groups" set correctly. :)

I wanted to do this, but there is virtually nothing to be set.
Why? I practically only have two groups set up so far:
Standard Users
Members of the board (this might be confusing, because here "board" is not referred to as FORUM boards, but it means more like CEOs, board of directors of the club, to give you an idea).

The board in question - board members (CEOs) - is only "assigned" to "members of the board".

BUT: I (and I am just trying to figure out where - remember this confusion of the admin structure? LOL) did see a setting somewhere, where the "borad member"-group is apparently set up as a child group of the standard group.

I believe, therefore the "board members" somehow inherit upward some rights to the standard member..??
And therefore thsi one standard member which I did set up for test purposes, can see the hidden "board member"-board?
Is that possible?
Permissions may be inherited, but board access shouldn't be.

From the default groups, Guest is self explanatory, Regular members is everyone who has registered.
If you want only a certain group to have access, then regular members should not have access. 
This is how you have set it up?



Title: Re: Startaza: Theme negates protected boards
Post by: Illori on January 19, 2018, 01:58:27 PM
Quote from: legaziofunk on January 19, 2018, 01:18:14 PM
Quote from: Illori on January 19, 2018, 12:19:33 PM
i dont think it should be using SSI in the first place. this really should be an issue the theme author should take a look at .

Are you saying, you'd recommend not to use this theme at all?
(although I am having not the slightest clu of what you're talking about...)

if it is not working how you want, it may be better to find a new theme that does out of the box.
Title: Re: Startaza: Theme negates protected boards
Post by: Deaks on January 23, 2018, 03:48:45 AM
Quote from: Illori on January 19, 2018, 12:19:33 PM
i dont think it should be using SSI in the first place. this really should be an issue the theme author should take a look at .

bigger question is how did the theme make it through approval guidelines?  this should have been spotted doing the process like other issues.
Title: Re: Startaza: Theme negates protected boards
Post by: nilar on January 25, 2018, 11:10:05 AM
Quote from: Aleksi "Lex" Kilpinen on January 19, 2018, 12:16:09 PM
I think it should be


$array =  ssi_recentPosts(5, null, null, 'array');


That's absolutely right. That was fixed some time ago, but not uploaded here yet.
Title: Re: Startaza: Theme negates protected boards
Post by: nilar on January 25, 2018, 11:13:07 AM
Quote from: BryanD on January 23, 2018, 03:48:45 AM
Quote from: Illori on January 19, 2018, 12:19:33 PM
i dont think it should be using SSI in the first place. this really should be an issue the theme author should take a look at .

bigger question is how did the theme make it through approval guidelines?  this should have been spotted doing the process like other issues.

Why is that? Is not SSI the standard way to do that? 
Title: Re: Startaza: Theme negates protected boards
Post by: Illori on January 25, 2018, 11:19:09 AM
usually we dont recommend using SSI within SMF.
Title: Re: Startaza: Theme negates protected boards
Post by: nilar on January 25, 2018, 11:25:33 AM
because of ...?

Is that not safe enough?

There are entire sections here https://wiki.simplemachines.org/ dedicated to SSI. If not recommended it should be written explicitly.
Title: Re: Startaza: Theme negates protected boards
Post by: Gary on January 25, 2018, 11:27:10 AM
SSI is more designed for effectively exporting data to separate sites to be displayed (we use it to display news on our homepage as an example), it's not really designed for use within SMF itself.
Title: Re: Startaza: Theme negates protected boards
Post by: nilar on January 25, 2018, 11:39:45 AM
I understand. Honestly I thought that it was a very clean solution for those tasks.
However I guess I can code those sections in a different way.
Title: Re: Startaza: Theme negates protected boards
Post by: engrz on April 24, 2020, 10:15:11 AM
how to make quick reply box mobile friendly with this theme?
Title: Re: Startaza: Theme negates protected boards
Post by: Kindred on April 24, 2020, 11:15:11 AM
unrelated to the OP question and a really old thread.

please open your own or -- better -- ask in the thread dedicated to supporting this theme.