Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: brynn on January 28, 2018, 09:35:12 PM

Title: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on January 28, 2018, 09:35:12 PM
Hi Friends,
I originally posted about this here (https://www.simplemachines.org/community/index.php?topic=558455.0), but since things got a little confused, and later focussed on reverting the upgrade, I decided to start a new topic, to figure out what I did wrong with the upgrade.

When I tried using the Package Manager, I had 3 failed tests, and needed to edit 1 file once, and the 2nd file needed 2 edits.

The first edit is for ./Sources/ManageMembers.php.  The instructions say to Find:

if ($context['sub_action'] == 'query' && !empty($_REQUEST['params']) && empty($_POST))
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));


And Replace with:

if ($context['sub_action'] == 'query' && empty($_POST))
{
if (!empty($_REQUEST['params']))
{
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));
}
elseif ($context['browser']['is_ie'] && !empty($_SESSION['params']))
{
$_POST += $_SESSION['params'];
unset($_SESSION['params']);
}
}


The closest thing I could find was:

if ($context['sub_action'] == 'query' && !empty($_REQUEST['params']) && (empty($_POST) || ((isset($_POST['spammers_checks']) || isset($_POST['spammers_report'])) && !empty($_POST['delete']))))
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));


And I replaced with the code provided above.  Since the problems I had as a result were with the Bad Behavior mod, I have to think this is where it must have happened.  My Bad Behav mod is version 2.5.19.  I see now that there is an upgrade, but it hasn't been installed yet.

The next closest thing I found to that was this:

if ($context['sub_action'] == 'query')

But since the first find was closer, I thought that's what I should have replaced.

What did I do wrong?

I'm thinking I'll save the edits to the other file until after we finish with this file.  But if you want it all at once, let me know, and I'll go ahead and post everything.

Uh-oh....I just noticed 2 new things.  I started to install the upgrade again, so that I can get the correct Find/Replace info for you.  (I don't intend to go through with the upgrade, until I figure out what I did wrong.)  Anyway, this text warning is new:

"This package is already installed, and no upgrade was found!

You should uninstall the old version first to avoid problems, or ask the author to create an upgrade from your old version.

Please remember to always make regular backups of your sources and database before installing mods, especially beta versions."

When I followed SOL's instructions in the other topic, I thought I was uninstalling it.  In the Browse Packages page of the Package Manager, I find 2.0.15 Update in a section titled "Installed - Not Uninstallable (no uninstall section for this version of SMF)"

And the 2nd new thing....possibly it's not new, and I overlooked it before, and it's the reason for the failed upgrade.  Anyway, it's 3 or 4 failed tests for ./proxy.php.  So either these failed tests for this file are related to that 'already installed' warning, or I overlooked them in my first attempt at upgrading.

(I don't think I overlooked them before, because as you can tell, I'm not sure about what I'm doing, so I was proceeding very slowly and deliberately.  But still, having overlooked them is a possibility.)

Is there any other info I can provide for you, at this time?

Most sincere thanks!
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Sir Osis of Liver on January 28, 2018, 10:39:56 PM
IIRC, this is a known problem with Stop Spammers mod.  A solution is posted in mod support topic.  As you are experiencing multiple problems with the upgrade, best thing to do is revert back to 2.0.14 and start clean.  Look in [b[/Packages/backups/[/b], there should be a backup from before installing .15 patch.  Download, unzip, upload to forum root.  That will get you back to .14.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on January 29, 2018, 01:17:54 AM
This would look like it https://www.simplemachines.org/community/index.php?topic=283309.msg3957547#msg3957547
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on January 30, 2018, 07:20:22 PM
Thanks SOL.

Yes, I already followed your instructions (you posted them in the other topic), and the forum is now reverted to 2.0.14.

What I would like to do now, is figure out what I did wrong with the upgrade.  Because I do want to keep the forum up to date.  These are the current questions.

1 - Was my edit to ./Sources/ManageMembers.php correct?  Please see the code in my last message.  If so, I'll post the edit I made to the next file.

2 - Is the message I see now in the Package Manager related to the method I used to revert (SOL's suggestion).  How can I fix that, if the 2.0.15 update is in a section called "not uninstallable"?  How can I uninstall it?  I thought what I did from SOL's instructions was uninstalling it.

("This package is already installed, and no upgrade was found!
You should uninstall the old version first to avoid problems, or ask the author to create an upgrade from your old version.
Please remember to always make regular backups of your sources and database before installing mods, especially beta versions.")

3 - Are the failed tests related to ./proxy.php part of the upgrade?  I don't remember seeing them when I did the upgrade before.  Or could they be a result of reverting?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on January 30, 2018, 07:33:49 PM
I thought the problems were with Bad Behavior.  But maybe I'm confused and they're from Stop Spammer?

The symptoms were related to identifying new members as spammers, and not clearing the notifications about blocked spammers.  When I see "1 member waiting approval" that means that a registered member is identified as a spammer, and their registration is....disallowed, I guess.  That notification was not being cleared after I removed the member.

Do I understand correctly (from https://www.simplemachines.org/community/index.php?topic=283309.msg3957547#msg3957547) that I need to fix some code before I do the upgrade?  Assuming that problem I described is actually part of stop Spammer.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on January 30, 2018, 11:57:28 PM
Yes - The message behind the link gives pretty good step by step instructions I think. See them all before you go ahead.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 08:01:39 AM
Oh gosh!  As you suggested, I read that message, along with the whole page before that.  That specific message is confusing, because I have no idea what "stock code" or "stock code section" is.

But the info in messages on the page before that, is conflicting.  On the page before, it says to uninstall Stop Spammer, before doing the update.  Then reinstall it after the update, and then change some code. 

But the specific message you referenced doesn't mention uninstalling SS.  Also, it says to find certain code and replace it.  But the code it says to find, is the code which in messages on the previous page you're supposed to use to replace.

And some messages say to put the site in maintenance mode, and others don't!  Do I just use the instructions which I can understand the best?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Kindred on February 01, 2018, 10:58:03 AM
https://www.simplemachines.org/community/index.php?topic=283309.msg3950558#msg3950558
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 03:56:48 PM
(https://forum.inkscapecommunity.com/Smileys/IC_Smileys/thup.gif)

(https://forum.inkscapecommunity.com/Smileys/IC_Smileys/anxfingers.gif)

Diving back in....
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 05:42:06 PM
Ok, so I've uninstalled Stop Spammer
I applied 2.0.15 upgrade.

At this point, as before, I've lost Personal Messages.  When I click on My Messages tab, I get a blank white page.  I must have done something wrong with editing Personal Messages.php.  Can I show you all the codes and what I did, and all that?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 05:44:58 PM
Oh crap, no.  I've lost everything!  Everything is gone!

Going to revert what I just did.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 05:53:54 PM
Ok, I replaced Personal Messages.php with the original file.  But it didn't bring back the forum.  I can't even get the Package Manager.

Ok, one forum is still ok.  But the other forum is only showing this error message on a blank white page:

Table 'smf_sessions' is marked as crashed and should be repaired

Can someone give me a clue what to do?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 05:57:04 PM
Looking at cPanel, all the files are still there, so I guess I didn't blow up the whole thing.  But I don't know how to fix....well, because it says "Table" I'm guessing that's either a database, or part of a database.  Anyway, I don't know how to fix that.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Sir Osis of Liver on February 01, 2018, 05:58:47 PM
You can repair the crashed database table using phpmyadmin.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 06:05:41 PM
Yes, I have it open already.  Comparing the db for this forum, with the other that's still working, all the....I guess they're either databases or tables, have "backup' in front.

I don't see any obvious "repair" button.

Oh wait.  Way at the bottom, there's a dropdown menu titled "With selected" and one of the choices is "repair".  Is that what I need?  So Check All > With Selected > Repair ??
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Sir Osis of Liver on February 01, 2018, 06:07:15 PM
Yes, pma will attempt to repair the table.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 06:10:26 PM
"attempt"

(https://www.inkscapecuttingdesign.com/smf/Smileys/IC_Smileys/anbeg.gif)

Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Sir Osis of Liver on February 01, 2018, 06:13:00 PM
You can empty smf_sessions, it doesn't harm the forum.  Worst case, you can drop the table and import a clean one from a scratch install.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 06:24:29 PM
Ok, it looks like all of them are "OK" except for 2.

smf_sessions --> repair info --> Found row block followed by deleted block

smf_sessions --> repair warning --> Number of rows changed from 898 to 896

Actually that might be the same one, instead of 2.

What does that mean?  Does that mean 2 people logged out?  Or 2 members were forcefully logged out?  All I know about sessions is that logging in starts a session and loggin out ends it.

But probably more importantly, I don't see any hints what to do next.

I see an Edit button.  But it looks like it might apply to all the tables.

Oh wait, there's yet a 3rd entry for smf_sessions, which is --> repair status --> OK

Is that good news?  My best guess is to hit that Edit button.  But I'll wait and hear what you say.

Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 07:08:26 PM
Or whoever might know :)

Whoa - the forum's back!  Does that mean I just need to close phpMyAdmin?

And if so, I can continue along with the upgrade activities?

If so, then I need to know if the edits I made to Personal Messages.php caused this problem.  Or was this database thing just some random hickup?  Because I undid that edit, so I need to re-do it, to continue with the upgrade.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 01, 2018, 10:42:44 PM
Yeah, that would sound like a random DB hickup more than anything caused by your file edits.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 10:47:12 PM
Ok then, thanks for the info.  I'll try the edits again.  Cross fingers....
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 10:54:07 PM
Sigh!!  I must be doing something wrong with the edit to Personal Messages.php.  Because whenever I upload the edits, I lose PMs.  When I click My Messages, it's just a blank white page.

Should I post the codes or upload the files?

Actually I'm going to have to sign off for tonight.  Will it hurt to leave the upgrade half finished, until tomorrow?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 01, 2018, 10:59:25 PM
There is probably a small error in code that causes it to fail.
For your users sake, perhaps revert the change once more, and continue tomorrow.

Upload the file here, and tell what you were trying to do exactly when the edit caused problems.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 01, 2018, 11:38:32 PM
Well, since I went through with the install button in the Package Manager, I don't know how to get the exact Find and Replace code anymore.  Oh, but I know the Replace code, because that's what's in the edited/upgraded version.  I just won't be able to tell you what the Find code was.

Ok, the files are labelled before and after, attached.  These are 2 edits to PersonalMessage.php

The 2nd edit is very small.  In the following code, it was to replace "raw" with "int"

WHERE ' . ($context['folder'] == 'sent' || $context['folder'] == 'unread' ? 'pm.id_member_from = {int:current_member}

The first edit seems likely where the problem is, because it's bigger.  This is  the Replace code.

if (!empty($possible_users))
{
// We need to bring this into the query and do it nice and cleanly.
$where_params = array();
$where_clause = array();
foreach ($possible_users as $k => $v)
{
$where_params['name_' . $k] = $v;
$where_clause[] = '{raw:real_name} LIKE {string:name_' . $k . '}';
if (!isset($where_params['real_name']))
$where_params['real_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(real_name)' : 'real_name';
}

// Who matches those criteria?
// !!! This doesn't support sent item searching.
$request = $smcFunc['db_query']('', '
SELECT id_member
FROM {db_prefix}members
WHERE ' . implode(' OR ', $where_clause),
$where_params
);

// Simply do nothing if there're too many members matching the criteria.
if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch)
$userQuery = '';
elseif ($smcFunc['db_num_rows']($request) == 0)
{
$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$userQuery = 'AND pm.id_member_from = 0 AND (' . implode(' OR ', $where_clause) . ')';
}
else
{
$memberlist = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
$memberlist[] = $row['id_member'];

$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$searchq_parameters['member_list'] = $memberlist;
$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND (' . implode(' OR ', $where_clause) . ')))';
}
$smcFunc['db_free_result']($request);
}
else
$userQuery = '';


I may be around a few more minutes tonight, so if an answer comes soon, I'll try tonight.  But otherwise, it will be tomorrow....well, maybe in the morning, maybe night.

Thank you all so much for the help  (https://forum.inkscapecommunity.com/Smileys/IC_Smileys/ankissdaisy.gif)

Edit - This is for the forum which uses Simple Portal.  I don't think it matters in this case.  But just in case.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 03, 2018, 01:37:34 AM
Sorry, I had a busy day yesterday - I'll take a look at your problem file here in a bit, and get back to you :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 03, 2018, 02:05:46 AM
You have the enhanced PM system mod installed? Do note it has been withdrawn from the cust.site and is no longer supported.

Also, please list any other mods you have installed currently, without knowing exactly what you are supposed to have in there - helping further is pretty much impossible.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 03, 2018, 07:06:03 PM
Yes, I do have Enhanced PM.  That's too bad it's been removed.  I hope someone else will pick it up, and keep it going.  I really like it!

Although if it's causing this problem with the upgrade.....well, I wouldn't like to uninstall it, but if I have to, of course I will.

When I said this is for the forum which uses Simple Portal, I meant that's the source of the files.  But this problem happens in both forums, which use similar, but not identical mods.  Although where PMs are concerned, they probably are identical.

List of mods:


Simple Audio Video Embedder - 4.2.1
SimpleColorizer - 1.1
Remove images from quotes - 1.6
Global Headers Footers - 2.0.1
dQuoteSelection - 2.6.1
SimplePortal - 2.3.6
6 Custom buttons / tabs with Sub Menus (4) - 0.5
Permission for Website URL of Users - 1.4
PM Attachments - 1.6
Extended Help - 1.0
Set order for sticky topics - 0.5
Integration Hooks Report - 1.5.3
Signature Area BBCode Buttons - 2.0.3
Arantor CAPTCHA - 1.0.8
Post and PM Inline Attachments - 4.14
More Spiders - 1.2
Remove SMF Logo - 1.4
Enhanced Dropdown - 1.3
SMF Articles - 3.0.2
SMF 2.0.15 Update - 1.0
Switch Permissions - 1.0
Alt Characters v1.7 - 1.7
Contact Page - 3.2
Drafts - no version given
Sorted BBCode List for SMF 2.0x - 1.1
Enhanced PM System - 3.2
Country Flags - 2.1
Forum Firewall - 2.0.0
Image Floating Left Right BBCode - 1.16
Bad Behavior mod - 1.5.18
Table Plus BBCodes - 1.2
Users Online Today - 2.1
Sorted Package Manager Listing - 1.2
DevCenter - 0.4.1

Thanks again.  I really appreciate your help!
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 04, 2018, 11:22:43 PM
Thanks I'll see what I can do, that's quite a list to go through. I'll get back to you a bit later.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 05, 2018, 04:30:13 PM
Thanks, I really appreciate it!

Yeah, I could probably get rid of some of those.  Someone else originally installed the forum, and some of them, I don't even know what they do!

Just curious -- why can't you look at just the section of the file that was changed (technically 2 sections, but one was just 3 characters)?  I didn't change anything else, so the problem almost has to be there, right?  Or do you mean that you already checked it and didn't find the problem?

Edit
Actually I was wrong when I said that both forums are probably identical regarding PMs.  The other forum does not use PM Attachments.  I want to use it, but I can't manage to install it.  So the other forum's file will be slightly different.  Would you need that file, to be able to fix it?  Or can we probably use the fix for one file, and just put the fix in the other file?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 05, 2018, 11:51:00 PM
Quote from: brynn on February 05, 2018, 04:30:13 PM
Just curious -- why can't you look at just the section of the file that was changed (technically 2 sections, but one was just 3 characters)?  I didn't change anything else, so the problem almost has to be there, right?  Or do you mean that you already checked it and didn't find the problem?

Edit
Actually I was wrong when I said that both forums are probably identical regarding PMs.  The other forum does not use PM Attachments.  I want to use it, but I can't manage to install it.  So the other forum's file will be slightly different.  Would you need that file, to be able to fix it?  Or can we probably use the fix for one file, and just put the fix in the other file?
I did try first simply looking at the 1 section, but that one section had changed code already - so I want to try to make sure what mods had changed what part of it and how. The Enhanced PM system -mod alone does over 70 edits to that file...
Let's do one at a time, I'll try to see if I can fix this - then let's see the other one separately.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 06, 2018, 12:38:59 AM
Alright, your "after" file had this:


// Who matches those criteria?
// !!! This doesn't support sent item searching.
$request = $smcFunc['db_query']('', '
SELECT id_member
FROM {db_prefix}members
WHERE ' . implode(' OR ', $where_clause),
$where_params
);

// Simply do nothing if there're too many members matching the criteria.
if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch)
$userQuery = '';
elseif ($smcFunc['db_num_rows']($request) == 0)
{
$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$userQuery = 'AND pm.id_member_from = 0 AND (' . implode(' OR ', $where_clause) . ')';
}
else
{
$memberlist = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
$memberlist[] = $row['id_member'];

$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$searchq_parameters['member_list'] = $memberlist;
$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND (' . implode(' OR ', $where_clause) . ')))';
}
$smcFunc['db_free_result']($request);
}
else
$userQuery = '';
// BEGIN: Enhanced PM System - Search users during Sent Item/Outbox searches:
if ($context['folder'] == 'inbox')
$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND (pm.from_name LIKE {raw:guest_user_name_implode})))';
else
$userQuery = 'AND (pmr.id_member IN ({array_int:member_list}))';
// END: Enhanced PM System - Search users during Sent Item/Outbox searches:




$searchq_parameters['guest_user_name_implode'] = '\'' . implode('\' OR pm.from_name LIKE \'', $possible_users) . '\'';
$searchq_parameters['member_list'] = $memberlist;
}



$smcFunc['db_free_result']($request);
}


Clean 2.0.15 has this:


// Who matches those criteria?
// !!! This doesn't support sent item searching.
$request = $smcFunc['db_query']('', '
SELECT id_member
FROM {db_prefix}members
WHERE ' . implode(' OR ', $where_clause),
$where_params
);

// Simply do nothing if there're too many members matching the criteria.
if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch)
$userQuery = '';
elseif ($smcFunc['db_num_rows']($request) == 0)
{
$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$userQuery = 'AND pm.id_member_from = 0 AND (' . implode(' OR ', $where_clause) . ')';
}
else
{
$memberlist = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
$memberlist[] = $row['id_member'];

$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$searchq_parameters['member_list'] = $memberlist;
$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND (' . implode(' OR ', $where_clause) . ')))';
}
$smcFunc['db_free_result']($request);
}
else
$userQuery = '';
}


Enhanced PM system replaces this


$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND (pm.from_name LIKE {raw:guest_user_name_implode})))';


With this

// BEGIN: Enhanced PM System - Search users during Sent Item/Outbox searches:
if ($context['folder'] == 'inbox')
$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND (pm.from_name LIKE {raw:guest_user_name_implode})))';
else
$userQuery = 'AND (pmr.id_member IN ({array_int:member_list}))';
// END: Enhanced PM System - Search users during Sent Item/Outbox searches:


So the code should end up like this I think


// Who matches those criteria?
// !!! This doesn't support sent item searching.
$request = $smcFunc['db_query']('', '
SELECT id_member
FROM {db_prefix}members
WHERE ' . implode(' OR ', $where_clause),
$where_params
);

// Simply do nothing if there're too many members matching the criteria.
if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch)
$userQuery = '';
elseif ($smcFunc['db_num_rows']($request) == 0)
{
$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$userQuery = 'AND pm.id_member_from = 0 AND (' . implode(' OR ', $where_clause) . ')';
}
else
{
$memberlist = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
$memberlist[] = $row['id_member'];

$where_params['real_name'] = 'pm.from_name';
$searchq_parameters = array_merge($searchq_parameters, $where_params);
$searchq_parameters['member_list'] = $memberlist;






// BEGIN: Enhanced PM System - Search users during Sent Item/Outbox searches:
if ($context['folder'] == 'inbox')
$userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND (pm.from_name LIKE {raw:guest_user_name_implode})))';
else
$userQuery = 'AND (pmr.id_member IN ({array_int:member_list}))';
// END: Enhanced PM System - Search users during Sent Item/Outbox searches:


}
$smcFunc['db_free_result']($request);


}


I hope I got that right, this should be done in the attached file, but please save a backup copy your current files before testing.
I do not have a test setup with the same mods as you do, so I can not test this.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 06, 2018, 12:54:32 AM
Before I try that file, I have a question.  What if I uninstall Enhanced PM.....  Well, I'd have to go back and uninstall the upgrade AGAIN.  But uninstall Enhanced PMs first (along with Stop Spammer, which is still uninstalled), run the upgrade, and then try to reinstall.  Would that accomplish the same thing?

Well, since you're so busy, I guess I will try the file.  But if it doesn'ts work, could that work?

Ok, cross fingers and toes....
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 06, 2018, 01:06:21 AM
If this doesn't work, I'd probably suggest wiping the code base clean and reinstalling mods you still want to keep only after that.
https://wiki.simplemachines.org/smf/How_to_upload_a_fresh_set_of_files
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 06, 2018, 02:06:18 AM
Oh good news -- it works!  I still haven't re-installed Stop Spammer, but one step at a time.

So what happened?  Did I do the edits wrong?  Or was it the Enhanced PM mod is already deprecated?  Should I just stop using it now, uninstall it? 

Ok here are the before and after files for the other forum.  The Replace code was exactly the same there, and I think this file, as far as the update is concerned, is the same as the other.  But just in case - attached.

And here's the mod list:

simipleColorizer -- 1.1
MultiLanguage Registration Agreement -- 1.0
Remove images from quotes -- 1.6
Forum Firewall -- 2.0.0
No Temp Directory Removal -- 1.1.8
dQuoteSelection -- 2.6.1
Enhanced PM System -- 3.1.1
6 Custom buttons / tabs with Sub Menus (4) -- 0.5
Tiny Portal -- 1.2
View Single Category -- 2.4
open mod reports -- 1.0
Set order for sticky topics -- 0.5
Extended Help -- 1.0
Country Flags -- 3.0
Modified No Topics Message (SMF 2.0+) -- 1.1
Integration Hooks Report -- 1.5.3
Signature Area BBCode Buttons -- 2.0.3
Simple Audio Video Embedder -- 4.0.2
SVG as Image Attachments Support -- 1.1
Arantor CAPTCHA -- 1.0.8
Global Headers Footers -- 2.0.1
Post and PM Inline Attachments -- 4.16
Indent BBC -- 1.0.1
More Spiders -- 1.2
Enhanced Dropdown -- 1.2
SMF Articles -- 3.0.2a
SMF 2.0.15 Update -- 1.0
Separate the sticky topics -- 1.0.1
Bad Behavior mod -- 1.5.19
Block Email Usernames -- 0.4.2
Sisyphus -- 2.0.1
Alt Characters v1.7 -- 1.7
Contact Page -- 3.2
Expanding & Collapsing Off-Topic Tag -- 3.2
SMFPacks Shoutbox -- 1.0.5
PM Quote -- 1.0
AWSP - Add Website Permission -- 1.4.3
SRAVC - Separate Replies and Views Column -- 1.9.4
Table Plus BBCodes -- 1.2
Drafts -- 2.0.5
Add Stars to Profile -- 1.0.1
Sorted Package Manager Listing -- 1.2
DevCenter -- 0.4.1

Not Uninstallable:

SMF 2.0.14 Update -- 1.0
Reason for Editing M od -- 2.3.2

Thanks again!
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 06, 2018, 02:14:03 AM
Good! It was just a little tricky, since you were working with already modified code, and so didn't get it exactly right just following the update steps.

I'm sorry to say I will have to focus on some other things now for a while, but I will return to this again later in the evening. Hope that is OK :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 06, 2018, 02:18:45 AM
Absolutely OK!

EDIT:
I don't think I would have had any hope of figuring that out.  Maybe I should uninstall it, just to prevent problems with future upgrades?

EDIT 2:
Hhm, "evening" for you is a good 8 to 10 hours from now, I think.  Well, if I'm not here then, eventually I be back.

-Lex tidied up a bit...
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 06, 2018, 11:12:32 AM
Ok, got to take a look at it - and it would seem to me that you can use the same -fixed file I attached earlier.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 06, 2018, 02:46:51 PM
More good news!  It's working too.

Thank you SO much!!

Still have to proceed with reinstalling Stop Spammer, and then fix that code.  Hopefully I will have more luck there.  Will post results :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 06, 2018, 02:52:35 PM
You are welcome :) And do let us know how it goes.

Re: Your question about future updates, mods always pose a risk that this can happen again, but I don't think it's actually worth worrying over in advance as long as everything is working now. :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 06, 2018, 03:34:40 PM
Ok, so starting to reinstall Stop Spammer, I have 8 failed tests.  As far as I can tell, none of them is the expected one.

More info. 

As I mentioned earlier, someone else had originally installed both forums.  I have no idea whether they needed to fix these things when they originally installed SS. 

I see a notation at the top of the installation info, which says that this mod works best with a mod called httpBL.  As far as I can tell, it looks similar to the mod Bad Behavior (integrates with Project Honeypot), which is what I have installed.  Not sure if this could account for the unexpected failed tests?

Also, please recall that in the middle of all this difficulty with the upgrade, I had the corrupt database (or...table, I think), which was successfully fixed.  Not sure it that would account for the unexpected failed tests either?

7 of the 8 failed tests are in ./Sources/ManageMembers.php, and 1 is in ./Sources/Subs.php

Should I just proceed and see what happens?  Or is this a bad sign, and I still need to install clean files?

Thanks for everyone's help and patience.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: lurkalot on February 06, 2018, 07:19:12 PM
Brynn, I was just going to post on your forum, but now I get,

The following error or errors occurred while posting this message: Your session timed out while posting. Please try to re-submit your message.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 06, 2018, 09:51:06 PM
Do you mean a message in the forum, or PM?

EDIT:
I've tested both forum post and PM, and both post ok.  Well that was for Inkscape Community.  Don't think you're a member of the other forum.

EDIT 2:
Further testing.

Using regular member account, but only with the full editor, I can reproduce the error.  Doesn't happen with Quick Reply.  Doesn't happen with admin account, either way.

EDIT 3:
No, now I can't reproduce it....  strange!

EDIT 4:
Oh, but checking the error log -- the test PM I sent you threw 6 or 8 errors.  6 errors for line 2183 and 3 errors for line 2204.  Looking them up....

-Lex tidied up a bit...
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 06, 2018, 10:30:26 PM
This is line 2183, which is in the section starting with the comment    // Now create the editor.

'height' => '175px',

This is 2204, which is in theh section starting with the comment    // If the user can post attachments prepare the warning labels.

$context['attachment_restrictions'][] = sprintf($txt['attach_restrict_' . $type], $modSettings[$type]);

Note that PM Attachments is not installed in this forum.

Neither one of those was edited, in the PersonalMessage.php file which Lex provided.  I don't know what to make of it.

Edit
Note that the PM was sent.  It just threw errors.
Whatever error which lurkalot reported, it doesn't seem to be reliably reproducible.  I thought I reproduced it once, but now I can't.

Edit #2
Also note that I still haven't even attempted to reinstall Stop Spammer in this forum yet.  Attempt reported above is for the other forum.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 07, 2018, 12:59:40 AM
Quote from: brynn on February 06, 2018, 03:34:40 PM
Ok, so starting to reinstall Stop Spammer, I have 8 failed tests.  As far as I can tell, none of them is the expected one.

More info. 

As I mentioned earlier, someone else had originally installed both forums.  I have no idea whether they needed to fix these things when they originally installed SS. 

I see a notation at the top of the installation info, which says that this mod works best with a mod called httpBL.  As far as I can tell, it looks similar to the mod Bad Behavior (integrates with Project Honeypot), which is what I have installed.  Not sure if this could account for the unexpected failed tests?

Also, please recall that in the middle of all this difficulty with the upgrade, I had the corrupt database (or...table, I think), which was successfully fixed.  Not sure it that would account for the unexpected failed tests either?

7 of the 8 failed tests are in ./Sources/ManageMembers.php, and 1 is in ./Sources/Subs.php

Should I just proceed and see what happens?  Or is this a bad sign, and I still need to install clean files?

Thanks for everyone's help and patience.
I can't really say much about the errors, but some of those mods may cause issues when installing other similar mods. That is quite normal to happen when you have many mods installed, that edit similar locations of the original code. I would say though that neither httpBL or Bad Behaviour are really required for the Stop Spammer mod as I understand it, it just a recommendation that it works well with httpBL.

Quote from: brynn on February 06, 2018, 10:17:08 PM
Oh, but checking the error log -- the test PM I sent you threw 6 or 8 errors.  6 errors for line 2183 and 3 errors for line 2204.  Looking them up....
This could have something to do with the PM mods you have, including the enhanced PM system - like I mentioned it is not available anymore, and not supported, and I'd guess there was some reason for that. ( I do not know exactly why though. )

Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 07, 2018, 01:34:43 AM
Thanks Lex!  Since you didn't urge me to install clean files again, I will tentatively proceed with making the edit which Stop Spammer needs to be reinstalled.

Regarding the errors from PMs, in those lines which are reported in the Error Log, do you actually see any wrong code? 

That one line is so short, and seemingly nothing to do with....well I'm not sure what the middle line refers to on the left in an error report.  But the middle lines refer to
attach_restrict_pmAttachmentSizeLimit
attach_restrict_attachmentPMLimit
attach_restrict_attachmentNumPerPMLimit

while line 2183 of the code seems to be about the height of the editor.  Very confusing.

lurkalot, if you want to test further, I started a thread here on the Testing board:  https://forum.inkscapecommunity.com/index.php?topic=975.0  I still can't reproduce that error.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: lurkalot on February 07, 2018, 02:23:28 AM
Quote from: brynn on February 07, 2018, 01:34:43 AM

lurkalot, if you want to test further, I started a thread here on the Testing board:  https://forum.inkscapecommunity.com/index.php?topic=975.0  I still can't reproduce that error.

All I did was use the "quote selected" to quote part of a post, and reply to it. 

Thing is, I've just tried it again this morning and it worked fine..  ???
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 07, 2018, 02:47:53 AM
lurkalot:  (https://forum.inkscapecommunity.com/Smileys/IC_Smileys/anwhew.gif)

These edits to Stop Spammer appear to be very complicated as well.  (at least for me they're complicated)

There are 7 Find/Replace failed tests to deal with.  Every single Find code starts with

'sprintf' => array(

and following that are different codes.  However, that sprintf code only appears once.  I do find bits and pieces of the Find codes behind

=> array(

But I'm also finding a lot of the Replace code is already in the file.  So I wonder if a different approach would work better here.  If instead of searching for the Find code, I search for the Replace code.  If I find the Replace code is already in the file character for character and space for space, then does it make sense to just skip that edit?

Or is it important to delete whatever I can find of the Find codes, even if the Replace code is already in the file?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: lurkalot on February 07, 2018, 03:07:19 AM
Quote from: brynn on February 07, 2018, 02:47:53 AM
lurkalot:  (https://forum.inkscapecommunity.com/Smileys/IC_Smileys/anwhew.gif)

These edits to Stop Spammer appear to be very complicated as well.  (at least for me they're complicated)

There are 7 Find/Replace failed tests to deal with.  Every single Find code starts with

'sprintf' => array(

and following that are different codes.  However, that sprintf code only appears once.  I do find bits and pieces of the Find codes behind

=> array(

But I'm also finding a lot of the Replace code is already in the file.  So I wonder if a different approach would work better here.  If instead of searching for the Find code, I search for the Replace code.  If I find the Replace code is already in the file character for character and space for space, then does it make sense to just skip that edit?

Or is it important to delete whatever I can find of the Find codes, even if the Replace code is already in the file?

I only had one edit to do when I installed stop spammer.  The problem you're having is because you use more than one antispam mod which I guess edit the same file.  Plus those mods are outdated due to the changes SMF 2.0.15
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 07, 2018, 04:43:16 AM
More than one spam mod?  Outdated?  Did you see my mod list, earlier in this thread?  (For the forum I'm currently trying to install Stop Spammer, it's in message #27.) 

As far as I understand, I only use 2.  Stop Spammer and Bad Behavior (which is similar to httpBL which is recommended to be used with SS).  It looks like Bad Behavior does have an update.  But Bad Behavior is the Project Honey Pot integration.  Would it be affecting ManageMembers.php?  Doesn't it just catch potential spammers in the honey, before they register?

I can see where there might be other mods editing ManageMembers.php file (non-spam mods).  But I'm not sure what you're suggesting I could do, to get SS reinstalled.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 08, 2018, 01:05:25 AM
Quote from: brynn on February 07, 2018, 01:34:43 AM
Thanks Lex!  Since you didn't urge me to install clean files again, I will tentatively proceed with making the edit which Stop Spammer needs to be reinstalled.

Regarding the errors from PMs, in those lines which are reported in the Error Log, do you actually see any wrong code? 

That one line is so short, and seemingly nothing to do with....well I'm not sure what the middle line refers to on the left in an error report.  But the middle lines refer to
attach_restrict_pmAttachmentSizeLimit
attach_restrict_attachmentPMLimit
attach_restrict_attachmentNumPerPMLimit

while line 2183 of the code seems to be about the height of the editor.  Very confusing.

lurkalot, if you want to test further, I started a thread here on the Testing board:  https://forum.inkscapecommunity.com/index.php?topic=975.0  I still can't reproduce that error.
What are the errors you are getting exactly?
Perhaps it would be best to try diagnose those first, before adding more code changes in the game.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 08, 2018, 07:37:17 PM
Just to make sure it's clear.  2 forums:  Inkscape Community (IC)  Inkscape for Cutting Design (ICD)

The current problem re-installing Stop Spammer is in ICD.  The PM errors are in IC.  ICD does not produce the PM errors.  Eventually I'll re-install SS in IC too.

My regular member account produced these:

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send
8: Undefined index: attach_restrict_attachmentNumPerPMLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2204

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send
8: Undefined index: attach_restrict_attachmentPMLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2204

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send
8: Undefined index: attach_restrict_pmAttachmentSizeLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2204


My admin account produced those above, and these next 3 below:

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send
8: Undefined index: attach_restrict_pmAttachmentSizeLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2183

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send
8: Undefined index: attach_restrict_attachmentPMLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2183

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send
8: Undefined index: attach_restrict_attachmentNumPerPMLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2183

Overall, the ones indicating Line 2183 are far more numerous.  Another member has produced these 3:

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send2
8: Undefined index: attach_restrict_pmAttachmentSizeLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2488

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send2
8: Undefined index: attach_restrict_attachmentPMLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2488

https://forum.inkscapecommunity.com/index.php?action=pm;sa=send2
8: Undefined index: attach_restrict_attachmentNumPerPMLimit
File: /home/brynn/public_html/forum/Sources/PersonalMessage.php
Line: 2488

Continuing thanks for patience, help and support!
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 08, 2018, 07:41:21 PM
OH!!  I just thought of a clue.  Clearly the errors are referring to PM attachments.  But I do not have PM Attachments mod installed here.  However, I do have Post and PM Inline Attachments installed.  I'll bet those errors about PM attachments are - somehow -  related to codes for Inline Attachments mod.

Also,  in ICD, I do have PM Attachments installed.  So my guess would be that because Inline Attachments mod does find the PM Attachments mod code, in ICD, everything is happy.  But in IC, Inline Attachments can't find PM Attachments code, because it's not installed.

Is that a reasonable explanation for the errors?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 08, 2018, 11:39:54 PM
Quote from: brynn on February 08, 2018, 07:41:21 PM
Is that a reasonable explanation for the errors?
Yes, I'd say that the PM Attachments code is a valid suspect, however if the PM Attachments mod is not installed there shouldn't really be errors related to it either.

Just to be sure now, could you again attach the current PersonalMessage.php from the forum producing those errors?

Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 09, 2018, 12:39:04 AM
attached
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 10, 2018, 04:27:50 AM
The 2204 line error comes from this


// If the user can post attachments prepare the warning labels.
if (!empty($context['can_post_attachment']))
{
$context['allowed_extensions'] = strtr($modSettings['pmAttachmentExtensions'], array(',' => ', '));
$context['attachment_restrictions'] = array();
$attachmentRestrictionTypes = array('attachmentNumPerPMLimit', 'attachmentPMLimit', 'pmAttachmentSizeLimit');
foreach ($attachmentRestrictionTypes as $type)
if (!empty($modSettings[$type]))
$context['attachment_restrictions'][] = sprintf($txt['attach_restrict_' . $type], $modSettings[$type]);
}


That code looks like it is from PM Attachments mod, which I think you said should not be installed there, right?

The other 2 errors a bit of a mystery to me honestly... But still also clearly related to the same mod.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 10, 2018, 08:04:15 PM
Yes, that's correct.  PM Attachments mod is not installed in the forum which is having these errors.

I do seem to recall that the person who originally installed the forum, commented that PM Attachments had been hard to install, and he warned me that some day we might not be able to use it.  And indeed, that day came.  But maybe he made some kind of unusual edits to that file, to make it work?  Maybe those edits are part of this trouble?

Fixable?  Or are we back to making the clean install again?

Although I suppose just putting up with the errors might be an option, since PMs work properly otherwise....?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 11, 2018, 01:11:16 AM
To start from a clean table is always an option, but if you don't wish to go there yet you could possibly also follow the PM Attachments -mod's manual installation instructions to either

a) remove the edits it does completely, noting that not all of them may be there now
or
b) complete the edits it needs, noting that it would seem some of them are already there

The manual installation instructions can be found on the mod download page
https://custom.simplemachines.org/mods/index.php?mod=1974
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 11, 2018, 02:51:20 AM
So you mean that somehow, it's partially installed?

I've never manually installed a mod before.  Is that a way of installing which bypasses the Package Manager?

If it had originally been manually installed, but uninstalled using the Package Manager, could that cause this situation?  As far as I recall, after an upgrade (2.0.13 or 2.0.14) it started throwing errors, and I uninstalled it.  But I used the Package Manager.  Maybe the person who originally installed did it manually?

So re the manual install instructions, you're saying I would need to UNDO the edits which the manual install instructions are saying to DO?  And do I need to fix all those 6 files?  Or just this one in question (PersonalMessage.php) ?

And finally.  Do you still think I need to do this, before I reinstall Stop Spammer?

Since I don't have these errors in the forum where I'm currently trying to re-install Stop Spammer, I should be able to reinstall it, right?  It's a different forum.  But I'm still stuck on that, details in Reply #47.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 11, 2018, 03:10:22 AM
Quote from: brynn on February 11, 2018, 02:51:20 AM
So you mean that somehow, it's partially installed?
Yes, clearly since the code is there and is part of that mod.
Quote from: brynn on February 11, 2018, 02:51:20 AM
I've never manually installed a mod before.  Is that a way of installing which bypasses the Package Manager?
Yes.
Manual Installation of Mods (https://wiki.simplemachines.org/smf/Manual_installation_of_mods)
Quote from: brynn on February 11, 2018, 02:51:20 AM
If it had originally been manually installed, but uninstalled using the Package Manager, could that cause this situation?  As far as I recall, after an upgrade (2.0.13 or 2.0.14) it started throwing errors, and I uninstalled it.  But I used the Package Manager.  Maybe the person who originally installed did it manually?
Did you get any errors in your uninstallation then? It could be the uninstallation was not complete.
Quote from: brynn on February 11, 2018, 02:51:20 AM
So re the manual install instructions, you're saying I would need to UNDO the edits which the manual install instructions are saying to DO?  And do I need to fix all those 6 files?  Or just this one in question (PersonalMessage.php) ?
Yes, if you have purposely uninstalled the mod and still have code left over from it, you would probably need to go through all the files it modifies, starting with the one now throwing errors, and make sure the edits have been removed correctly - So reverse the manual install instructions. This can be a tedious job to do though.
Quote from: brynn on February 11, 2018, 02:51:20 AM
And finally.  Do you still think I need to do this, before I reinstall Stop Spammer?
Always a good idea to fix current problems first, before possible creating new ones.
Quote from: brynn on February 11, 2018, 02:51:20 AM
Since I don't have these errors in the forum where I'm currently trying to re-install Stop Spammer, I should be able to reinstall it, right?  It's a different forum.  But I'm still stuck on that, details in Reply #47.
To help with that, I would need to know each and every error you got in their entirety - and probably see the files you are working with.
It's hard to offer advice on an error, when I don't really know what the error is.
https://wiki.simplemachines.org/smf/Error_in_mod_installation
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 11, 2018, 06:01:25 AM
As far as I recall, I did have to make some file edits to uninstall it.  Of course I could have made a mistake with it.  But it was like 2 or 3 edits, not everything I see in the manual installation instructions.  Yes, that will take some time!

Ok, I'll start with manually uninstalling PM Attachments in IC.  And meanwhile, below is all the info for reinstalling Stop Spammer in ICD.




7 failed tests for ./Sources/ManageMembers.php  (attached)

Note that as far as I can tell, all the Replace code is already in the file.  It's just I can't find anything close to the Find codes.
Also note that Find/Replace #1 and Find/Replace #5 appear to be identical - not sure why? Also, #3 and #6 also appear to be identical. And also #4 and #7 look identical.

Find #1:
'sprintf' => array(
'format' => '<a href="' . strtr($scripturl, array('%' => '%%')) . '?action=profile;u=%1$d">%2$s</a>',
'params' => array(
'id_member' => false,
'member_name' => false,
),
),


Replace #1:
'function' => create_function('$rowData', '
global $scripturl;
$url = strtr($scripturl, array(\'%\' => \'%%\')) . \'?action=profile;u=\' . $rowData[\'id_member\'];
return sprintfspamer($rowData, $url, \'member_name\', 2);
'),


Find #2:
'sprintf' => array(
'format' => '<a href="' . strtr($scripturl, array('%' => '%%')) . '?action=profile;u=%1$d">%2$s</a>',
'params' => array(
'id_member' => false,
'real_name' => false,
),
),


Replace #2:
'function' => create_function('$rowData', '
global $scripturl;
$url = strtr($scripturl, array(\'%\' => \'%%\')) . \'?action=profile;u=\' . $rowData[\'id_member\'];
return sprintfspamer($rowData, $url, \'real_name\', 0);
'),


Find #3:
'sprintf' => array(
'format' => '<a href="mailto:%1$s">%1$s</a>',
'params' => array(
'email_address' => true,
),
),
'class' => 'windowbg',


Replace #3:
'function' => create_function('$rowData', '
global $scripturl;
$url = \'mailto:\' . $rowData[\'email_address\'];
return sprintfspamer($rowData, $url, \'email_address\', 3);
'),


Find #4:
'sprintf' => array(
'format' => '<a href="' . strtr($scripturl, array('%' => '%%')) . '?action=trackip;searchip=%1$s">%1$s</a>',
'params' => array(
'member_ip' => false,
),
),


Replace #4:
'function' => create_function('$rowData', '
global $scripturl;
$url = strtr($scripturl, array(\'%\' => \'%%\')) . \'?action=trackip;searchip=\' . $rowData[\'member_ip\'];
return sprintfspamer($rowData, $url, \'member_ip\', 1);
'),


Find #5:
'sprintf' => array(
'format' => '<a href="' . strtr($scripturl, array('%' => '%%')) . '?action=profile;u=%1$d">%2$s</a>',
'params' => array(
'id_member' => false,
'member_name' => false,
),
),


Replace #5:
'function' => create_function('$rowData', '
global $scripturl;
$url = strtr($scripturl, array(\'%\' => \'%%\')) . \'?action=profile;u=\' . $rowData[\'id_member\'];
return sprintfspamer($rowData, $url, \'member_name\', 2);
'),


Find #6:
'sprintf' => array(
'format' => '<a href="mailto:%1$s">%1$s</a>',
'params' => array(
'email_address' => true,
),
),
'class' => 'windowbg',


Replace #6:
'function' => create_function('$rowData', '
global $scripturl;
$url = \'mailto:\' . $rowData[\'email_address\'];
return sprintfspamer($rowData, $url, \'email_address\', 3);
'),


Find #7:
'sprintf' => array(
'format' => '<a href="' . strtr($scripturl, array('%' => '%%')) . '?action=trackip;searchip=%1$s">%1$s</a>',
'params' => array(
'member_ip' => false,
),
),


Replace #7:
'function' => create_function('$rowData', '
global $scripturl;
$url = strtr($scripturl, array(\'%\' => \'%%\')) . \'?action=trackip;searchip=\' . $rowData[\'member_ip\'];
return sprintfspamer($rowData, $url, \'member_ip\', 1);
'),


1 failed test for  ./Sources/Subs.php (attached)

As far as I can tell, (and just like the Replace code for the previous file) the file already shows the correct Replace code.  Not sure why it comes up as a failed test??

Find:
$context['unapproved_members'] = (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;

Replace:
$context['unapproved_members'] = $modSettings['unapprovedMembers'];
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 11, 2018, 06:15:24 AM
Oops, another question about manually uninstalling PM Attach.  At the bottom of the manual instructions it has Code and File Operations sections.  I guess I can sort out the File Operations section.  But for the Code section, I don't understand what to do....or undo, as is the case.

For Code, it says

"db_install.php
This file should be able to execute standalone.
add_remove_hooks.php
This file should be able to execute standalone."

Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 11, 2018, 06:21:27 AM
I'll take a stab at your files above a bit later and get back to you.

For the install scripts, if you have done the uninstall once through the package manager - you should not need to worry about those anymore. :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 11, 2018, 07:37:00 AM
Ok, I've plowed through the first 3 files, and found not a single original edit was still in those files.  So far, so good, I guess....

Now for PersonalMessage.php, which we already know has some leftover codes.  The first code change for installing manually, is

Find:
global $txt, $scripturl, $modSettings, $context, $subjects_request

And Add Before:
//
// PM ATTACHMENTS MOD MessageFolder global...
//
global $attachments;
//
// PM ATTACHMENTS MOD END!!
//


If I understand what I'm supposed to do, I should expect to find the Add Before code, before the Find code.  For manually installing, it was supposed to be placed before.  So that's where I should find it.  Right?

However, I actually find it 2 lines after.

If I understand what I'm doing, I should remove it anyway.  Right?

Does that explain why it wasn't removed during the first attempt to uninstall?  Because Package Manager couldn't find it?



I appreciate your help, whenever you can find time ;)

Thanks agian.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 11, 2018, 07:39:18 AM
Yes, you should be OK by just removing it - and yes, probably that explains why the uninstall didn't catch it correctly.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 11, 2018, 12:25:10 PM
As it turns out, it was only PersonalMessage.php which still was containing edits from PM Attachments mod.  With reasonable confidence, I've fixed all but 2, which are different enough that I can't be sure about them.

The new PersonalMessage.php is attached.  And below are the 2 sets of Find and Whatever, which I can't sort out.  (I'm naming them A and B to help avoid confusion with the Stop Spammer message and codes.)

Find A:
// Got some known members?

Add Before A:
checkSession('request');



The problem I have with that is that Find code is on line 2132.  Searching for the Add Before code, I find it on both line 2123 and line 2602.  Possibly the one on line 2123 would be the correct one to remove, but since it's separated by 9 lines, I'm just not sure.  Plus there's the 2nd occurrence which I have no idea what to think about.

Find B:
// Do the actual deletion.
$smcFunc['db_query']('', '
UPDATE {db_prefix}pm_recipients
SET deleted = {int:is_deleted}
WHERE id_member IN ({array_int:member_list})
AND deleted = {int:not_deleted}' . $where,
array(


Add After B:
'blank_string' => '',

In this case, the file contains an extra line among the Find code, so I'm not 100% sure if it's the correct Find code.  In between the line which starts SET deleted, and the line which starts WHERE id_ is a line having something to do with "blank string".  Here, the Add After code is immediately after the Find code.  But since it's about "blank string" and the extra line in the find code is about "blank string"....well, it's just not a clear choice what to do.

Next I'll start on the File Operations section, and reverse those.  Edit - if they haven't already been reversed.  (Edit #2 -- "reversing" those would just be deleting them, I guess?) (Hhmm, maybe I'll just download, just in case , so if it's there's a mistake, I can put it back....)

Thanks again  :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 11, 2018, 12:53:14 PM
Ok, except for those 2 edits, I've finished the manual uninstall!
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 12:22:02 AM
Quote from: brynn on February 11, 2018, 12:25:10 PM
As it turns out, it was only PersonalMessage.php which still was containing edits from PM Attachments mod.  With reasonable confidence, I've fixed all but 2, which are different enough that I can't be sure about them.

The new PersonalMessage.php is attached.  And below are the 2 sets of Find and Whatever, which I can't sort out.  (I'm naming them A and B to help avoid confusion with the Stop Spammer message and codes.)
This would seem to me that you can probably remove the checkSession on line 2123 in section //An error in the message

And probably edit the //do the actual deletion section to be this


// Do the actual deletion.
$smcFunc['db_query']('', '
UPDATE {db_prefix}pm_recipients
SET deleted = {int:is_deleted}
WHERE id_member IN ({array_int:member_list})
AND deleted = {int:not_deleted}' . $where,
array(

'member_list' => $owner,
'is_deleted' => 1,
'not_deleted' => 0,
'pm_list' => $personal_messages !== null ? array_unique($personal_messages) : array(),
)


BUT, do note that now I am partly guessing - because I have not compared your code to each and every one of your mods.
So test it with caution, and keep an eye on your error log.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 12:29:34 AM
Quote from: brynn on February 11, 2018, 06:01:25 AM
And meanwhile, below is all the info for reinstalling Stop Spammer in ICD.
For these, ALL the edits you mentioned seem to be there already - so they fail because they can not find the original lines they are told to edit.
You should be fine using the attached Subs and Managemembers I think.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 08:59:43 AM
Ok, re Stop Spammer, you're saying to just ignore the failed tests and install it anyway, without making any edits?

I can easily do that, considering your comments as instructions (or suggestion).  But I couldn't be more confused about why there are the failed test errors, if the correct code is already there.

When.....well, I'm not sure what to call it, other than "it"....I guess it's a script, or some kind of codes, which performs the installation?  So "it" is looking for certain codes, pretty much as a landmark.  Once it finds that landmark, "it" either replaces the landmark, or adds more code before or after the landmark.

So if it doesn't find the landmark, it just....gives up?  Is the reason it doesn't look any further, because at this point, human thought and reasoning is needed?



Re PMs.....  Geez, talk about a long, strange trip!  Ok....unless I'm forgetting something, I just need to upload/overwrite PersonalMessage.php.

(https://forum.inkscapecommunity.com/Smileys/IC_Smileys/anxfingers.gif)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 10:29:01 AM
Yeah, you seem to have understood right. The script is "dumb" if it can not find exactly what it is looking for, it will call on the admin to see what is happening, and will not try to make educated guesses on it's own.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 10:35:08 AM
Some good news anyway.  The re-installation of Stop Spammer (in ICD forum) seems to have been successful.  I just cleared out all the spam which came through while it was uninstalled, reported the spammers, and removed them too.

Not such good news with PMs.  After I upload/overwrite PersonalMessage.php, when I try to visit My Messages tab, I just get a blank white page in the browser.  Even though you had fixed it once before, I had to make many edits during manually uninstalling PM Attachments.  So I probably did something wrong somewhere.

May I impose yet again, and ask if you can have a look?  Or I would welcome help from anyone, if Lex isn't available.

PersonalMessage-Lex.php is the file you fixed the first time.
PersonalMessage-brynn.php is the file after I manually re-uninstalled PM Attachments mod.

Is there any other info or files I can provide?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 10:40:38 AM
No errors reported in the log.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Illori on February 13, 2018, 10:41:28 AM
which log? there should be something in the server error log.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 11:46:15 AM
I meant in the forum's Error Log, in the admin panel.  But I don't see any errors on the server either - well, not that's related to either my IP or PMs.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Illori on February 13, 2018, 11:47:29 AM
there should be one on the server error log especially if you are getting a white screen or a 500 error.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 12:18:05 PM
No 500 error, just blank white page.

I'll re-upload and try to trigger some kind of error.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 12:24:55 PM
The white page is usually a PHP error and should end up in a server error log. With a quick look at your file, I didn't notice any obvious cause for a white page, so the error log would be a good place to turn to.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 12:40:22 PM
No I don't see any errors in cPanel.  I've been looking in WHM, but so far, I can't find anything like an error log.

I looked in the Raw Access (edit) Visitor Log (cPanel), and found where I had browsed to the My Messages tab.  It shows that the icons and smiley's and such, did not load, because for for Size, it shows 0 bytes. 

But I don't see any Errors.

I'll keep looking.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 12:48:54 PM
Depending on the setup, it can usually be accessed either through the control panel directly,
or is saved as a file called error.log, errorlog. or similar in a place you can access.

I think the current default location for cPanel is .../USER/logs/error.log
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 01:36:21 PM
cPanel > Metrics > Errors doesn't show any errors for my IP address, or anything about PMs or the forum (something about htaccess file).

username/logs/php.error.log only shows 2 errors from July 2017.

I downloaded and opened the Raw Access Log, and found this below.  I'm not sure if it's giving any helpful info.  Specifically, I'm not sure what the "304" means.

my.ip.add.ress - - [13/Feb/2018:10:22:46 -0700] "GET /Themes/Aqua/css/index.css?fin20 HTTP/1.1" 304 - "https://forum.inkscapecommunity.com/index.php?action=pm" "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1"
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 01:40:38 PM
304 is nothing to worry about, it is a sign that your browser already has a valid copy of the resource, and it's not necessary to send it again.
But I am curious as to how a blank page wouldn't leave an error somewhere.

https://wiki.simplemachines.org/smf/What_the_white_screen_of_death_means
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 01:43:37 PM
I found user/logs/forum.inkscapecommunity.com-Feb-2018.gz.  Downloaded, opening now....

Will read the info on white screen as soon as I finish looking in that log.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 02:01:01 PM
No luck with that file.

I'll try to output more info, using the info on https://wiki.simplemachines.org/smf/What_the_white_screen_of_death_means

But first, tell me what to expect.  Will the site still be still be live for members and guests, or should I do this overnight?

After I upload/overwrite index.php, what's going to happen?  Does it give me a log or a list?  Do I need to browse to PM page to trigger the white page?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 02:30:21 PM
The index.php method should make the error visible when it happens, so you should go to the address currently causing the white page.
Since your earlier version of the PM -file worked (albeit with errors) and since that index.php edit may cause confusion and / or give out somewhat sensitive info on your setup, I would perhaps suggest reverting to the previously working PM -file for now, and wait for a suitable quiet moment for further investigation - unless you are in a hurry. :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 02:50:38 PM
Oh yeah, I reverted to the. last working file immediately when I saw the problem.

The problem with waiting for quiet time, is that it's fairly well an international community, so visitors are around all the time.  But I'll check my analytics and see if there might be good time.

So you're saying that anyone who clicks the link for PMs will see the error message? 

But it won't take very long to do this, will it?  Just upload/overwrite, browse to PM page, copy/paste whatever is there, then upload the original index.php.  Sounds like 5 minutes, if I don't get distracted.

Mon, Tues, Wed are our busiest days.  But we've been without Stop Spammer for over 2 weeks, and the spam is piling up.  (No one ever sees it, but still.)  I'll still check the analytics, but I'll probably bet that none of the visitors who might visit during those few minutes are going to use PMs.  And I'll go ahead and do it in the next little while.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 02:53:21 PM
Yeah, anyone able to cause a PHP error would be seeing the error messages, so anyone who went to their PMs would see the error.

Shouldn't take long to see what the error is, you are right - and it's not that big a deal to do any time you feel like, just as long as it's not your biggest peak hours :)

Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 03:18:00 PM
Hhm, this is our peak time right now.  So I'll wait until around 6 to 7 pm, when it drops off (5 or 6 hours from now).

I'll post whatever results I get.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 08:18:42 PM
Ok, here's what was produced with that trick.  I don't think I even need to disguise that path, it looks pretty generic.

Parse error: syntax error, unexpected ';' in /home/brynn/public_html/forum/Sources/PersonalMessage.php on line 2519

Based on my extremeley limited understanding, I would guess that error means there's an extra semicolon in that line.

2519 is a somewhat long line, with only 1 semicolon, which is at the end.  The file attached to one of the last messages above PersonalMessage-brynn.php is the file.

I can't really guess, by looking at other code, exactly what the semicolon does, or whether is should or should not be there.  I can only wait for suggestions.

Thanks again for Lex and everyone else's help and support, and patience!
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 13, 2018, 10:58:53 PM
Quote from: brynn on February 13, 2018, 08:18:42 PM
Ok, here's what was produced with that trick.  I don't think I even need to disguise that path, it looks pretty generic.

Parse error: syntax error, unexpected ';' in /home/brynn/public_html/forum/Sources/PersonalMessage.php on line 2519
Actually yes, this is what is there now


// Do the actual sending of the PM.
if (!empty($recipientList['to']) || !empty($recipientList['bcc']))
$context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], !empty($_REQUEST['outbox']), null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0, !empty($_REQUEST['pmsg']) ? (int) $_REQUEST['pmsg'] : 0;
else


I think it only needs one symbol more, and should be this


// Do the actual sending of the PM.
if (!empty($recipientList['to']) || !empty($recipientList['bcc']))
$context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], !empty($_REQUEST['outbox']), null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0, !empty($_REQUEST['pmsg']) ? (int) $_REQUEST['pmsg'] : 0);
else

The change is right at the end of the line, before the ;

To further explain a bit, the unexpected * error means there is a symbol that is misplaced, usually so that it cuts off something that was started but not finished completely. In this case there is a line with an opening ( but no closing ) before the ;.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 13, 2018, 11:59:36 PM
(https://forum.inkscapecommunity.com/Smileys/IC_Smileys/anyay.gif)

Yay, I think it's fixed!  No more white page, Inbox is showing as expected.  Sent a test message.  Although the reply might not come right away, still, I'm pretty sure it's fixed.  No errors in the forum Error Log.

Lex, how can I ever thank you for such patience and persistence!  Thank you so, so much!!  And thanks to everyone else too, who were still following the thread!

Now one last task, to reinstall Stop Spammer in the IC forum.  I'll try right now....
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 14, 2018, 12:01:33 AM
Great! Now, you have done a lot of changes in a small time frame, so keep a lookout for errors and oddities for a while. Just to be sure :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 14, 2018, 01:05:56 AM
Yyyaaaayy!!  Good news!  Stop Spammer was reinstalled as per earlier instructions, and without any problems.

Whew, that was one long update process!!  Everything seems to be working properly, no new errors showing up.

I just have to THANK YOU SO, SO MUCH !! especially to Lex, but to everyone who has been following and helping!!

I've been thinking about trying to learn PHP.  Not enough to be able to write programs, but maybe learning a little bit about it will help me make edits like these, without having to ask so many questions.

When I looked at the W3Schools PHP Tutorial, it says that learning Javascript is a prerequisite.  So that's a little bit of a bummer.  But I guess JS can be useful to know as well.  But it makes the road seem so long!

Is it true that JS is needed, to be able to learn PHP?  Or is that just the way the W3Schools tutorial teaches it?
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 14, 2018, 01:48:21 AM
From my own experience, tinkering with SMF is a good start. I started as a complete noob. I'm sure this experience right now has even tought you something that you will be able to apply in practise the next time :)

Edited to add:
I'm happy to have marked the topic solved. :) If however you still run in to errors or other problems related to this, do let us know.
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: brynn on February 14, 2018, 05:24:38 AM
Oh yes, I did not forget about marking it solved.  I just thought I'd wait a few days, just to make sure nothing else comes up.  Because as you pointed out, there were significant changes, which could affect other things, unforeseen.  But I can unsolve it, if necessary.

You're right -- I did learn a lot....if nothing else, I gained in confidence.  It gives me hope that you started as much a novice as me.

Anyway, thanks again!
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Aleksi "Lex" Kilpinen on February 14, 2018, 05:39:14 AM
You're welcome. :)
Title: Re: failed upgrade autopsy (2.0.14 to 2.0.15)
Post by: Tansy on May 03, 2018, 07:09:49 PM
Reading this thread was the most educational and terrifying I've had in a long time.  I too had a problem upgrading to 2.0.15 from 2.0.14 so thought I'll read up on problems others have had first.  WOW.  Once the panic attack was over, I took a deep breath, scrolled back to page one and started by uninstalling Stop Spammer and went from there.  Fortunately my forum is a little pipsqueak of a forum and I only have a few mods and once upon a time I used to be a computer programmer (very old school).  So uninstall, install, modify code and reinstall was all that was necessary and the pipsqueak seems very happy indeed.

Thank you to Lex and everyone else who helped Brynn wade through her upgrade problems - your expertise & her experiences helped me avoid all sorts of chaos!