Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Doug Heffernan on March 04, 2018, 08:42:25 AM

Title: $smcFunc defined twice as global
Post by: Doug Heffernan on March 04, 2018, 08:42:25 AM
Hello,

The $smcFunc var is being defined twice as global in the Register.php file.

// Begin the registration process.
function Register($reg_errors = array())
{
global $txt, $boarddir, $context, $settings, $modSettings, $user_info;
global $language, $scripturl, $smcFunc, $sourcedir, $smcFunc, $cur_profile;
Title: Re: $smcFunc defined twice as global
Post by: albertlast on March 04, 2018, 09:19:17 AM
In smf 2.1 this issue didn't exists,
maybe got already fixed.
Title: Re: $smcFunc defined twice as global
Post by: d3vcho on March 04, 2018, 09:27:39 AM
Yes, it was fixed by Arantor a long time ago for SMF 2.1 but it's still there for 2.0.x. I'll pass it to the developers.

Thank you.
Title: Re: $smcFunc defined twice as global
Post by: Shambles on March 04, 2018, 09:34:15 AM
I wouldn't class this as a bug since it doesn't cause incorrect or unexpected results, or for Register.php to behave in unintended ways.

Just sayin'
Title: Re: $smcFunc defined twice as global
Post by: d3vcho on March 04, 2018, 09:37:14 AM
Nope it's not a bug, it's just repeated code that should be removed. But it's better to keep it here so we don't forget about it.
Title: Re: $smcFunc defined twice as global
Post by: Doug Heffernan on March 04, 2018, 01:54:30 PM
Indeed, it is not really a bug per se. But I did not know where else to post it. And yes, it appears that in the 2.1. version it has been fixed.