Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: Bigguy on March 29, 2018, 08:13:13 PM

Title: A few questions
Post by: Bigguy on March 29, 2018, 08:13:13 PM
Running the latest SMF 2.1 and I have only one mod installed, the gallery. One custom theme made for SMF 2.1 named Vision. I have modified the theme a bit but mostly css. My first question is...Is the wysiwyg editor supposed to show up by default on quick reply. ?? Also, I have just found out I can not turn off the editor for some reason. There are no errors in the logs and this happens on the default theme as well.

"Use full editor in quick reply" is turned off in my profile but yet it still shows. I have turned cache off in SMF and cleared my own browser cache. Disable WYSIWYG editor is checked but yet it still shows. I have no idea what is going on. Anyone have any ideas.
Title: Re: A few questions
Post by: Bigguy on March 29, 2018, 08:25:06 PM
Is this what the editor in the quick reply box is supposed to look like when the editor is disabled. I thought the quick reply wasn't suppose to have any of that if the editor is disabled.
Title: Re: A few questions
Post by: Bigguy on March 29, 2018, 08:31:59 PM
Also, when i press spell check It says this at the bottom of the screen.

Draft last saved: Today at 07:29 PM

Something does not seem right at all. I have not edited the default theme in any way either.
Title: Re: A few questions
Post by: Bigguy on March 29, 2018, 08:36:40 PM
When you turn the editor off the spell check button does nothing. When it's on It saves a draft, but no popup window. When you click the save draft it shows the pop up for that button like it is supposed to.
Title: Re: A few questions
Post by: Antes on March 30, 2018, 08:53:14 AM
Just thinking out loud here, what is the point of having these settings for editor ? (I think there are 3-4), Removing all (I mean all) will ease the integration and code greatly IMO also (this is kinda a question) what is the gain from those settings, I mean what do the user(s) gain from not having editor.
Title: Re: A few questions
Post by: Bigguy on March 30, 2018, 08:58:53 AM
It's nice to be able to turn it off if you don't want it. It's all about giving the user choices I guess.
Title: Re: A few questions
Post by: Kindred on March 30, 2018, 09:26:46 AM
For example, I almost always disable wysiwyg editors...
Title: Re: A few questions
Post by: lurkalot on March 30, 2018, 12:02:43 PM
Quote from: Kindred on March 30, 2018, 09:26:46 AM
For example, I almost always disable wysiwyg editors...

Me too.  ;)
Title: Re: A few questions
Post by: Bigguy on March 30, 2018, 12:29:20 PM
I like giving user the choice. I use them a lot. I find it handy. Just wish this one worked right.
Title: Re: A few questions
Post by: Sesquipedalian on March 31, 2018, 11:39:36 PM
The toolbar buttons always load because that is the way SCEditor is designed to work. Here's what the settings in question are meant to do in SMF 2.1:

Show WYSIWYG editor on post page by default: Controls whether the editor initially loads in WYSIWYG mode or source mode. The full SCEditor loads in either case; this setting just determines which mode it loads in. So for folks like Kindred who prefer source mode, this setting will give them what they want.

Use full editor in Quick Reply: Controls whether all or only some parts of the editor toolbar are shown in the Quick Reply box. Most notably, the row of smilies is not shown when this is turned off. The basic toolbar buttons are still shown, and that is as intended.
Title: Re: A few questions
Post by: Sesquipedalian on March 31, 2018, 11:47:06 PM
It occurs to me that the descriptive text for both of those settings could be clearer. Therefore, I've updated them in #4683 (https://github.com/SimpleMachines/SMF2.1/pull/4683).
Title: Re: A few questions
Post by: Antes on April 01, 2018, 04:40:18 AM
Quote from: Sesquipedalian on March 31, 2018, 11:39:36 PM
The toolbar buttons always load because that is the way SCEditor is designed to work. Here's what the settings in question are meant to do in SMF 2.1:

Show WYSIWYG editor on post page by default: Controls whether the editor initially loads in WYSIWYG mode or source mode. The full SCEditor loads in either case; this setting just determines which mode it loads in. So for folks like Kindred who prefer source mode, this setting will give them what they want.

Use full editor in Quick Reply: Controls whether all or only some parts of the editor toolbar are shown in the Quick Reply box. Most notably, the row of smilies is not shown when this is turned off. The basic toolbar buttons are still shown, and that is as intended.

Well this already changes the behavior of SMF 2.0, since you can completely turn off the editor in 2.0, which makes the settings more redundant.
Title: Re: A few questions
Post by: Bigguy on April 01, 2018, 10:01:43 AM
At least someone still likes to help. Thanks for the answer and explaining that to me. It was very helpful.
Title: Re: A few questions
Post by: Sesquipedalian on April 02, 2018, 03:29:54 AM
Quote from: Antes on April 01, 2018, 04:40:18 AM
Well this already changes the behavior of SMF 2.0, since you can completely turn off the editor in 2.0, which makes the settings more redundant.

I anticipate several complaints will come from crotchety old-timers long-time users about how 2.1 doesn't do things exactly the way 2.0 did things. But I expect zero complaints about these changes removing any actual functionality for the user.
Title: Re: A few questions
Post by: Kindred on April 02, 2018, 08:31:47 AM
Hey, I resemble that remark!      I don't care about changing the way things get done  (although I still disagree with putting the full editor in quick reply... LOL)

but, if there is no functionality removed, I have no major complaints. :P
Title: Re: A few questions
Post by: Antes on April 02, 2018, 08:50:19 AM
Quote from: Sesquipedalian on April 02, 2018, 03:29:54 AM
Quote from: Antes on April 01, 2018, 04:40:18 AM
Well this already changes the behavior of SMF 2.0, since you can completely turn off the editor in 2.0, which makes the settings more redundant.

I anticipate several complaints will come from crotchety old-timers long-time users about how 2.1 doesn't do things exactly the way 2.0 did things. But I expect zero complaints about these changes removing any actual functionality for the user.

I mean, I don't care if some old-people complains about certain things, I never did :P the point is, since the editor (the way it works) changed certain settings are no longer as effective as before so to simplify the code I suggest developers to think about removing those options... nothing more nothing less :P
Title: Re: A few questions
Post by: Gwenwyfar on April 03, 2018, 08:28:26 AM
I really would not remove the default load mode option, having to toggle it on/off every time you post would be annoying, whatever the way you prefer and what the admin sets as default. Full editor mode: what is the supposed usefulness of that?

And which other 1-2 options are you referring to, Antes?
Title: Re: A few questions
Post by: Bigguy on April 03, 2018, 02:22:20 PM
Quote from: Antes on April 01, 2018, 04:40:18 AM
Well this already changes the behavior of SMF 2.0, since you can completely turn off the editor in 2.0, which makes the settings more redundant.

It would be nice to be able to turn things off on quick reply. Just my thought is all.
Title: Re: A few questions
Post by: Sesquipedalian on April 03, 2018, 11:39:24 PM
Quote from: Kindred on April 02, 2018, 08:31:47 AM
Hey, I resemble that remark!      I don't care about changing the way things get done  (although I still disagree with putting the full editor in quick reply... LOL)

but, if there is no functionality removed, I have no major complaints. :P

I had no one in particular in mind. But if you see yourself reflected in that description, who am I to argue?  ;D

But no, there's no functionality removed. Turn off the option to use WYSIWYG by default, and you'll always get your non-WYSIWYG editor that you can type your raw BBC into just the way you like. :)

Quote from: Antes on April 02, 2018, 08:50:19 AM
I mean, I don't care if some old-people complains about certain things, I never did :P the point is, since the editor (the way it works) changed certain settings are no longer as effective as before so to simplify the code I suggest developers to think about removing those options... nothing more nothing less :P
Quote from: Gwenwyfar on April 03, 2018, 08:28:26 AM
I really would not remove the default load mode option, having to toggle it on/off every time you post would be annoying, whatever the way you prefer and what the admin sets as default. Full editor mode: what is the supposed usefulness of that?

And which other 1-2 options are you referring to, Antes?
Quote from: Bigguy on April 03, 2018, 02:22:20 PM
It would be nice to be able to turn things off on quick reply. Just my thought is all.

The options have been kept, but the descriptions have been updated to better explain what they do in 2.1:
Title: Re: A few questions
Post by: Antes on April 04, 2018, 06:00:29 AM
New wording fine by me... Tho you should also change string in admin panel.
Title: Re: A few questions
Post by: Gwenwyfar on April 04, 2018, 12:15:24 PM
If all that changes are some of the editor options in quick reply, what is the point of having the full editor option now? I can only see it being (slightly) useful as an admin option, not as user choice.
Title: Re: A few questions
Post by: Antes on April 04, 2018, 03:51:49 PM
Quote from: Gwenwyfar on April 04, 2018, 12:15:24 PM
If all that changes are some of the editor options in quick reply, what is the point of having the full editor option now? I can only see it being (slightly) useful as an admin option, not as user choice.

Admin setting > Disable WYSIWYG editor (aka the editor) for forum.
User setting(s) > 1) Disable the editor / 2) Load smiley box -for 2.1-
Title: Re: A few questions
Post by: Bigguy on April 04, 2018, 08:18:11 PM
I actually have always thought of the quick reply as just that, a place to make a quick reply with no bells no whistles attached just straight forward type and submit. If you wanted to get technical about your post then you would hit reply and get the wysiwyg editor. That's just me though. This way is fine to. I just wanted to tell ya what I thought.
Title: Re: A few questions
Post by: Gwenwyfar on April 22, 2018, 01:51:40 PM
Quote from: Antes on April 04, 2018, 03:51:49 PM
Quote from: Gwenwyfar on April 04, 2018, 12:15:24 PM
If all that changes are some of the editor options in quick reply, what is the point of having the full editor option now? I can only see it being (slightly) useful as an admin option, not as user choice.

Admin setting > Disable WYSIWYG editor (aka the editor) for forum.
User setting(s) > 1) Disable the editor / 2) Load smiley box -for 2.1-
I know, I'm asking what's the point of having a disable smileys setting?
Title: Re: A few questions
Post by: Antes on April 22, 2018, 02:57:04 PM
Quote from: Gwenwyfar on April 22, 2018, 01:51:40 PM
Quote from: Antes on April 04, 2018, 03:51:49 PM
Quote from: Gwenwyfar on April 04, 2018, 12:15:24 PM
If all that changes are some of the editor options in quick reply, what is the point of having the full editor option now? I can only see it being (slightly) useful as an admin option, not as user choice.

Admin setting > Disable WYSIWYG editor (aka the editor) for forum.
User setting(s) > 1) Disable the editor / 2) Load smiley box -for 2.1-
I know, I'm asking what's the point of having a disable smileys setting?

That's exactly my point :)
Title: Re: A few questions
Post by: Kindred on April 22, 2018, 03:28:23 PM
Because some sites may not want smilies....
Title: Re: A few questions
Post by: Bigguy on April 22, 2018, 05:40:08 PM
More sites may want to just have a quick reply box with no options and a reply box with a wysiwyg editor. Or a choice of variations of that.. (Just my thoughts)
Title: Re: A few questions
Post by: Gwenwyfar on April 23, 2018, 06:50:29 AM
Quote from: Kindred on April 22, 2018, 03:28:23 PM
Because some sites may not want smilies....
It does make sense as an admin setting, but not as an user one. I'd just not have it at all for users and leave a popup instead (unless disabled by admin, which can make sense for performance reasons or less clutter).