Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: dimsarostov on August 03, 2018, 02:49:46 AM

Title: support PHP Version 7.2.7
Post by: dimsarostov on August 03, 2018, 02:49:46 AM
Hi people!
SMF 2.1.x supported the PHP Version 7.2.7 ?
Title: Re: support PHP Version 7.2.7
Post by: Arantor on August 03, 2018, 02:53:10 AM
It should do.
Title: Re: support PHP Version 7.2.7
Post by: dimsarostov on August 03, 2018, 03:07:10 AM
Quote from: Arantor on August 03, 2018, 02:53:10 AM
It should do.
have you tried?
Title: Re: support PHP Version 7.2.7
Post by: Arantor on August 03, 2018, 03:19:42 AM
No, mostly because I'm not really working on SMF 2.1.

The main issues that 7.2 raised that broke a lot of SMF 2.0, however, I *know* those have been fixed.
Title: Re: support PHP Version 7.2.7
Post by: d3vcho on August 03, 2018, 04:59:14 AM
Not sure if I tried it with PHP 7.2.6 or 7.2.7 but definitely it works.
Title: Re: support PHP Version 7.2.7
Post by: Arantor on August 03, 2018, 05:00:43 AM
And if it doesn't work in some way, that's a bug and should be reported.
Title: Re: support PHP Version 7.2.7
Post by: Chen Zhen on August 04, 2018, 02:53:26 PM

I currently use PHP 7.2.8 and have had no issues.
Title: Re: support PHP Version 7.2.7
Post by: Kindred on August 04, 2018, 03:46:33 PM
and you have self-modified the forum to make it work....

And possibly missed something...

Either way - when the official support for 7.2 comes out (if it does) thn you will have to undo all of your self-made changes.

Once again. SMF 2.0.x does not support php 7.2 (and there is no reason that any reasonable host would force you to run 7.2
Title: Re: support PHP Version 7.2.7
Post by: Arantor on August 04, 2018, 04:01:10 PM
This is the 2.1 board... one presumes we were all discussing 2.1 which should be ok on 7.2...
Title: Re: support PHP Version 7.2.7
Post by: Kindred on August 04, 2018, 05:07:49 PM
whoops...  right.

I know that Chen Zen was trying to modify 2.0 to allow php 7.2 as well and got confused
Title: Re: support PHP Version 7.2.7
Post by: Chen Zhen on August 04, 2018, 06:01:19 PM

Yes that was concerning SMF 2.1.

Concerning SMF 2.0 I made a mod that provides all the changes which should only involve uninstalling that modification when/if the SMF 2.0 branch is updated concerning deprecated syntax.
People are not forced to upgrade to PHP 7.2 at this time but they like to have a choice for various reasons.

Quote from: Kindred on August 04, 2018, 03:46:33 PM
and you have self-modified the forum to make it work....

And possibly missed something...

Either way - when the official support for 7.2 comes out (if it does) thn you will have to undo all of your self-made changes.

Once again. SMF 2.0.x does not support php 7.2 (and there is no reason that any reasonable host would force you to run 7.2

Perhaps I can respond to that above statement in kind.

I could explain further but if you can not fathom reasons for using it on your own then I see no point.
BTW - I missed nothing but apparently you did.



Title: Re: support PHP Version 7.2.7
Post by: vivien on November 08, 2018, 09:41:43 AM
Note: Ubuntu server 18.04 only supports PHP 7.2 and more and more hosts migrate to this version.
Title: Re: support PHP Version 7.2.7
Post by: albertlast on November 08, 2018, 01:10:48 PM
i already got a php 7.3 RC4 env running and
notice no error in smf 2.1 gh version.
Title: Re: support PHP Version 7.2.7
Post by: SpacePhoenix on November 08, 2018, 02:53:54 PM
Both versions 5.6 and 7.0 of PHP go EOL by the end of the year, once that happens some hosts might move all their servers over to 7.1 or 7.2
Title: Re: support PHP Version 7.2.7
Post by: live627 on November 08, 2018, 03:01:45 PM
Quote
Concerning SMF 2.0 I made a mod that provides all the changes
It's over 9000!!! :P

That mod seems to me very brittle due to the amount of edits it makes.
Title: Re: support PHP Version 7.2.7
Post by: Chen Zhen on November 10, 2018, 08:29:23 PM
Quote from: live627 on November 08, 2018, 03:01:45 PM
It's over 9000!!! :P

That mod seems to me very brittle due to the amount of edits it makes.

That's highly over exaggerated and Imo very internet troll (https://en.wikipedia.org/wiki/Internet_troll) like in nature.
Perhaps some peer`s bad habits are rubbing off.

Also (unrelated to the above) maybe someone can delete the post from the spam lecher.

Title: Re: support PHP Version 7.2.7
Post by: Irisado on November 11, 2018, 06:18:46 AM
The spam post has been removed, but please use the report to moderator button next time to ensure a faster response.
Title: Re: support PHP Version 7.2.7
Post by: Arantor on November 11, 2018, 06:26:24 AM
I'm not sure I'd disagree on brittle, because there's only three ways to do it: do a find/replace on each standard code using package manager (relies on no changes, misses non stock codes), do a find/replace on just the syntax (way more fragile, can still miss some), or write something insanely clever to do the conversion on Subs.php to pick up every code and every mod in the file.

That last one isn't entirely impossible but it does rely on detecting implicit conditional compilation but some clever calls to get_tokens() to get the syntax as PHP itself sees it would solve that. It also breaks uninstalling any of the mods while it's at it (though so do the others)

Honestly, while I applaud the effort that's gone into trying to prolong the life of a 7 year old system, maybe that energy would have been better spent on getting 2.1 out that already has this future proofed.
Title: Re: support PHP Version 7.2.7
Post by: SD-X on November 14, 2018, 11:03:40 PM
Quote from: albertlast on November 08, 2018, 01:10:48 PM
i already got a php 7.3 RC4 env running and
notice no error in smf 2.1 gh version.
Same here with PHP 7.2.8.
Title: Re: support PHP Version 7.2.7
Post by: vivien on December 07, 2018, 08:52:03 AM
Yesterday the PHP team released PHP 7.3.0 for general availability (GA) and marked the third feature update to PHP 7.

Changelog : http://www.php.net/ChangeLog-7.php#7.3.0

PHP 5.6.39 and PHP 7.0.33 are both security releases considered to be the last release in their respective branches. You should view these versions as the final releases.
Title: Re: support PHP Version 7.2.7
Post by: live627 on December 07, 2018, 03:46:15 PM
Quote from: vivien on December 07, 2018, 08:52:03 AM
Yesterday the PHP team released PHP 7.3.0 for general availability (GA) and marked the third feature update to PHP 7.
very nice
Title: Re: support PHP Version 7.2.7
Post by: Arantor on December 07, 2018, 03:52:00 PM
Unfortunately over here in the real world, neither apps nor hosts keep up with PHP releases as fast as PHP out them out.
Title: Re: support PHP Version 7.2.7
Post by: Gwenwyfar on December 07, 2018, 04:04:11 PM
If there's anything good the culture of "maniacally being up to date with everything" brought, it's at least a reduced wait period for new things.

Then instead of "horray! new feature in N! *sets reminder to use it in 10 years*" it's more like "horray! new feature in N! *sets reminder to use it in 5 years*"
Title: Re: support PHP Version 7.2.7
Post by: Arantor on December 07, 2018, 04:22:35 PM
I've never been fond of "move fast and break things", a lesson that the npm world hasn't learned yet but that thankfully enough Composer contributors have.
Title: Re: support PHP Version 7.2.7
Post by: Gwenwyfar on December 07, 2018, 04:29:55 PM
Me neither.

Maybe soon enough more people will learn the lesson (or burn themselves out enough, as already happens to so many) that things go back to a sane pace. Things that don't work can't last long. The sad part is the amount of people who see it as a "good thing".
Title: Re: support PHP Version 7.2.7
Post by: SD-X on December 07, 2018, 05:59:00 PM
Well, personally I fear updating things such as PHP and MySQL because of that same chance of things breaking, (which is all too common with both of those products). In fact, the only thing stopping me from updating to anything higher than PHP 7.2.8 right now is the fact that they reverted everything allowing the use of "caching_sha2_password" from MySQL 8+ in PHP 7.2.9 and higher.

Security is important to me, so I'm stuck in a loop of trying to decide whether I should upgrade PHP and lower the encryption on my MySQL passwords to secure PHP further, or hold off and leave PHP at risk so MySQL remains more secure. (Not that it matters anyway. The right type of security exploit in either can probably result in the other being breached, but hey...that's life).

Too bad they don't offer updates to their products like SMF does. *Wink wink*.

As for the actual topic, has anyone tested PHP 7.3.0 with SMF 2.1.x yet?
Title: Re: support PHP Version 7.2.7
Post by: Kindred on December 07, 2018, 09:44:17 PM
It will break even more things than 7.2 does
Title: Re: support PHP Version 7.2.7
Post by: albertlast on December 08, 2018, 12:27:13 AM
Quote from: albertlast on November 08, 2018, 01:10:48 PM
i already got a php 7.3 RC4 env running and
notice no error in smf 2.1 gh version.

--> 2.1 is fine with php 7.3