Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: DragonLady on August 02, 2018, 04:55:15 PM

Title: Re: SMF 2.1 Beta 3 Released
Post by: DragonLady on August 02, 2018, 04:55:15 PM
I've downloaded this and installed in a sandbox file.  So far, I love it, but I'd like to see a counterpart to the "core" theme, with the tabbed  menu and scrolling news fader.  Any plans for those to be included?
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Arantor on August 02, 2018, 04:57:05 PM
No, and no. Both were removed years ago from what is the 2.1 'core theme'.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: DragonLady on August 02, 2018, 05:09:55 PM
Quote from: Arantor on August 02, 2018, 04:57:05 PM
No, and no. Both were removed years ago from what is the 2.1 'core theme'.

Yeah; I know. I still use them (are they part of curves now? I don't recall), and when I took them down for a while several of my members asked them for them back.  I love almost everything about this new upgrade, but would like to have an option that looks more like what I have in use now.  It just looks classier, IMO, with the higher contrast and more complicated gradient bars.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Arantor on August 02, 2018, 05:13:13 PM
Honestly, I doubt they will be returned. They've been gone for 5 years now...
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: DragonLady on August 02, 2018, 05:17:57 PM
Quote from: Arantor on August 02, 2018, 05:13:13 PM
Honestly, I doubt they will be returned. They've been gone for 5 years now...

:( Darn. Okay. :(  Thanks for your quick responses. :)
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Kindred on August 02, 2018, 06:09:22 PM
core theme wpould be almost impossible to make responsive... it would have to be recoded from the ground up and, honestly that table layout is decades old at this point.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Gwenwyfar on August 02, 2018, 06:20:04 PM
Quote from: DragonLady on August 02, 2018, 04:55:15 PM
I've downloaded this and installed in a sandbox file.  So far, I love it, but I'd like to see a counterpart to the "core" theme, with the tabbed  menu and scrolling news fader.  Any plans for those to be included?
I plan to make a 2.1 responsive core theme, as well as a 2.0 one, but it's very unlikely it will be included in 2.1, and I won't work on it until after 2.1 is complete from the frond end side.


Quote from: Kindred on August 02, 2018, 06:09:22 PM
core theme wpould be almost impossible to make responsive... it would have to be recoded from the ground up and, honestly that table layout is decades old at this point.
Core is not that different from 2.0 curve.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Arantor on August 02, 2018, 06:43:22 PM
Aside from all the table markup ;)
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Gwenwyfar on August 02, 2018, 06:48:19 PM
Unless the core in this site has been modified, I don't see much more tables than in curve.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: DragonLady on August 02, 2018, 09:18:27 PM
???

AFAICT, they both work just fine on 2.015; as I have them both installed.

Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: DragonLady on August 02, 2018, 10:10:18 PM
Another little nitpick:  When I'm writing posts, I like to be able to select words or blocks of text, then hit the buttons to wrap the codes around them for bold, colors, quotes, etc.  But that doesn't work in the new version. :(


Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Kindred on August 02, 2018, 10:12:59 PM
Well, yes and no...   the core theme in 2.0 is a mess of code and it most certainly is not responsive.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Arantor on August 03, 2018, 03:25:17 AM
@Gwenwyfar - seems my memory deceives me, Core does have more tables than Curve but not as many as I remember it having - the board index is still a table.

@DragonLady, no-one is disputing that the themes work on 2.0, this is about modernising "Core" for 2.1 to work with Curve since the new theme changed an awful lot of things. Also regarding the editor, it works as expected for me - are you really using Beta 3 which is a year old, or current version from GitHub? In WYSIWYG mode or not?
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: DragonLady on August 03, 2018, 08:58:15 AM
Quote@DragonLady, no-one is disputing that the themes work on 2.0, this is about modernising "Core" for 2.1 to work with Curve since the new theme changed an awful lot of things. Also regarding the editor, it works as expected for me - are you really using Beta 3 which is a year old, or current version from GitHub? In WYSIWYG mode or not?


I don't recall if I went to GitHub or not.  It says "2.1 Beta 3", if that helps.  I usually disable wysiwyg because my members have trouble with it, but when it's on it does wrap the quotes around the text. 
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Arantor on August 03, 2018, 09:02:07 AM
If it says beta 3, you have a version that's about a year behind the current development progress build...
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Gwenwyfar on August 03, 2018, 09:20:45 AM
Quote@Gwenwyfar - seems my memory deceives me, Core does have more tables than Curve but not as many as I remember it having - the board index is still a table.
Indeed, but so is curve. All the most important content bits are still using proper markup somewhat, I don't see it being that different to make responsive than curve is, at least not in all the main user pages. I actually got hired once to make a site responsive, and was not allowed to touch any html (because it was "being rebuilt from scratch" and they didn't want any changes in the old one). It hardly had classes and plenty tables everywhere. This is actually pretty smooth by comparison, you can use proper selectors instead of a-mile-long ones and all that :laugh:

For porting it to 2.1 it would be more sane to make a sort of Core2, and for that few html edits are needed.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Arantor on August 03, 2018, 09:28:10 AM
At least in Curve most of the things that are tables are reasonably justified in being tables - Core seems to have a few holdovers.

Thing about making Curve2 responsive is that it took a scary amount of work to actually do - but the upshot is that in theory at least making Core2 out of Curve2 should be easier than it was going the other way.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: DragonLady on August 03, 2018, 09:40:02 AM
Quote from: DragonLady on August 03, 2018, 08:58:15 AM
Quote@DragonLady, no-one is disputing that the themes work on 2.0, this is about modernising "Core" for 2.1 to work with Curve since the new theme changed an awful lot of things. Also regarding the editor, it works as expected for me - are you really using Beta 3 which is a year old, or current version from GitHub? In WYSIWYG mode or not?


I don't recall if I went to GitHub or not.  It says "2.1 Beta 3", if that helps.  I usually disable wysiwyg because my members have trouble with it, but when it's on it does wrap the quotes around the text. 

'kay.  Do you have a link to the latest version?
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Illori on August 03, 2018, 09:41:04 AM
https://www.simplemachines.org/community/index.php?topic=530252.msg3816577#msg3816577
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Gwenwyfar on August 03, 2018, 09:41:49 AM
Quote from: Arantor on August 03, 2018, 09:28:10 AM
At least in Curve most of the things that are tables are reasonably justified in being tables - Core seems to have a few holdovers.

Thing about making Curve2 responsive is that it took a scary amount of work to actually do - but the upshot is that in theory at least making Core2 out of Curve2 should be easier than it was going the other way.
Since you can change how tables display, and they're only in some of the content (if we had a full table layout that'd be really painful to attempt), it's not a big deal either way. Though ideally you'd rewrite them, you can work around some of them just fine.

Specially for something as big as SMF, it does take a lot of work and a lot of testing. And curve2 still has much to go.

Yep - It's as it goes with theming, you have one good base and any further changes are the easy part. Core could have been the same, there's no need to have two completely different templates when they still show the same content mostly the same way. That's what I may do for a responsive 2.0 core actually, since then you only need to make curve responsive, instead of making both core and curve.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Arantor on August 03, 2018, 09:46:53 AM
I know you can change how tables display - I've done my share of making things responsive in my time. I'm just mindful that I've seen the process over several years of going from Core to Curve to Curve2 plus my own efforts at theme templating and I think it not wise to ever underestimate the work involved.

Not to mention making mods play nice with that.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Gwenwyfar on August 03, 2018, 10:00:50 AM
I had my forum changed to be responsive before the mod was released. Never fully finished other than the main user pages. I know very well it's no small amount of work. But even if the code was perfect it would still be a lot of work, there's no way around that.

Better make mods have to add some css than have them not even install properly for every person that tries to use them, because you changed the whole template :P And that's already how it is with many themes anyway.
Title: Re:Re: SMF 2.1 Beta 3 Released
Post by: Kindred on August 03, 2018, 11:29:47 AM
Of course -- all of this conversation should be split off by an admin (please)   since this topic is not actually supposed to be used for support
Title: Re: SMF 2.1 Beta 3 Released
Post by: Irisado on August 03, 2018, 12:00:44 PM
I'm no administator, but I have used my team lead powers accordingly :).