Simple Machines Community Forum

Customizing SMF => Graphics and Templates => Theme Site Themes => Topic started by: Antes on August 29, 2018, 07:16:12 AM

Title: Lunarfall
Post by: Antes on August 29, 2018, 07:16:12 AM
Link to the theme (https://custom.simplemachines.org/index.php?theme=2919)

Lunarfall is a gaming theme for SMF 2.1 with dark/transparent color style. Theme won't be ported back to earlier versions of SMF (Simple Machines Forum).

How to Install/Upgrade
For general users releases will be done in SMorg. For bit more advanced testers you can grab a copy of the repository and upload Lunarfall folder to Themes folder.

There will be no upgrade pack for this theme so you have to do the standard ways to upgrade your theme.

FAQ / Wiki
How to add Custom Post Icons (https://github.com/XinYenFon/Lunarfall/wiki/Adding-Custom-Post-Icons)

Demo (https://www.wowsnips.xyz/smfnext/index.php?theme=2)

How to Contribute
To contribute back to this theme, you have to sign-off each of your commits and send PR to its GitHub repository (https://github.com/xinyenfon/Lunarfall).
(Note: Translations are not accepted)

Support me on Patreon (https://www.patreon.com/XinYenFon)

Changelog
Please read changelog.txt (https://github.com/xinyenfon/Lunarfall/blob/master/changelog.txt)

License
Theme is under MIT license, please read LICENSE (https://github.com/xinyenfon/Lunarfall/blob/master/LICENSE) file in the repository.
Title: Re: Lunarfall
Post by: -Rock Lee- on August 29, 2018, 03:21:58 PM
Very beautiful @Antes I have to dust my test site with smf 2.1!


Regards!
Title: Re: Lunarfall
Post by: Antes on September 01, 2018, 09:12:45 AM
A catchup release... v0.6.1 released for Cutting Edge users.

Quote from: Rock Lee on August 29, 2018, 03:21:58 PM
Very beautiful @Antes I have to dust my test site with smf 2.1!


Regards!

Thank you :)
Title: Re: Lunarfall
Post by: EthanR on September 04, 2018, 09:02:59 PM
Very nice theme, 2.1 really needs a new default like this (perhaps a light version)
Title: Re: Lunarfall
Post by: Kindred on September 04, 2018, 09:52:07 PM
2.1has a new default theme...  but one like this would not serve well as a default
Title: Re: Lunarfall
Post by: EthanR on September 04, 2018, 11:36:08 PM
Fair enough, the color scheme not necessarily but a more neutral colored one could well be.

Good news about the new 2.1 theme, development time has caused the old one to look quite dated :-[ Is there a demo or some screenshots of it somewhere?
Title: Re: Lunarfall
Post by: Antes on November 18, 2018, 12:49:14 PM
With today's push, Theme should be up to par with cutting-edge builds. There won't be any release in here till official RC1 release. You can find the project here: https://github.com/Antes/Lunarfall
Title: Re: Lunarfall
Post by: RML on February 27, 2019, 12:29:50 PM
Hello Antes!

I tested your theme with the latest version from GitHub on my RC1 test site, I like it but found two things that don't work properly.

1. Signature appears twice (see the attached screenshot).
2. There is no Thumb up/down icon before the Like/Unlike.

Title: Re: Lunarfall
Post by: Antes on February 28, 2019, 04:52:05 AM
Quote from: RML on February 27, 2019, 12:29:50 PM
Hello Antes!

I tested your theme with the latest version from GitHub on my RC1 test site, I like it but found two things that don't work properly.

1. Signature appears twice (see the attached screenshot).
2. There is no Thumb up/down icon before the Like/Unlike.



Are you using mod site version? (Which is not updated yet), or github version ?

https://github.com/Antes/Lunarfall - you can grab github version here.
Title: Re: Lunarfall
Post by: RML on February 28, 2019, 10:21:35 AM
I'm using github version.
Title: Re: Lunarfall
Post by: Antes on February 28, 2019, 10:39:41 AM
Quote from: RML on February 28, 2019, 10:21:35 AM
I'm using github version.

Okay, I'll look at it asap. Wait for theme site package.
Title: Re: Lunarfall
Post by: Antes on February 28, 2019, 11:11:37 AM
v0.6.2 released. This should work chill with RC1 (mostly). Likes still a bit issue, I'll fix hopefully soon.
Title: Re: Lunarfall
Post by: Hero2019 on February 28, 2019, 11:19:33 AM
In the ACP I always get this error log

  Type of error: Not defined
8: Undefined index: errlog
/index.php?action=admin;area=logs;sa=errorlog;desc
  /www/htdocs/xxxxxxx/forum/Themes/Lunarfall/Errors.template.php (line 69)

Title: Re: Lunarfall
Post by: Antes on February 28, 2019, 11:29:53 AM
Yea there is a typo or change in txt file, If you can open the file and change errlog with errorlog
Title: Re: Lunarfall
Post by: Hatshepsut on February 28, 2019, 12:19:15 PM
I just have installed Lunarfall 0.6.2 on my SMF 2.1 RC1 test forum.
In each topic, the theme loads only first posting, on the second post there is an error message:

Click => (https://i.postimg.cc/ZvJQXYXy/Lunarfall.jpg) (https://postimg.cc/ZvJQXYXy)

All the next posts in topics are not shown  :-\


================

Forum version: SMF 2.1 RC1 (more detailed)
Current SMF version: SMF 2.1 RC1
GD version: bundled (2.1.0 compatible)
MySQLi engine: MySQL
MySQLi version: 5.5.59-cll
PHP: 7.2.0 (more detailed)
Server version: Apache
Title: Re: Lunarfall
Post by: Antes on February 28, 2019, 01:26:58 PM
Upload this one. See if it fixes.
Title: Re: Lunarfall
Post by: TurtleKicker on February 28, 2019, 01:39:07 PM
Is there a demo of this anywhere?
Title: Re: Lunarfall
Post by: Antes on February 28, 2019, 01:49:29 PM
Quote from: TurtleKicker on February 28, 2019, 01:39:07 PM
Is there a demo of this anywhere?

I don't have one yet... I'll setup one soon(TM).
Title: Re: Lunarfall
Post by: Hatshepsut on February 28, 2019, 11:55:03 PM
Quote from: Antes on February 28, 2019, 01:26:58 PM
Upload this one. See if it fixes.

No, I get the same error on the second post:

string(50) "/home/bulataka/public_html/test/Sources/Errors.php" ["line"]=> int(290) ["function"]=> string(9) "log_error" } [1]=> array(3) { ["file"]=> string(76) "/home/bulataka/public_html/test/Themes/Lunarfall_v0.6.2/Display.template.php" ["line"]=> int(856) ["function"]=> string(17) "smf_error_handler" } [2]=> array(3) { ["file"]=> string(76) "/home/bulataka/public_html/test/Themes/Lunarfall_v0.6.2/Display.template.php" ["line"]=> int(280) ["function"]=> string(20) "template_single_post" } [3]=> array(3) { ["file"]=> string(48) "/home/bulataka/public_html/test/Sources/Load.php" ["line"]=> int(2463) ["function"]=> string(13) "template_main" } [4]=> array(3) { ["file"]=> string(48) "/home/bulataka/public_html/test/Sources/Subs.php" ["line"]=> int(3291) ["function"]=> string(15) "loadSubTemplate" } [5]=> array(3) { ["file"]=> string(41) "/home/bulataka/public_html/test/index.php" ["line"]=> int(154) ["function"]=> string(6) "obExit" } } Error loop.
Title: Re: Lunarfall
Post by: Antes on March 01, 2019, 02:35:36 AM
Can you check Modification.english.php (under Lunarfall)

<?php
// Version: 2.1 RC1; Modifications

// Lunarfall Post
$txt['lunarfall_facebook'] = 'Share on Facebook';
$txt['lunarfall_twitter'] = 'Share on Twitter';
?>


it should be like this.
Title: Re: Lunarfall
Post by: Hatshepsut on March 01, 2019, 06:20:34 AM
Quote from: Antes on March 01, 2019, 02:35:36 AM
Can you check Modification.english.php (under Lunarfall)

<?php
// Version: 2.1 RC1; Modifications

// Lunarfall Post
$txt['lunarfall_facebook'] = 'Share on Facebook';
$txt['lunarfall_twitter'] = 'Share on Twitter';
?>


it should be like this.

Yes, the code in Modification.english.php is the same.
Title: Re: Lunarfall
Post by: Antes on March 01, 2019, 09:27:16 AM
Your site says otherwise... But for now remove the following code from Display.template

// Share this post! I order no?
echo '
<ul class="post_socialshare qbuttons">
<li><a href="//facebook.com/sharer/sharer.php?u=', $message['href'], '" target="_blank" title="', $txt['lunarfall_facebook'],'"><i class="fab fa-facebook-f fa-lg fa-fw"></i></a></li>
<li><a href="//twitter.com/share?text='. $message['subject'].'&url='. $message['href']. '" title="', $txt['lunarfall_twitter'],'"><i class="fab fa-twitter fa-lg fa-fw"></i></a></li>
</ul>';
Title: Re: Lunarfall
Post by: Hatshepsut on March 01, 2019, 12:10:08 PM
Quote from: Antes on March 01, 2019, 09:27:16 AM
Your site says otherwise... But for now remove the following code from Display.template

// Share this post! I order no?
echo '
<ul class="post_socialshare qbuttons">
<li><a href="//facebook.com/sharer/sharer.php?u=', $message['href'], '" target="_blank" title="', $txt['lunarfall_facebook'],'"><i class="fab fa-facebook-f fa-lg fa-fw"></i></a></li>
<li><a href="//twitter.com/share?text='. $message['subject'].'&url='. $message['href']. '" title="', $txt['lunarfall_twitter'],'"><i class="fab fa-twitter fa-lg fa-fw"></i></a></li>
</ul>';


Yes, the problem is solved. I have removed these lines and the theme don't generate error message, and all posts in topic are shown. Thanks :)
And now, I will install Lunarfall theme on my work forum too :)
Title: Re: Lunarfall
Post by: RML on March 01, 2019, 12:34:41 PM
I won't do that yet if you have Like enabled because it doesn't work. When you click on like button all of the quick button disappear and when you reload the page or open it again the like gets undo.
Title: Re: Lunarfall
Post by: Antes on March 01, 2019, 12:39:44 PM
Quote from: RML on March 01, 2019, 12:34:41 PM
I won't do that yet if you have Like enabled because it doesn't work. When you click on like button all of the quick button disappear and when you reload the page or open it again the like gets undo.

I'll revert likes changes back to original for now. Will release 0.6.3 soon.
Title: Re: Lunarfall
Post by: Antes on March 01, 2019, 12:40:09 PM
Quote from: Hatshepsut on March 01, 2019, 12:10:08 PM
Quote from: Antes on March 01, 2019, 09:27:16 AM
Your site says otherwise... But for now remove the following code from Display.template

// Share this post! I order no?
echo '
<ul class="post_socialshare qbuttons">
<li><a href="//facebook.com/sharer/sharer.php?u=', $message['href'], '" target="_blank" title="', $txt['lunarfall_facebook'],'"><i class="fab fa-facebook-f fa-lg fa-fw"></i></a></li>
<li><a href="//twitter.com/share?text='. $message['subject'].'&url='. $message['href']. '" title="', $txt['lunarfall_twitter'],'"><i class="fab fa-twitter fa-lg fa-fw"></i></a></li>
</ul>';


Yes, the problem is solved. I have removed these lines and the theme don't generate error message, and all posts in topic are shown. Thanks :)
And now, I will install Lunarfall theme on my work forum too :)

It is interesting that, I can't reproduce your issue in my local setup...
Title: Re: Lunarfall
Post by: Antes on March 02, 2019, 01:37:26 PM
v0.6.3
This version should be better related to compat and fixes... Still a way to go but 1 is bigger than 0 :)
Title: Re: Lunarfall
Post by: RML on March 03, 2019, 05:21:08 AM
Thanks Antes. It's much better, the like works but the double signature line is still there.
Title: Re: Lunarfall
Post by: Hero2019 on March 03, 2019, 05:40:52 AM
Oh yes right. The signature is displayed twice. Is due to the Display.template.php file.
Title: Re: Lunarfall
Post by: RML on March 03, 2019, 07:29:07 AM
I found another issue, on mobile devices the mobile menu is invisible, it's there but you can't see it.
Title: Re: Lunarfall
Post by: Antes on March 03, 2019, 11:24:48 AM
Probably while syncing with main repo (Curve2), I added some code twice.

Open Display.template
Code (Remove) Select

// Show the member's signature?
if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled'])
echo '
<div class="signature" id="msg_', $message['id'], '_signature"', $ignoring ? ' style="display:none;"' : '', '>', $message['member']['signature'], '</div>';


About empty line (likes)
Code (Find) Select
if (!empty($modSettings['enable_likes']) | !empty($message['likes']['count']))
Code (Replace) Select
if (!empty($modSettings['enable_likes']) & (!empty($context['data']['can_like']) | !empty($message['likes']['count'])))

About responsive part, it needs some attention. Unfortunately, I don't have much time at my hand atm but I'll do my best and release small patches (0.6.4/5/6...)

Many thanks for the reports.
Title: Re: Lunarfall
Post by: RML on March 03, 2019, 12:38:40 PM
Thanks, will try it. But I have another problem, sorry. Those fontawesome board icons are nice but if you have custom message icons they won't show up.
Title: Re: Lunarfall
Post by: Antes on March 03, 2019, 12:57:23 PM
Requires fixing from mod author.
Title: Re: Lunarfall
Post by: RML on March 04, 2019, 04:02:43 AM
I'm not talking about any mod, I'm talking about the built in SMF message icons, when you add your own and 'Enable customized message icons' is checked.
Title: Re: Lunarfall
Post by: Antes on March 04, 2019, 05:27:16 AM
Quote from: RML on March 04, 2019, 04:02:43 AM
I'm not talking about any mod, I'm talking about the built in SMF message icons, when you add your own and 'Enable customized message icons' is checked.

Actually you don't need to do much different than what you are doing in classic icons... This time you need a placeholder item, since we are getting all icons from FA, for example you are going to use "pen" icon, simply upload an pen.png (you can just upload a 1 kb, or empty, pen.png file) go back to your admin panel and add pen as an icon. You are done, for post part, it requires fixing from the theme. But still your icon will be there once you pick it.
Title: Re: Lunarfall
Post by: Antes on March 15, 2019, 10:43:19 AM
v0.6.4 released.

Lunarfall still awaiting few fixes from core theme/devs. Latest version should work fine with both RC1 (release) and Cutting Edge (GitHub) versions.

A wiki page added for Custom Board Icons: https://github.com/Antes/Lunarfall/wiki/Adding-Custom-Post-Icons
Title: Re: Lunarfall
Post by: Hatshepsut on March 17, 2019, 12:29:08 AM
Quote from: Antes on March 01, 2019, 12:40:09 PM
Quote from: Hatshepsut on March 01, 2019, 12:10:08 PM
Quote from: Antes on March 01, 2019, 09:27:16 AM
Your site says otherwise... But for now remove the following code from Display.template

// Share this post! I order no?
echo '
<ul class="post_socialshare qbuttons">
<li><a href="//facebook.com/sharer/sharer.php?u=', $message['href'], '" target="_blank" title="', $txt['lunarfall_facebook'],'"><i class="fab fa-facebook-f fa-lg fa-fw"></i></a></li>
<li><a href="//twitter.com/share?text='. $message['subject'].'&url='. $message['href']. '" title="', $txt['lunarfall_twitter'],'"><i class="fab fa-twitter fa-lg fa-fw"></i></a></li>
</ul>';


Yes, the problem is solved. I have removed these lines and the theme don't generate error message, and all posts in topic are shown. Thanks :)
And now, I will install Lunarfall theme on my work forum too :)

It is interesting that, I can't reproduce your issue in my local setup...

I use custom fields in user profiles (for Gender, Location, Zodiac signs...), and custom buttons in main forum menu (I have edited index.template.php to add them).
Maybe these changes generate error messages :/

Link to my forum: https://bg-nacionalisti.org/BNF/index.php
Title: Re: Lunarfall
Post by: Antes on March 17, 2019, 06:00:11 AM
You should add new items to menu (main_menu) via Subs.php.

// All the buttons we can possible want and then some, try pulling the final list of buttons from cache first.

Find this section, and you will see the menu constructed here. You can add your menu items via this section.
Title: Re: Lunarfall
Post by: Antes on March 30, 2019, 02:10:38 PM
Latest version 0.6.4, is also compatible with RC2. There are few issues in the theme, they are known and will be fixed with certain core changes merged into the software.
Title: Re: Lunarfall
Post by: SleePy on April 06, 2019, 12:19:46 PM
Antes,


Notice: Undefined index: icon in /Themes/Lunarfall_v0.6.4/GenericMenu.template.php on line 211


Got that while testing SimpleDesk and on this page: index.php?action=admin;area=theme;sa=list
Title: Re: Lunarfall
Post by: Antes on April 06, 2019, 12:34:21 PM
Quote from: SleePy on April 06, 2019, 12:19:46 PM
Antes,


Notice: Undefined index: icon in /Themes/Lunarfall_v0.6.4/GenericMenu.template.php on line 211


Got that while testing SimpleDesk and on this page: index.php?action=admin;area=theme;sa=list

I fixed that in local build, thanks for report. I'll wrap up new version soonTM (hopefully).
Title: Re: Lunarfall
Post by: TigerAnt on July 02, 2019, 09:05:53 AM
I have uploaded your theme but Simple Machine said there were errors. I copied some of your code and took it to a code analyzer and it confirmed errors in the code.

This is the error according to the analyzer :  221:                           <a href="', $scripturl, '?action=helpadmin;help=', !empty($selected_tab['help']) ? $selected_tab['help'] : $tab_context['help'], '" onclick="return reqOverlayDiv(this.href);" class="help"><i class="fa fa-question-circle fa-lg" title="', $txt['help'], '"></i></a>';
Title: Re: Lunarfall
Post by: m4z on July 02, 2019, 09:11:30 AM
Quote from: Super_Ant on July 02, 2019, 09:05:53 AM
I have uploaded your theme but Simple Machine said there were errors. I copied some of your code and took it to a code analyzer and it confirmed errors in the code.

What are the exact errors? What you posted is the line supposedly causing the error, but not the error message.

If you have other mods installed, they might interfere.
Title: Re: Lunarfall
Post by: TigerAnt on July 02, 2019, 12:47:41 PM
I'm not a coder so my ability is limited. all that I can tell you is Simple Machine repeated the error 11 times so far in the log files.

Does this help:

Error: No space between attributes.

At line 86, column 48

(0);><i class="fa fa-times fa-

Error: Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.

At line 86, column 80

floatright red"></i></a>↩            

Warning: Attribute red" is not serializable as XML 1.0.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Error: Attribute fa not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute fa-times not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute fa-lg not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute floatright not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Attribute red" not allowed on element a at this point.

From line 86, column 9; to line 86, column 81

u↩                        <a href="javascript:void(0);><i class="fa fa-times fa-lg floatright red"></i></

Attributes for element a:
Global attributes
href — Address of the hyperlink
target — Browsing context for hyperlink navigation
download — Whether to download the resource instead of navigating to it, and its file name if so
ping — URLs to ping
rel — Relationship between the location in the document containing the hyperlink and the destination resource
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
referrerpolicy — Referrer policy for fetches initiated by the element
Error: Stray end tag i.

From line 86, column 82; to line 86, column 85

ight red"></i></a>↩   

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 145, column 96; to line 145, column 102

y at 21:13</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 202, column 97; to line 202, column 103

y at 07:52</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 259, column 96; to line 259, column 102

y at 14:13</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 316, column 94; to line 316, column 100

y at 20:48</time> <span

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 337, column 295; to line 337, column 301

y at 07:52</time>)<br>↩

Error: The text content of element time was not in the required format: The literal did not satisfy the time-datetime format.

From line 349, column 83; to line 349, column 89

y at 15:57</time>)<br>↩
Title: Re: Lunarfall
Post by: KAMDen on July 16, 2019, 04:10:49 AM
Dear Antes. Please explain why the theme Lunarfall is missing the button image bb code - YouTube. I attach a screenshot, the problem highlighted in red. Tell me how to fix it without waiting for Your update?
Thanks.
(https://i.ibb.co/mF9SP3d/2019-07-16-195251.gif)
Title: Re: Lunarfall
Post by: KAMDen on July 19, 2019, 07:45:23 AM
And silence... Normally so(
Title: Re: Lunarfall
Post by: Kindred on July 19, 2019, 08:18:53 AM
possible because you never added that icon into the lunarfall images directory or CSS?

Youtube is not a standard icon in the SMF editor. Icons added by mods have to be applied to custom themes as well
Title: Re: Lunarfall
Post by: KAMDen on July 19, 2019, 09:21:53 AM
How is Youtube not a standard icon? The theme is written specifically for version 2.1 RC2. There this bb-code is present.
Title: Re: Lunarfall
Post by: Kindred on July 19, 2019, 10:20:27 AM
oops...  right.
However, the issue is going to be the same.  Is the YouTube icon present in the sprite?
images/icons/editor_sprite.png
Title: Re: Lunarfall
Post by: KAMDen on July 19, 2019, 07:56:50 PM
Kindred, on the path: "Themes/Lunarfall_v0.6.4/images/icons" file editor_sprite.png at all not watch.
Title: Re: Lunar fall
Post by: TigerAnt on July 22, 2019, 10:04:36 PM
Can I get some help on how to fix Error


Error
Type of error: Undefined_vars
Error message: 8: Undefined index: mediapro_copyremove
File: /home/djradios/public_html/Sources/AutoEmbedMediaProHooks.php
Line: 48
URL of page causing the error: https://djradiosoundstation.com/index.php?action=admin;area=logs;sa=errorlog;desc
Backtrace information
#0: smf_error_handler()
Called from /home/djradios/public_html/Sources/AutoEmbedMediaProHooks.php on line 48
#1: automedia_admin_areas()
Called from /home/djradios/public_html/Sources/Subs.php on line 4846
#2: call_integration_hook()
Called from /home/djradios/public_html/Sources/Subs-Menu.php on line 75
#3: createMenu()
Called from /home/djradios/public_html/Sources/Admin.php on line 474
#4: AdminMain()
Called from /home/djradios/public_html/index.php on line 151
Title: Re: Lunarfall
Post by: Antes on July 23, 2019, 06:26:24 AM
I`m on strict schedule with my Masters` thesis & PhD pre-research (+other health issues I want to keep private), all those issues are fixed but not yet released. Sorry to say but you have to wait at least 1 more month before I can commit some fixes/changes.

Thank you for your understanding.
Title: Re: Lunarfall
Post by: Antes on August 12, 2019, 08:11:52 AM
0.6.5 released : )
0.6.5 (12 August 2019)
* Icon changes
* Sync with Curve2
* RC2 ready
* Font-Awesome updated to 5.10.1


@RML
Check: https://github.com/Antes/Lunarfall/wiki/Adding-Custom-Post-Icons (0.6.5 or above required)

@SleePy
Fixed with 0.6.5

@KAMDen
Its known issue even in 0.6.5 release, it will stay that way for some time till I find proper fix. To explain the issue, Font-Awesome does not offer standard sprite icons, its system little bit different and with more icons in pack, they are dividing the certain groups into sub groups, YouTube in this case belongs to FAB sub-group, all other icons are belong to FAS group.

@TigerAnt
I have no idea about the issue, can you reproduce it in default theme? Maybe you can get better answer from author of the mod.
Title: Re: Lunarfall
Post by: TigerAnt on August 12, 2019, 10:39:23 AM
That is ok, I have decided not to use it.
Title: Re: Lunarfall
Post by: m4z on September 12, 2019, 05:35:20 PM
Hey, with 0.6.5 I'm seeing the following errors:
Quote
Type of error: Undefined
8: Undefined index: calendar_default_view
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 138)

Type of error: Undefined
8: Undefined index: calendar_viewlist
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 140)

Type of error: Undefined
8: Undefined index: calendar_viewmonth
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 141)

Type of error: Undefined
8: Undefined index: calendar_viewweek
https://(redacted)/index.php?action=profile;area=theme
/home/beta-smf/public_html/Themes/Lunarfall_v0.6.5/Settings.template.php (Line 142)


The relevant code section:

   135: $txt['theme_opt_calendar'],
   136: array(
   137: 'id' => 'calendar_default_view',
==>138: 'label' => $txt['calendar_default_view'],
   139: 'options' => array(
==>140: 'viewlist' => $txt['calendar_viewlist'],
==>141: 'viewmonth' => $txt['calendar_viewmonth'],
==>142: 'viewweek' => $txt['calendar_viewweek']
   143: ),
   144: 'default' => true,
   145: 'enabled' => !empty($modSettings['cal_enabled']),
   146: ),



Also, I guess you forgot to bump the version somewhere, because the theme is displayed as "Lunarfall_v0.6.5 (0.6.4)" to me under "Modify Themes".

I'm seeing more errors, but I'll have to filter those that are related to other mods... will post more info in a few days.
Title: Re: Lunarfall
Post by: Antes on September 14, 2019, 10:05:54 AM
Try going latest GitHub version and try again. If you are using RC2 (release), stay on 0.6.4.
Title: Re: Lunarfall
Post by: m4z on September 14, 2019, 02:19:24 PM
With 0.6.4 I had much more errors (similar to those reported by others above); couldn't use it in "production", so I'll stick with 0.6.5 for now (my handful of users hardly use the calendar; I'll just inform them about it).

PS: Also seeing the following two errors on 0.6.5 when installing a mod (a modified version of the "GDPR Helper" mod with postgres support):

Error number one:
Quote
Type of error: Undefined
8: Undefined variable: i
https://(redacted)/index.php?action=admin;area=packages;sa=install;package=1568479393.zip
/home/alpha-smf/public_html/Themes/Lunarfall_v0.6.5/Packages.template.php (Line 165)


   155: $action_num = 1;
   156: $js_operations = array();
   157: foreach ($context['actions'] as $packageaction)
   158: {
   159: // Did we pass or fail?  Need to now for later on.
   160: $js_operations[$action_num] = isset($packageaction['failed']) ? $packageaction['failed'] : 0;
   161:
   162: echo '
   163: <tr class="windowbg">
   164: <td>', isset($packageaction['operations']) ? '<img id="operation_img_' . $action_num . '" src="' . $settings['images_url'] . '/selected_open.png" alt="*" style="display: none;">' : '', '</td>
==>165: <td style="width: 30px;">', $i++, '.</td>
   166: <td style="width: 23%;">', $packageaction['type'], '</td>
   167: <td style="width: 50%;">', $packageaction['action'], '</td>
   168: <td style="width: 20%;">', $packageaction['description'], '</td>
   169: </tr>';



Error number two:
Quote
Type of error: Undefined
8: Undefined variable: operation_num
https://(redacted)/index.php?action=admin;area=packages;sa=install;package=1568479393.zip
/home/alpha-smf/public_html/Themes/Lunarfall_v0.6.5/Packages.template.php (Line 192)


   179: // Show the operations.
   180: foreach ($packageaction['operations'] as $operation)
   181: {
   182: // Determine the position text.
   183: $operation_text = $operation['position'] == 'replace' ? 'operation_replace' : ($operation['position'] == 'before' ? 'operation_after' : 'operation_before');
   184:
   185: echo '
   186: <tr class="windowbg">
   187: <td class="righttext">
   188: <a href="', $scripturl, '?action=admin;area=packages;sa=showoperations;operation_key=', $operation['operation_key'], !empty($context['install_id']) ? ';install_id=' . $context['install_id'] : '', ';package=', $_REQUEST['package'], ';filename=', $operation['filename'], ($operation['is_boardmod'] ? ';boardmod' : ''), (isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'uninstall' ? ';reverse' : ''), '" onclick="return reqWin(this.href, 600, 400, false);">
   189: <i class="fas fa-scroll"></i>
   190: </a>
   191: </td>
==>192: <td width="30">', $operation_num++, '.</td>
   193: <td width="23%">', $txt[$operation_text], '</td>
   194: <td width="50%">', $operation['action'], '</td>
   195: <td width="20%">', $operation['description'], !empty($operation['ignore_failure']) ? ' (' . $txt['operation_ignore'] . ')' : '', '</td>
   196: </tr>';
   197: }


PPS: When I select Lunarfall 0.6.5 as my user theme (under Look and Layout in my profile), and try to switch back to the default theme, I get a "session verification error" under some circumstances, re-logging-in doesn't change anything. Only when I first preview the default theme can I then successfully change it. (First I thought this doesn't happen when Lunarfall is selected as the default forum theme; but the situation seems to be more complex.)

PPPS:
QuoteLunafall is a dark gaming inspired by Steam website.



I tested the GH version, and what I see is the following:

I'm not sure whether I did anything to my beta forum before that caused this, I don't think so, though. (For all I care, the fix is fine, I'm planning to update my other forums to a more recent version than 2.1rc2 soon-ish.)

Thanks for your awesome theme (and time)! <3
Title: Re: Lunarfall
Post by: Antes on September 14, 2019, 02:44:44 PM
I`ll take a look at the soonish. Thank you for the reports.
Title: Re: Lunarfall
Post by: m4z on September 14, 2019, 02:49:17 PM
Also, in 2.1rc2, the Save Draft and Preview buttons during Quickreply or normal Reply disappear when using 0.6.5 or your GH version, and the keyboard shortcuts for draft/preview/post don't work. [edit: also, the buttons for modifying/reporting/etc. of posts are gone]

In the SMF Github version from 2019-09-01, all of the above works normally.
Title: Re: Lunarfall
Post by: Antes on September 14, 2019, 03:30:32 PM
Quote from: m4z on September 14, 2019, 02:49:17 PM
Also, in 2.1rc2, the Save Draft and Preview buttons during Quickreply or normal Reply disappear when using 0.6.5 or your GH version, and the keyboard shortcuts for draft/preview/post don't work. [edit: also, the buttons for modifying/reporting/etc. of posts are gone]

In the SMF Github version from 2019-09-01, all of the above works normally.

0.6.5 / GH version both designed for Nightly builds of SMF 2.1.

0.6.4 probably the only proper release for SMF 2.1 RC2 (release).
Title: Re: Lunarfall
Post by: m4z on September 14, 2019, 05:24:03 PM
Good to know, I'll shut up about it then (the 0.6.5 changelog says "rc2 ready" tho). ;)
Title: Re: Lunarfall
Post by: Antes on September 18, 2019, 12:30:28 PM
Fixed few issues in github, you can get it. But I strongly suggest you to use GitHub version of both SMF & Lunarfall. Otherwise you probably end up having more issues.
Title: Re: Lunarfall
Post by: m4z on October 05, 2019, 03:22:14 PM
Using both GH versions works fine, thank you!
Title: Re: Lunarfall
Post by: Antes on May 15, 2020, 07:46:26 AM
A demo finally? (https://www.wowsnips.xyz/smfnext/index.php?theme=2)
Title: Re: Lunarfall
Post by: kengel on May 26, 2020, 08:30:29 AM
I tried installing this and now I am getting an error message: HTTP Error 500. How do I fix this?
Title: Re: Lunarfall
Post by: Antes on October 16, 2020, 05:43:50 PM
v0.7.0 Released

* RC3 ready :)
Title: Re: Lunarfall
Post by: Antes on October 27, 2020, 05:43:37 PM
v0.7.1

- Some fixes on HTML & CSS
- Updated the FA version
- Icons moved away from FA's own file
Title: Re: Lunarfall
Post by: Antes on April 30, 2021, 12:59:15 PM
v0.7.2


- sync mostly no improvements or bugfixes I can say of ...
Title: Re: Lunarfall
Post by: Shades. on October 21, 2021, 09:49:50 AM
No logout button in the Userbox.

logout.PNG
Title: Re: Lunarfall
Post by: Antes on October 22, 2021, 06:58:22 AM
Will fix those issues at certain point but dunno when, too busy with IRL work...
Title: Re: Lunarfall
Post by: Antes on November 02, 2021, 03:12:24 AM
v0.7.4

* Sync with Curve2
* Fixed few icons
* Added some missing editor icons

Quote from: Shades. on October 21, 2021, 09:49:50 AMNo logout button in the Userbox.

logout.PNG
This was related to core-software, fixed with #7133 (https://github.com/SimpleMachines/SMF2.1/pull/7133).
Title: Re: Lunarfall
Post by: SethStudent on November 17, 2021, 04:58:09 PM
I'm looking for a dark theme for a couple of my forum members, and thought this was a nice one. The only problem I've seen so far is that the drop down profile menu says string(x) "text" with icons for all the options. Rolling over the items brings up the black box with link name.

I'm using v.7.4 with the most recent version of RC4 (downloaded today).

I'm on a Mac, I checked it in Firefox and Safari.
Title: Re: Lunarfall
Post by: Diego Andrés on November 17, 2021, 05:10:21 PM
Looks like certain cat forgot to remove some debugging from the Profile.template.php  :P

echo '<pre>';
var_dump($area['plain_class']);
echo '</pre>';
Title: Re: Lunarfall
Post by: SethStudent on November 17, 2021, 06:14:28 PM
Ah! Diego! Thank you. I took that out and now I get this (below).
Title: Re: Lunarfall
Post by: Diego Andrés on November 17, 2021, 07:29:13 PM
That's how it should look I believe, it doesn't have any additional text besides the fa icons.
It has a title attribute so hovering over the icon should display the text.
Title: Re: Lunarfall
Post by: Antes on November 18, 2021, 03:43:44 AM
Quote from: Diego Andrés on November 17, 2021, 05:10:21 PMLooks like certain cat forgot to remove some debugging from the Profile.template.php  :P

echo '<pre>';
var_dump($area['plain_class']);
echo '</pre>';
inc. commit of shame :)
sowwy :(
Title: Re: Lunarfall
Post by: SethStudent on November 18, 2021, 05:25:43 PM
Ooops, just noticed there's no icon or visible link for Logout in the profile drop down menu. The link is there, the tool tip pops up when hovered over. How to fix this?
Title: Re: Lunarfall
Post by: Diego Andrés on November 18, 2021, 06:09:19 PM
It's related to this: https://github.com/SimpleMachines/SMF2.1/pull/7133
Either update the files or just do that single change manually.
Title: Re: Lunarfall
Post by: SethStudent on November 18, 2021, 06:57:01 PM
Quote from: Diego Andrés on November 18, 2021, 06:09:19 PMEither update the files or just do that single change manually.

Wow, thank you for the speedy reply! All better.  ;D
Title: Re: Lunarfall
Post by: SethStudent on April 23, 2022, 06:14:39 PM
It's me again. :D

I'm all upgraded to SMF 2.1.1. Spent the day at SMFHacks getting their Awesome Post Ratings working with Lunarfall (latest version 0.7.4), so that's been taken care of.

In the process, I noticed that when I highlight text to take a partial quote, the "Quote selected text button" does not appear. There's just a little square blank box after the Quote button. Hovering over  the box, it turns blue and two text hints do appear. That's nice, but it would be nicer to have some sort of graphic on the button. I thought I could just go in a fix it with CSS, but I "inspected the element" and it's way out of my league.

Help please? Thanks.


Title: Re: Lunarfall
Post by: Antes on April 23, 2022, 06:28:44 PM
I do not suggest you to use Lunarfall with SMF 2.1 / 2.1.1 and forward... many many files are out of sync.
Title: Re: Lunarfall
Post by: SethStudent on April 23, 2022, 06:34:11 PM
Thanks! I have a member who has been using Lunarfall and other than it not working with the Mod, he is happy with it and not having problems. But I'll keep that in mind in case something else comes up.

We've looked at other dark themes and none of them are as nice as Darkfall. Are you going to eventually upgrade it? If not, I'll explain the situation to him.
Title: Re: Lunarfall
Post by: Antes on April 24, 2022, 05:59:51 AM
Quote from: SethStudent on April 23, 2022, 06:34:11 PMThanks! I have a member who has been using Lunarfall and other than it not working with the Mod, he is happy with it and not having problems. But I'll keep that in mind in case something else comes up.

We've looked at other dark themes and none of them are as nice as Darkfall. Are you going to eventually upgrade it? If not, I'll explain the situation to him.
To be honest, I really don't know one side of me wants to but other not and currently the other side is winning... I'm not happy about it but as you understand, instead of suffering myself I rather not do it...

Lunarfall is a broken theme... many of its parts changed to experiment things for Curve2... so it ended up being abomination of Curve2 with dark-color-scheme... I was overall happy with the progress in that time, still am... 

I still hope to push myself to sync it with 2.1.x & fix some leftover issues (I intentionally left -aka being lazy-). As long as its working fine, its fine but don't know if anything is actually broken.
Title: Re: Lunarfall
Post by: Steve on April 24, 2022, 06:39:27 AM
Quote from: Antes on April 23, 2022, 06:28:44 PMI do not suggest you to use Lunarfall with SMF 2.1 / 2.1.1 and forward... many many files are out of sync.
Do you want your first post to reflect this or have the theme removed or leave things as they are Antes?
Title: Re: Lunarfall
Post by: Antes on April 24, 2022, 10:48:39 AM
I mean the page already suggest that its compatible up to RC... not SMF 2.1.x (Gold and forward) so no change is needed... I don't want to remove it, people still can take a look (or fork or get some code)... "as is" is fine.
Title: Re: Lunarfall
Post by: Steve on April 24, 2022, 01:41:59 PM
Roger that.  :)
Title: Re: Lunarfall
Post by: Antes on May 22, 2022, 08:26:58 AM
so yea I did something... and v0.8 is here and compatible with SMF 2.1, theme site still saying Compatible with SMF 2.1 RC4 but its set to install 2.1.*
Title: Re: Lunarfall
Post by: SethStudent on May 23, 2022, 12:33:51 PM
Awesome, thank you so much!!!
Title: Re: Lunarfall
Post by: SethStudent on May 23, 2022, 02:21:57 PM
I just updated to 2.1.2 and also the Lunarfall theme. Both went just fine, but I see the graphic for taking a partial quote is still missing—there's just a blank space until hovering brings up the tooltips. See my attachment below.