Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Arskrigitsioniets on December 17, 2018, 06:55:33 AM

Title: [2.0] [2.1] Emoji break preview
Post by: Arskrigitsioniets on December 17, 2018, 06:55:33 AM
Emojis like this 😄 break preview on 2.0 and on 2.1.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Gwenwyfar on December 17, 2018, 07:04:33 AM
Are you using Beta 3 or the latest github version?
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Bigguy on December 17, 2018, 07:10:01 AM
This works fine on my site.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arskrigitsioniets on December 17, 2018, 07:59:13 AM
Quote from: Gwenwyfar on December 17, 2018, 07:04:33 AM
Are you using Beta 3 or the latest github version?
I tried beta 3 that is installed on Russian smf support forum: https://www.simplemachines.ru.

And I myself use 2.0.15 version on my forum форум.стратегикон.рф and I see the same problem.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Kindred on December 17, 2018, 09:37:08 AM
hmmmm... looks like he's inserting emoji emojis - not a smiley from the server...
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Gwenwyfar on December 17, 2018, 10:00:00 AM
It might have been fixed already. Try the latest version.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arskrigitsioniets on December 17, 2018, 10:16:51 AM
Quote from: Gwenwyfar on December 17, 2018, 10:00:00 AM
It might have been fixed already. Try the latest version.
I'm too lazy to install it  :D If you have free time, just try it on your version in development.

Quotehmmmm... looks like he's inserting emoji emojis - not a smiley from the server...
Yes, the problem is exactly with emoji emojis.

Like this: 😄. You can copy it by cntrl+c and insert as a text.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arantor on December 17, 2018, 11:33:07 AM
The comedy is that this will almost certainly be two completely different bugs depending on 2.1 configuration.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Sesquipedalian on December 17, 2018, 07:23:30 PM
This was fixed in SMF 2.1 in pull request #4059 (https://github.com/SimpleMachines/SMF2.1/pull/4059) on May 17, 2017, and I just did a preview of this post right now, which demonstrated clearly to me that it has also already been fixed in SMF 2.0. 😉 Please upgrade to the latest versions.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arskrigitsioniets on December 18, 2018, 02:49:25 AM
QuoteThis was fixed in SMF 2.1 in pull request #4059 on May 17, 2017, and I just did a preview of this post right now, which demonstrated clearly to me that it has also already been fixed in SMF 2.0. 😉 Please upgrade to the latest versions.
If you speak that you have already fixed it on 2.0, why do I right now do a preview and see this? For some reasons, I can't attach an attachment to this post now, so this is a screenshot:
(https://i.imgur.com/4k8G0iC.png)

Also on my forum 2.0.15 форум.стратегикон.рф I see the same problem. And on Russian smf community forum 2.1.3 I see the same problem. https://www.simplemachines.ru/index.php
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Sesquipedalian on December 18, 2018, 03:24:05 AM
QuoteAlso on my forum 2.0.15 форум.стратегикон.рф I see the same problem.
I don't know why it isn't working for you, but I can't reproduce the problem in any of my tests. I've tested again on two other SMF 2.0.15 forums, and previewing a post containing emoji characters works in both cases.

QuoteAnd on Russian smf community forum 2.1.3 I see the same problem. https://www.simplemachines.ru/index.php
That forum is using a version of SMF 2.1 Beta 3 from before the bug was fixed. It needs to be updated.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Sesquipedalian on December 18, 2018, 03:39:11 AM
Is your 2.0.15 forum using Unicode character encoding, known as UTF-8? If not, that might be causing you problems. Emoji characters only work properly with Unicode.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arantor on December 18, 2018, 03:49:16 AM
Is that preview from quick reply or preview from full editor? I have long suspected the latter as mangling submissions with emoji.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arskrigitsioniets on December 18, 2018, 09:29:47 AM
Quote from: Sesquipedalian on December 18, 2018, 03:39:11 AM
Is your 2.0.15 forum using Unicode character encoding, known as UTF-8? If not, that might be causing you problems. Emoji characters only work properly with Unicode.
Yes, I'm using UTF-8. If I see this bug on this forum as well (www.simplemachines.org), but you speak that you don't have the bug... maybe the problem is in the browser? I use Google Chrome 71.0.3578.98 in the Russian language. I've just installed clear 2.0.15 version and I see the same bug...

QuoteIs that preview from quick reply or preview from full editor? I have long suspected the latter as mangling submissions with emoji.
From full editor.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arantor on December 18, 2018, 09:33:34 AM
Yeah, I bet the JS chokes on it.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Sesquipedalian on December 18, 2018, 10:22:32 AM
I was doing my tests from the full editor.

Edit: Never mind. My memory must be failing. Yes, this bug does appear when the preview comes from the full editor, but not from the quick editor.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Arantor on December 18, 2018, 10:31:19 AM
That's why I've suspected but never proven that it worked properly because ever since I wrote the emoji handling hack, I've never been 100% convinced it was 100% reliable... but I could never consistently reproduce it breaking, even when it was just a patch I had locally.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: Sesquipedalian on December 18, 2018, 10:35:52 AM
I'm reopening this now that we've figured out how to reproduce it.
Title: Re: [2.0] [2.1] Emoji break preview
Post by: live627 on December 18, 2018, 07:29:16 PM
This will be fixed in the upcoming 2.0.16.

Originally reported in SMF 2.0.15 Message Preview failing on emojis (https://www.simplemachines.org/community/index.php?topic=558414.0)
Title: Re: [2.0] [2.1] Emoji break preview
Post by: shawnb61 on October 03, 2019, 07:02:47 PM
This was reported a few times & a fix is targeted for 2.0.16 - I am going to close the dupes & keep one open:
https://www.simplemachines.org/community/index.php?topic=569620.0