Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: hitsme on January 13, 2019, 11:06:59 PM

Title: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: hitsme on January 13, 2019, 11:06:59 PM
https://archive.org/details/software?and[]=creator%3A%22microsoft%22

it breaks on the "="
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: hitsme on January 13, 2019, 11:35:42 PM
Quote from: hitsme on January 13, 2019, 11:06:59 PM
https://archive.org/details/software?and[]=creator%3A%22microsoft%22

it breaks on the "="
I found a way around it by removing https://
archive.org/details/software?and[]=creator%3A%22microsoft%22
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: Aleksi "Lex" Kilpinen on January 13, 2019, 11:44:42 PM
That's interesting. The http/https part shouldn't really make a difference.
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: Arantor on January 14, 2019, 02:03:16 AM
It does, though, by not auto converting it to a link.

The issue is that the link contains [ and ] which is also part of bbcode and SMF has never properly supported this.
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: Aleksi "Lex" Kilpinen on January 14, 2019, 02:10:08 AM
Oh, right - yeah, I was thinking of the linking. http or https should make no difference there, but leaving it as text of course is another thing.
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: Kindred on January 14, 2019, 08:08:04 AM
Well, the [ and ] should not be used in URLs anyways...


although
https://tools.ietf.org/html/rfc3986#section-2
does technically allow them, they are a part of the list of unsafe characters which should be encoded if required in the URL

Unsafe characters   Includes the blank/empty space and " < > # % { } | \ ^ ~ [ ] `



Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: GigaWatt on January 14, 2019, 06:40:19 PM
Yep, just tried, the URL tag also breaks the link :-\.

Just use the code tag, that's what I would do ;). Or use the nobbc tag either one of those should do the trick ;).

Hmmm... a question just popped up. Why would the BBC parser search for any BBC inside the [url=http://somesite.tld/] part of the tag? Does the URL tag allow other BBCs to be present in that part of the tag?
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: Arantor on January 15, 2019, 02:22:22 AM
It isn't. The ] in the link is treated naively as the end of the opening tag.
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: hitsme on January 16, 2019, 04:28:12 PM
Quote from: Arantor on January 15, 2019, 02:22:22 AM
It isn't. The ] in the link is treated naively as the end of the opening tag.
https://archive.org/details/software?and[%5D=creator%3A%22microsoft%22 (https://archive.org/details/software?and%5B%5D=creator%3A%22microsoft%22)

If thats the case Replacing ] With %5D Does the trick

But I dont expect SMF to do it
Title: Re: Could you please get me this as a URL, or atleast dont convert to a url?
Post by: Kindred on January 16, 2019, 04:55:44 PM
yes... that would do the trick...   and that is how URLs SHOULD be listed, even from the site itself...   those characters are unsafe to use in URLS, and, if used, should be changed to the encoded version.