Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: Storebror on February 12, 2019, 06:42:39 AM

Title: Smileys missing completely
Post by: Storebror on February 12, 2019, 06:42:39 AM
Dear all,

I've successfully converted an existing 2.0.15 forum to 2.1 RC 1 and so far managed to make my way through the small issues I've faced alongside that conversion, but now I got to a point I somehow don't manage to solve:
My converted Forum doesn't show the available Smileys in the "Post" form.
Not at all.
It's not that the smileys aren't there (they are, and they are enabled and visible in the "Edit Smileys" settings page.
It's also not that the smileys which are installed won't work. When I manually enter the corresponding smiley "code", it will show in the message just normal.
It's just that the "bar" of smileys, which is usually shown on top of the "Post" form textbox, is missing completely.
Furthermore I've got the SMFPacks Shoutbox 1.4 installed (which is 2.1 RC 1 compatible), and it works well except for the fact that the smiley icon is missing on the shoutbox too.

I'm kinda lost here as all settings seem to be fine.
Any help would be appreciated!

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: Gwenwyfar on February 12, 2019, 06:46:26 AM
What browser are you using?
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 07:00:25 AM
I've tried Chrome and Firefox so far.

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: Gwenwyfar on February 12, 2019, 07:14:45 AM
There's a bug with smileys not showing in IE, I guess that's not the case.

Have you made sure the smileys are set to display in the editor? They can be disabled on the quickreply box.

Edit: Theme settings -> "Use full editor toolbar in Quick Reply"
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 07:25:35 AM
I don't even have that setting.
Here are my Theme Settings:
(https://i.postimg.cc/26D1t38s/Theme-Settings.png)

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: Gwenwyfar on February 12, 2019, 07:32:15 AM
It's under Member Options.
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 07:39:44 AM
There's even less of it:
(https://i.postimg.cc/sfks3bRc/Themes-and-Layout-settings.png)

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 07:43:17 AM
Ah I see, it's in each member's own "Look and Layout" settings.
Enabled that setting, doesn't change a thing.
I've also enabled the "Wysiwyg" setting, also no change.

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: maximus23 on February 12, 2019, 07:44:36 AM
Check this fix specified here: https://www.simplemachines.org/community/index.php?topic=564893.msg4006524#new

:)
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 08:00:36 AM
Thanks, applied the fix, doesn't change things either.
I do have a clue now.
Looking at the smf_smileys database table, it starts with the smileys that have been defined on my old 2.0.15 board:
(https://i.postimg.cc/nc6WjQVb/smileys-sql-01.png)
...then at the end of that (formerly working) list, something new comes up...
(https://i.postimg.cc/43ZH3wrK/smileys-sql-02.png)

That new (non-working) part, and only that, is what I see in the "Edit Smileys" settings:
(https://i.postimg.cc/CKt7t3Zy/Edit-Smileys.png)

Seems to me like the Upgrade Process somehow messed up the smiley configuration.
Only question is: Which is the right way to get this fixed?

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 08:37:08 AM
For what it's worth, I've dropped both "smf_smileys" and "smf_smiley_files" tables and re-imported the smiley set from start, which restores both tables with apparently valid content, and it restores the smileys in the admin panel's smiley settings as well, however the result is still the same: No clickable smileys anywhere.

I'm lost again...

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: shawnb61 on February 12, 2019, 10:45:12 AM
Which sets do you have? 

What happens if you change the default set?
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 11:04:08 AM
I've tried the preinstalled "Default" set and the (also standard me thinks) "Akyhne" set.
Changing them shows absolutely no effect on posting, but I can see that the corresponding smileys have been imported correctly in the database.

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: shawnb61 on February 12, 2019, 12:55:47 PM
The 2.0 sets included the default directory (alienine, in .gifs), Aaron & Akyhne.

The 2.1 sets include fugue and alienine (in .pngs).  Those should have been copied over to the Smileys directory when you unpacked the install zip. 

A few more questions -

What are the permissions settings for your Smileys folders & files?

Do you see alienine & fugue in the dropdown when you use the New Smiley Set function under Smiley Sets?

Do you see alienine & fugue folders in your file system?

What do you see when you Inspect (right click, choose Inspect) the smileys bar in the editor?   (Should look something like the attached...)
Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 01:53:53 PM
The 2.0 sets included the default directory (alienine, in .gifs), Aaron & Akyhne.

The 2.1 sets include fugue and alienine (in .pngs).  Those should have been copied over to the Smileys directory when you unpacked the install zip.
Okay, that's understood.
Yes, the new 2.1 sets are there (in .pngs), I've selected "fugue" now so we're all on the same page and have set this to be the only (and therefore default) smiley set there is.

What are the permissions settings for your Smileys folders & files?
This particular system is a Windows Server 2016 (IIS) and in order to make sure that this cannot be an issue, I've added full permission to "everyone" to the whole SMF 2.1 folder and subfolders for the time being.
I've tried on another Windows Machine with XAMPP locally and get the very same issue.

Do you see alienine & fugue in the dropdown when you use the New Smiley Set function under Smiley Sets?

Do you see alienine & fugue folders in your file system?
Yes to both, seen and selected.

What do you see when you Inspect (right click, choose Inspect) the smileys bar in the editor?   (Should look something like the attached...)
There's the issue: I don't have no smileys bar in the editor.
My editor looks like this:
(https://i.postimg.cc/R0MmPPy2/Post-reply.png)

The only place where I can see the smileys bar is in the admin settings:
(https://i.postimg.cc/FKB97yCq/Smileys-and-Message-Icons.png)

I can inspect that bar and it looks fine to me:
(https://i.postimg.cc/gkZ6dJjm/smiley-admin.png)

The problem is that I cannot for my life get that bar to show in the editor...

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: shawnb61 on February 12, 2019, 02:05:19 PM
I think we may need to eliminate the possibility the Shoutbox is the problem... 

Could you try de-installing Shoutbox?



Title: Re: Smileys missing completely
Post by: Storebror on February 12, 2019, 02:47:38 PM
Did so before already, no change.

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: SychO on February 12, 2019, 03:09:14 PM
So you can't even see the smileys when creating a new topic ?
Title: Re: Smileys missing completely
Post by: Shambles on February 12, 2019, 04:14:35 PM
I'd be inspecting the browser tool's "console" for JS errors.
Title: Re: Smileys missing completely
Post by: Storebror on February 13, 2019, 12:44:20 AM
Okay, we're a tad further.
Today I have started from scratch again, with the full backup of my SMF 2.0.15 forum, then uninstalled all mods, made sure that the log was (and stayed) error-free and then performed the upgrade again.
Smileys were there.
Then I installed the shoutbox mod.
Smileys were gone.
Then I uninstalled the shoutbox mod.
Smileys were there, but I got errors about missing hooks.
Removed the hooks, smileys were there, errors gone.
Installed shoutbox, smileys were gone.
Left the shoutbox installed but deactivated in settings: Smileys were there, no errors.
Activated shoutbox again: Smileys are gone.

And indeed there are JS errors, two of them.

First error:
Code: [Select]
Error parsing header X-XSS-Protection: 1, 1; mode=block: expected semicolon at character position 1. The default protections will be applied.
index.php?action=post;topic=60554.0;last_msg=666330:1
Clicking on the error link shows that it complains about the main source's doctype, this "error" cannot be taken serious apparently:
Code: [Select]
<!DOCTYPE html>
Second error:
Code: [Select]
colorpicker.js:78 Error parsing header X-XSS-Protection: 1, 1; mode=block: expected semicolon at character position 1. The default protections will be applied.
ColorPicker_ColorBox @ colorpicker.js:78
The complaint concerns this line of code:
Code: [Select]
document.write('<div>');and it complains about anything past the dot after "document".
This seems odd to me.
"document.write" should not be allowed anymore?

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: shawnb61 on February 13, 2019, 01:10:50 AM
It sounds like you need to check with the shoutbox folks for support. 

There was a rewrite of the smiley logic just before RC1 release.  They probably need to be made aware of the issues so they can adapt their logic. 
Title: Re: Smileys missing completely
Post by: Storebror on February 13, 2019, 03:12:52 AM
Thanks, did so already: https://www.smfpacks.com/b135/smileys-missing-shoutbox-1-4-smf-2-1-rc-1/4608/
Let's see what Nibogo can come up with.
Thanks for all your support guys, much appreciated!

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: Storebror on February 13, 2019, 03:30:25 AM
There was a rewrite of the smiley logic just before RC1 release.
Sorry for double post but is there any documentation or a specific commit where this rewrite of the smiley logic happened?
I've tried a quick search on this but couldn't come up with anything useful.

Cheers!
Mike
Title: Re: Smileys missing completely
Post by: shawnb61 on February 13, 2019, 01:58:02 PM
Here you go:
https://github.com/SimpleMachines/SMF2.1/pull/5342

I am going to mark this thread as solved - as it was a mod issue, not a 2.1 issue.   
Title: Re: Smileys missing completely
Post by: Hero2019 on February 13, 2019, 02:04:37 PM
Unfortunately I do not understand it. How can I fix that please?
Title: Re: Smileys missing completely
Post by: shawnb61 on February 13, 2019, 02:14:43 PM
Unfortunately I do not understand it. How can I fix that please?

This issue was caused by using the shoutbox mod.  The solution was to uninstall the mod until it is fixed for RC1. 

If this isn't the same as your problem, please open a new thread with the specifics for your issue!

Title: Re: Smileys missing completely
Post by: Storebror on February 14, 2019, 08:00:06 AM
I am going to mark this thread as solved - as it was a mod issue, not a 2.1 issue.
Thanks and agreed.

Cheers!
Mike