Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: piotao on April 18, 2019, 01:19:11 PM

Title: hardcoded 'Themes' path in Sources/Themes.php is wrong! [2.0.15]
Post by: piotao on April 18, 2019, 01:19:11 PM
Hey, I'd just notice everybody that when you change your default 'Themes' path to something different (which is allowed in Admin), then the forum will never allow you to write to this themes directory again, because of a bug. The 'Themes' path is hardcoded in Themes.php file:

just look for '/Themes' string with grep and you'll find that there should be something different.
So, if I change this by hand to my custom path, it will be overwritten during update, right? Meh!
Title: Re: hardcoded 'Themes' path in Sources/Themes.php is wrong! [2.0.15]
Post by: Arantor on April 18, 2019, 01:21:44 PM
Yes, it's hardcoded. I cannot imagine a single situation you'd *want* to put it anywhere else.

Yes, it will be overwritten if you upgrade to SMF 2.1. It will not be overwritten if you upgrade to SMF 2.0.16 or beyond using the package manager.

Such changes are officially considered unsupported and if you discover other bugs as a result of an unnecessary change, there will not be a lot of help on offer.