Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Aiheen aloitti: jim3cantos - tammikuu 06, 2020, 05:36:03 AP

Otsikko: warnings in ./Sources/Subs.php when testing SMF 2.0.16 update
Kirjoitti: jim3cantos - tammikuu 06, 2020, 05:36:03 AP
Hello,

I'm getting two warnings in subs.php when executing 2.0.16 update test. The strange thing is that I have also compared with vanilla 2.0.15 version of the file and both are identical. I have searched this forum too for these warnings, but I coudn't find something similar.

thanks.
Otsikko: Re: warnings in ./Sources/Subs.php when testing SMF 2.0.16 update
Kirjoitti: jim3cantos - tammikuu 06, 2020, 06:46:48 AP
ok. I dindn't choose the correct versions of Subs.php when comparing. There are indeed differences in the files. Should I simply add the attribute: rel="noopener noreferrer" by hand in both places after upgrading?
Otsikko: Re: warnings in ./Sources/Subs.php when testing SMF 2.0.16 update
Kirjoitti: Kindred - tammikuu 06, 2020, 09:27:14 AP
yes....   that's what you do when a mod package fails in a specific section of code. :)

https://wiki.simplemachines.org/smf/Error_in_mod_installation
Otsikko: Re: warnings in ./Sources/Subs.php when testing SMF 2.0.16 update
Kirjoitti: jim3cantos - tammikuu 08, 2020, 12:14:12 IP
How could I identify which mod is responsible for the differences? I'm checking diff results and there are no comments in this part of the file indicating which Mod "did" the changes. I'd prefer to do a "clean" install if possible.
Otsikko: Re: warnings in ./Sources/Subs.php when testing SMF 2.0.16 update
Kirjoitti: jim3cantos - tammikuu 08, 2020, 12:28:10 IP
Ok. I think I found the culprit: Show Local Url Titles (https://custom.simplemachines.org/mods/index.php?action=parse) and indeed it doesn't seem to work anymore. Uninstalling it will revert the changes in Subs.php or should I have to do them manually?

thanks.
Otsikko: Re: warnings in ./Sources/Subs.php when testing SMF 2.0.16 update
Kirjoitti: Illori - tammikuu 08, 2020, 12:28:39 IP
https://wiki.simplemachines.org/smf/How_to_upload_a_fresh_set_of_files
Otsikko: Re: warnings in ./Sources/Subs.php when testing SMF 2.0.16 update
Kirjoitti: jim3cantos - tammikuu 14, 2020, 05:57:40 AP
Upgraded our forum without problems last Saturday. At the end I uninstalled Show Local Url Titles Mod before upgrading. Tapatalk Mod upgrade was a bit trickier but also successful. Thanks for your support.