Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: skb on October 17, 2020, 11:31:18 PM

Title: 2.1 RC3 Recycle Bin
Post by: skb on October 17, 2020, 11:31:18 PM
Since RC2 I've noticed the Recycle Bin shows '0' posts and topics. If I click the Recycle Bin link it leads me to an empty Board, but if I click on the post, it does take me to the Post.
Title: Re: 2.1 RC3 Recycle Bin
Post by: Massl on October 18, 2020, 04:44:20 PM
I can't reproduce your issue, recycle Bin shows the correct data on RC2 and RC3.
Title: Re: 2.1 RC3 Recycle Bin
Post by: Arantor on October 18, 2020, 05:19:40 PM
Are the posts pending moderationif you go look at them?
Title: Re: 2.1 RC3 Recycle Bin
Post by: skb on October 18, 2020, 11:26:20 PM
Quote from: Arantor on October 18, 2020, 05:19:40 PM
Are the posts pending moderationif you go look at them?

No. Most of them have been moderated and disapproved therefore they are in the Recycle Bin.
Title: Re: 2.1 RC3 Recycle Bin
Post by: Arantor on October 19, 2020, 03:33:03 AM
Did you unapprove them along the way? Unapproved posts don't count towards stats.
Title: Re: 2.1 RC3 Recycle Bin
Post by: skb on October 19, 2020, 05:11:39 AM
Yes, like I said, they were disapproved. I'll check with both options again and revert.
Title: Re: 2.1 RC3 Recycle Bin
Post by: Arantor on October 19, 2020, 06:26:53 AM
Sorry that wasn't entirely clear to me, but yes, if they are not approved they do not count towards the board count, not even for recycle bin (and it should always have been this way)
Title: Re: 2.1 RC3 Recycle Bin
Post by: skb on October 19, 2020, 01:46:33 PM
What you say makes sense. So I made a legit Test post, then deleted it so that it went to Recycle Bin.
It was visible for some time along with the other disapproved posts. Once I Moved the Disapproved posts to another board called Trash, the legit post is there but still the Board shows as '0'.

Hope I'm making sense.
Title: Re: 2.1 RC3 Recycle Bin
Post by: Arantor on October 19, 2020, 01:58:02 PM
Is the board set to count posts?
Title: Re: 2.1 RC3 Recycle Bin
Post by: skb on October 19, 2020, 02:04:17 PM
No. It doesn't count posts. That is why Board Trash was created. At some point of time we move posts from Recycle Bin to Trash so that they get counted.
Title: Re: 2.1 RC3 Recycle Bin
Post by: Arantor on October 19, 2020, 02:13:49 PM
I'm trying to remember exactly how 2.0 handles this but I have a feeling it's much the same way. But I'm not sure and I don't have a 2.0 handy right now to test.
Title: Re: 2.1 RC3 Recycle Bin
Post by: skb on October 19, 2020, 02:23:44 PM
I've been regularly using the Recycle Bin with 2.0 and 2.1. Posts therein, though not counted in the total forum posts, the Board Index did display the number of Topics and Posts.