Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: viking9 on August 27, 2021, 02:54:37 PM

Title: A new member is not required to accept the registration agreement!?
Post by: viking9 on August 27, 2021, 02:54:37 PM
When I, as Admin, register a new member I enter their username and E-mail. I have also checked "Require user to accept the registration agreement:".

The new member then gets an E-mail with his username and password and can log in immediately.

However, the the new member never needs to accept the registration agreement. Is this a bug?

How can I require a new member to accept the registration agreement?

Title: Re: A new member is not required to accept the registration agreement!?
Post by: @rjen on August 27, 2021, 03:33:43 PM
The same happens on my forum, so you right. If it's a bug or by design I do not know...
Title: Re: A new member is not required to accept the registration agreement!?
Post by: viking9 on August 27, 2021, 03:39:52 PM
When I, as Admin, register a new member I enter their username and E-mail. I have also checked "Require user to accept the registration agreement:".

The new member then gets an E-mail with his username and password and can log in immediately.

However, the new member never needs to accept the registration agreement. Is this a bug?

I am using SMF 2.0.18
This is what it looks like:
(https://i.gyazo.com/95e9172170771097b946a385a6a848b5.png)
Title: Re: A new member is not required to accept the registration agreement!?
Post by: @rjen on August 27, 2021, 03:45:12 PM
I think that will be considered as 'double-posting'....
Title: Re: A new member is not required to accept the registration agreement!?
Post by: Steve on August 27, 2021, 04:07:00 PM
Quote from: @rjen on August 27, 2021, 03:45:12 PMI think that will be considered as 'double-posting'....

It's fine, I just merged the two topics.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: viking9 on August 27, 2021, 05:32:23 PM
We had planned to register members and open the Forum this weekend. However, we definitely need them to agree to the registration agreement first.

I there maybe some quick fix we can do while this presumed bug is fixed?
Title: Re: A new member is not required to accept the registration agreement!?
Post by: Aleksi "Lex" Kilpinen on August 28, 2021, 09:02:53 AM
This is by design (at least originally). The registration agreement is required for registering,
if you register someone on their behalf you have already bypassed the point of agreement to register.
At the point where they receive the email, the registration is done and over with.

The question I would have, is why is there an option to require it in the first place when the registration is already done.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: lurkalot on August 28, 2021, 09:53:02 AM
If you edit the stock registration agreement and save. Then after that anyone who you register as admin will have to agree to the agreement before they proceed.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: Illori on August 28, 2021, 12:23:45 PM
Quote from: lurkalot on August 28, 2021, 09:53:02 AMIf you edit the stock registration agreement and save. Then after that anyone who you register as admin will have to agree to the agreement before they proceed.

that is not how it works in SMF 2.0 unless you have a mod installed that gives this feature.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: lurkalot on August 28, 2021, 12:31:16 PM
Quote from: Illori on August 28, 2021, 12:23:45 PM
Quote from: lurkalot on August 28, 2021, 09:53:02 AMIf you edit the stock registration agreement and save. Then after that anyone who you register as admin will have to agree to the agreement before they proceed.

that is not how it works in SMF 2.0 unless you have a mod installed that gives this feature.

I have no mods, I was trying it on a fresh install on my local.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: Aleksi "Lex" Kilpinen on August 28, 2021, 12:38:23 PM
I'm guessing these options were part of the 2.0 GDPR update, and so they do make some sense - just this particular option in this context makes no sense GDPR-wise to me. The registration agreement was originally, and really should still be, an optionally required agreement that needs to be given (if required) before the actual registration is done.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: viking9 on August 28, 2021, 04:04:49 PM
Quote from: Aleksi "Lex" Kilpinen on August 28, 2021, 09:02:53 AMThis is by design (at least originally). The registration agreement is required for registering,
if you register someone on their behalf you have already bypassed the point of agreement to register.
At the point where they receive the email, the registration is done and over with.

The question I would have, is why is there an option to require it in the first place when the registration is already done.
We have turned of registration since we have a private forum. The new users need to send us an E-mail asking to be registered. Thus, the only way to have them agree to the agreement is when they log in to the forum for the first time.
I thought that checking the option would accomplish this.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: viking9 on August 28, 2021, 04:08:42 PM
Quote from: lurkalot on August 28, 2021, 09:53:02 AMIf you edit the stock registration agreement and save. Then after that anyone who you register as admin will have to agree to the agreement before they proceed.
Perfect! This workaround solves the problem.
However, I would consider this a bug unless it is documented that a new user agreement needs to be created before the check box ("Require user to accept the registration agreement:") will work.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: Kindred on August 28, 2021, 04:56:13 PM
It's not a bug.  It's FAD.
The reg agreement is asked on registration... but the admin is doing the registration in your case.

Your situation is unusual and is not the way that 99.99% of tgexrest of the forum world does things
Title: Re: A new member is not required to accept the registration agreement!?
Post by: viking9 on August 28, 2021, 05:14:48 PM
Quote from: Kindred on August 28, 2021, 04:56:13 PMIt's not a bug.  It's FAD.
The reg agreement is asked on registration... but the admin is doing the registration in your case.

Your situation is unusual and is not the way that 99.99% of tgexrest of the forum world does things
Sorry, but what is "FAD"?
Why is there an option to check "Require user to accept the registration agreement:" when Admin registers a new member? It doesn't seem to work.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: Aleksi "Lex" Kilpinen on August 28, 2021, 05:17:34 PM
Quote from: Kindred on August 28, 2021, 04:56:13 PMIt's not a bug.  It's FAD.
The reg agreement is asked on registration... but the admin is doing the registration in your case.
In a way, it is a bug if we have that checkbox available there and it does nothing.
But yes, this is how admin registrations were originally deviced so the fix IMO would be to remove that option.

Quote from: viking9 on August 28, 2021, 05:14:48 PM
Quote from: Kindred on August 28, 2021, 04:56:13 PMIt's not a bug.  It's FAD.
The reg agreement is asked on registration... but the admin is doing the registration in your case.

Your situation is unusual and is not the way that 99.99% of tgexrest of the forum world does things
Sorry, but what is "FAD"?
Why is there an option to check "Require user to accept the registration agreement:" when Admin registers a new member? It doesn't seem to work.
FAD = Functioning As Designed.
Title: Re: A new member is not required to accept the registration agreement!?
Post by: lurkalot on August 28, 2021, 05:52:18 PM
Quote from: Aleksi "Lex" Kilpinen on August 28, 2021, 05:17:34 PMIn a way, it is a bug if we have that checkbox available there and it does nothing


It looks like a duplicate setting to me, the exact same setting is on the registration settings page.  The one on the settings page seems to override the the other one and acts like a master.

But yes it appears to work as it should.  If you as admin are registering someone, then you are essentially accepting the agreement on their behalf.

While someone else registering would have to accept the agreement before they register.   
 
Title: Re: A new member is not required to accept the registration agreement!?
Post by: Steve on August 30, 2021, 08:03:22 AM
@ viking: I split off your last post and moved it here:

Feature Requests (https://www.simplemachines.org/community/index.php?board=3.0)