Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: Diego Andrés on February 19, 2022, 11:18:08 PM

Title: Tasks Manager
Post by: Diego Andrés on February 19, 2022, 11:18:08 PM
Link to the mod (https://custom.simplemachines.org/index.php?mod=4307)

(https://smftricks.com/logos/logo.png) (https://smftricks.com/)

(https://img.shields.io/badge/License-MIT-248049) (https://img.shields.io/badge/Hooks%20Only-Yes-6041a3) (https://img.shields.io/badge/SMF-2.1-3f73a0)

Tasks Manager
Developed by Diego Andrés (https://smftricks.com/index.php?action=profile;u=1)
Designed by Database Dreams (https://www.databasedreams.co.uk/)




Introduction
Tasks Manager lets you configure projects along with assigning individual or multiple tasks to each project. You can create categories and statuses for both projects and categories and filter through them.

Features

Localization
(https://www.simplemachines.org/site_images/lang/english.gif) English
(https://www.simplemachines.org/site_images/lang/russian.gif) Russian by Bugo (https://www.simplemachines.org/community/index.php?action=profile;u=229017)
(https://www.simplemachines.org/site_images/lang/turkish.gif) Turkish by gevv (https://www.simplemachines.org/community/index.php?action=profile;u=155076)


Changelog (https://github.com/SMFTricks/Tasks-Manager/blob/main/CHANGELOG.md)
GitHub (https://github.com/SMFTricks/Tasks-Manager)
Title: Re: Tasks Manager
Post by: mickjav on February 20, 2022, 02:36:57 PM
Found A Couple of Things


2022-02-19.png
Title: Re: Tasks Manager
Post by: Diego Andrés on February 21, 2022, 07:28:19 PM
1.0.1 - 21 February 2022
- (https://smftricks.com/assets/changelog/tag--pencil.png) Remove auto-complete from date inputs.
- (https://smftricks.com/assets/changelog/tag--pencil.png) Return to filter when editing tasks.
- (https://smftricks.com/assets/changelog/tag--pencil.png) Improved filter language.
- (https://smftricks.com/assets/changelog/tag--pencil.png) Allow to use the same date for projects and tasks.
Title: Re: Tasks Manager
Post by: mickjav on February 21, 2022, 07:45:04 PM
Thanks I'll update tomorrow.

If anybodies interested in seeing a working version check it out here
Task manager (https://www.databasedreams.co.uk/support/index.php?action=tasksmanager)
Title: Re: Tasks Manager
Post by: mickjav on February 22, 2022, 01:22:29 AM
Hi The "Return to filter when editing tasks" Returns me to the home page Instead of the tasks List.

I've also updated the Test forum

all the best mick
Title: Re: Tasks Manager
Post by: mickjav on February 22, 2022, 01:28:40 AM
I've also edited the database as below

description varchar(500) Found when adding some descriptions 255 was not enough
additional_details varchar(1000) When Adding Additional Resources: Links It cut them short.

regards mick
Title: Re: Tasks Manager
Post by: Diego Andrés on February 22, 2022, 12:33:54 PM
Fixed

1.0.2 - 22 February 2022
- (https://smftricks.com/assets/changelog/tag--pencil.png) Increased width of tasks and projects name/title.
- (https://smftricks.com/assets/changelog/bug--minus.png) Fixed occasional missing language string.
- (https://smftricks.com/assets/changelog/bug--minus.png) Fixed redirect link after editing a task.

I'll work on v1.1 at some point so any suggestions or feedback I'll just add it to that
Title: Re: Tasks Manager
Post by: mickjav on February 22, 2022, 02:35:28 PM
Looking Good ;D
Title: Re: Tasks Manager
Post by: Doug Heffernan on February 22, 2022, 06:04:12 PM
Great work @Diego Andrés.
Title: Re: Tasks Manager
Post by: mickjav on February 23, 2022, 02:28:48 PM
Made A Few Edits  ;D I'm still new to PHP/MYSQL So hope what I've done Isn't too bad lol

Not sure if this is right place To post this

Task Manager (https://www.databasedreams.co.uk/support/index.php?action=tasksmanager;area=projects)


Find In Themes/default/languages/TasksManager/.english.php

$txt['TasksManager_projects_view_tasks'] = 'View tasks';
Add Below:
$txt['TasksManager_projects_Total_tasks'] = 'Tasks';
Create Link Of Project Name

Find In Sources/TasksManager/Projects.php
'function' => function($row)
{
$title = '<h6>' . $row['project_title'] . '</h6>';

Replace With
'function' => function($row) use ($txt, $scripturl)
{
$dlink ='<a href="' . $scripturl . '?action=tasksmanager;area=tasks;sa=index;project=' . $row['project_id'] . '">' . $row['project_title'] . '</a>';
$title = '<h6>' . $dlink . '</h6>';

Get count of Tasks For each project
Find Around Line 619
SELECT
p.project_id, p.project_title, p.project_picture, p.view_type,
p.category_id, p.start_date, p.end_date, p.description, p.additional_details,
p.type_id, p.status_id, c.category_name, t.type_name, s.status_name
FROM {db_prefix}taskspp_projects AS p
LEFT JOIN {db_prefix}taskspp_project_categories AS c ON (c.category_id = p.category_id)
LEFT JOIN {db_prefix}taskspp_project_types AS t ON (t.type_id = p.type_id)
LEFT JOIN {db_prefix}taskspp_project_status AS s ON (s.status_id = p.status_id) ' . (!empty($query) ?
$query : '') . '
ORDER BY {raw:sort}
LIMIT {int:start}, {int:limit}',

Replace with
SELECT
p.project_id, p.project_title, p.project_picture, p.view_type,
p.category_id, p.start_date, p.end_date, p.description, p.additional_details,
p.type_id, p.status_id, c.category_name, t.type_name, s.status_name, Count(d.task_id) As tasks
FROM {db_prefix}taskspp_projects AS p
LEFT JOIN {db_prefix}taskspp_tasks AS d ON (d.project_id = p.project_id)
LEFT JOIN {db_prefix}taskspp_project_categories AS c ON (c.category_id = p.category_id)
LEFT JOIN {db_prefix}taskspp_project_types AS t ON (t.type_id = p.type_id)
LEFT JOIN {db_prefix}taskspp_project_status AS s ON (s.status_id = p.status_id) ' . (!empty($query) ?
$query : '') . '
GROUP BY p.project_id
ORDER BY {raw:sort}
LIMIT {int:start}, {int:limit}',

Update The Status Column
Find
// Tasks Link
$status .= '<br /><a href="' . $scripturl . '?action=tasksmanager;area=tasks;sa=index;project=' . $row['project_id'] . '">' . $txt['TasksManager_projects_view_tasks'] . '</a>';

Replace With

// Count Tasks
$status .= '<br /><strong>'. $txt['TasksManager_projects_Total_tasks'] . ':</strong> '  . $row['tasks'];




Title: Re: Tasks Manager
Post by: mickjav on February 25, 2022, 12:00:02 PM
Made Another Update Thanks to @Arantor for his help solving the last issue and as Always @Diego Andrés for his magic i was able to use.

As Always View The Results Here (https://www.databasedreams.co.uk/support/index.php?action=tasksmanager;area=projects)

NOTE THIS ASSUMES YOU HAVE USED MY LAST UPDATE?

Find In Themes/default/languages/TasksManager/.english.php

$txt['TasksManager_projects_Total_tasks'] = 'Tasks';
Replace with
$txt['TasksManager_projects_Total_tasks'] = 'Total Tasks';
Find In Sources/TasksManager/Projects.php

$status .= '<br /><strong>'. $txt['TasksManager_projects_Total_tasks'] . ':</strong> '  . $row['tasks'];
Add Below:
// Minutes
$minutes = (!empty($row['minutes_worked']) ? ($row['minutes_worked'] % 60) : 0);

// Actual hours
$hours = $row['hours_worked'] + floor($row['minutes_worked'] / 60);

$status .= '<br /><strong>'. $txt['TasksManager_tasks_time_booked'] . ':</strong> ' . (!empty($hours) || !empty($minutes) ? sprintf('%02d', $hours). ':' . sprintf('%02d', $minutes) : $txt['TasksManager_no_total_time']);

Find Around Line 628
SELECT
p.project_id, p.project_title, p.project_picture, p.view_type,
p.category_id, p.start_date, p.end_date, p.description, p.additional_details,
p.type_id, p.status_id, c.category_name, t.type_name, s.status_name, Count(d.task_id) As tasks
FROM {db_prefix}taskspp_projects AS p
LEFT JOIN {db_prefix}taskspp_tasks AS d ON (d.project_id = p.project_id)
LEFT JOIN {db_prefix}taskspp_project_categories AS c ON (c.category_id = p.category_id)
LEFT JOIN {db_prefix}taskspp_project_types AS t ON (t.type_id = p.type_id)
LEFT JOIN {db_prefix}taskspp_project_status AS s ON (s.status_id = p.status_id) ' . (!empty($query) ?

Replace With
SELECT
p.project_id, p.project_title, p.project_picture, p.view_type,
p.category_id, p.start_date, p.end_date, p.description, p.additional_details,
p.type_id, p.status_id, c.category_name, t.type_name, s.status_name, COUNT(DISTINCT d.task_id) As tasks,
SUM(ts.hours_worked) AS hours_worked, SUM(ts.minutes_worked) AS minutes_worked
FROM {db_prefix}taskspp_projects AS p
LEFT JOIN {db_prefix}taskspp_tasks AS d ON (d.project_id = p.project_id)
LEFT JOIN {db_prefix}taskspp_timesheet AS ts ON (ts.task_id = d.task_id)
LEFT JOIN {db_prefix}taskspp_project_categories AS c ON (c.category_id = p.category_id)
LEFT JOIN {db_prefix}taskspp_project_types AS t ON (t.type_id = p.type_id)
LEFT JOIN {db_prefix}taskspp_project_status AS s ON (s.status_id = p.status_id) ' . (!empty($query) ?





Title: Re: Tasks Manager
Post by: mickjav on February 26, 2022, 03:16:35 AM
I'm not able to do it myself as looked at it and really not sure enough on what I would be doing to tackle it  ;D

I would like to Move the Modify And Delete columns into One Column this would give a little bit more real estate for Admins.

Hopefully it will make it into a edit for the next version  8)

https://www.databasedreams.co.uk/support/index.php?action=tasksmanager

mick
Title: Re: Tasks Manager
Post by: Diego Andrés on March 03, 2022, 04:49:37 PM
1.1 - 03 March 2022
(https://camo.githubusercontent.com/33b5ae016b1a4c742049dc443886d242b5129207264c7d76586052d316646876/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f6c616e67756167652e706e67) Russian translation provided by Bugo
(https://camo.githubusercontent.com/dabbb7cab40c66b82cb563365d644a1f098f665bf28cef0616f69a1a0f25084e/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f7461672d2d706c75732e706e67) Added 'Who" action integration.
(https://camo.githubusercontent.com/2b4ab97b0305c84fe3d563f95de3f5eaa7019a88172cd590e0d0ffbb681f2cf1/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f7461672d2d70656e63696c2e706e67) Merged delete and modify columns.
(https://camo.githubusercontent.com/2b4ab97b0305c84fe3d563f95de3f5eaa7019a88172cd590e0d0ffbb681f2cf1/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f7461672d2d70656e63696c2e706e67) It now uses the topics table to assign tasks.
(https://camo.githubusercontent.com/dabbb7cab40c66b82cb563365d644a1f098f665bf28cef0616f69a1a0f25084e/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f7461672d2d706c75732e706e67) Added total tasks counter to projects.
(https://camo.githubusercontent.com/dabbb7cab40c66b82cb563365d644a1f098f665bf28cef0616f69a1a0f25084e/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f7461672d2d706c75732e706e67) Added total time booked from tasks to projects.
(https://camo.githubusercontent.com/5ba14cc5b307fd7683ab0b95737b5548d492d0029f2ce6f42c7cda8cc1c90fb9/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f6275672d2d6d696e75732e706e67) Fixes issues with some queries.
(https://camo.githubusercontent.com/2b4ab97b0305c84fe3d563f95de3f5eaa7019a88172cd590e0d0ffbb681f2cf1/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f7461672d2d70656e63696c2e706e67) Code cleanup.
Title: Re: Tasks Manager
Post by: mickjav on March 06, 2022, 08:05:07 AM
Have Updated Which looks good But have found that It seems to remove all Topic links from Tasks but have checked the table and they are still there??

All The Best mick

Chart Tracker Elite Tasks (https://www.databasedreams.co.uk/support/index.php?action=tasksmanager;area=tasks;sa=index;project=3)
Title: Re: Tasks Manager
Post by: mickjav on March 06, 2022, 08:50:10 AM
Just noticed The Book Time: Tasks Lists Seems To Use "Amount of items to show in the filters" But This will cause problems, I had to adjust "Amount of items to show in the filters" So I could select what I needed??

Can you do the list like, I expect to have hundreds of tasks for different projects some of which I may have to revisit from time to time

Project 1
--Task 1
--Task 2
Project 2
-- Task 1
-- Task 2

act

mick
Title: Re: Tasks Manager
Post by: Diego Andrés on March 06, 2022, 11:06:49 AM
Quote from: mickjav on March 06, 2022, 08:05:07 AMHave Updated Which looks good But have found that It seems to remove all Topic links from Tasks but have checked the table and they are still there??

All The Best mick


It now uses the topics table to remove the extra query in the topic page.
The topic column has been removed from tasks.
Title: Re: Tasks Manager
Post by: Diego Andrés on March 06, 2022, 11:13:55 AM
Quote from: mickjav on March 06, 2022, 08:50:10 AMJust noticed The Book Time: Tasks Lists Seems To Use "Amount of items to show in the filters" But This will cause problems, I had to adjust "Amount of items to show in the filters" So I could select what I needed??

You mean you want to be displaying the whole list A-Z when adding a new entry?
Title: Re: Tasks Manager
Post by: mickjav on March 06, 2022, 11:25:36 AM
If you have left the default 20 Entries And are filtering by Name Then if you have say 35 Tasks in your tasks table it may only show those tasks that start with the letters A-S and if you want to add time for a task that begins with T you can't as it wont be in the list
Title: Re: Tasks Manager
Post by: mickjav on March 06, 2022, 11:39:18 AM
Sorry just trying to understand You said you Had to Run A Query I prusume to check that the topic existed?

which You changed for this LEFT JOIN {db_prefix}topics AS t ON (t.tasks_task_id = tk.task_id)


That's still going to cause the system to work hard to build that query but Less than before I.E this site has 480k topics.

Why not Update the Topic Delete function so it checks for a linked topic in the tasks table that would remove the overhead completely?

As I said just trying to understand :)
Title: Re: Tasks Manager
Post by: tmachu on March 07, 2022, 08:55:25 AM
Really useful and nice mod, I will definitely use it, thanks Diego Andrés.
Title: Re: Tasks Manager
Post by: Diego Andrés on March 07, 2022, 12:22:15 PM
Quote from: mickjav on March 06, 2022, 11:25:36 AMIf you have left the default 20 Entries And are filtering by Name Then if you have say 35 Tasks in your tasks table it may only show those tasks that start with the letters A-S and if you want to add time for a task that begins with T you can't as it wont be in the list

Do you want to remove the limit from the booking page for both the filter and the booking action?
Title: Re: Tasks Manager
Post by: mickjav on March 07, 2022, 12:29:51 PM
Quote from: Diego Andrés on March 07, 2022, 12:22:15 PM
Quote from: mickjav on March 06, 2022, 11:25:36 AMIf you have left the default 20 Entries And are filtering by Name Then if you have say 35 Tasks in your tasks table it may only show those tasks that start with the letters A-S and if you want to add time for a task that begins with T you can't as it wont be in the list

Do you want to remove the limit from the booking page for both the filter and the booking action?

I think it would be better for the program to sort something else out as over time that list may end up with hundreds of items.

As I pointed out something that Gallery pro uses which works well even with 600 records as below.

Project One
--Task One
--Task two
Project two
--Task one

And So One
Title: Re: Tasks Manager
Post by: Shades. on March 17, 2022, 10:01:52 PM
SMF 2.1.1
Tasks Manager v1.1

@Diego Andrés I'm having a bad day I guess, sorry! O:)

Tried to install this on my theme demo site so I can keep up with all my tasks and theme edits but got this error:

QuoteKey column 'topic_id' doesn't exist in table
File: /home2/*****/public_html/*****/*****/Packages/temp/install.php
Line: 355

QuoteError
Type of error
Database
Error message
Database Error: Key column 'topic_id' doesn't exist in table
File
/home2/*****/public_html/*****/*****/Packages/temp/install.php
Line
355
URL of page causing the error
https://*****.*****.com/index.php?action=admin;area=packages;sa=install2;package=Tasks-Manager_v1.1.zip;pid=0

Backtrace information
#0: smf_db_error()
Called from /home2/*****/public_html/*****/*****/Sources/Subs-Db-mysql.php on line 494
#1: smf_db_query()
Called from /home2/*****/public_html/*****/*****/Sources/DbPackages-mysql.php on line 206
#2: smf_db_create_table()
Called from /home2/*****/public_html/*****/*****/Packages/temp/install.php on line 355
#3: require()
Called from /home2/*****/public_html/*****/*****/Sources/Packages.php on line 1064
#4: PackageInstall()
Called from /home2/*****/public_html/*****/*****/Sources/Subs.php on line 6001
#5: call_helper()
Called from /home2/*****/public_html/*****/*****/Sources/Packages.php on line 91
#6: Packages()
Called from /home2/*****/public_html/*****/*****/Sources/Admin.php on line 499
#7: AdminMain()
Called from /home2/*****/public_html/*****/*****/index.php on line 187
Title: Re: Tasks Manager
Post by: Diego Andrés on March 17, 2022, 11:19:29 PM
It's a bug, sort of. I forgot to remove that index from the tasks table.
Will update it in later  :P
Title: Re: Tasks Manager
Post by: Diego Andrés on March 18, 2022, 12:03:28 AM
1.1.1 - 17 March 2022


Quote from: mickjav on March 06, 2022, 11:25:36 AMIf you have left the default 20 Entries And are filtering by Name Then if you have say 35 Tasks in your tasks table it may only show those tasks that start with the letters A-S and if you want to add time for a task that begins with T you can't as it wont be in the list
Will have a look at this next week, if you have any suggestion let me know.
Title: Re: Tasks Manager
Post by: mickjav on March 18, 2022, 02:20:02 AM
Quote from: Diego Andrés on March 18, 2022, 12:03:28 AM1.1.1 - 17 March 2022
  • (https://camo.githubusercontent.com/5ba14cc5b307fd7683ab0b95737b5548d492d0029f2ce6f42c7cda8cc1c90fb9/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f6275672d2d6d696e75732e706e67) Fixed wrong index for tasks column in install file.


Quote from: mickjav on March 06, 2022, 11:25:36 AMIf you have left the default 20 Entries And are filtering by Name Then if you have say 35 Tasks in your tasks table it may only show those tasks that start with the letters A-S and if you want to add time for a task that begins with T you can't as it wont be in the list
Will have a look at this next week, if you have any suggestion let me know.

I do have a wishlist  ;D  ;D
https://www.databasedreams.co.uk/support/index.php?topic=90.0

I've also added a new ERD But need to update it for Task_ID Etc My main wish would be the time entry Comment and logging of Members_ID So we can have the option to team work.

All the best mick
Title: Re: Tasks Manager
Post by: mickjav on March 18, 2022, 02:31:49 AM
Quote from: mickjav on March 07, 2022, 12:29:51 PM
Quote from: Diego Andrés on March 07, 2022, 12:22:15 PM
Quote from: mickjav on March 06, 2022, 11:25:36 AMIf you have left the default 20 Entries And are filtering by Name Then if you have say 35 Tasks in your tasks table it may only show those tasks that start with the letters A-S and if you want to add time for a task that begins with T you can't as it wont be in the list

Do you want to remove the limit from the booking page for both the filter and the booking action?

I think it would be better for the program to sort something else out as over time that list may end up with hundreds of items.

As I pointed out something that Gallery pro uses which works well even with 600 records as below.

Project One
--Task One
--Task two
Project two
--Task one

And So One


This is the only suggestion I can add for the Problem with the Tasks list, Unless you limit the list to items not marked as completed but then you will need a way for the user to identify what Status They use for Completed tasks??

mick

P.S. The post above has a image attached
Title: Re: Tasks Manager
Post by: Shades. on March 18, 2022, 04:51:08 AM
Quote from: Diego Andrés on March 18, 2022, 12:03:28 AM1.1.1 - 17 March 2022
  • (https://camo.githubusercontent.com/5ba14cc5b307fd7683ab0b95737b5548d492d0029f2ce6f42c7cda8cc1c90fb9/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f6275672d2d6d696e75732e706e67) Fixed wrong index for tasks column in install file.


Quote from: mickjav on March 06, 2022, 11:25:36 AMIf you have left the default 20 Entries And are filtering by Name Then if you have say 35 Tasks in your tasks table it may only show those tasks that start with the letters A-S and if you want to add time for a task that begins with T you can't as it wont be in the list
Will have a look at this next week, if you have any suggestion let me know.

Just an fyi on the latest download Tasks Manager v1.1.1 for SMF 2.1.1...

Error on install fresh install SMF 2.1.1

Quote'*****_demo.p.project_title' isn't in GROUP BY
File: /home2/*****/public_html/*****/Sources/TasksManager/Projects.php
Line: 555

QuoteError
Type of error
Database
Error message
Database Error: '*****_demo.p.project_title' isn't in GROUP BY
File
/home2/*****/public_html/*****/Sources/TasksManager/Projects.php
Line
555
URL of page causing the error
https://*****.com/index.php?action=tasksmanager

Backtrace information
#0: smf_db_error()
Called from /home2/*****/public_html/*****/Sources/Subs-Db-mysql.php on line 494
#1: smf_db_query()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Projects.php on line 555
#2: getProjects()
Called from /home2/*****/public_html/*****/Sources/Subs-List.php on line 132
#3: createList()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Projects.php on line 265
#4: list()
Called from /home2/*****/public_html/*****/Sources/Subs.php on line 5998
#5: call_helper()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Projects.php on line 76
#6: main()
Called from /home2/*****/public_html/*****/Sources/Subs.php on line 5998
#7: call_helper()
Called from /home2/*****/public_html/*****/Sources/TasksManager/View.php on line 219
#8: main()
Called from /home2/*****/public_html/*****/index.php on line 187
Title: Re: Tasks Manager
Post by: mickjav on March 19, 2022, 10:17:42 AM
Tried to install Version 1.1.1 on my test Forum But have the install Index Error @Shades. has reported

I can see where in the install File the problem seems to be coming from but not sure how to correct it  :(

Also just noticed on my Support Site, This only seems to generate a error when viewing the Summery Page of a profile "See Image"
Title: Re: Tasks Manager
Post by: mickjav on March 19, 2022, 10:52:51 AM
I suspect removing the below from install.php will allow it to complete

NOTE this will only work if you have installed 1.01
// Add a tasks column for the topics
$smcFunc['db_add_column']('
{db_prefix}topics',
[
'name' => 'tasks_task_id',
'type' => 'mediumint',
'size' => 8,
'unsigned' => true,
'default' => 0,
'not_null' => false,
]
);

I Think it needs a check to see if the column exists

This worked on my Test forum
Title: Re: Tasks Manager
Post by: Diego Andrés on March 19, 2022, 11:58:11 AM
That'll break adding tasks to a topic.
The issue is from something else.
I'll have a look later.
Title: Re: Tasks Manager
Post by: mickjav on March 19, 2022, 12:23:19 PM
Quote from: Diego Andrés on March 19, 2022, 11:58:11 AMThat'll break adding tasks to a topic.
The issue is from something else.
I'll have a look later.

That's the code I had to REMOVE to enable It to complete the install:)

Haven't found why this is happening https://www.simplemachines.org/community/index.php?msg=4116852
Title: Re: Tasks Manager
Post by: Diego Andrés on March 19, 2022, 01:15:56 PM
1.1.2 - 19 March 2022
Title: Re: Tasks Manager
Post by: Shades. on March 19, 2022, 02:39:36 PM
Clean SMF 2.1.1
Task Manager 1.1.2

Getting this error after install and clicking on the "Task Manager" link:

Quote'*****.p.project_picture' isn't in GROUP BY
File: /home2/*****/public_html/*****/Sources/TasksManager/Projects.php
Line: 555

QuoteError
Type of error
Database
Error message
Database Error: '*****.p.project_picture' isn't in GROUP BY
File
/home2/*****/public_html/*****/Sources/TasksManager/Projects.php
Line
555
URL of page causing the error
https://*****.com/index.php?action=tasksmanager

Backtrace information
#0: smf_db_error()
Called from /home2/*****/public_html/*****/Sources/Subs-Db-mysql.php on line 494
#1: smf_db_query()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Projects.php on line 555
#2: getProjects()
Called from /home2/*****/public_html/*****/Sources/Subs-List.php on line 132
#3: createList()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Projects.php on line 265
#4: list()
Called from /home2/*****/public_html/*****/Sources/Subs.php on line 5998
#5: call_helper()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Projects.php on line 76
#6: main()
Called from /home2/*****/public_html/*****/Sources/Subs.php on line 5998
#7: call_helper()
Called from /home2/*****/public_html/*****/Sources/TasksManager/View.php on line 219
#8: main()
Called from /home2/*****/public_html/*****/index.php on line 187
Title: Re: Tasks Manager
Post by: Diego Andrés on March 19, 2022, 02:52:01 PM
Try with this file in Sources/TasksManager/

Projects.php
Title: Re: Tasks Manager
Post by: Shades. on March 19, 2022, 03:07:32 PM
Quote from: Diego Andrés on March 19, 2022, 02:52:01 PMTry with this file in Sources/TasksManager/

Projects.php
Yes that worked thanks! 8)
Title: Re: Tasks Manager
Post by: Shades. on March 19, 2022, 03:16:11 PM
Looks like Project categories and task categories are the same!?

If I add a new category to either one they both appear in Task categories but not in Project categories.
Title: Re: Tasks Manager
Post by: Diego Andrés on March 19, 2022, 03:39:08 PM
Ok both issues fixed.

Anything else mr mod tester  :laugh:
Before I upload
Title: Re: Tasks Manager
Post by: Shades. on March 19, 2022, 04:43:36 PM
Quote from: Diego Andrés on March 19, 2022, 03:39:08 PMOk both issues fixed.

Anything else mr mod tester  :laugh:
Before I upload
LOL! That's all I can see right now! O:)  :laugh:
Title: Re: Tasks Manager
Post by: Diego Andrés on March 19, 2022, 08:08:37 PM
1.1.3 - 19 March 2022
Title: Re: Tasks Manager
Post by: gevv on March 20, 2022, 04:51:51 AM
Hi,

Nice mod. Thanks @Diego Andrés

Turkish translation.
Title: Re: Tasks Manager
Post by: Shades. on March 20, 2022, 11:53:05 AM
SMF 2.1.1
Tasks Manager 1.1.3

Sorry @Diego Andrés! O:)

It won't let me delete Tasks categories! It pops up and asks "Are you sure you want to delete this category? This will make the relevant projects or tasks uncategorized."
tasks1.PNG

But then takes me to the edit screen and then a full circle back to the category list where the category I tried to delete is still there.
tasks2.jpeg
Title: Re: Tasks Manager
Post by: Diego Andrés on March 20, 2022, 01:33:45 PM
The url is wrong, will update package in a bit and will include Turkish translation.

Thanks
Title: Re: Tasks Manager
Post by: Diego Andrés on March 20, 2022, 06:05:11 PM
1.1.4 - 20 March 2022
Title: Re: Tasks Manager
Post by: Shades. on March 20, 2022, 08:03:11 PM
Quote from: Diego Andrés on March 20, 2022, 06:05:11 PM1.1.4 - 20 March 2022
  • (https://camo.githubusercontent.com/33b5ae016b1a4c742049dc443886d242b5129207264c7d76586052d316646876/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f6c616e67756167652e706e67) Turkish translation provided by @gevv
  • (https://camo.githubusercontent.com/5ba14cc5b307fd7683ab0b95737b5548d492d0029f2ce6f42c7cda8cc1c90fb9/68747470733a2f2f736d66747269636b732e636f6d2f6173736574732f6368616e67656c6f672f6275672d2d6d696e75732e706e67) Fixed wrong links when deleting categories.
Superb! Great mod @Diego Andrés! 8)
Title: Re: Tasks Manager
Post by: Shades. on March 20, 2022, 08:26:58 PM
Uh oh I ran into another error. O:)

When going to Booking>Time Log or Book Time I get this error:

Quote'mysite.tk.task_name' isn't in GROUP BY
File: /home2/*****/public_html/*****/Sources/TasksManager/Tasks.php
Line: 544

QuoteError
Type of error
Database
Error message
Database Error: 'mysite.tk.task_name' isn't in GROUP BY



SELECT

tk.task_id, tk.task_name, tk.task_cat_id, tk.project_id,

tk.start_date, tk.end_date, tk.task_desc, tk.task_status_id, tk.estimated_hrs,

c.category_name, s.status_name, p.project_title, SUM(ts.hours_worked) AS hours_worked, SUM(ts.minutes_worked) AS minutes_worked, t.id_topic

FROM swb4_taskspp_tasks AS tk

LEFT JOIN swb4_topics AS t ON (t.tasks_task_id = tk.task_id)

LEFT JOIN swb4_taskspp_timesheet AS ts ON (ts.task_id = tk.task_id)

LEFT JOIN swb4_taskspp_projects AS p ON (p.project_id = tk.project_id)

LEFT JOIN swb4_taskspp_task_categories AS c ON (c.task_cat_id = tk.task_cat_id)

LEFT JOIN swb4_taskspp_project_status AS s ON (s.status_id = tk.task_status_id)

GROUP BY tk.task_id, c.category_name, s.status_name, p.project_title, t.id_topic

ORDER BY tk.task_id DESC

LIMIT 0, 25
File
/home2/*****/public_html/*****/Sources/TasksManager/Tasks.php
Line
544
URL of page causing the error
https://*****.com/index.php?action=tasksmanager;area=booking;sa=log

Backtrace information
#0: smf_db_error()
Called from /home2/*****/public_html/*****/Sources/Subs-Db-mysql.php on line 494
#1: smf_db_query()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Tasks.php on line 544
#2: getTasks()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Book.php on line 59
#3: main()
Called from /home2/*****/public_html/*****/Sources/Subs.php on line 6057
#4: call_helper()
Called from /home2/*****/public_html/*****/Sources/TasksManager/View.php on line 219
#5: main()
Called from /home2/*****/public_html/*****/index.php on line 187

QuoteError
Type of error
Database
Error message
Database Error: 'mysite.tk.task_name' isn't in GROUP BY



SELECT

tk.task_id, tk.task_name, tk.task_cat_id, tk.project_id,

tk.start_date, tk.end_date, tk.task_desc, tk.task_status_id, tk.estimated_hrs,

c.category_name, s.status_name, p.project_title, SUM(ts.hours_worked) AS hours_worked, SUM(ts.minutes_worked) AS minutes_worked, t.id_topic

FROM swb4_taskspp_tasks AS tk

LEFT JOIN swb4_topics AS t ON (t.tasks_task_id = tk.task_id)

LEFT JOIN swb4_taskspp_timesheet AS ts ON (ts.task_id = tk.task_id)

LEFT JOIN swb4_taskspp_projects AS p ON (p.project_id = tk.project_id)

LEFT JOIN swb4_taskspp_task_categories AS c ON (c.task_cat_id = tk.task_cat_id)

LEFT JOIN swb4_taskspp_project_status AS s ON (s.status_id = tk.task_status_id)

GROUP BY tk.task_id, c.category_name, s.status_name, p.project_title, t.id_topic

ORDER BY tk.task_id DESC

LIMIT 0, 25
File
/home2/*****/public_html/*****/Sources/TasksManager/Tasks.php
Line
544
URL of page causing the error
https://*****.com/index.php?action=tasksmanager;area=booking;sa=booktime
Backtrace information
#0: smf_db_error()
Called from /home2/*****/public_html/*****/Sources/Subs-Db-mysql.php on line 494
#1: smf_db_query()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Tasks.php on line 544
#2: getTasks()
Called from /home2/*****/public_html/*****/Sources/TasksManager/Book.php on line 59
#3: main()
Called from /home2/*****/public_html/*****/Sources/Subs.php on line 6057
#4: call_helper()
Called from /home2/*****/public_html/*****/Sources/TasksManager/View.php on line 219
#5: main()
Called from /home2/*****/public_html/*****/index.php on line 187
Title: Re: Tasks Manager
Post by: shawnb61 on March 20, 2022, 09:10:38 PM
Mysql version? Or is it MariaDB?

Older mysql versions (and current mariadb) want a lot of unnecessary items in the group by.

The fix is typically to add all non-aggregate items in the select clause to the group by.
Title: Re: Tasks Manager
Post by: Shades. on March 20, 2022, 09:17:03 PM
Quote from: shawnb61 on March 20, 2022, 09:10:38 PMMysql version? Or is it MariaDB?

Older mysql versions (and current mariadb) want a lot of unnecessary items in the group by.

The fix is typically to add all non-aggregate items in the select clause to the group by.
MySQL 5.6 PHP 7.4

The mod works great like it is and I don't really need the Booking part myself I was just testing it out. But I guess sooner or later I'm gonna have to upgrade to another host with a bigger MySQL version!?
Title: Re: Tasks Manager
Post by: shawnb61 on March 20, 2022, 09:19:51 PM
Yep.  Mysql 5.7 doesn't behave that way, but 5.6 does.

Since SMF supports 5.6, I suspect the query needs to change. 
Title: Re: Tasks Manager
Post by: Diego Andrés on March 20, 2022, 09:22:21 PM
I'm just gonna dump all of the columns there in all of those before I need to go look for a rope instead of a query  :laugh:
Title: Re: Tasks Manager
Post by: shawnb61 on March 20, 2022, 09:40:45 PM
I just ran into this on some custom stuff used in my forum that I'm bringing forward into 2.1.  My host is still on 5.6...  (I may submit it as a mod - an attachment browser w/tags & filters to help peruse attachments.)
Title: Re: Tasks Manager
Post by: Diego Andrés on March 21, 2022, 03:16:16 AM
@Shades. test?

Tasks.php
Title: Re: Tasks Manager
Post by: Shades. on March 21, 2022, 01:56:08 PM
Quote from: Diego Andrés on March 21, 2022, 03:16:16 AM@Shades. test?

Tasks.php
Uploaded and getting:

QuoteUnknown column 'ttk.task_id' in 'field list'
File: /home2/*****/public_html/*****/Sources/TasksManager/Tasks.php
Line: 544

Title: Re: Tasks Manager
Post by: Diego Andrés on March 21, 2022, 02:32:07 PM
typo
Tasks.php
Title: Re: Tasks Manager
Post by: Shades. on March 21, 2022, 02:55:47 PM
Quote from: Diego Andrés on March 21, 2022, 02:32:07 PMtypo
Tasks.php
:laugh: Now getting:

QuoteUnknown column 'k.task_status_id' in 'field list'
File: /home2/shades75/public_html/shadesweb/Sources/TasksManager/Tasks.php
Line: 544
Title: Re: Tasks Manager
Post by: Diego Andrés on March 21, 2022, 03:01:55 PM
:D

Tasks.php
Title: Re: Tasks Manager
Post by: Shades. on March 21, 2022, 03:06:16 PM
Quote from: Diego Andrés on March 21, 2022, 03:01:55 PM:D

Tasks.php
Bingo!! ;D  :laugh:
Title: Re: Tasks Manager
Post by: Diego Andrés on March 21, 2022, 03:24:29 PM
Great!

1.1.5 - 21 March 2022