Forum version: SMF2.1.1.
PHP Version 7.4.29
Trying to use the new function to "Not Follow" a topic gives some strange results..
This is what happens:
I set a topic to "Not Following".
According to the text this should result in the Topic not showing up in my Unread items when new replies are posted...
2022-05-04_122200.jpg
But this seems not to work: when a new Reply is posted the topic is showing as unread regardless..
Funny side effect is that now it is not possible to mark it read anymore..
Reading it, and it still shows up as new in the unread topics.
In the message itself it does state that the message is read: If I thane change the topic back to "No Alerts or Emails" it disappears from the Unread items
It seems that the logic for Unread items is somehow not working correctly for topics that are marked to "Not Follow"
Is this just me, or is this a bug in SMF 2.1?
It's sort of the point but also a bit of a bug.
The idea is that if you are explicitly not watching, you don't want it to appear in unread etc. but I think this has moved slightly since it was originally implemented like 10 years ago.
Thing is that it DOES show up in unread when I try not to follow a topic
Then it's definitely not working as intended :(
It is working here, so it must be a local issue
Setup a vanilla install of SMF2.1.2 and that works fine.
My production forum is if course upgraded from 2.0.19 and it behaves differently: the topic that I set to not follow DOES show up in the recent topics, and I cannot mark it read as long as I leave it set on NOFOLLOW..
I did some digging in the code and in the tables, but I do not see any differences in the core files such as Recent.php and Recent.template.php, nor do I see differences in the database updates that explain this behaviour..
Anyony have any idea where to look further?
Hi everyone, I'm one of @rjen's minions (hehe). It's quite the annoying bug, and as one of the support guys I run into it as well, and more often than most users, I reckon. Has there this been verified already? Is it a borked setting? If not, it's definitely a bug, but we can't seem to find where it's coming from. Any hope of a centralized fix?
Is this still an issue?
Yep
rjen -- you confirmed that it works as expected on a clean installation --- so, it has to be due to some configuration, mod or customization -- yes?
Correct, but like I mentioned at the time: I cannot find the cause, so I am still hoping for some guidance where to look...
I personally am not suffering that much from the situation, but as it seems my 'Minions' do...
Quote from: @rjen on May 12, 2022, 11:59:38 AMSetup a vanilla install of SMF2.1.2 and that works fine.
My production forum is if course upgraded from 2.0.19 and it behaves differently: the topic that I set to not follow DOES show up in the recent topics, and I cannot mark it read as long as I leave it set on NOFOLLOW..
I did some digging in the code and in the tables, but I do not see any differences in the core files such as Recent.php and Recent.template.php, nor do I see differences in the database updates that explain this behaviour..
Anyony have any idea where to look further?
386b4d3f939714a3185d543b79ba5a4a.jpg
Should I assume you've tried uninstalling the mods one at a time and see if the problem goes away?
You can assume that, but that is not what I have done: since this is a productive forum I do not want to start uninstalling mods and hinder the users because I need to find a bug somewhere.
Instead I have done this:
- installed a vanilla 2.1.2 forum on Xampp locally
tested the 'Not Follow" function and it worked fine
- took a backup of the production database and imported that into the test forum
tested the 'Not Follow" function and it worked fine
- one by one installed the MODs and after each mod tested the 'Not Follow' function and it work fine everytime
So now I have a new install 2.1.2 locally with the production database and all mods that are in production, and the functionality works fine...
That is pretty well were I am... still no clue where the problem originates...
The last thing I will do later is to compare the full local codebase with that of the productive forum and see if any code difference come to light.... >:(
Quote from: @rjen on September 20, 2022, 08:32:44 AMYou can assume that, but that is not what I have done: since this is a productive forum I do not want to start uninstalling mods and hinder the users because I need to find a bug somewhere.
Instead I have done this:
- installed a vanilla 2.1.2 forum on Xampp locally
tested the 'Not Follow" function and it worked fine
- took a backup of the production database and imported that into the test forum
tested the 'Not Follow" function and it worked fine
- one by one installed the MODs and after each mod tested the 'Not Follow' function and it work fine everytime
So now I have a new install 2.1.2 locally with the production database and all mods that are in production, and the functionality works fine...
That is pretty well were I am... still no clue where the problem originates...
The last thing I will do later is to compare the full local codebase with that of the productive forum and see if any code difference come to light.... >:(
Just throwing this out there from left field..
During the testing on your local xampp setup, are you using the same theme as the production site?
Yep, happens on both themes,
And I compared sources and both theme files and not finding any relevant differences
Quote from: @rjen on September 20, 2022, 12:18:54 PMYep, happens on both themes,
And I compared sources and both theme files and not finding any relevant differences
Another really random and crazy idea here..
Have you tried making a local SMF 2.0 install, then upgrade it to 2.1, then try to replicate the issue?
While unlikely, I am wondering if something during the upgrade process could be the cause.
Right now I can only try to debug the code to find what the ... is happening.
Can someone tell me where the "Not Following" information is stored when a user chooses not to follow a certain topic?
I would assume that the "not following"" record is not an existent instant as such. Instead instead the logic probably is remove the following tracker Of course I haven't looked at the actual code myself
Did you migrate during RC, or later, directly to 2.1.0+?
This PR comes to mind, late in the RCs:
https://github.com/SimpleMachines/SMF/pull/6683
I migrated directly from 2.0.19 to 2.1
Thinks for the link, I will check it later today
Quote from: shawnb61 on September 20, 2022, 06:03:36 PMThis PR comes to mind, late in the RCs:
https://github.com/SimpleMachines/SMF/pull/6683
Checked the PR, but that does not seem to apply: the PR is releated to the update of table 'smf_log_notify' which holds entries for topics that users DO want to be notified on.
The problem I have is with the setting "Not following" on a topic
2022-09-21_090315.jpg
Got a little further and some result...
The Not following is stored in table smf_log_topics in the column 'unwatched'
Update and all working
In recent.php this table is read.
Now there is something specific:
If there are less then 100.000 messages in the forum the code builds up an internal table called "log_topics_unread" and processes that, if the number of messages exceeds 100.000 another query is used to retrieve the data...
Now my forum has around 300.000 messages, so query 2 is used, and it keeps showing the topics that re 'unwatched' in the unread topics.
Now when I change the threshold value to 1.000.000 messages the functionality works..
So the first query with the internal table "log_topics_unread" gives the correct result, but the second query, reading the smf_log_topics table does not.
Still hoping that one of the devs can have a look into these functions and explain the different behaviour...
There was a fix in this area not too long ago:
https://github.com/SimpleMachines/SMF/pull/6908
To:
https://github.com/SimpleMachines/SMF/issues/6907
My initial thought is that the fix addressed the <=100000 but not the >100000. I'll take a peek.
I believe I have a fix for this:
https://github.com/SimpleMachines/SMF/pull/7548
I was able to confirm the issue in my test forum, of a similar size (245K posts).
BUT... Not just by clicking "Unread Posts". Unread Posts invokes the logic for "
RECENT UNREAD TOPICS". That logic, I think, was working fine. However, if you subsequently press the button for "
ALL UNREAD TOPICS", the issue is visible. I think this is why this was difficult for folks to reproduce.
I suspect
@@rjen has a setting or template tweak somewhere that defaults "Unread Posts" to invoke "ALL UNREAD TOPICS". I.e.,
/index.php?action=unread;all;start=0 as opposed to
/index.php?action=unreadThe 'all;' in the URL is important.
The temporary table used for forums with > 100000 messages is only used when processing "ALL UNREAD TOPICS".
@@rjen - let me know if this addresses the issue!
I will check today.
I can confirm that we use the all unread instead of the default since last visit: that is indeed a tweak I made..
Confirmed: I applied your correction and it solves the problem..
Wow, glad you found that one, that took a while...
Marking solved as a solution to the OP's problem has been provided and submitted for future release.
Brilliant! Many thanks, Shawn, hero material indeed!