Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Antechinus on May 16, 2022, 06:13:23 PM

Title: Deprecated CSS in 2.1.1
Post by: Antechinus on May 16, 2022, 06:13:23 PM
This doesn't exist anymore, as the ID was removed from that div before Final.

Although, arguably, it may make sense to put the ID back, but the way the markup is at the moment this CSS does nothing:
Code (admin.css) Select
/* The welcome thingy. */
#welcome {
    border: 1px solid #ddd;
    border-top: none;
    border-radius: 0 0 7px 7px;
    font-size: 0.9em;
    padding: 12px 9px 8px 9px;
}
#welcome a {
    font-weight: bold;
}
#welcome img {
    vertical-align: middle;
}


And while we're at it, this doesn't exist in 2.1 either:
Code (index.css) Select
/* the small stats */
#index_common_stats {
    margin: -4px 8px 6px 8px;
    padding: 4px 0 0 0;
    font-size: 0.9em;
    border-top: 1px solid #ddd;
}

And this doesn't work in 2.1 either, even with js disabled, due to the way the menu declarations were changed between Alpha and Final:
Code (index.css) Select
/* Note: The next declarations are for keyboard access with js disabled. */
.dropmenu ul a:focus, .dropmenu ul ul a:focus {
    margin-left: 9990px;
    border: none;
    width: 17em;
}
.dropmenu ul ul a:focus {
    margin-left: 19950px;
}
/* Cancel those for hover and/or js access. */
.dropmenu ul li:hover a:focus, .dropmenu ul li a:focus {
    margin-left: 0;
    width: auto;
}
It would not be that hard to make it work again, but I doubt anyone except me will bother, so might as well remove it from default.
Title: Re: Deprecated CSS in 2.1.1
Post by: Oldiesmann on May 17, 2022, 10:13:35 PM
Submit a PR for it on GitHub and it can get pulled in for 2.1.3 if Sesq and others think it's a good idea.
Title: Re: Deprecated CSS in 2.1.1
Post by: Max22 on November 27, 2022, 04:48:22 PM
https://github.com/SimpleMachines/SMF/pull/7489
Title: Re: Deprecated CSS in 2.1.1
Post by: shawnb61 on November 27, 2022, 05:29:52 PM
Thanks, @Max22 !