This has been reported twice in past couple days -
https://www.simplemachines.org/community/index.php?topic=582736.msg4128664#msg4128664
https://www.simplemachines.org/community/index.php?topic=582793.msg4129057#msg4129057
So I gather that there is an attachments issue which means now would not be the time to upgrade from 2.0.19 to 2.1.2
I gather the problem is due to be fixed in 2.1.3?
Am I correct as if that's he case, I'll wait.
There is no known, documented, reproducible bug where a 2.1 upgrade loses pix.
OTOH, The upgrader is definitely sensitive to improper settings, e.g., if the attachment folders are incorrect. This usually happens after a forum move, restore, or site restructure; under all such circumstances, you should run repair_settings.php prior to upgrading to ensure smf knows where your folders are - especially attachments.
You absolutely MUST be upgrading a fully working forum, with proper settings & folders, or bad things happen.
There have been multiple reports of upgrade completing successfully but failed to add .dat extension to hashed attachment filenames. Attachments aren't lost, they just can't be found. It's fixed by manually adding the extension, then they're displayed correctly. This glitch is often accompanied by failure to move uploaded avatars from /attachments to /custom_avatar.
I cannot reproduce on an upgrade of a working forum.
OTOH, it's very easy to reproduce if you use the wrong folders for avatars & attachments.
If you can reproduce by any other means, please share!
I logged an enhancement request, to confirm the existence of the folders before the upgrade and to issue a warning if they are not found:
https://github.com/SimpleMachines/SMF/issues/7555
This could just be a simple case of bad server config, where attachments have at some point ended up owned by no-one, and the issue has been later resolved but the files have not been chowned correctly. I don't see either of those topics including any checks to error logs from the time of upgrade.
Speaking from experience here, that's a real issue with some servers...
The attached script has worked on several forums that had this problem. If it were caused by server config or incorrect chown, wouldn't script also fail?
Probably yes, if one php script fails because of that, another shouldn't work any better. You do have a point there.
So then assuming that I have a fully working forum, and take a back up first, then upgrading to 2.1.x shouldn't result in these issues. Is that correct?
Quote from: landyvlad on October 04, 2022, 10:21:50 PMSo then assuming that I have a fully working forum, and take a back up first, then upgrading to 2.1.x shouldn't result in these issues. Is that correct?
Yep.
Thank you
Folder checks were added in 2.1.3.
Likely an overdue feature.