Hi all,
I can't figure out where to look for to correct the smf_popup login icon class in the header of the popup window. I looked into Login.Template.php but was not lucky.
Currently, in both our theme and the SMF Default theme, the class for the icon is "help" instead of "login".
login wrong icon.png
I assume the error must be in our Default theme files as it's also there which it shouldn't if it wasn't tempered with, I guess?
Edit: I just noticed that it must be the popup window accessed from the mobile_user_menu div in the main menu secondary login option (Home, Login, Sign Up). When I use the "Welcome to..." login option, the icon is displayed correctly:
login popup from welcome header.png
So, one login option uses class main_icons help the other the correct main_icons login
The icon is indeed missing.
I'll send a PR later, thanks
Sent: https://github.com/SimpleMachines/SMF/pull/7585
Un millón de gracias, Diego! That worked. I just wanted to let everyone know that I also had to adapt the code in Index.Template.php as the Pelikan Theme used another class "visitor" for the smf_popup heading for login for guests.
Quote// Otherwise they're a guest. Ask them to either register or login.
else
{
echo '
<ul class="user-menu menu menu--flat" id="top_info">
<li class="visitor">
<a class="login" href="', $scripturl, '?action=login" onclick="return ', empty($maintenance) ? 'reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ', \'login\')' : 'true', ';"><i class="fas fa-right-to-bracket"></i> <span class="header__user-panel-text">', $txt['login'], '</span></a>
</li>';