Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: Shades. on March 24, 2023, 09:06:02 PM

Title: Member Approval Admin Menu Count
Post by: Shades. on March 24, 2023, 09:06:02 PM
SMF 2.1.3

How do I get rid of or turn off "Member Approvals" log count in the "Admin" menu button? I've had members awaiting approval before and have never seen this.

I have another site that has about 8 waiting for approval but this number does not show up in the Admin button there.

Did I miss a setting or is this normal behavior (that I've never noticed before) and can I turn it off? I only wish to see forum error counts in the Admin menu button please. O:)

memberapprovalalert.JPG

Thanks,
Shades 8)
Title: Re: Member Approval Admin Menu Count
Post by: Shades. on March 24, 2023, 09:18:30 PM
I guess I can just click on "Approve and require activation"? But why did they require approval? I have registration set for email activation. :o
Title: Re: Member Approval Admin Menu Count
Post by: Arantor on March 25, 2023, 04:49:39 AM
Is there an account pending deletion?
Title: Re: Member Approval Admin Menu Count
Post by: Shades. on March 25, 2023, 05:34:54 AM
Quote from: Arantor on March 25, 2023, 04:49:39 AMIs there an account pending deletion?
No, the person just registered yesterday. I thought it might be because of stop forum spam mod but I checked the users IP, username and email at the stopforumspam website and nothing came up so I don't know what could've triggered it.
Title: Re: Member Approval Admin Menu Count
Post by: Arantor on March 25, 2023, 09:13:07 AM
So this value ultimately comes from $modSettings['unapprovedMembers'] (which means, almost nearly directly from smf_settings table, under unapprovedMembers)

Places this changes in a default SMF 2.1:
* when a user is pending deletion and logs in, cancelling the deletion request
* when you do any approval/rejection in admin (the entire count is recounted)
* when a user is activated from their profile

The old SFS mod definitely manipulates this too. I vaguely remember reading about a bug where it would set this incorrectly at times.

If you're sure that no user is in any approval state they shouldn't be in (relevant states: pending admin approval, pending user deletion, pending COPPA form from parents), you can fix the count by going to smf_settings and resetting the count in there for unapprovedMembers to 0.

If you're not sure if you have people potentially in this situation, you can check this in phpMyAdmin:

SELECT * FROM smf_members WHERE is_activated IN (3, 4, 5, 13, 14, 15)
Title: Re: Member Approval Admin Menu Count
Post by: Shades. on March 25, 2023, 09:46:57 AM
Quote from: Arantor on March 25, 2023, 09:13:07 AMThe old SFS mod definitely manipulates this too. I vaguely remember reading about a bug where it would set this incorrectly at times.
Possibly the case here

Quote from: Arantor on March 25, 2023, 09:13:07 AMIf you're sure that no user is in any approval state they shouldn't be in (relevant states: pending admin approval, pending user deletion, pending COPPA form from parents), you can fix the count by going to smf_settings and resetting the count in there for unapprovedMembers to 0.

This one user definitely was in admin approval state I just can't figure out how he got there to begin with. Would this be somewhere in the logs too?

Meanwhile, I went ahead and approved the user and required activation and made a backup copy before approving the user so I can check it later on a backup site.

Thanks,
Shades 8)

Title: Re: Member Approval Admin Menu Count
Post by: Arantor on March 25, 2023, 09:55:08 AM
My memory of SFS - not that I've used it in years - was that it would dump a member in admin approval if it ticked boxes at the point they came in because it was iffy but not *too* iffy.

Not sure about the logs, I never really used SFS after a while, found better tools for solving my problem.
Title: Re: Member Approval Admin Menu Count
Post by: Shades. on March 25, 2023, 01:06:33 PM
Thanks, I'll mark this solved for now and see if it happens again then I'll post in the SFS board. It's not really a big deal because this is the first time it's happened and I've been using that mod for a long time.

Thanks again,
Shades 8)