Simple Machines Community Forum

SMF Development => Feature Requests => Topic started by: Julius_2000 on April 25, 2023, 05:38:31 AM

Title: 2.1.4 suggestion for attachment feature under posts
Post by: Julius_2000 on April 25, 2023, 05:38:31 AM
I don't know where to post this, so please, move it to an appropriate board if necessary.

I noticed from comments and from some changes on here that the SMF team might be currently testing 2.1.4 features on this site. The one thing that caught my eye is the overhaul of the attachment design.
While it's great to be able to just click right away or drag 'n drop, I noticed that inserting such an attachment is now a bit inconspicuous, just represented by an icon. If you would like to keep it that way, would you be able to leave a bit more space between that and the delete-icon? I could imagine this causing some usability issue on mobile devices where you could accidentally hit "delete" instead of "insert".
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Sesquipedalian on April 25, 2023, 10:39:11 AM
There's always a confirmation dialog before deleting, so it can't be done accidentally.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Sir Osis of Liver on April 25, 2023, 05:16:42 PM
That's a HUGE improvement.  Just a suggestion -

attach1.jpg

And get rid of the shortcuts, can't imagine anyone still uses them.  Just clutter, I always remove them.

Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: SleePy on April 25, 2023, 09:26:34 PM
Quote from: Sir Osis of Liver on April 25, 2023, 05:16:42 PMThat's a HUGE improvement.  Just a suggestion -

attach1.jpg

And get rid of the shortcuts, can't imagine anyone still uses them.  Just clutter, I always remove them.

I still use them. If you know your shortcuts, you will find them handy
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Sir Osis of Liver on April 25, 2023, 10:50:53 PM
Keyboard shortcuts go all the way back to the bad old DOS days,  And they're right next to the post/preview buttons.  Easier to just click/tap the buttons, so why would you use the 3-key shortcuts?
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Sesquipedalian on April 26, 2023, 12:34:51 AM
🤨 Because keyboard shortcuts are faster than mouse-based input.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Aleksi "Lex" Kilpinen on April 26, 2023, 02:05:22 AM
I use them too, it is easier to to just end your typing by typing, than switching from your keyboard to your mouse to post.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Julius_2000 on April 26, 2023, 04:51:15 AM
Quote from: Sesquipedalian on April 25, 2023, 10:39:11 AMThere's always a confirmation dialog before deleting, so it can't be done accidentally.
Got it. A bit more space for mobile purposes out of the box would be appreciated though, if possible. Otherwise, it looks good.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: DeadMan... on April 26, 2023, 07:10:16 AM
Quote from: Aleksi "Lex" Kilpinen on April 26, 2023, 02:05:22 AMI use them too, it is easier to to just end your typing by typing, than switching from your keyboard to your mouse to post.

Especially if using a laptop and the touchpad is deciding to be a pain. 😂
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Arantor on April 26, 2023, 07:33:34 AM
Surely the first part makes the second part irrelevant - all laptop touchpads are awful.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: SleePy on April 26, 2023, 11:10:31 PM
Quote from: Arantor on April 26, 2023, 07:33:34 AMSurely the first part makes the second part irrelevant - all laptop touchpads are awful.

I think Apple wins that category and has for years.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Sesquipedalian on April 27, 2023, 12:37:47 AM
I was going to say the same. My MacBook's trackpad is great. The ones on non-Apple machines are pretty consistently awful.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Arantor on April 27, 2023, 03:51:57 AM
Nope, hard disagree, I had a MacBook in 2012-2015 and currently for work, and I went back to a regular mouse almost immediately.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Sesquipedalian on April 27, 2023, 09:02:45 AM
To each their own.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Arantor on April 27, 2023, 09:13:25 AM
But the point stands, all sorts of device inputs, and that's before we talk about the situation with people with motor impairment issues - it is very easy to take it for granted that everyone can be as precise as us with mice or fingers on mobile, the reality is less clear.

Especially as we know SMF has a higher than typical contingent of people in the 60+ bracket and motor function can decline with age.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: DeadMan... on April 27, 2023, 10:49:57 AM
Quote from: Arantor on April 27, 2023, 09:13:25 AMfingers on mobile

This is true, but not very relevant when comes to keyboard shortcuts.

But it is a valid point about the spacing of the buttons.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Arantor on April 27, 2023, 10:59:21 AM
In the case of the keyboard shortcuts, I'd strongly suggest ditching the ones that are there (which have always been problematic for certain languages, especially Eastern European ones that overload the modifier keys for diacritics)

The more accepted standard at this point is Ctrl-Enter to submit (far fewer problems than the S), though this should be Command+Enter on Mac (rather than the very non standard Ctrl-Option-S)

Ctrl-Shift-P (Cmd-Shift-P) might fly for preview. But again, Mac doesn't use Ctrl the way Windows does, and Ctrl-Option as a Mac modifier is a bit weird.

I'd also suggest hiding the prompt on mobile by default... can't use a shortcut key I literally don't have...
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: DeadMan... on April 27, 2023, 01:44:11 PM
Quote from: Arantor on April 27, 2023, 10:59:21 AMI'd also suggest hiding the prompt on mobile by default... can't use a shortcut key I literally don't have...

It is already hidden on mobile.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Arantor on April 27, 2023, 02:01:43 PM
Quote from: DeadMan... on April 27, 2023, 01:44:11 PM
Quote from: Arantor on April 27, 2023, 10:59:21 AMI'd also suggest hiding the prompt on mobile by default... can't use a shortcut key I literally don't have...

It is already hidden on mobile.

Not on my iPad it isn't.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: DeadMan... on April 27, 2023, 03:45:17 PM
Quote from: Arantor on April 27, 2023, 02:01:43 PMNot on my iPad it isn't.

Most likely due to screen size.
Guessing it's hidden for smaller devices, like phones.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Arantor on April 27, 2023, 04:30:10 PM
It's still a mobile device, identifiable and detectable as such.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: DeadMan... on April 27, 2023, 06:34:14 PM
Quote from: Arantor on April 27, 2023, 04:30:10 PMIt's still a mobile device, identifiable and detectable as such.

Still, it gets hidden due to whatever size is set in the css. I agree that it should be hidden on all mobile devices. However, some tablets have bigger screen resolution settings than others. Not to mention that some tablets also do desktop version for websites by default.
Title: Re: 2.1.4 suggestion for attachment feature under posts
Post by: Arantor on April 27, 2023, 07:34:20 PM
So by that logic if I turn my phone on its side, I should see the shortcuts even though they're still no use?

Responsive is not a magic bullet, there are other behaviours and factors at work.