It's come to our attention that a bug in Firefox 1.5 is causing some issues on SMF forums. The bug (https://bugzilla.mozilla.org/show_bug.cgi?id=318419) causes Firefox to time its javascript functions incorrectly, which in turn results in a page reloading in the background many, many times. It's possible that some hosts may incorrectly flag this as a Denial of Service (DoS) attack due to the ferocity of the calls. If you are having problems with your server, with many calls looking like: "index.php?action=keepalive", then it almost certainly is this Firefox bug - in this case we recommend you following the advanced information included in this post.
To minimize the risk to this happening when viewing an SMF forum, we've created a work around for the bug which should solve this issue. If you are using SMF 1.1 RC1 or RC2 we recommend you simply replace the current script.js file found in your Themes/default directory with the attached file. This does not affect uses running SMF 1.0.6 or lower.
Advanced Information:
If you are currently experiencing these issues, replacing script.js with the attached should solve them for all new users, but existing users may hold a cached version of the file in their browser. If you are still experiencing issues after changing the file, we recommend editing your copy of index.template.php in your themes and searching for:
Code:
$settings['default_theme_url'], '/script.js?
After this line, regardless of what currently follows the "?", simply add a "j", this will invalidate any cached data and force clients to refetch the document.
Regards,
Simple Machines
what is the point of the "j"?
I just renamed my .js file to script2.js (after copying over some membermap javascript!)
Is that ok too?
Thanks!
by adding the j after ? you invalidate any previous cache of it. If you rename it then any other theme that doesn't have it's own script.js will try to use the now nonexistant script.js causing problems.
So the code will be ?
$settings['default_theme_url'], '/script.js?j
Quote from: dimitrist on January 21, 2006, 09:05:34 PM
So the code will be ?
$settings['default_theme_url'], '/script.js?j
Yes, that would be it.
do we need to put it on every heme or just default?
Thanks!
I had a server overload the other day due to this. I had around 2000 "index.php?action=keepalive" requests in a span of just a couple minutes. First I thought it was an exploit attempt.
AngelSL if your theme uses it's own script.js then you have to replace that one also.
-JayBachatero
I presume that 1.1 final will have the new script.js in the package?
Yea it will have it.
-JayBachatero
Propulsé par SMF 1.1 Beta 3 Public.
Does this version also have the bug ?
Yes. This affects the whole 1.1 Line. 1.1 Beta 1 to 1.1 RC2
Quote from: Grudge on January 20, 2006, 07:47:20 PM
All,
If you are using SMF 1.1 RC1 or RC2 we recommend you simply replace the current script.js file found in your Themes/default directory with the attached file.
Regards,
Simple Machines
I received this email this morning hours after updating.
But i don't see any attached file "script.js " with the email, where can i download that one so i can replace it ?
Thanks !
The update script is attached to the first message in this thread.
Grudge thank you so very much. I had been affected by this twice in the last 2 weeks. Pats on the back for all who fixed this up. ;)
Quote from: adrianbj on January 22, 2006, 02:48:28 AM
The update script is attached to the first message in this thread.
OK Thanks !
Good job on fixing it so fast after it came under your attention, devs! Thanks for fixing it. :)
If we add that 'j' to the line as indicated, should we remove it after a few days so that users aren't downloading the script every time they need to run it?
Aaah, so that's why my server crashed this often!
Thanks alot!
IngeJones, The "j" doesn't cause users to download it each page load. Instead it just changes the name of the file (As far as browsers are concerned). By adding a "j" (or any other letter) a browser thinks it's a different file from the last one so downloads it again. The next time they visit they see they already have the version with a "j" in it so don't bother themselves at getting it again.
Quote from: Grudge on January 20, 2006, 07:47:20 PM
All,
It's come to our attention that a bug in Firefox 1.5 is causing some issues on SMF forums. The bug (https://bugzilla.mozilla.org/show_bug.cgi?id=318419) causes Firefox to time its javascript functions incorrectly, which in turn results in a page reloading in the background many, many times. It's possible that some hosts may incorrectly flag this as a Denial of Service (DoS) attack due to the ferocity of the calls. If you are having problems with your server, with many calls looking like: "index.php?action=keepalive", then it almost certainly is this Firefox bug - in this case we recommend you following the advanced information included in this post.
To minimize the risk to this happening when viewing an SMF forum, we've created a work around for the bug which should solve this issue. If you are using SMF 1.1 RC1 or RC2 we recommend you simply replace the current script.js file found in your Themes/default directory with the attached file. This does not affect uses running SMF 1.0.5 or lower.
Advanced Information:
If you are currently experiencing these issues, replacing script.js with the attached should solve them for all new users, but existing users may hold a cached version of the file in their browser. If you are still experiencing issues after changing the file, we recommend editing your copy of index.template.php in your themes and searching for:
Code:
$settings['default_theme_url'], '/script.js?
After this line, regardless of what currently follows the "?", simply add a "j", this will invalidate any cached data and force clients to refetch the document.
Regards,
Simple Machines
Thank you for the info!
Now i dunno if im experiencing this problem
but should i still do this anyway
i use Smf 1.1 rc2
Firefox 1.5 RC3 has fixed this bug??
Quote from: dyrer on January 22, 2006, 06:11:27 AM
Firefox 1.5 RC3 has fixed this bug??
hasnt ff 1.5 final released already?!!
Anyone with SMF 1.1 (regardless of version) should use this file as it only takes a new visitor with Firefox 1.5 to visit the site and you can find yourself in problems.
How do I know if I'm getting this problem? All my URLs appear correctly and not with a "?action=keepalive" or similar.. Does this mean I don't have it?
Anyway, I plan to replace the "js" file, so all I need to do is replace it and that will solve the bug?? Because you guys are discussing some CODE and stuff so I was wondering if i need to do anything BESIDES replacing the JS file.
Thanks. And the e-mail was such a good idea!! I wouldn't have noticed it otherwise!!! Thanks a lot guys, its so nice that you care about your users to inform them thru email.
Quote from: Grudge on January 22, 2006, 06:32:52 AM
Anyone with SMF 1.1 (regardless of version) should use this file as it only takes a new visitor with Firefox 1.5 to visit the site and you can find yourself in problems.
okay will do thanks!
i will have to make this change for each skin right?
or is this code only applicable to the default theme?
Teknomancer,
If you have yet to experience any server problems just replacing the file should be fine. For people who have already experienced issues they need to make the code change.
Grudge
I've replaced the file to be on the safe side, but don't think I've had any problems....
I'm use FF 1.5 have been for a while ?? pretty sure a few others are
at ../Themes/default/index.templates.php i see
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js?rc2p"></script>
What do i change it?
huijaa, literally just add a "j" after the question mark
so that....
/script.js?jrc2p
or
/script.js?j
???
I'm puzzled. The bug is apparently caused by the combination of a specific version of FF and a specific version of SMF. SMF blames FF. FF has not confirmed it (I've done a search of their site and found only one 7-month old reference to SMF).
There is obviously an incompatibility between the two, but this could end up as a fruitless dialogue between deaf people, each saying the other is the cause. SMF has a workaround; why not simply add this workaround to a new RC build?
Now you see why I'm still with FF1.0 and SMF1.0.5 :)
Thanks, updating my site now :D
Also is this fixed in Firefox 1.5.01 RC1 (the next firefox minor release)?
Quote from: The_Devil on January 22, 2006, 07:18:36 AM
I'm puzzled. The bug is apparently caused by the combination of a specific version of FF and a specific version of SMF. SMF blames FF. FF has not confirmed it (I've done a search of their site and found only one 7-month old reference to SMF).
There is obviously an incompatibility between the two, but this could end up as a fruitless dialogue between deaf people, each saying the other is the cause. SMF has a workaround; why not simply add this workaround to a new RC build?
Now you see why I'm still with FF1.0 and SMF1.0.5 :)
Read your post and say who is starting this fight... ::) We told the user about the error but didn't cry around etc. - instead we post a fix and you're not satisfied? What do you want? It helps the users so stop talking this way.
thanks for the heads up :D
Thanks for the info :).
huijaa,
Either version.
The_Devil,
This is not about compatibility between SMF and FF - but about a bug in Firefox that adversely affects SMF. Firefox would not have SMF listed in their bug list as it's not a flaw in SMF that causes this bug - it's a problem with a very popular timing mechanism. The two important points to note are:
1) The bug in Firefox is linked to in my original post in this topic (Note the link under the word "bug")
2) The reason it only affects SMF 1.1 and not SMF 1.0.5 is because we added a new feature into SMF 1.1 to stop session timeouts. This feature uses javascript to ping the forum every 2 minutes to keep the session alive. The problem is that Firefox 1.5 has a bug in it's timer that means instead of running every 2 minutes, it does it many times a second - this effectively is a DoS attack from the users browser. The fix we've releases puts some extra javascript around the timer to counteract Firefox's problem.
Thanks for the fix! :D
i added the j
it says this now
QuoteUnable to load the 'main_above' template.
Quote from: The_Devil on January 22, 2006, 07:18:36 AM
Now you see why I'm still with FF1.0 and SMF1.0.5 :)
If everyone was to simply use FF1.0 and SMF1.0.5, as you do, to avoid any type of error/bugs etc, then there would never be any kind of advancement, everything would just remain stagnant, is that what you would like to see? or would you prefer to see more reliability, features and progress?
I think that it has clearly been demonstrated that the developers of smf have indeed got their fingers on the pulse when a fix was released so quickly.
To the all the developers I congratulate you on you hard work and dedication.
you mention put it in the default directory. what If im not using that theme??? do I still need this file?
macgig, yes, put it in the default directory - all other themes get that file from the default directory.
Prasad007, you must have added it in the wrong place :) Can you post the line you changed?
I'd had server problems and I know one of the admin team always uses FF. So I've updated the script.js file on the server and also in my PC copy of the RC2 install files. Fortunately all my themes are based on the NDT and all I had to do was alter the default index.template and one copy with the modifications for all the others.
Thanks
Quote from: Grudge on January 22, 2006, 10:25:08 AM
macgig, yes, put it in the default directory - all other themes get that file from the default directory.
Prasad007, you must have added it in the wrong place :) Can you post the line you changed?
i use helios multi for rc2
heres the line:
Quote<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js?jrc1"></script>
after i restored to the default i.e. deleted the j
it still gives the error now!! :( :(
Parasad, you must have unwittingly edited another line as well - as that j is no problem. Maybe try modifying a new heliod index.template.php file, if you're really stuck email me the one with the error and I'll email it back (smf@mattwolf.co.uk)
ill try reuploading a fresh copy of that file and retry
ill keep you updated
but im sure i did it correctly
thanks for the help grudge, and everyone. great support here. ;)
i tried again
it worked when i uploaded a fresh copy
but again when i added a j after ?
i get:
QuoteUnable to load the 'main_above' template.
please help!!
Prasad...
What editor are you using to make this change?
Quote from: Kindred on January 22, 2006, 11:02:31 AM
Prasad...
What editor are you using to make this change?
notepad
simple and sweet
I'm sure notepad is messing it up somehow. If you wish to send me the file unmodified I'll open it with UltraEdit and send it back.
EDIT: Or you could of course use the editor within the admin centre itself?
how can notepad or anything mess up anything for adding a simple j
i did it correctly im sure
Quote from: Prasad007 on January 22, 2006, 11:24:46 AM
how can notepad or anything mess up anything for adding a simple j
i did it correctly im sure
Before this topic goes on another page, please send him the file and let him try it or use another editor.
Quote from: Daniel D. on January 22, 2006, 11:27:19 AM
Quote from: Prasad007 on January 22, 2006, 11:24:46 AM
how can notepad or anything mess up anything for adding a simple j
i did it correctly im sure
Before this topic goes on another page, please send him the file and let him try it or use another editor.
okay
i uploaded it @ http://tech-ultimatum.uni.cc/Files/index.template.zip
zipped version
This bug caused me a great deal of time and expense in tracking down last week. Two Apache modules, mod_security and mod_ddosevasive will likely see anyone using SMF1.1 with Firefox 1.5 (as I am and a number of my board users are) as an attack and not send data to them.
I can't begin to elaborate on how frustrating it was to try to find out what was wrong with the server, and am not relieved to find that SMF was the culprit all along.
Pinging the server to keep the connection alive... for a message board? Why, oh why would this be necessary? It's not like it's a live chat.
Is this a "feature" we can turn off in the admin control panel, or do we have to edit the script.js file to remove it?
With the feature, SMF is essentially a server attacking tool.
Quote from: jough on January 22, 2006, 11:35:58 AMI can't begin to elaborate on how frustrating it was to try to find out what was wrong with the server, and am not relieved to find that SMF was the culprit all along.
SMF's script was alright in this case, just the execution by Firefox 1.5 wasn't.
QuotePinging the server to keep the connection alive... for a message board? Why, oh why would this be necessary? It's not like it's a live chat.
No, it's not a live chat. That's why the server is only pinged each 20 minutes. But it does prevent frustration about having worked on a message for an hour and then finding out your session timed out.
QuoteIs this a "feature" we can turn off in the admin control panel, or do we have to edit the script.js file to remove it?
The easiest way would be to remove it from the script.js.
QuoteWith the feature, SMF is essentially a server attacking tool.
I don't agree, pinging 3 times an hour like it's supposed to, is no server attack imho.
Must I make modification with the " j " in default theme only or in all my themes ?
That modification should be done in all themes, though it's only to prevent the old script from being cached. Browsers will refresh the cache from time to time as well.
Ok ... Thanks for instant reply ....
But:
This was on my original index.template.php :
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js?rc2p"></script>
And this is changed:
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js?jrc2p"></script>
Is that ok ?
That's fine
Would just like to compliment the SMF team on a timely FF fix. You guys are on it, and I appreciate it very much. Thank you!
Thank you for the alert. I checked my logs and sure nuff, I was getting those "index.php?action=keepalive". I changed all the index.template.php the way you said by putting the j after the question mark and put the script.js in the default theme directory.
I wasn't sure that I was suppose to change all index.template.php's with the j, but it seems to work ok.
I love this place.. ;D
Quote from: Prasad007 on January 22, 2006, 11:24:46 AM
how can notepad or anything mess up anything for adding a simple j
i did it correctly im sure
Just as a side note to anyone else...
Notepad will mess up ANY php files!!
DO NOT USE NOTEPAD TO EDIT YOUR PHP FILES.
Use a text editor like ConText, UltraEdit or EditPlus
i'm totaly lost but i suppose thats cause,
my theme i use don't have a "script.js", infact the only JS file it has is a collapse.js
My skin is : Daze Skin by Diplomat | Unofficial Grey Version modified by maCe
So would i just add the file attached to the 1st post and be done or *sigh*. i checked the index.template.php and there wasn't nothing in it that was like "$settings['default_theme_url'], '/script.js?"
Could this be related to why some of my users are blocked, and the forum is not working properly, as in, time to time reciving a login_incomplete error (that i thought i got fixed from the related bridge topic for Smf + Mambo.)
Anyways Thanks for the notification email, and the quick fix. now i just got to figure it out :P
I don't have a question mark in the code where I'm supposed to add a "j." This is the only line I have like that in my theme:
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js"></script>
What should the code be?
NiCRo - the script.js is in the theme directory called "default" - that is the only one you need to upload, not individual themes.
abcsurvivors, add "?j" after script.js
Thanks guys for this fix.
I'd like to add
If you edit any forum files in Dreamweaver, DON'T update links, when you ftp any forum files, database backups included, select ASCII mode. Auto will not do, if possible add php, css and sql to the list of ASCII file names. Since doing this I have been free from errors caused by corrupted data.
Does this also affect you if you are working with SMF 1.0.5?
manolain NO it does not affect you if you are using SMF 1.0.5.
-JayBachatero
I don't know if I had to, but I use the Joomla-SMF bridge and a code for it was placed in the Joomla template index.php file. I changed the "script.js?" part in it also just to be safe.
After I installed the new script, my smilies dont work anymore, my news fader wont fade, and I can't highlight words.
=\ Help!
Quote from: JayBachatero on January 22, 2006, 02:33:09 PM
manolain NO it does not affect you if you are using SMF 1.0.5.
-JayBachatero
Thanks for the answer Jay
we just suffered a few DoS attacks, couple of weeks ago....It is such a coincidence!!!
Quote from: capierno on January 22, 2006, 02:49:39 PM
After I installed the new script, my smilies dont work anymore, my new fader wont fade, and I can highlight words.
=\ Help!
Can you please make sure that you have uploaded the script.js file. If so check the size of it.
Quote from: manolain on January 22, 2006, 02:50:46 PM
Quote from: JayBachatero on January 22, 2006, 02:33:09 PM
manolain NO it does not affect you if you are using SMF 1.0.5.
-JayBachatero
Thanks for the answer Jay
we just suffered a few DoS attacks, couple of weeks ago....It is such a coincidence!!!
No problemo. Well it just affects the 1.1 line.
-JayBachatero
I dont know what you mean, i did upload the new script, thats what i said.
Can you please verify that the file uploaded correctly? Maybe upload it using another FTP client.
-JayBachatero
Tnx for the quick fix of this problem.
Always nice to know that there are people who take care of us. :)
capierno,
What browser do you use?
Grudge
capierno,
I registered on your site and it works fine with IE, Firefox and Opera. (Opera doesn't support the fade though). Can you try hitting Ctrl+F5 on your browser?
Thanks for the help Grudge, not sure if i needed it or if it will help with my other problems but Thanks for the info :)
I just want to thank you for the quick response time and full explaination of what was wrong + how to fix it. Considering that I'm running about five installs of SMF across several domains, this bug could really have messed life up with my host.
hmm, is this update a must do?
I'm running Firefox 1.5 and haven't noticed any problems with SMF.
It is recommended if you do it your forum is 1.1
-JayBachatero
Thanks for the heads up.
I uploaded the file and added the j.
One of my users noticed that we could not use tags in the posts.
So I took the "j" out and now the tags work.
What am I doing wrong?
I also went to the error log and hav a TON of errors related to the script URL
Not from recently but going back awhile.
8: Undefined variable: scripturl
etc. etc
I will search the forums for answers to this one.
It's incredible ! ... My site goes more faster ...
Thank you a lot for this fix ...
Sorry guys, but I can't download the file. I click on it, and the download screen appears, then I click on the save button but nothings get saved (with opera) I just get a 0 bytes saved file.
In FF I click the link but nothing happens. Maybe it's because of the file extension, maybe you could do a .zip file?
Thanks in advance.
Quote from: Kindred on January 22, 2006, 01:53:39 PM
Quote from: Prasad007 on January 22, 2006, 11:24:46 AM
how can notepad or anything mess up anything for adding a simple j
i did it correctly im sure
Just as a side note to anyone else...
Notepad will mess up ANY php files!!
DO NOT USE NOTEPAD TO EDIT YOUR PHP FILES.
Use a text editor like ConText, UltraEdit or EditPlus
okay thanks!
which one do you suggest?
I like your question Prasda. Did you read everything?
Quote from: Prasad007 on January 23, 2006, 12:27:29 AM
Quote from: Kindred on January 22, 2006, 01:53:39 PM
Quote from: Prasad007 on January 22, 2006, 11:24:46 AM
how can notepad or anything mess up anything for adding a simple j
i did it correctly im sure
Just as a side note to anyone else...
Notepad will mess up ANY php files!!
DO NOT USE NOTEPAD TO EDIT YOUR PHP FILES.
Use a text editor like ConText, UltraEdit or EditPlus
okay thanks!
which one do you suggest?
Quote from: Prasad007 on January 23, 2006, 12:27:29 AM
which one do you suggest?
Allow me to simplify this for you...even more.
www.context.cx
VIM forever!
woah! yay! it works now :)
i did it using context just like you said :D
i dont get it tho
using notepad adding a single j cudnt damn work!?!!?!!
i use firefox
but i havent noticed any problems or strange going ons
should i update the file as well just in case? or leave it as it is?
If you are using 1.1 Beta, RC1 or RC2 - update it.
yes i use RC2
thanks ill update it now :D
If keepalive is diabled in Apache... would this mitigate the problem? Or is the problem not the actual keepalive, but the severity of the number of REQUESTS for keepalive?
Updated with no problems, thanks for the fix. Another good program to use is PhpDesigner (http://www.mpsoftware.dk/phpdesigner.php) I love it, awesome program.
Uploaded script file made changes to appropriate index.template files and it's still doing it. Any thoughts?
Rename the file to script2.js and update any themes that call it to point to it's new name.
Dumb question, but does that mean I change each index.template file to point to renamed script?
Every themes index.template.php by default points to the default themes script.js, so in effect, yes.
Quote from: Prasad007 on January 23, 2006, 03:15:04 AM
woah! yay! it works now :)
i did it using context just like you said :D
i dont get it tho
using notepad adding a single j cudnt damn work!?!!?!!
The reason is simply that some windows editors (and even some windows FTP clients) modify the file when you save it, changing the end of line (EOL) characters to windows specific ones. This in turn causes the file to break when its being processed by interpreters.
I guess I do have an error. For some reason I cant play the arcade now. When I go to it I get this:
QuoteFatal error: Only variables can be passed by reference in /home/bigguy/public_html/smf/Sources/Arcade2.php on line 333
I asked at smfarcade.net but I figure seeing as it was all working before I did this that this might be the cause. Any ideas ???
Check to see if the arcade makes any changes to script.js if it does transfer those changes to the new file.
-JayBachatero
Ok I`ll give that a shot and post back.
No changes at all made to that file. Here is my line 333 from Arcade2.php
Quote$top10[$i]['comment'] = censorText(doUBBC(stripslashes($score['comment'])));
My host just recently upgraded to php 5.0.5 would that be the problem. Someone found this about it.
http://the-stickman.com/web-development/php/php-505-fatal-error-only-variables-can-be-passed-by-reference/
That might be it. Make a post about it in the Arcade Mod topic.
Ok, I did thanks. Would the php compatibility mod clear this up at all ???
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js?rc2p"></script>
I am using SMF Default theme, and it contains the ?rx2p at the end, do I take that out and replace it with "j"?
no put the j between the ? and the r
Quote from: Bigguy on January 23, 2006, 11:49:38 PM
Ok, I did thanks. Would the php compatibility mod clear this up at all ???
No it wouldn't because they are two different things. Same error though.
Well, I`m lost then,lol. I dont know wether this is a php error because of the upgrade the host did or if its got something to do with the database or the arcade. I`m sure the answer is around here somewhere. :)
Well that is an Arcade Mod issue. I'm sure Niko will provide a fix soon.
-JayBachatero
The error is because censorText() takes a variable in by reference and returns true or false.
Its invalid to take the return value from parse_bbc() and pass it directly to censorText().
At first blush I'd change
$top10[$i]['comment'] = censorText(doUBBC(stripslashes($score['comment'])));
to
censorText($top10[$i]['comment'] = parse_bbc(stripslashes($score['comment'])));
Note: In SMF 1.1 doUBBC() is basically just a wrapper for parse_bbc()
ok I tried what you said by changing it and that doesnt work. Thank you though, anymore ideas would be greatly appreciated.
Ok, I just noticed that some of the games are working so the whole arcade is not down. But the games that arent working were working before.
I've got to say that it's very confusing for unlogged in users to see references to attachments when they don't show up for us.
Maybe a link to a page saying you have to be logged in to download the attachment would be more friendly.
I'm about to upgrade from 1.0.5 to 1.1 RC2.
Is this bug fixed in current download version?
Ibiza no at the moment the bug is not fix on the curent downloads. The fix will be reflected on the release of 1.1 Final.
-JayBachatero
I figured out my problem with the arcade, so its working now and sending scores. Just thought I`d say something.
Glad to hear it's working now Bigguy
It did take a bit of fooling around but with the help of this site and smfarcade we we`re all able to figure it out. Thanks for all the help again guys. :)
and if you don't have '?' in code
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js"></script>
Add ?j at the end
i opened my Themes/Default and there is no script.js and there is no "$settings['default_theme_url'], '/script.js" in my index.template.php although i can access the file through its url /forum/Themes/default/script.js but i just can't see it when i open the file manager so should i just go ahead and upload it anyway?. i'm using the default SMF 1.1 RC2 theme.
uhm i got this in my email - i could not see an attachment nor can i see one in the first msg of this thread - pls can someone direct me to where the dl script is
thanks a million
theresa
I installed SMF a few minutes ago, went to the admin panel, and it told me to upload some patches, which I did. Then it had an alert about the firefox bug which sent me to this thread. course I was a guest, so I registered and came back.
What's unclear to me is whether the thank you in the post right before me means that everything is okay? or do I have to go through the hassle of figuring out how to do the things that were described earlier in the thread?
I haven't even begun to set up my SFM forum!!
Quote from: theresa on January 29, 2006, 03:00:49 PM
uhm i got this in my email - i could not see an attachment nor can i see one in the first msg of this thread - pls can someone direct me to where the dl script is
thanks a million
theresa
You have to be logged in to see it. It's on the first post.
Quote from: maggieH on January 29, 2006, 03:17:16 PM
I installed SMF a few minutes ago, went to the admin panel, and it told me to upload some patches, which I did. Then it had an alert about the firefox bug which sent me to this thread. course I was a guest, so I registered and came back.
What's unclear to me is whether the thank you in the post right before me means that everything is okay? or do I have to go through the hassle of figuring out how to do the things that were described earlier in the thread?
I haven't even begun to set up my SFM forum!!
Did you overwrite the script.js file then changed script.js?RC2 to script.js?RC2j in index.template.php for your themes?
I've changed permissions on this forum so guests can see the attachment.
"Did you overwrite the script.js file then changed script.js?RC2 to script.js?RC2j in index.template.php for your themes? "
nol I don't know anything about what you're talking about. I don't have themes, I don't have a forum. I don't know what script.js?RC2j
Installed SMF this afternoon and the first thing I found out is that there's a bug that I'll need to deal with. I expected SMF to be easy to use.
Someone posted that the fix will be reflected on the release of 1.1 final. I think I'll wait until then to establish the forum. When will that happen?
oh, it seems that I can ignore this whole thing because I've got 1.06 not 1.1
thanks Jay -- am a dork - thought i was logged in or if i was i could not see it for looking last night - oh well i was tired ;D
thats my excuse and i am sticking to it!
thanks again
Well the permission was added for guest to see attachments since you are not the only one that has experienced this. :)
It's most likely falls alert, but I have unique visitors increase from steady 3000 to 6500 in 3 days since I have upgraded from 1.0.5. to 1.1 RC2
I have replaced script.js before uploading forum to server and my theme doesn't use it's own script.js, but default.
I tough that visitors can not use faulty script.js since I replaced it before upload so I did not add that "j" in code...
But is it possible that visitors have script.js in cache from previous version 1.0.5 - does it makes same errors when used in 1.1. ???
Can you tell from statistics (http://www.motori.hr/_temp/daily_usage_200601.png) if this could be a problem?
I'm going to add that "j" now and see what happens...
This is that code now...
src="', $settings['default_theme_url'], '/script.js?jrc2p"
Quote from: JayBachatero on January 29, 2006, 03:54:13 PM
Did you overwrite the script.js file then changed script.js?RC2 to script.js?RC2j in index.template.php for your themes?
Hi there good people.. I'm new here but..
I need some clarification here
which part should I put the "
j" on my index.template.php?
is it "/script.js?
jrc2p"
or
"/script.js?rc2p
j"
I did some testing with my cpanelX and with "?
jxxx" , most of the time the server load jump from normal green to 12.xx red..
but "?xxx
j" seems OK..or is just me noticing things?
please help.. thanks in advance for the help
This by any chance wasn't fixed by the update to Firefox that I installed tonight was it?
Downloaded the update today. I would have to research if it resolves the bug that was originally posted here though.
;)
fairx it wouldn't matter as long as is after ?
Quote from: Kindred on January 22, 2006, 01:53:39 PM
Quote from: Prasad007 on January 22, 2006, 11:24:46 AM
how can notepad or anything mess up anything for adding a simple j
i did it correctly im sure
Just as a side note to anyone else...
Notepad will mess up ANY php files!!
DO NOT USE NOTEPAD TO EDIT YOUR PHP FILES.
Use a text editor like ConText, UltraEdit or EditPlus
I normally use Ultraedit myself.
But I've always wondered if the code editor in Dreamweaver is all right. I wouldn't want to use it for extensive coding, but for these sort of small edits it would be quite convenient.
Anyone have experience?
I wouldn't use Dreamweaver. It messes up files. Take it from me. Happened to me a few times. :-\
Firefox issue?
Thanks for the info guys.
I just replace the script.js with a new one and rename the old into script_bug_firefox.js and change the code in default theme. So, my visitors doesnt need to refresh and clear their browser cache.
So much for FF being the golden child browser.... Now it has bugs just like the rest of them... :D Don't get me wrong, I still use it... I just don't care for the hype that its the best thing since sliced bread..
Quote from: JayBachatero on February 03, 2006, 09:08:56 PM
I wouldn't use Dreamweaver. It messes up files. Take it from me. Happened to me a few times. :-\
How's it do that??
When you save it it messed it up beyond repair. Try it. It moves lines around, etc.
Quote from: rickc on February 05, 2006, 02:57:20 AM
Quote from: JayBachatero on February 03, 2006, 09:08:56 PM
I wouldn't use Dreamweaver. It messes up files. Take it from me. Happened to me a few times. :-\
How's it do that??
DreamWeaver is a WYSIWIG HTML editor. WYSIWIG HTML editors like to heavily modify the code of any files it loads so that it can display properly.
Dreamweaver can mess up files, if you have some preferences set a certain way, for example: inserting linefeeds in long lines. However, it is designed to leave existing code alone and only change what you want. When set-up correctly reformatting only happens on request.
Beyond that, some customisation of the integrated ftp client configuration may be required for certain file-types to ensure correct ascii/binary transfer.
I've personally never had any problems with Dreamweaver messing about with html, php, or javascript files. I find it to be an excellent tool for wysiwyg layout and hand-coding. The only times I've had problems, it was my fault.
Here's one for you:
I am using SMF 1.1 beta 4 and I am looking at my default theme right now. The interesting thing is, there is no "?" at all after the $settings['default_theme_url'], '/script.js. In other words, it has:
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js"></script>
What do I do now? Insert a ?j (or whatever) after it? Sounds like everyone else here had a "?" What gives?
Thanks,
Uhm... Guys... the ?rc1 or ?rc2 is postdata used by certain parts of the themes... modifying that with a j will break some themes!!! You most certainly shouldn't be trying ?jrc1 or ?rc1j as it will respond "cannot load the template" (which appears to be the problem some folks are having)
If you are going to add the j in the cases where your line reads ?rc1 or ?rc2, it should be added as &j
So, if your call to script.js already has a ?rc1 it should read ?rc1&j like this:
<script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js?rc1&j"></script>
You don't modify existing postdata, you make a new one. Dee dee dee! ::)
I have a question. I'm thinking of DLing it for my forums, just have one question;
With Version 2 does it still do this, or would I have to change it myself?
i am still running SMF 1.1 RC1 at two sites (simsarea.nl and champi.nl)... none of my members or visitors at both sites using FF have experienced problems..
Is this a general problem.. do i have to make those changes if i experience no problems at all..
It's not so much the Firefox user that will experience the problems (they won't hardly notice), but the server that would be hammered as a result of FF's timer being close to resetting (once in 19 hours if I'm not mistaken). It's advisable to at least replace your script.js by the one in the first post.
I'm new to SMF, and just two more questions;
is there a version without this bug?
is it easy for moderate users to install?
Quote from: goodgameral on February 13, 2006, 03:43:26 PM
I'm new to SMF, and just two more questions;
is there a version without this bug?
is it easy for moderate users to install?
1.0.6, the latest stable version of SMF does not have this bug. However the fix for this issue is a drop in replacement. Meaning you only need to replace the old file with the new one and it will work.
Then how come it looks more complicated than that on the font page? Also, I thought the front page said 1.05 and under were bug-free.
Dank je.. Thnx.. so replace the js and modify the link in index.template.. ok :)
Quote from: goodgameral on February 13, 2006, 10:23:20 PM
Also, I thought the front page said 1.05 and under were bug-free.
1.0.6 was released after this was posted, I have updated the first post to reflect that 1.0.6 is safe.
so if i were to install the new 1.2, it's just replacin a file that i could find easy and replace? (I'm newwer to anything but reg. HTML)
Ummm 1.2 Jumping ahead buddy :P Just download the file on the first post and replace it for your themes.
i confused ???
I haven't DLed anything yet; what should i do.
Step by step procedure
1. Download file
- http://www.simplemachines.org/community/index.php?action=dlattach;topic=66862.0;attach=12998
2. Connect to FTP
3. Browse to your forum/Themes/default folder
4. Upload
5. Repeat steps 3 and 4 for each theme that has a script.js file.
um... 1st things 1st;
how do I upload the entire forums script and everything from the download? :-[ (Sorry, but haven't even done that yet.)
Me= Web Admin Noob :'(
:D Plz help me some more
Take a look at the Installation Guide (http://www.simplemachines.org/community/index.php?topic=6765.0) topic. :)
thanks. you are definitely a support specialist to be able to put up with me. :D
You're welcome. Meh it's just a badge :P It's all a matter of personality ;)
I appreciate your help too, JayBachatero. The process turned out to be SO easy with your guidance.
It turns out only my "Themes/default" folder contained a script.js file. My site is still under development and not yet accessible to the public. I currently have about nine themes in place for my intended viewers to choose from. All of those themes come from Bloc and none apparently use a script.js file. So I only had to clear my own Firefox cache after replacing the previous "Themes/default/script.js" file.
Thanks again for the support. :D
Glad to hear everything s sorted out :)
I've done everything suggested here and still our SMF is slow.
BTW, ths forum is very slow too. ???
I don't think these two things are related. Start a new topic with the link to status.php and more details on this issue. Also PM me the link afterwards so that I can see it.
Would this cause this error message:
Connection Problems
Sorry, SMF was unable to connect to the database. This may be caused by the server being busy. Please try again later.
Not it shouldn't. You MySQL database went down or a corrupted Settings.php. Did you change any settings on the 'Server Settings" page?
I don't think so. How can I fix it?
Open Settings.php and verify that all the information is correct there.
Hi All,
Mine says:
$settings['default_theme_url'], '/script.js?rc2p"
Do I need to change this or is it okay?
Thanks,
Darren
It's ok. No change needed :)
Does this bug manifest itself by creating tons of sess_* and ruby_sess* files in /tmp ?
I didn't do the fix right away on a testsite as I was the only user - but I think even one user can hammer a server without the fix - correct?
Thanks
PS - the reason I ask is that if both of the above aren't true - I have other server issues ...
Quote from: iowamf on March 04, 2006, 05:10:45 PM
Does this bug manifest itself by creating tons of sess_* and ruby_sess* files in /tmp ?
Not very likely (that is, it shouldn't create more sessions, just keep the current one alive too many times).
QuoteI didn't do the fix right away on a testsite as I was the only user - but I think even one user can hammer a server without the fix - correct?
Yep, though the server would probably only start to slow down when it's already under stress.
Has anyone seen what the error message this bug produces or what symptoms? Slowness, 500 Internet Server Error, etc?
I replaced the file anyway just in case.
Even though I upgraded from SMF 1.0.5 to RC2 just about a week ago, the script file is different that what came with the RC2 download package. The file sizes are different.
well yeah they're diff sizes. You're not totally deleting one to put in another, youre simply replacing other files and adding other ones.
Anyway, whats the point with using JavaScript so much ?
SMF should have all standard themes without any JavaScript and only JavaScript in "media fx" enhanced themes, there is no need for using JavaScript for only the functionality or good design, this is more an effect and multimedia design which is not what World-Wide Web is made for in the first case. Make SMF faster and with less possibilities to bugs, remove JavaScript and it will work and only use it in enhanced themes.
The total loadsize for pages would also be much smaller without JavaScript. See how big for example the standard theme which viewing the mainpage which shows all forums and subforums. A page shall normally never be more than 50-70 Kb including images. There is a lot of people on the net on bad backbones, isp:s and old modems, not so unusual as many thinks.
Anyway, whats the point with using JavaScript so much ?
SMF should have all its themes without any JavaScript and only JavaScript in "media fx" enhanced themes, there is no need for using JavaScript for only the functionality or good design, this is more an effect and multimedia design which is not what World-Wide Web is made for in the first case. Make SMF faster and with less possibilities to bugs, remove JavaScript and it will work and only use it in enhanced themes.
The total loadsize for pages would also be much smaller without JavaScript. See how big for example the standard theme which viewing the mainpage which shows all forums and subforums. A page shall normally never be more than 50-70 Kb including images. There is a lot of people on the net on bad backbones, isp:s and old modems, not so unusual as many thinks.
Hello,
I upgraded a couple of weeks ago from 1.06, I replaced the script.js added a 'j' after the '?' , checked and double checked all my theme folders and added the 'j' as well to the joomla/smf bridge code in my joomla theme templates, but I'm seeing these in my server logs - not huge amounts - maybe 6 or 7 per 300 hits they mostly.
/forums/index.php?action=keepalive;1143398251287
Http Code: 200 Date: Mar 26 12:37:30 Http Version: HTTP/1.1 Size in Bytes: 5
Referer: http://www.mysite.com/index.php?option=com_content&task=view&id=15&Itemid=28
Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; Supplied by Tesco.net; SV1; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
I'm getting a bit concerned about it as I don't want to crash the server :-X
You are supposed to get keepalive notices on your logs. The problem was that the FF bug was keeping the keepalive on forever and it didn't stop.
Thankyou :) That's a relief - I hadn't noticed them before today :D
I have a question about this, The script update was done in Jan on my site and then in Feb I upgraded from 1.3bp to 1.1rc2
Would I then have to replace this script again or should it be alright?
I havent had any of those messages about denial of service or action=keepalive but our bandwidth usage has jumped significantly recently so I am just covering all bases
thanks
I would run it just to be safe but you should be ok.
You have to replace it again because the script.js in 1.1 b3 and 1.1 RC2 are the same. The one of this topic is the updated one.
Today firefox was updated to 1.5.02. In the update notes (http://www.squarefree.com/burningedge/releases/1.5.0.2.html) it says that bug 318419 (https://bugzilla.mozilla.org/show_bug.cgi?id=318419) is now fixed.
My theme (cerberus) doesn't have a script.js file, but I still have this problem. What is going on?
Quote from: Pyro In A Cage on May 04, 2006, 04:30:37 AM
My theme (cerberus) doesn't have a script.js file, but I still have this problem. What is going on?
If your theme doesn't have its own script.js file it's using the file from
/Themes/default/, so replace that one and you should be OK.
Quote from: JayBachatero on February 14, 2006, 07:11:19 PM
Step by step procedure
1. Download file
- http://www.simplemachines.org/community/index.php?action=dlattach;topic=66862.0;attach=12998
2. Connect to FTP
3. Browse to your forum/Themes/default folder
4. Upload
5. Repeat steps 3 and 4 for each theme that has a script.js file.
Quote from: Grudge on January 22, 2006, 02:08:25 PM
NiCRo - the script.js is in the theme directory called "default" - that is the only one you need to upload, not individual themes.
abcsurvivors, add "?j" after script.js
Ummm... so which is it?
If your custom themes have their own .js file you update board files if not just update the default theme file.
I've just installed (and updated/patched) SMF but which script.js is the right one? The one at the start of this thread or the one in the updated_files_1-1-RC2.zip file in this thread:
http://www.simplemachines.org/community/index.php?topic=78841.0 (http://www.simplemachines.org/community/index.php?topic=78841.0)
Thanks
Quote from: roxpace on March 26, 2006, 01:08:29 PM
Anyway, whats the point with using JavaScript so much ?
SMF should have all its themes without any JavaScript and only JavaScript in "media fx" enhanced themes, there is no need for using JavaScript for only the functionality or good design, this is more an effect and multimedia design which is not what World-Wide Web is made for in the first case. Make SMF faster and with less possibilities to bugs, remove JavaScript and it will work and only use it in enhanced themes.
The total loadsize for pages would also be much smaller without JavaScript. See how big for example the standard theme which viewing the mainpage which shows all forums and subforums. A page shall normally never be more than 50-70 Kb including images. There is a lot of people on the net on bad backbones, isp:s and old modems, not so unusual as many thinks.
JS is more and more an important point of modern webpages.
Web 2.0, innerHTML, XMLHttpReQuests and all this makes sites faster not slower ...
It´s lesser traffix, when you can use so called microrequest.
Many of the Google Services or Flickr and all this sites makes an extensive use of JS.
Quote from: polchasa on May 14, 2006, 01:11:07 PM
I've just installed (and updated/patched) SMF but which script.js is the right one? The one at the start of this thread or the one in the updated_files_1-1-RC2.zip file in this thread:
http://www.simplemachines.org/community/index.php?topic=78841.0 (http://www.simplemachines.org/community/index.php?topic=78841.0)
Thanks
Apply updated_files_1-1-RC2.zip since it have a few security fixes.
Quote from: mediman on May 14, 2006, 01:23:06 PM
Quote from: roxpace on March 26, 2006, 01:08:29 PM
Anyway, whats the point with using JavaScript so much ?
SMF should have all its themes without any JavaScript and only JavaScript in "media fx" enhanced themes, there is no need for using JavaScript for only the functionality or good design, this is more an effect and multimedia design which is not what World-Wide Web is made for in the first case. Make SMF faster and with less possibilities to bugs, remove JavaScript and it will work and only use it in enhanced themes.
The total loadsize for pages would also be much smaller without JavaScript. See how big for example the standard theme which viewing the mainpage which shows all forums and subforums. A page shall normally never be more than 50-70 Kb including images. There is a lot of people on the net on bad backbones, isp:s and old modems, not so unusual as many thinks.
JS is more and more an important point of modern webpages.
Web 2.0, innerHTML, XMLHttpReQuests and all this makes sites faster not slower ...
It´s lesser traffix, when you can use so called microrequest.
Many of the Google Services or Flickr and all this sites makes an extensive use of JS.
Javascript is old and not modern, it is also a heavy security risc in many environments. That is why MANY companies doesnt allow the ude of Javascript and has disabled it completely in all their workstations.
"Web 2.0" is just hyped junk and no standard which will not make any revolution... innerHTML (IE) and AJAX as you meantion is even more considered riscs in many environments, that it is why they are only an option for users, not a requirement on all serious websites on Internet. You are talking about Google for example, they do not demand this on their open public webpages at all, only on GMail and Statistics which is login based for a narrow service in mind.
Still there is a lot of websurfer with slow modems or slow connections where Javascript doesnt provide any easier life for them as I pointed out in the earlier example.