Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: Nibogo on May 23, 2006, 12:44:11 AM

Title: Reason For Editing Mod
Post by: Nibogo on May 23, 2006, 12:44:11 AM
Link to Mod (https://custom.simplemachines.org/mods/index.php?mod=349)

(https://www.smfpacks.com/imagenes/nuevo_logo_mod.png) (http://www.smfpacks.com)

Reason for Editing Mod v2.3.2 - NIBOGO
This mod add a reason for editing a post that will be inputed when you edit a post.


Support topic (http://www.simplemachines.org/community/index.php?topic=89012.0) | Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=349) | My Mods (http://custom.simplemachines.org/mods/index.php?action=search;author=126412) | Website (http://www.smfpacks.com)



Important Info:
o This Mod was created by SMFPacks.com - The #1 Website for the Customziation of your SMF.
o Remember to set the permission "Set Reason for Edit" for all the membergroups that you want to be allowed to use this mod.

Author:
- Winrules

Developer:
- NIBOGO

Features:
o Set the reason for edit a post.
o Permission for set reason for edit in messages.
o Reason displayed on the << Last Edit: ... >> line.
o Support for SMF 1.1.11 & 2.0 RC2
o English, Spanish_latin, Spanish_es, Portuguese and Dutch with utf8 support.
o Easy integration with other themes

VERY IMPORTANT!!

If you are using a 1.x version of this mod and want to upgrade please do this things:

1. Remove all the code MANUALLY

2. Delete the mod in the package manager

3. Install this new version

PD: If you uninstall using the package manager you will delete all the data of this mod so you need to do this or replace the package in the Packages dir with a new one without the uninstall

Languages:
- English/English-utf8
- Spanish Latin/Spanish Latin-utf8
- Spanish Es/Spanish Es-utf8
- Portuguese Brazilian/Portuguese Brazilian-utf8
- Portuguese Pt/Portuguese Pt-utf8
- Dutch/Dutch-utf8

Compatibility:
- 1.1.X
- 2.0 RC4

Special Thanks:
- winrules (Original Author of the Mod)
- movingmagic (Dutch Translator)
- FragaCampos (Portuguese Translator)




Changelog:

2.3.2 - 19 Jan 2011
o Added SMF 2.0 RC4 Support.

2.3.2 - 08 Mar 2010
o Added SMF 2.0 RC3 Support
o Fixed Incorrect Package Version on Package Manager

2.3 - 13 Feb 2010 - If you are using SMF 1.1.X you don't need to upgrade
o Fixed bug with the installation. (Only for SMF 2.0)
o Fixed "Field 'edit_reason' doesn't have a default value". (Only for SMF 2.0)
o Fixed Issues editing messages using JS (Like Quick Edit, Change Title on Messageindex and Change Message Icon). (Only for SMF 2.0)
o Fixed Redirect after installation. (Only for SMF 2.0)


2.2 - 22 Nov 2009
o Added Curve Support
o Added Support for SMF 2.0 RC2
o Fixed bug with the permission to use this mod.

2.0 - 22 June 2009
o Added Permission for "Set Reason for Edit"
o Added Support for SMF 2.0
o Now Developed by NIBOGO
o Changed all the text now using languages strings
o Added spanish, spanish_es, spanish_latin, portuguese and dutch all with utf8 support

1.14
o Compatibillity added.

1.13
o Compatibility added, 1.1 RC2 development stopped.

1.12
o Fixes a bug that fills up the error log..

1.11
o Fixes a bug with not displaying the reason if a reason isn't specified.

1.1
o Doesn't display the reason if one is not specified, adds permissions to who can give a reason in features and options.

1.0
o Initial Public Release by winrules
Title: Re: Reason For Editing Mod
Post by: Jorin on May 23, 2006, 02:54:19 AM
Is there a chance to change this mod that only global mods and admins can see and enter the reason for editing?
Title: Re: Reason For Editing Mod
Post by: sbarnes on May 23, 2006, 05:26:28 AM
Great little mod,
How would you set the default reason if someone didnt enter one.

e.g if someone edited their post but did not put in a reason, it could say "no reason given"

I can make the field contain the text by default by:
<tr>
<td valign="top" align="right">
<b>Reason For Edit:</b>
</td>
<td>
<input type="text" name="edit_reason" size="50" value="No Reason Given" />
</td>
</tr>';


But how could this be done and have the text field left blank as if people see it is already filled in with something they are more likely to not change it.
Title: Re: Reason For Editing Mod
Post by: winrules on May 23, 2006, 04:31:56 PM
Quote from: nehcregit on May 23, 2006, 02:54:19 AM
Is there a chance to change this mod that only global mods and admins can see and enter the reason for editing?
OK, I'll put an option in features and options about who to show the box to.

Quote from: sbarnes on May 23, 2006, 05:26:28 AM
Great little mod,
How would you set the default reason if someone didnt enter one.

e.g if someone edited their post but did not put in a reason, it could say "no reason given"

I can make the field contain the text by default by:
<tr>
<td valign="top" align="right">
<b>Reason For Edit:</b>
</td>
<td>
<input type="text" name="edit_reason" size="50" value="No Reason Given" />
</td>
</tr>';


But how could this be done and have the text field left blank as if people see it is already filled in with something they are more likely to not change it.
Next version will not display a reason if they don't specify one, I don't see why you'd want the reason to stay though because someone usually wouldn't edit the post for the same reason the person before did, and it would be confusing as to who edited the post for the reason.
Title: Re: Reason For Editing Mod
Post by: sbarnes on May 23, 2006, 05:17:47 PM
It doesnt matter but I think you have mis-understood what I meant, or I wrote it wrong.

What I meant was, because the reason for editing text area is not 'required' (it does not need to be filled in to continue - it is optional), the editor can choose to leave it blank.

This then prints on screen: <last edit, blah, blah, Reason:>
with obviously no reason there.

If the editor did not enter a reason the script could input 'Not given' or 'no reason given'

Alternativley not show the 'reason:' at the end of the line.
Title: Re: Reason For Editing Mod
Post by: winrules on May 23, 2006, 05:35:52 PM
I think you mis-understood my answer :P, I meant that it wouldn't whos the ", Reason:" if you didn't specify one.
Title: Re: Reason For Editing Mod
Post by: sbarnes on May 23, 2006, 05:48:07 PM
 ;D Thats good, thats exactly what I meant in my attempt as an alternative solution
QuoteAlternativley not show the 'reason:' at the end of the line.

Glad thats sorted out (phew) Any ideas when the next version will be available?

Great work by the way.
Title: Re: Reason For Editing Mod
Post by: winrules on May 23, 2006, 06:02:14 PM
Quote from: sbarnes on May 23, 2006, 05:48:07 PM
;D Thats good, thats exactly what I meant in my attempt as an alternative solution
QuoteAlternativley not show the 'reason:' at the end of the line.

Glad thats sorted out (phew) Any ideas when the next version will be available?

Great work by the way.
soon.
mabye I'll release 1.1 with just that and some permissions for who can use it, and then in 2.0 I could do a pick-list of reasons (that is user-congufurable).
Title: Re: Reason For Editing Mod
Post by: Jorin on May 24, 2006, 01:55:30 AM
Who-whoooo! Then I'll wait for 2.0 ;)
Title: Re: Reason For Editing Mod
Post by: winrules on May 24, 2006, 04:59:43 PM
Version 1.1 has been released! This version adds permissions to who can specify a reason (change them in features and options) and doesn't display a reason if one isn't specified.
Title: Re: Reason For Editing Mod
Post by: sbarnes on May 24, 2006, 05:38:16 PM
Removed the previous version, installed the 1.1 version which installed fine.
Trouble is, its as if the mod has not been installed! no reason for edit box, no settings in admin. Uninstalled again fine.

Any ideas?
Title: Re: Reason For Editing Mod
Post by: _Ryan_ on May 24, 2006, 06:07:39 PM
I'm trying to install this on 1.1 RC2 and I keep getting a page can't be displayed error after clicking the install link. Then when I go back to the packages page, it says its installed but nothing shows up when I go to edit a post.

[Edit]
Just tried it on a fresh install of 1.1 RC2 with no other mods. It went through the install, but no options are showing up for it and the reason for editing box doesn't show up when I modify a post.
Title: Re: Reason For Editing Mod
Post by: winrules on May 24, 2006, 08:08:02 PM
Wierd, I can't seem to replicate it though. Could you pm me your post.template.php?
Title: Re: Reason For Editing Mod
Post by: Dazzler on May 24, 2006, 08:38:48 PM
Quote from: sbarnes on May 24, 2006, 05:38:16 PM
Removed the previous version, installed the 1.1 version which installed fine.
Trouble is, its as if the mod has not been installed! no reason for edit box, no settings in admin. Uninstalled again fine.

Any ideas?

i am getting exactly the same.. running RC2 with tinyportal.. get mod.. would love to have it working
Title: Re: Reason For Editing Mod
Post by: winrules on May 24, 2006, 08:45:52 PM
Quote from: dodgydazzler on May 24, 2006, 08:38:48 PM
Quote from: sbarnes on May 24, 2006, 05:38:16 PM
Removed the previous version, installed the 1.1 version which installed fine.
Trouble is, its as if the mod has not been installed! no reason for edit box, no settings in admin. Uninstalled again fine.

Any ideas?

i am getting exactly the same.. running RC2 with tinyportal.. get mod.. would love to have it working
Can anyone having this problem please pm me their post.template.php, I just can't replicate it.
Title: Re: Reason For Editing Mod
Post by: winrules on May 25, 2006, 04:27:20 PM
OK, I've figured out what's causing it, If you were having problems please uninstall you're ucrrent version and re-download it, I have uploaded an updated version (but I didn't change the version number because there wern't very many downloads).
Title: Re: Reason For Editing Mod
Post by: Vinspire on May 27, 2006, 05:53:47 AM
can i c the screenshot of this mod ? :P
Title: Re: Reason For Editing Mod
Post by: winrules on May 27, 2006, 10:00:26 AM
Quote from: Vinspire on May 27, 2006, 05:53:47 AM
can i c the screenshot of this mod ? :P
Go to the mod's page on the mod site.
Title: Re: Reason For Editing Mod
Post by: Teknomancer on May 27, 2006, 10:23:57 AM
it still shows "Reason" even though no reason was set.

i.e. for posts that were edited before this mod.
Title: Re: Reason For Editing Mod
Post by: winrules on May 27, 2006, 10:34:55 AM
Quote from: Teknomancer on May 27, 2006, 10:23:57 AM
it still shows "Reason" even though no reason was set.

i.e. for posts that were edited before this mod.

1.1 was supposed to fix that...I think I forgot to put it in the install files...I will fix it ASAP.
Title: Re: Reason For Editing Mod
Post by: Teknomancer on May 27, 2006, 10:38:59 AM
Actually i fixed it...

isset () is not working

it is always returning TRUE meaning even if NO reason was specified it was getting TRUE.

I changed it to this:


if ($message['modified']['edit_reason'] != '')
echo '<br />Reason: ' . $message['modified']['edit_reason'] . '</i> »';
else
echo '</i> »';


now it works perfectly!

Thanks wonderful mod.
Title: Re: Reason For Editing Mod
Post by: Harzem on May 27, 2006, 10:42:55 AM
Instead of isset, you can use !empty, so there won't be that problem.
Title: Re: Reason For Editing Mod
Post by: winrules on May 27, 2006, 10:43:17 AM
Quote from: Teknomancer on May 27, 2006, 10:38:59 AM
Actually i fixed it...

isset () is not working

it is always returning TRUE meaning even if NO reason was specified it was getting TRUE.

I changed it to this:


if ($message['modified']['edit_reason'] != '')
echo '<br />Reason: ' . $message['modified']['edit_reason'] . '</i> »';
else
echo '</i> »';


now it works perfectly!

Thanks wonderful mod.

Oh, thats where I messed  up.

« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], isset($message['modified']['edit_reason']) ? ', Reason: ' . $message['modified']['edit_reason'] : '' , '  </i> »';

should be:

« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], !empty($message['modified']['edit_reason']) ? ', Reason: ' . $message['modified']['edit_reason'] : '' , '  </i> »';

I will release an update package later today.


edit: Harzem beat me to it :P
Title: Re: Reason For Editing Mod
Post by: winrules on May 27, 2006, 11:32:03 AM
Version 1.11 has been released! This version fixes a bug with the mod displaying a reason when a reason isn't specified.
Title: Re: Reason For Editing Mod
Post by: geezmo on May 30, 2006, 03:02:47 AM
Screenshot of how it actually looks in the board? Is it on the same line as "Edited On:..." in the post?

Or if there's anyone with a forum that uses this, let us take a look :D
Title: Re: Reason For Editing Mod
Post by: sbarnes on May 30, 2006, 05:32:39 AM
I was going to post a pic for you to see but you may as well see it in action here:

http://www.pick-your-brains.co.uk/index.php/topic,102.msg678.html#msg678
Title: Re: Reason For Editing Mod
Post by: winrules on May 30, 2006, 04:56:09 PM
Also there are some screenshots on the mod page.
Title: Re: Reason For Editing Mod
Post by: Dazzler on June 01, 2006, 05:53:56 PM
This is now working perfect with the latest upload..

i am looking forward to any upgrades you may do to this with the likes of drop down box etc..

top class keep up the good work
Title: Re: Reason For Editing Mod
Post by: ltdeta on June 02, 2006, 04:02:14 AM
any chance to get it compatible with SMF 1.0.7 ?
Title: Re: Reason For Editing Mod
Post by: DivZero on June 07, 2006, 01:09:25 PM
Hi,

Your mod seems great, and works perfectly on the default theme. But it doesnt display on the custom theme im using. Any code that I have to put in there? or should the mod have done that automaticly? Let me know :)
Title: Re: Reason For Editing Mod
Post by: winrules on June 07, 2006, 03:54:17 PM
Quote from: DivZero on June 07, 2006, 01:09:25 PM
Hi,

Your mod seems great, and works perfectly on the default theme. But it doesnt display on the custom theme im using. Any code that I have to put in there? or should the mod have done that automaticly? Let me know :)
Look here: http://docs.simplemachines.org/index.php?topic=402
Title: Re: Reason For Editing Mod
Post by: littleone on June 08, 2006, 11:08:14 PM
I an getting an undefined index for edit_reason.  Anyway to resolve this?  Thanks
Title: Re: Reason For Editing Mod
Post by: winrules on June 09, 2006, 03:46:27 PM
Quote from: littleone on June 08, 2006, 11:08:14 PM
I an getting an undefined index for edit_reason.  Anyway to resolve this?  Thanks
What is the exact error you are getting, and what version of the mod are you running?
Title: Re: Reason For Editing Mod
Post by: Vinspire on June 10, 2006, 06:09:33 AM
Winrules bro, I am using Helios Theme and want to get this mod working in the theme.

I've look into modification.xml and found this. I dont really understand.

Original code

<file name="$themedir/Display.template.php">
<operation>
<search position="replace"><![CDATA[
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';
]]></search>
<add><![CDATA[
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], !empty($message['modified']['edit_reason']) ? ', Reason: ' . $message['modified']['edit_reason'] : '' , '  </i> »';
]]></add>
</operation>

</file>


Edit display.template .... find

![CDATA[
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';
]]


and add

<![CDATA[
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], !empty($message['modified']['edit_reason']) ? ', Reason: ' . $message['modified']['edit_reason'] : '' , '  </i> »';
]]>


In Helios Theme there isn't post.template.php ... So, i need to create a file with that name or just leave it ?
Title: Re: Reason For Editing Mod
Post by: winrules on June 10, 2006, 09:37:54 AM
If the file doesn't exist then skip it.
Title: Re: Reason For Editing Mod
Post by: littleone on June 10, 2006, 11:40:18 AM
8: Undefined index: edit_reason
File: /home/xxxxxxx/public_html/forum/Sources/Post.php
Line: 2263


Version 1.11
Title: Re: Reason For Editing Mod
Post by: winrules on June 10, 2006, 12:45:46 PM
Can you post the lines around line 2263 in Post.php?
Title: Re: Reason For Editing Mod
Post by: Vinspire on June 10, 2006, 01:30:30 PM
Quote from: winrules on June 10, 2006, 09:37:54 AM
If the file doesn't exist then skip it.

Okie. Then what about this ?

I open helios theme display.template.php

I find

![CDATA[
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';
]]


Then where to add

<![CDATA[
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], !empty($message['modified']['edit_reason']) ? ', Reason: ' . $message['modified']['edit_reason'] : '' , '  </i> »';
]]>


Under it ?
Title: Re: Reason For Editing Mod
Post by: winrules on June 10, 2006, 01:37:54 PM
replace the 2nd one with the first one.
Title: Re: Reason For Editing Mod
Post by: littleone on June 10, 2006, 02:06:09 PM
Quote$posterOptions = array();

      if (time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
      {
         $msgOptions['modify_time'] = time();
         $msgOptions['modify_name'] = addslashes($user_info['name']);
      }
      $msgOptions['edit_reason'] = addslashes(strtr(htmlspecialchars($_POST['edit_reason']), array("\r" => '', "\n" => '', "\t" => '')));

      modifyPost($msgOptions, $topicOptions, $posterOptions);

      // Changing the first subject updates other subjects to 'Re: new_subject'.

The red line is 2263
Title: Re: Reason For Editing Mod
Post by: winrules on June 10, 2006, 03:14:25 PM
Quote from: littleone on June 10, 2006, 02:06:09 PM
Quote$posterOptions = array();

      if (time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
      {
         $msgOptions['modify_time'] = time();
         $msgOptions['modify_name'] = addslashes($user_info['name']);
      }
      $msgOptions['edit_reason'] = addslashes(strtr(htmlspecialchars($_POST['edit_reason']), array("\r" => '', "\n" => '', "\t" => '')));

      modifyPost($msgOptions, $topicOptions, $posterOptions);

      // Changing the first subject updates other subjects to 'Re: new_subject'.

The red line is 2263
OK, I will fix that in th next version.
Title: Re: Reason For Editing Mod
Post by: littleone on June 10, 2006, 03:44:40 PM
ok when you do, can you post the code fix here, so I can just go in and edit that one piece?  Thanks ;)
Title: Re: Reason For Editing Mod
Post by: Vinspire on June 11, 2006, 08:39:59 AM
Winrules, manage to fix it already :)
Title: Re: Reason For Editing Mod
Post by: winrules on June 11, 2006, 10:31:51 AM
It's comming...
Title: Re: Reason For Editing Mod
Post by: winrules on June 11, 2006, 11:26:36 AM
Version 1.12 has been released! This version fixes a bug with 8: Undefined index: edit_reason errors in the error log.
Title: Re: Reason For Editing Mod
Post by: Vinspire on June 11, 2006, 01:57:26 PM
winrules, I've updated my version to 1.12. Its working perfectly. Thank you  :D :D :D
Title: Re: Reason For Editing Mod
Post by: geezmo on June 12, 2006, 11:49:02 AM
I installed and uninstalled this mod before and now that i want to re-install it, I'm getting an error that the tables are already in the db. Can you tell me what to do with the existing tables so I can properly install this mod? I think these tables are "edit_reason" and "er_who"
Title: Re: Reason For Editing Mod
Post by: DemonicInfluence on June 12, 2006, 11:57:48 AM
Thanks for the great mod :)
Title: Re: Reason For Editing Mod
Post by: winrules on June 12, 2006, 03:41:22 PM
Quote from: geezmo on June 12, 2006, 11:49:02 AM
I installed and uninstalled this mod before and now that i want to re-install it, I'm getting an error that the tables are already in the db. Can you tell me what to do with the existing tables so I can properly install this mod? I think these tables are "edit_reason" and "er_who"
It's just the edit_reason. Go to phpmyadmin and delete it.
Title: Re: Reason For Editing Mod
Post by: littleone on June 12, 2006, 07:09:15 PM
Quote from: winrules on June 11, 2006, 11:26:36 AM
Version 1.12 has been released! This version fixes a bug with 8: Undefined index: edit_reason errors in the error log.

fixed it.  Works perfectly.  Thanks ;)
Title: Re: Reason For Editing Mod
Post by: geezmo on June 12, 2006, 07:38:19 PM
I dropped edit_reason but the er_who table still creates a prob. Here's the error:

Duplicate entry 'er_who' for key 1
File: /home/mysite/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 3
Title: Re: Reason For Editing Mod
Post by: winrules on June 12, 2006, 08:22:03 PM
Quote from: geezmo on June 12, 2006, 07:38:19 PM
I dropped edit_reason but the er_who table still creates a prob. Here's the error:

Duplicate entry 'er_who' for key 1
File: /home/mysite/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 3
Oh. er_who isn't a table, it's a row. In the settings table, drop the row for variable er_who.
Title: Re: Reason For Editing Mod
Post by: geezmo on June 12, 2006, 08:37:10 PM
That's the thing, I can't seem to find the er_who row in smf_settings table. (It's not really there, it's not about me being unable to find the row). What query can I run in mySQL that can hopefully address this er_who problem?
Title: Re: Reason For Editing Mod
Post by: winrules on June 12, 2006, 08:44:13 PM
Quote from: geezmo on June 12, 2006, 08:37:10 PM
That's the thing, I can't seem to find the er_who row in smf_settings table. (It's not really there, it's not about me being unable to find the row). What query can I run in mySQL that can hopefully address this er_who problem?


DELETE FROM `{$db_prefix}settings` WHERE `variable` = 'er_who' LIMIT 1
Title: Re: Reason For Editing Mod
Post by: geezmo on June 12, 2006, 09:10:27 PM
That did it. Thanks very much for the help. :)
Title: Re: Reason For Editing Mod
Post by: PrizeLive.com on June 30, 2006, 12:58:39 PM
Installed smoothly. Thanks!
Title: Re: Reason For Editing Mod
Post by: perplexed on July 14, 2006, 12:32:47 PM
I just installed on my test site and I entered a reason for editing the post, but where is the reason displayed?  I cant see it anywhere?
Title: Re: Reason For Editing Mod
Post by: PrizeLive.com on July 14, 2006, 12:42:20 PM
I made a screenshot for you.. It's displayed on the bottom of the post..

(http://img365.imageshack.us/img365/7528/untitled1rp1.png)
Title: Re: Reason For Editing Mod
Post by: winrules on July 14, 2006, 01:18:24 PM
Quote from: perplexed on July 14, 2006, 12:32:47 PM
I just installed on my test site and I entered a reason for editing the post, but where is the reason displayed?  I cant see it anywhere?
Also here is a close-up: http://mods.simplemachines.org/index.php?action=download;mod=349;id=15976;image :)
Title: Re: Reason For Editing Mod
Post by: perplexed on July 15, 2006, 11:29:03 AM
hey thanks for that, I tried it again and the reason is there, but it didnt show up yesterday.  maybe my fault

~thanks
Title: Re: Reason For Editing Mod
Post by: Sady on July 16, 2006, 12:07:30 PM
we just installed this mod on our forum and now the preview and quick modify buttons no longer work.  we uninstalled the mod and they still don't work.  any ideas what we need to do to completely uninstall this?
Title: Re: Reason For Editing Mod
Post by: perplexed on July 16, 2006, 12:52:58 PM
Looks like Winrules is away till 30th July. 

I have installed it on my forum 1.1RC2 today and those options are still working on mine.

Did you try uninstalling from package manager?  Otherwise, if you backed up before installing you could restore the backup?
Title: Re: Reason For Editing Mod
Post by: perplexed on July 16, 2006, 02:30:48 PM
I have been testing this mod out today and it seems that I have to edit the post 3 times before it will accept my edit.  Does it have anything to do with the courtesy wait time or editing time before it will be accepted?
Title: Re: Reason For Editing Mod
Post by: Sady on July 16, 2006, 04:27:33 PM
Quote from: perplexed on July 16, 2006, 12:52:58 PM
Did you try uninstalling from package manager?  Otherwise, if you backed up before installing you could restore the backup?

my other admin is the one who installed it so I don't know if he did a backup right before or not, but I do know that it was uninstalled from the package manager and it appeared to be successful.  that's why I don't understand why preview and quick modify still don't work.  I don't know enough about php to go through and find what was altered when the mod was installed.  would really appreciate anyone's help on this.  thanks

EDIT: nevermind... we fixed the problem.  thanks
Title: Re: Reason For Editing Mod
Post by: CyberOps on August 22, 2006, 03:16:13 PM
a version for RC3 would be great if possible
Title: Re: Reason For Editing Mod
Post by: winrules on August 22, 2006, 04:17:57 PM
Quote from: CyberOps on August 22, 2006, 03:16:13 PM
a version for RC3 would be great if possible
I agree :)

The only problem is I have 8 mods, and RC3 came out less then 24 hours ago...
I'll try and make this one the next one I convert :)
Title: Re: Reason For Editing Mod
Post by: Bigguy on August 22, 2006, 04:25:03 PM
I have this mod installed on RC3. Works awesome, if you change the version in the package-info.xml file it installs no problem.
Title: Re: Reason For Editing Mod
Post by: winrules on August 22, 2006, 04:27:14 PM
Quote from: Bigguy on August 22, 2006, 04:25:03 PM
I have this mod installed on RC3. Works awesome, if you change the version in the package-info.xml file it installs no problem.
Or download the new version (Version 1.13 has been released! This version adds support for 1.1 RC3.).
Title: Re: Reason For Editing Mod
Post by: Bigguy on August 22, 2006, 04:50:30 PM
Or I could do that, thanks, lol. I guess I was to anxiuos to get my board going with RC3

Quote from: winrules on August 22, 2006, 04:27:14 PM
Quote from: Bigguy on August 22, 2006, 04:25:03 PM
I have this mod installed on RC3. Works awesome, if you change the version in the package-info.xml file it installs no problem.
Or download the new version (Version 1.13 has been released! This version adds support for 1.1 RC3.).
Title: Re: Reason For Editing Mod
Post by: winrules on August 22, 2006, 04:58:51 PM
Quote from: Bigguy on August 22, 2006, 04:50:30 PM
Or I could do that, thanks, lol. I guess I was to anxiuos to get my board going with RC3

Quote from: winrules on August 22, 2006, 04:27:14 PM
Quote from: Bigguy on August 22, 2006, 04:25:03 PM
I have this mod installed on RC3. Works awesome, if you change the version in the package-info.xml file it installs no problem.
Or download the new version (Version 1.13 has been released! This version adds support for 1.1 RC3.).
You need to update you signature :)
Title: Re: Reason For Editing Mod
Post by: Bigguy on August 22, 2006, 05:12:56 PM
Thank you again, I will do that now. ;)
Title: Re: Reason For Editing Mod
Post by: Skipdawg on August 22, 2006, 05:26:01 PM
Oh man I forgot all about this Mod. Glad the update brought it back up. Will have to check it out. Like the concept allot.  8) ;D
Title: Re: Reason For Editing Mod
Post by: CyberOps on August 22, 2006, 05:49:38 PM
winrules thanks for doing it so quick :)
Title: Re: Reason For Editing Mod
Post by: satelitepro on September 27, 2006, 07:34:44 PM
Hello, excuse my English.

You wanted that you told myself as eliminating this mod in toto, as much in the database as in the file archive of my SMF, since when restoring the database he gives me errors and you don't allow me to publish any message.

Thank you.
Title: Re: Reason For Editing Mod
Post by: winrules on September 28, 2006, 04:54:38 PM
Can you try to go into more detail about the problem?

What errors are you getting?
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 03, 2006, 05:05:45 AM
I've gotten this error when I tried to install this mod ver 1.13 on SMF RC 3

Installation Readme
Sorry, but there is no upgrade package from your version. Please uninstall the previous version, and install this version. You won't lose any data.

Install Actions
Installations actions for "Reason For Editing Mod":
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.
Title: Re: Reason For Editing Mod
Post by: NEMINI on October 03, 2006, 06:33:21 AM
Is there a way to require this field when editting?
Title: Re: Reason For Editing Mod
Post by: winrules on October 03, 2006, 04:01:09 PM
Quote from: NEMINI on October 03, 2006, 06:33:21 AM
Is there a way to require this field when editting?
Not right now.
Title: Re: Reason For Editing Mod
Post by: ivo2296 on October 05, 2006, 12:44:04 AM
Hello,

Is there a way the reason text to be in red color?
Title: Re: Reason For Editing Mod
Post by: winrules on October 05, 2006, 04:43:04 PM
Quote from: ivo2296 on October 05, 2006, 12:44:04 AM
Hello,

Is there a way the reason text to be in red color?
The whole edited by line or just the reason?
Title: Re: Reason For Editing Mod
Post by: ivo2296 on October 05, 2006, 08:33:39 PM
Quote from: winrules on October 05, 2006, 04:43:04 PM
Quote from: ivo2296 on October 05, 2006, 12:44:04 AM
Hello,

Is there a way the reason text to be in red color?
The whole edited by line or just the reason?

I think whole line will be fine.

Thanks
Title: Re: Reason For Editing Mod
Post by: geezmo on October 08, 2006, 05:09:02 PM
Had this for 1.1RC2 but when I upgraded to 1.1RC3 and tried to install this mod, I got this Database Error:

Duplicate column name 'edit_reason'
File: /home/xxx/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 2

Help?

Title: Re: Reason For Editing Mod
Post by: winrules on October 08, 2006, 08:28:12 PM
Quote from: geezmo on October 08, 2006, 05:09:02 PM
Had this for 1.1RC2 but when I upgraded to 1.1RC3 and tried to install this mod, I got this Database Error:

Duplicate column name 'edit_reason'
File: /home/xxx/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 2

Help?


Delete the edit_reason column from the messages table and it should work.
Title: Re: Reason For Editing Mod
Post by: geezmo on October 08, 2006, 08:53:54 PM
I dropped it but when I tried to upgrade the mod, I got another error saying I need to drop another table called "er_who". I'm a newbie at these things so please tell me if there are other tables need to dropped and what the command is in phpmyadmin. Thanks.
Title: Re: Reason For Editing Mod
Post by: winrules on October 09, 2006, 04:17:15 PM

DELETE FROM `{$db_prefix}settings` WHERE `variable` = 'er_who' LIMIT 1

Substitute {$db_prefix} with your database prefix. Probobally "smf_".
Title: Re: Reason For Editing Mod
Post by: geezmo on October 10, 2006, 02:04:52 AM
Needed to delete one more table "edit_reason" in settings but anyway, thanks winrules, the mod's now working...
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 10, 2006, 05:10:23 AM
winrules, it seems like my forum doesn't like ur mod ...

after i upgraded my forum board from RC 2 or RC 3 i kept getting this error when i wanted to install your mod

Installation Readme
Sorry, but there is no upgrade package from your version. Please uninstall the previous version, and install this version. You won't lose any data.

Install Actions
Installations actions for "Reason For Editing Mod":
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.


it happened on 2 of ur mod that i had it install on the board previously .... i uninstall it and re-install it a couple of time but still didnt work.

this problem occur in Custom Action Mod too.
Title: Re: Reason For Editing Mod
Post by: NEMINI on October 10, 2006, 05:41:37 PM
Quote from: winrules on October 03, 2006, 04:01:09 PM
Quote from: NEMINI on October 03, 2006, 06:33:21 AM
Is there a way to require this field when editting?
Not right now.

Is this a possibility for a future version?
Title: Re: Reason For Editing Mod
Post by: winrules on October 10, 2006, 05:52:07 PM
Quote from: Vinspire on October 10, 2006, 05:10:23 AM
winrules, it seems like my forum doesn't like ur mod ...

after i upgraded my forum board from RC 2 or RC 3 i kept getting this error when i wanted to install your mod

Installation Readme
Sorry, but there is no upgrade package from your version. Please uninstall the previous version, and install this version. You won't lose any data.

Install Actions
Installations actions for "Reason For Editing Mod":
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.


it happened on 2 of ur mod that i had it install on the board previously .... i uninstall it and re-install it a couple of time but still didnt work.

this problem occur in Custom Action Mod too.
Remove any lines that say Reason For Editing Mod for in Packages/installed.list and it should work.


Quote from: NEMINI on October 10, 2006, 05:41:37 PM
Quote from: winrules on October 03, 2006, 04:01:09 PM
Quote from: NEMINI on October 03, 2006, 06:33:21 AM
Is there a way to require this field when editting?
Not right now.

Is this a possibility for a future version?
Maybe.
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 11, 2006, 04:13:54 AM
Quote from: winrules on October 10, 2006, 05:52:07 PM
Remove any lines that say Reason For Editing Mod for in Packages/installed.list and it should work.

Did what you said ... But i've received this error when I tried to apply the mod  :'(

Database Error
Duplicate column name 'edit_reason'
File: /home/korobox/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 2
Title: Re: Reason For Editing Mod
Post by: geezmo on October 11, 2006, 08:26:36 AM
Vinspire, delete that column in the smf_settings table. I had the same problem some posts up.
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 11, 2006, 08:36:17 AM
Quote from: geezmo on October 11, 2006, 08:26:36 AM
Vinspire, delete that column in the smf_settings table. I had the same problem some posts up.

Is this the one ?

Quote from: winrules on June 12, 2006, 08:44:13 PM

DELETE FROM `{$db_prefix}settings` WHERE `variable` = 'er_who' LIMIT 1


I've never played wif the database before and i am afraid i would screw it up :P
Title: Re: Reason For Editing Mod
Post by: geezmo on October 11, 2006, 07:32:47 PM
Yes, I think you need to delete three columns in two tables, including edit_reason and er_who. These columns will appear when you try re-installing the mod, you'll get the error that the database is already existing.
Title: Re: Reason For Editing Mod
Post by: richiehale on October 11, 2006, 09:51:07 PM
Problem installing upgrade.. any suggestions?? 

Apply Mod
Please remember to always make regular backups of your sources and database before installing mods, especially beta versions. 


!!Error in Package Installation

At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
Installation Readme
This will upgrade the mod from version 1.0 to 1.12.


Install Actions
Installations actions for "Reason For Editing Mod":
Installing this package will perform the following actions:  Type Action Description
1. Execute Code reasonforeditingupgrade.php 
2. Execute Modification ./Themes/default/Post.template.php Test failed
3. Execute Modification ./Themes/default/Display.template.php Test successful
4. Execute Modification ./Sources/Subs-Post.php Test successful
5. Execute Modification ./Sources/ModSettings.php Test successful
6. Execute Modification ./Sources/Post.php Test successful

Title: Re: Reason For Editing Mod
Post by: winrules on October 12, 2006, 04:09:05 PM
Have you changed anything with the mod in Display.template.php?
Title: Re: Reason For Editing Mod
Post by: richiehale on October 13, 2006, 07:15:38 AM
no
Title: Re: Reason For Editing Mod
Post by: perplexed on October 20, 2006, 11:52:14 AM
I have managed to install this mod finally but there is something interesting that happens with another mod

merge double posts

If you merge double posts and one of them has a 'reason for editing' comment, then it disappears

Title: Re: Reason For Editing Mod
Post by: winrules on October 20, 2006, 04:06:09 PM
You'll have to modify it to get it to move the reason for editing.
Title: Re: Reason For Editing Mod
Post by: perplexed on October 21, 2006, 03:42:16 AM
modify the reason for editing mod or the merge double posts mod?

(Sorry I'm catching up on things after being offline for a month or so)
Title: Re: Reason For Editing Mod
Post by: winrules on October 21, 2006, 12:47:52 PM
The merge double posts mod. I'm not quite sure how it works.
Title: Re: Reason For Editing Mod
Post by: perplexed on October 21, 2006, 07:20:40 PM
ok I will enquire tomorrow - thanks
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 22, 2006, 11:01:12 AM
Quote from: geezmo on October 11, 2006, 07:32:47 PM
Yes, I think you need to delete three columns in two tables, including edit_reason and er_who. These columns will appear when you try re-installing the mod, you'll get the error that the database is already existing.

I've gotten this error

Duplicate column name 'edit_reason'
File: /home/kokorobo/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 2

and when i put in

DELETE FROM `{$db_prefix}settings` WHERE `variable` = 'edit_reason' LIMIT 1

it gave me this error in phpmyadmin

Error

SQL query:

DELETE FROM `{$db_prefix}settings` WHERE `variable` = 'edit_reason' LIMIT 1

MySQL said: Documentation
#1146 - Table 'kokorobo_forum.{$db_prefix}settings' doesn't exist
Title: Re: Reason For Editing Mod
Post by: winrules on October 22, 2006, 11:02:50 AM
Replace {$db_prefix} with your database prefix. Probobally smf_.
Title: Re: Reason For Editing Mod
Post by: tekgik on October 22, 2006, 12:55:07 PM
Hi there, I installed this mod on 1.1 rc3 with tiny portal 0.96. Now im having a problem with the it, the editng reason doesnt show on my installed tiny portal theme (aero).

Do i have to manually edit a template file?

Thanks
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 22, 2006, 12:57:13 PM
Has this error been discussed. I looked through the thread but didn't see anything:

8: Undefined index: edit_reason
File: /home/****/public_html/smfhelper/Sources/Display.php
Line: 934
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 22, 2006, 01:53:22 PM
Quote from: tekgik on October 22, 2006, 12:55:07 PM
Hi there, I installed this mod on 1.1 rc3 with tiny portal 0.96. Now im having a problem with the it, the editng reason doesnt show on my installed tiny portal theme (aero).

Do i have to manually edit a template file?

Thanks

You need to edit the codes in aero theme manually to get it working :)
Title: Re: Reason For Editing Mod
Post by: winrules on October 22, 2006, 03:19:06 PM
Quote from: Bigguy on October 22, 2006, 12:57:13 PM
Has this error been discussed. I looked through the thread but didn't see anything:

8: Undefined index: edit_reason
File: /home/****/public_html/smfhelper/Sources/Display.php
Line: 934

What version do you have?
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 22, 2006, 03:54:05 PM
Reason For Editing Mod 1.13
Title: Re: Reason For Editing Mod
Post by: winrules on October 22, 2006, 05:10:18 PM
Can you post lines 930-940 in Display.php here?
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 22, 2006, 05:12:36 PM
Yep, here ya go:

'counter' => $counter,
'modified' => array(
'time' => timeformat($message['modifiedTime']),
'timestamp' => forum_time(true, $message['modifiedTime']),
'edit_reason' => $message['edit_reason'],
'name' => $message['modifiedName']
),
'body' => $message['body'],
'k_os' => $message['k_os'],
'k_br' => $message['k_br'],
'k_ver' => $message['k_ver'],
Title: Re: Reason For Editing Mod
Post by: winrules on October 22, 2006, 06:07:17 PM
When do you get that error?
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 22, 2006, 06:41:29 PM
Its in the error log. It makes like millions of pages of errors.
Title: Re: Reason For Editing Mod
Post by: winrules on October 22, 2006, 08:21:11 PM
Quote from: Bigguy on October 22, 2006, 06:41:29 PM
Its in the error log. It makes like millions of pages of errors.
I mean like what URL is it listed in.
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 22, 2006, 08:40:59 PM
You mean this:

http://www.smfhelper.com/index.php
Apply Filter: Only show the errors with the same message
8: Undefined index: edit_reason
File: /home/*****/public_html/smfhelper/Sources/Display.php
Line: 934
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 22, 2006, 10:59:33 PM
Quote from: winrules on October 22, 2006, 11:02:50 AM
Replace {$db_prefix} with your database prefix. Probobally smf_.

Did this, everything went smooth in phpmyadmin but when i tried installing the package. I've got the same error.

Database Error

Duplicate column name 'edit_reason'
File: /home/kokorobo/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 2
Title: Re: Reason For Editing Mod
Post by: winrules on October 23, 2006, 04:02:57 PM
Drop the edit_reason column from the messages table in phpMyAdmin.

/me makes a check if it already exists in next version
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 23, 2006, 11:35:17 PM
Quote from: winrules on October 23, 2006, 04:02:57 PM
Drop the edit_reason column from the messages table in phpMyAdmin.

/me makes a check if it already exists in next version

I don't understand what do you mean by drop the edit_reason  :'(
Title: Re: Reason For Editing Mod
Post by: winrules on October 24, 2006, 03:56:50 PM
ALTER TABLE {$db_prefix}messages DROP edit_reason
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 24, 2006, 04:37:02 PM
He has been able to drop edit_reason. Now he has another error about "er_who" It shows up in three spots in the db smf_messages, smf_personal_mesages and smf_settings. I figured I would relay this to you for him. He's not sure what which ones to drop.
Title: Re: Reason For Editing Mod
Post by: winrules on October 24, 2006, 04:45:34 PM
What is the exact error?
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 24, 2006, 05:07:25 PM
Same as the first he posted only it has er_who instead of edit reason. Here is the error:

Database Error

Duplicate entry 'er_who' for key 1
File: /home/******/public_html/forum/Packages/temp/reasonforeditinginstall.php
Line: 3


Title: Re: Reason For Editing Mod
Post by: winrules on October 24, 2006, 05:10:17 PM
DELETE FROM {$db_prefix}settings WHERE variable = 'er_who' LIMIT 1
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 24, 2006, 05:41:39 PM
Well either he will see this post or the one at my forum which I will point him to this one. :)
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 24, 2006, 10:03:55 PM
I found out what my error was i think. The edits weren't added to the display.php file in the Sources directory. I hope thats it, I am checking it out now.
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 25, 2006, 01:06:51 AM
Quote from: winrules on October 24, 2006, 05:10:17 PM
DELETE FROM {$db_prefix}settings WHERE variable = 'er_who' LIMIT 1

I've got this error when i posted this command.

(http://img146.imageshack.us/img146/9281/errorpv5.png) (http://imageshack.us)

Thanks bigguy for the help :)
Title: Re: Reason For Editing Mod
Post by: Harzem on October 25, 2006, 01:17:23 AM
Change {$db_prefix} to your smf prefix. Probably smf_
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 25, 2006, 03:56:19 AM
Quote from: HarzeM on October 25, 2006, 01:17:23 AM
Change {$db_prefix} to your smf prefix. Probably smf_

Tried this and i've gotten this error.

(http://img329.imageshack.us/img329/4306/error2qe3.png) (http://imageshack.us)
Title: Re: Reason For Editing Mod
Post by: Harzem on October 25, 2006, 04:17:26 AM
No, you'll change {$db_prefix} to smf_ :)


DELETE FROM smf_settings WHERE variable = 'er_who' LIMIT 1
Title: Re: Reason For Editing Mod
Post by: Vinspire on October 25, 2006, 04:34:18 AM
Quote from: HarzeM on October 25, 2006, 04:17:26 AM
No, you'll change {$db_prefix} to smf_ :)


DELETE FROM smf_settings WHERE variable = 'er_who' LIMIT 1

Just did this. Here is the screenshot of it.

(http://img96.imageshack.us/img96/7978/error2vq8.png) (http://imageshack.us)

and i've gotten back the edit_reason error  :'(

(http://img155.imageshack.us/img155/6840/error3ki4.png) (http://imageshack.us)
Title: Re: Reason For Editing Mod
Post by: Bigguy on October 25, 2006, 12:12:21 PM
You could go in and delete it manually, but do all of them have to be deleted or just the one in the settings table.
Title: Re: Reason For Editing Mod
Post by: winrules on October 25, 2006, 03:50:53 PM
http://www.simplemachines.org/community/index.php?topic=117045.msg762825#msg762825
Title: Re: Reason For Editing Mod
Post by: Vinspire on November 05, 2006, 02:51:23 AM
Quote from: winrules on October 25, 2006, 03:50:53 PM
http://www.simplemachines.org/community/index.php?topic=117045.msg762825#msg762825

Huh ? dont understand this.
Title: Re: Reason For Editing Mod
Post by: winrules on November 05, 2006, 10:22:30 AM
Sorry, linked to the wrong post.

http://www.simplemachines.org/community/index.php?topic=89012.msg781655#msg781655
Title: Re: Reason For Editing Mod
Post by: Pedja on November 06, 2006, 02:55:26 AM
A suggestion: make this mod work on message deletion too. That is also kind of editing, and if forum is set to move deleted messges to specific board instead of actually deleting it, edit reason could be used do inform why message is deleted which would be very useful.
Title: Re: Reason For Editing Mod
Post by: DemonicInfluence on November 15, 2006, 04:43:01 PM
I think this mod should work in ajax editing. That would be so useful
Title: Re: Reason For Editing Mod
Post by: trenchteam on November 18, 2006, 02:48:51 AM
It would be great if it would include a soft delete so that admins can still view what was deleted or modified.
Title: Re: Reason For Editing Mod
Post by: ivo2296 on November 27, 2006, 12:16:35 AM
Quote from: ivo2296 on October 05, 2006, 08:33:39 PM
Quote from: winrules on October 05, 2006, 04:43:04 PM
Quote from: ivo2296 on October 05, 2006, 12:44:04 AM
Hello,

Is there a way the reason text to be in red color?
The whole edited by line or just the reason?

I think whole line will be fine.

Thanks


Any chance to have it red :) ?
Title: Re: Reason For Editing Mod
Post by: ladyshanae on November 28, 2006, 07:47:51 AM
Not terribly important, but a curious question.  I know php reads things differently, but I don't know enough about it to know how to fix this (or if it can be fixed).  Whenever myself or my mods edit a post and use an apostrophe, it adds a slash.  For example:

QuoteYou don't need to use . . . blah blah blah

turns into:

QuoteYou don\'t need to use . . blah blah blah

So, yes . . . anyway to get rid of the slash?
Title: Re: Reason For Editing Mod
Post by: KHVT on November 29, 2006, 01:35:04 AM
I'm using SMF 1.1RC3, when added Reason for Editting mod, I found in Forum Error log:
8: Use of undefined constant er_who - assumed 'er_who'
File: /home2/domain/public_html/forum/Themes/default/Post.template.php (eval?)

8: Use of undefined constant er_who - assumed 'er_who'
File: /home2/domain/public_html/forum/Themes/default/languages/Modifications.vietnamese-utf8.php (eval?)

File: Modifications.vietnamese-utf8.php:

<?php
?>


I don't know what happen with my forum, plz help me!
Thanks before!
Title: Re: Reason For Editing Mod
Post by: winrules on November 30, 2006, 08:26:19 PM
You will have to copy the er_who language string from Post.english.php to Post.vietnamese-utf8.php.
Title: Re: Reason For Editing Mod
Post by: KHVT on November 30, 2006, 09:19:28 PM
Thanks Winrules!
It's working perfectly!  ;)
Title: Re: Reason For Editing Mod
Post by: marinelife on December 08, 2006, 08:26:57 AM
Will this mod be made to work with 1.1 final
Title: Re: Reason For Editing Mod
Post by: marinelife on December 14, 2006, 01:20:21 PM
anyone?
Title: Re: Reason For Editing Mod
Post by: creatures on December 14, 2006, 08:21:38 PM
It looks like a good mod if there will be available version for 1.1 final I am gonna have a test drive :)
Title: Re: Reason For Editing Mod
Post by: marinelife on December 14, 2006, 09:15:35 PM
I used it on RC3 and it was great, it really should just be standard on SMF
Title: Re: Reason For Editing Mod
Post by: creatures on December 15, 2006, 02:37:34 AM
Quote from: marinelife on December 14, 2006, 09:15:35 PM
I used it on RC3 and it was great, it really should just be standard on SMF
I have seen a mod or default on vbulletin. In fact I have never used vbulletin.

I am waiting for the update version for that mod :)
Title: Re: Reason For Editing Mod
Post by: 05185736 on December 16, 2006, 08:31:38 AM
Quote from: creatures on December 15, 2006, 02:37:34 AM
Quote from: marinelife on December 14, 2006, 09:15:35 PM
I used it on RC3 and it was great, it really should just be standard on SMF
I have seen a mod or default on vbulletin. In fact I have never used vbulletin.

I am waiting for the update version for that mod :)

same here, waiting eagerly for 1.1
Title: Re: Reason For Editing Mod
Post by: geezmo on December 16, 2006, 05:29:43 PM
waiting for 1.1 version too...
Title: Re: Reason For Editing Mod
Post by: Fatherguido on December 19, 2006, 06:45:18 AM
Quote from: geezmo on December 16, 2006, 05:29:43 PM
waiting for 1.1 version too...
<getting in line> ;)
Title: Re: Reason For Editing Mod
Post by: 05185736 on December 19, 2006, 07:47:04 AM
why do we have to wait when SMF updates because i don't think we ever had to wait when Phpbb did but i do prefer SMF
Title: Re: Reason For Editing Mod
Post by: Fatherguido on December 19, 2006, 08:11:46 AM
because the mod updates are done by the individuals that create the Mods ....... It's not like they are getting paid for it so they determine if it is a priority or not.

Until then, I brought a pup tent and some snacks - in case it is going to be a while  :D
Title: Re: Reason For Editing Mod
Post by: Fatherguido on December 23, 2006, 08:20:06 PM
Singing

All I want for Christmas is
the Reason for editing mod,
is the reason for editing mod,
the reason for editing mod,

Gee, if I could only
have the reason for editing mod,
then I could wish you
"Merry Christmas."
Title: Re: Reason For Editing Mod
Post by: 05185736 on December 23, 2006, 08:33:40 PM
hopefully SMF will figure something out which means we don't have to keep waiting for updated mods
Title: Re: Reason For Editing Mod
Post by: marinelife on December 23, 2006, 08:39:23 PM
This mod should just be a default feature
Title: Re: Reason For Editing Mod
Post by: Fatherguido on December 23, 2006, 08:57:18 PM
Quote from: marinelife on December 23, 2006, 08:39:23 PM
This mod should just be a default feature
I couldn't agree more
Title: Re: Reason For Editing Mod
Post by: winrules on December 23, 2006, 10:51:29 PM
Version 1.14 adds 1.1 and 1.1.1 compatibillity.
Title: Re: Reason For Editing Mod
Post by: marinelife on December 23, 2006, 10:52:50 PM
Is this mod version out
Title: Re: Reason For Editing Mod
Post by: marinelife on December 23, 2006, 10:55:02 PM
ok got the mod, test site shows this
Blank page with this
Fatal error: Call to undefined function: upgrade_query() in /home/****/*****/mts/Packages/temp/reasonforeditinginstall.php on line 3

Default theme and TP
Title: Re: Reason For Editing Mod
Post by: winrules on December 23, 2006, 10:57:16 PM
Quote from: marinelife on December 23, 2006, 10:55:02 PM
ok got the mod, test site shows this
Blank page with this
Fatal error: Call to undefined function: upgrade_query() in /home/****/*****/mts/Packages/temp/reasonforeditinginstall.php on line 3

Default theme and TP

Can you redownload it and try again. I uploaded the wrong file at first. It should be fixed now.
Title: Re: Reason For Editing Mod
Post by: marinelife on December 23, 2006, 10:59:20 PM
yes it is working now, thanks so much, this is a great mod!!!!!!!!!!!!!!!!!!!! :D ;D
Title: Re: Reason For Editing Mod
Post by: Fatherguido on December 24, 2006, 07:38:01 AM
Yes Virginia ........... Santa Claus is real!!!! Thank you


Merry Christmas!!!
Title: Re: Reason For Editing Mod
Post by: creatures on December 24, 2006, 10:59:10 AM
Quote from: winrules on December 23, 2006, 10:51:29 PM
Version 1.14 adds 1.1 and 1.1.1 compatibillity.

Yeah thanks for updating to version 1.1.1

I have installed it and had encouraged no problem.

Good mod and cheers for you  ;D
Title: Re: Reason For Editing Mod
Post by: Greek on December 24, 2006, 02:18:38 PM
Thanks. It works.
Title: Re: Reason For Editing Mod
Post by: saosangmo on January 04, 2007, 05:33:22 AM
When I use quick edit button to edit my post, i can't note my reason on this screen.
I wonder if you apply this mod to quick-edit function?
thanks
Title: Re: Reason For Editing Mod
Post by: winrules on January 04, 2007, 11:30:49 AM
It doesn't currently work on quick edit.
Title: Re: Reason For Editing Mod
Post by: buhaychat.com on January 04, 2007, 12:32:28 PM
this mod works now on 1.1.1 .. yay! thanks!
Title: Re: Reason For Editing Mod
Post by: oxlo on January 11, 2007, 08:09:26 PM
Hello.

This is a very functionally Mod and works very well on 1.1.1. Thanks a lot.

I only have a question:

Is possible to add an option for design any member group, by GROUP ID, to allow any 'reason for edit' post?

Thanks again.

Regards.
Title: Re: Reason For Editing Mod
Post by: JeffersonRyan on January 13, 2007, 10:57:39 PM
I don´t know if it´s a bug in the mod or in my setup, but whenever I do a first edit in a message and cut and past a long reason (50 or more words), the entire "last edit" line is not shown, but the message IS edited.

I.E: The user may edit his/her message without leaving a trace.

Worried, I uninstalled the mod. I will try again in a test forum.

I´m running SMF 1.1.1 with Tinyportal 0.971
Title: Re: Reason For Editing Mod
Post by: winrules on January 13, 2007, 11:37:06 PM
Oxlo - That may be a possiblility in future versions.

JeffersonRyan - Did you get any errors in your error log?
Title: Re: Reason For Editing Mod
Post by: JeffersonRyan on January 14, 2007, 09:26:20 AM
Quote from: winrules on January 13, 2007, 11:37:06 PM
Oxlo - That may be a possiblility in future versions.

JeffersonRyan - Did you get any errors in your error log?

I have *a lot* of errors here, the majority *I think* are related to a language file issue, that I don´t know how to solve yet:

8: Undefined variable: txt
Ficheiro: /home/jeffryan/public_html/smf/Sources/Load.php
Linha: 2319


There are others that *I think* are related to this issue:

8: Undefined index: ajax_in_progress
Ficheiro: /home/jeffryan/public_html/smf/Themes/default/MessageIndex.template.php (eval?)
Linha: 534

8: Undefined index: mark_read_short
Ficheiro: /home/jeffryan/public_html/smf/Themes/default/MessageIndex.template.php (eval?)
Linha: 728

8: Undefined index: pm_short
Ficheiro: /home/jeffryan/public_html/smf/Themes/default/MessageIndex.template.php (eval?)
Linha: 657

8: Undefined index: hello_member_ndt
Ficheiro: /home/jeffryan/public_html/smf/Themes/default/MessageIndex.template.php (eval?)
Linha: 255


Sorry for my English. My natural language is Brazilian Portuguese.


Edit: The errors above seems related to my Tinyportal installation. I uninstalled all my mods except TP and I continue getting these errors
Title: Re: Reason For Editing Mod
Post by: JeffersonRyan on January 14, 2007, 09:53:27 AM
I just found some errors really related to your mod:

http://ryan.com.br/smf/index.php?action=packages;sa=install2;package=reasonforediting1-14.zip
8: Undefined variable: txt
File: /home/jeffryan/public_html/smf/Sources/Load.php
Line: 2319

http://ryan.com.br/smf/index.php?action=packages;sa=install2;package=reasonforediting1-14.zip
8: Undefined variable: found
File: /home/jeffryan/public_html/smf/Packages/temp/reasonforeditinginstall.php
Line: 8

http://ryan.com.br/smf/index.php?action=packages;sa=install2;package=reasonforediting1-14.zip
2: Missing argument 3 for db_query()
File: /home/jeffryan/public_html/smf/Sources/Subs.php
Line: 238

http://ryan.com.br/smf/index.php?action=packages;sa=install2;package=reasonforediting1-14.zip
2: Missing argument 2 for db_query()
File: /home/jeffryan/public_html/smf/Sources/Subs.php
Line: 238

http://ryan.com.br/smf/index.php?action=packages;sa=install;package=reasonforediting1-14.zip
8: Undefined variable: txt
File: /home/jeffryan/public_html/smf/Sources/Load.php
Line: 2319


I don´t understand. The package was installed successfully and these errors seems related (at the top of my SMF ignorance) to the installation, not the use.  :(
Title: Re: Reason For Editing Mod
Post by: JeffersonRyan on January 14, 2007, 10:10:42 AM
For the record, the "8: Undefined variable: txt" error seems related to the LanguageDrop mod that I installed previously.

Title: Re: Reason For Editing Mod
Post by: Kajol on January 15, 2007, 11:02:38 AM
I don't know what I am doing wrong, but this Mod - how senseful it can be - is not working.
I got the following Database error:

Field 'edit_reason' doesn't have a default value
Datei: E:\Apache2\htdocs\smf\Sources\Subs-Post.php
Zeile: 1518


It was a good Idea to test it on my local version first.
I have the newest version of SMF installed.

Knows someone what the problem could be?
Title: Re: Reason For Editing Mod
Post by: Farmacija on January 22, 2007, 08:33:20 AM
ok, i install it wirhout any problems but it would be like if it can have bb code support because in that way the reason for editing colud be in red color for example and users will notice that edit faster. 
Title: Re: Reason For Editing Mod
Post by: choloman05 on January 23, 2007, 10:35:52 PM
Hello and thanks for the mod. Nice job.
I have so far gotten these two errors in my error log. Any clue on what needs to be done here? Thank you. 

8: Undefined variable: found
File: /*******/testing/Packages/temp/reasonforeditinginstall.php
Line: 8

2: Missing argument 3 for db_query()
File: /******/testing/Sources/Subs.php
Line: 238

Title: Re: Reason For Editing Mod
Post by: lexhair on January 26, 2007, 01:02:14 PM
Most of my edits are linking existing events to the calendar which leaves behind the "Last edit..." Doesn't look like this mod will allow me to edit in this case. True?
Title: Re: Reason For Editing Mod
Post by: Kajol on January 29, 2007, 06:43:55 AM
i think here is no one who can help because of our errors, or what?
Title: Re: Reason For Editing Mod
Post by: Farmacija on January 29, 2007, 09:39:32 AM
yes it looks like that
Title: Re: Reason For Editing Mod
Post by: winrules on January 31, 2007, 08:19:04 PM
Don't worry about the installation errors.

Kajol, do you have MySQL in Strict mode?
Title: Re: Reason For Editing Mod
Post by: lexhair on February 01, 2007, 10:58:28 AM
Quote from: Farmacija on January 22, 2007, 08:33:20 AM
ok, i install it wirhout any problems but it would be like if it can have bb code support because in that way the reason for editing colud be in red color for example and users will notice that edit faster. 
You can do this by editing the style.css for your theme.

1. Create a class with the attributes you want and save it in the style.css file. I called the class ".editformat" for this example.
2. Edit your theme's Display.Template.php file. Search for the text "// Show "« Last Edit: Time by Person »" if this post was edited."
3. In the code line above it:
Replace:<td valign="bottom" class="smalltext" id="modified_', $message['id'], '">';With:<td valign="bottom" class="editformat" id="modified_', $message['id'], '">';  
Title: Re: Reason For Editing Mod
Post by: Farmacija on February 02, 2007, 07:42:31 AM
ok thanks, i put this class .editformat
{

   font-weight: normal;
   color: green;
}

but i would just the reason of editing be in different color, how i can do that?

and it would be nice if this change of color appear just when moderator edit message, not user by himself...
Title: Re: Reason For Editing Mod
Post by: lexhair on February 04, 2007, 01:07:57 PM
Code deleted due to excessive errors.
Title: Re: Reason For Editing Mod
Post by: Farmacija on February 05, 2007, 04:13:54 AM
no, its still the same  
Title: Re: Reason For Editing Mod
Post by: lexhair on February 05, 2007, 09:46:40 AM
Quote from: Farmacija on February 05, 2007, 04:13:54 AM
no, its still the same 
Do you have multiple administrators?
Title: Re: Reason For Editing Mod
Post by: Farmacija on February 06, 2007, 03:52:55 AM
No. Just one.  
Title: Re: Reason For Editing Mod
Post by: lexhair on February 06, 2007, 03:24:08 PM
Quote from: lexhair on January 26, 2007, 01:02:14 PM
Most of my edits are linking existing events to the calendar which leaves behind the "Last edit..." Doesn't look like this mod will allow me to edit in this case. True?
Answering my own question...it does when I use the Modify button.
Title: Re: Reason For Editing Mod
Post by: malapija on February 06, 2007, 04:58:23 PM
i've just installed this mod on my smf v. 1.1.1 but it doesn't work. i can fill in the reason for editing but it won't appear in the message then. and when i try to uninstall the mod it shows this error:

Incorrect table name ''
File: /mnt/data/accounts/e/entheobotanika/data/www/smf/Packages/temp/reasonforeditinguninstall.php
Line: 2
Title: Re: Reason For Editing Mod
Post by: MoreBloodWine on February 06, 2007, 10:53:53 PM
SMF 1.1.1 - TP 0.9.7.1

No errors as far as I can tell... anyway the reason box shows up on the post page when I hit the modify button but the reason doesnt show up on the post... it just shows what it would normally show...

« Last Edit: Today at 10:50:10 PM by MoreBloodWine »

Edit : It works fine on the default theme so it has to be something with my custom theme I just dont know what... and I know I did the hand edits fine on the files needed to be modified...
Title: Re: Reason For Editing Mod
Post by: [Lucien] on February 07, 2007, 10:03:17 AM
Love this mod, working perfectly with the helios theme  :D

Thanks  :)
Title: Re: Reason For Editing Mod
Post by: MoreBloodWine on February 10, 2007, 07:43:55 AM
bump...

Quote from: MoreBloodWine on February 06, 2007, 10:53:53 PM
SMF 1.1.1 - TP 0.9.7.1

No errors as far as I can tell... anyway the reason box shows up on the post page when I hit the modify button but the reason doesnt show up on the post... it just shows what it would normally show...

« Last Edit: Today at 10:50:10 PM by MoreBloodWine »

Edit : It works fine on the default theme so it has to be something with my custom theme I just dont know what... and I know I did the hand edits fine on the files needed to be modified...
Title: Re: Reason For Editing Mod
Post by: MoreBloodWine on February 12, 2007, 11:37:08 PM
Problem solved... on my own...
Title: Re: Reason For Editing Mod
Post by: Zenigata on February 15, 2007, 08:58:23 AM
Quote from: winrules on January 04, 2007, 11:30:49 AM
It doesn't currently work on quick edit.

Please add support for quick edit. Thanks.
Title: Re: Reason For Editing Mod
Post by: jonopow on February 17, 2007, 08:13:01 AM
Quote from: MoreBloodWine on February 12, 2007, 11:37:08 PM
Problem solved... on my own...
Would you like to share your solution with everybody?  
Title: Re: Reason For Editing Mod
Post by: MoreBloodWine on February 17, 2007, 08:25:44 AM
little hard to explain really lol... I kinda did it by accident, but it had to do with some spacing and a missing character... but surprised no one offered to help before I got lucky on my own heh...
Title: Re: Reason For Editing Mod
Post by: lostinphp on February 18, 2007, 06:02:51 AM
Had this same problem with the Amber theme. Won't leave a "reason" ,but when I switch back to Core theme, the message is there. Just not working correctly with some specific themes.
Title: Re: Reason For Editing Mod
Post by: Bigguy on February 18, 2007, 11:45:18 PM
It sounds like you have not edited the amber theme so it will show the reason. Package modifications only install to the default theme so if you are using a theme other then the default then you have to do some manual editing. :)
Title: Re: Reason For Editing Mod
Post by: Farmacija on February 26, 2007, 08:36:57 AM
hm, probably bug but when i select that just admn and moderators can see reason for editing in Admin panel, just Administrator really have that permission, moderators still doesnt have it?
Title: Re: Reason For Editing Mod
Post by: 4creator on March 02, 2007, 11:07:34 PM
Great Mod, thanks!  ;)

Is there any way to make this Mod work with the multiple language?
When I comment in Japanese, they got garbled (english is fine).
Title: Re: Reason For Editing Mod
Post by: xtremebass on March 02, 2007, 11:10:26 PM
Can't we just rename our current Theme folder to Default, and then change the Theme paths in the admin?
Title: Re: Reason For Editing Mod
Post by: lexhair on March 03, 2007, 08:58:09 AM
Quote from: xtremebass on March 02, 2007, 11:10:26 PM
Can't we just rename our current Theme folder to Default, and then change the Theme paths in the admin?
You DO NOT want to do that. There are so many things that will go wrong...
Title: Re: Reason For Editing Mod
Post by: Gorm on March 04, 2007, 08:21:03 AM
Quote from: Farmacija on February 26, 2007, 08:36:57 AM
hm, probably bug but when i select that just admn and moderators can see reason for editing in Admin panel, just Administrator really have that permission, moderators still doesnt have it?

I have the same problem, can the reason be that I use "Global moderators"?

/Johan 
Title: Re: Reason For Editing Mod
Post by: Gorm on March 23, 2007, 07:31:23 AM
Anyone?  
Title: Re: Reason For Editing Mod
Post by: dDOTr2 on March 25, 2007, 12:30:59 PM
well, its a nice mod. it worked great for me under Dilber MC theme without any edit. but i m getting these errors. someone plz tell me how to fix this or can i ignore this( if thers no impact). btw i m using 1.1.2 version.

thanks in advance.

http://localhost/indiamusics/index.php?action=packages;sa=install2;package=reasonforediting1-14.zip
8: Undefined variable: found
File: C:\wamp\www\indiamusics\Packages\temp\reasonforeditinginstall.php
Line: 8


http://localhost/indiamusics/index.php?action=packages;sa=install2;package=reasonforediting1-14.zip
2: Missing argument 3 for db_query(), called in C:\wamp\www\indiamusics\Packages\temp\reasonforeditinginstall.php on line 5 and defined
File: C:\wamp\www\indiamusics\Sources\Subs.php
Line: 238


http://localhost/indiamusics/index.php?action=packages;sa=install2;package=reasonforediting1-14.zip
2: Missing argument 2 for db_query(), called in C:\wamp\www\indiamusics\Packages\temp\reasonforeditinginstall.php on line 5 and defined
File: C:\wamp\www\indiamusics\Sources\Subs.php
Line: 238
Title: Re: Reason For Editing Mod
Post by: pulkit on April 13, 2007, 09:45:58 AM
Hi,

This is a great mod ... Worked very well with the core theme (on 1.1.2) but ever since I have switched to TP 0.9.8 with Mesh TP theme, it does not work.
It still asks for the reason for editing but does not display it. Is there any fix for this ??
Title: Re: Reason For Editing Mod
Post by: Kajol on April 14, 2007, 08:52:42 AM
Quote from: winrules on January 31, 2007, 08:19:04 PM
Kajol, do you have MySQL in Strict mode?

No, I asked and they told me that it has strict mode off. but it doesn't work. :-(
Title: Re: Reason For Editing Mod
Post by: dampier on April 22, 2007, 02:16:48 PM
Had this question/suggestion from one of my users:

A while after my first edit, I needed to make another change. The Reason For Edit box was blank, but that didn't bother me. I assumed that my original edit reason would remain at the bottom of the post. It didn't.

Is there a way to make the Reason For Edit box default to the reason previously entered? Or make the reason persist unless changed?


Thoughts?
Title: Re: Reason For Editing Mod
Post by: pulkit on April 22, 2007, 03:01:12 PM
http://www.simplemachines.org/community/index.php?topic=89012.msg1050776#msg1050776

Sorry 4 da bump
Title: Re: Reason For Editing Mod
Post by: linexp on April 25, 2007, 01:29:34 PM
i installed it on my site with the edited dilbert theme. the users do get the box where they enter the reason but the reason isn't displayed. how do i see what the reason for editing was?
Title: Re: Reason For Editing Mod
Post by: pulkit on April 25, 2007, 05:31:31 PM
Quote from: linexp on April 25, 2007, 01:29:34 PM
i installed it on my site with the edited dilbert theme. the users do get the box where they enter the reason but the reason isn't displayed. how do i see what the reason for editing was?

exactly my question but with a different theme ...
Title: Re: Reason For Editing Mod
Post by: pulkit on May 14, 2007, 12:34:34 PM
http://www.simplemachines.org/community/index.php?topic=89012.msg1064816#msg1064816

Sorry 4 da bump
Title: Re: Reason For Editing Mod
Post by: ldk on May 30, 2007, 09:28:30 AM
I was able to make these slashes not show up by using "stripslashes" in Display.template.php where you display this information.

Quote from: ladyshanae on November 28, 2006, 07:47:51 AM
Not terribly important, but a curious question.  I know php reads things differently, but I don't know enough about it to know how to fix this (or if it can be fixed).  Whenever myself or my mods edit a post and use an apostrophe, it adds a slash.  For example:

QuoteYou don't need to use . . . blah blah blah

turns into:

QuoteYou don\'t need to use . . blah blah blah

So, yes . . . anyway to get rid of the slash?
Title: Re: Reason For Editing Mod
Post by: angelofwisdom on May 30, 2007, 02:31:11 PM
I don't know if this has already been said, but I'll say it anyway :P
Some things I'd like to see changed:

1) When I edit and give a reason, I'd like to have that reason written on the Reason box when I edit it later. This way, I don't have to rewrite the reason if it is something like "typos" (which would be the reason of the second and third edits, for example)

2) slashes ... the previous post explains it :P

3) could you make a Reason box to appear with the Inline Edit? So that when a post is moderated, I don't have to use the Modify link to show a reason ... I could just write it below the edited post with the inline editor.

Great mod, anyway :)
Title: Re: Reason For Editing Mod
Post by: ldk on May 30, 2007, 04:30:11 PM
I would love to see it show up with the inline editor too. I tried to figure it out myself but no luck.
Title: Re: Reason For Editing Mod
Post by: greyknight17 on June 05, 2007, 08:27:22 PM
Ran into a problem. I have a custom theme installed (Neon) on SMF 1.1.2. I edited all the files needed for the Reason For Editing Mod and tried to run that PHP install file, but got this error:

Fatal error: Call to undefined function db_query() in D:\wamp\www\SMF112\reasonforeditinginstall.php on line 3

That line it's referring to is just:

$request = db_query("

What's the problem here and how to get it working?

Thanks.
Title: Re: Reason For Editing Mod
Post by: chep on June 05, 2007, 08:47:38 PM
function db_query should be defined inside smf112\sources\Subs.php

I don't know how to fix it. However if you cannot find that function inside Subs.php that would indicate the source of your problem. You could always try adding it back in there if it is missing or try installing on the core theme first...


EDIT:
Read a little closer and understand that you are not trying to install this via the package manager or even inside SMF. so....

You probably can't\shouldn't run "reasonforeditinginstall.php" outside of SMF because it needs to call into Subs.php to utilize the db_query function. It can't see that function unless it is run inside the SMF forum or you hacked it by including it somehow...

The first thing I would try is to install the package to the core theme. Then edit the other necessary theme files manually. If you do that then it should create the database tables for you and you would not need to run reasonforeditinginstall.php outside of SMF.

Otherwise if I was really desperate I would copy and paste that function out of subs.php then into reasonforeditinginstall.php and try it.... You could get lucky or it could get even more complicated though... Don't blame me if it doesn't work for you.

The whole error makes sense actually...
Title: Re: Reason For Editing Mod
Post by: greyknight17 on June 05, 2007, 11:28:06 PM
No problem. It will all be done on a test forum first before going live ;)

Should have done that earlier. Will run it on core theme so it runs the database query there. Thanks.
Title: Re: Reason For Editing Mod
Post by: erlend_sh on July 10, 2007, 04:58:56 PM
Title: Re: Reason For Editing Mod
Post by: delta5 on July 26, 2007, 10:56:23 PM
Will this mod work with 1.1.3?
Title: Re: Reason For Editing Mod
Post by: delta5 on July 26, 2007, 11:18:30 PM
This seems to install correctly on 1.1.3, but I cant get it to work, or find any settings for it. Any ideas?
Title: Re: Reason For Editing Mod
Post by: pulkit on August 07, 2007, 05:09:27 AM
http://www.simplemachines.org/community/index.php?topic=89012.msg1050776#msg1050776
Title: Re: Reason For Editing Mod
Post by: Diven on August 18, 2007, 04:56:44 PM
Well.. Sadr said I should link you to my request over in the Mod Request board.
So, here (http://www.simplemachines.org/community/index.php?topic=189605.0) you are..
Title: Re: Reason For Editing Mod
Post by: Farmacija on August 18, 2007, 06:25:33 PM
yes, it sholud add that just moderators can write reason for editing.
Title: Re: Reason For Editing Mod
Post by: ~Unkn0wn~ on August 18, 2007, 11:12:24 PM
how to make it work on 1.1.3
Title: Re: Reason For Editing Mod
Post by: erlend_sh on August 19, 2007, 06:06:34 PM
I've even tried to pm winrules about checking out the latest replies to his mod, but he seems to be out of reach. So, just, don't get your hopes up.

Quote from: assasinkilla on August 18, 2007, 11:12:24 PM
how to make it work on 1.1.3
- It works for 1.1.3, it just doesn't say so in the description yet. I just installed it without any problems on my 1.1.3 forum.
Title: Re: Reason For Editing Mod
Post by: Vinspire on August 19, 2007, 10:03:21 PM
Quote from: Sadr on August 19, 2007, 06:06:34 PM
I've even tried to pm winrules about checking out the latest replies to his mod, but he seems to be out of reach. So, just, don't get your hopes up.

Quote from: assasinkilla on August 18, 2007, 11:12:24 PM
how to make it work on 1.1.3
- It works for 1.1.3, it just doesn't say so in the description yet. I just installed it without any problems on my 1.1.3 forum.

I tried installing mine but it doesn't seems to work. Using the package and also manual installation. Weird.
Title: Re: Reason For Editing Mod
Post by: pulkit on September 07, 2007, 05:36:14 AM
And like my other posts in this thread, this one too should be completely ignored ...
Title: Re: Reason For Editing Mod
Post by: edi67 on September 13, 2007, 05:05:04 AM
nice mod , but you can make it MUI for multilanguage users?
Title: Re: Reason For Editing Mod
Post by: Neorics on September 24, 2007, 03:25:22 PM
i'm using smf 1.1.3 + tiny portal + cerberus theme and i'm getting an installation error for display.php so i used the package unpacker to install it manually but i cant find the line

ID_MSG, icon, subject, posterTime, posterIP, ID_MEMBER, modifiedTime, modifiedName, body,
or anything similar to that one so i dont know where to add the edit_reason, that it's suppose to add, is that code important?
Title: Re: Reason For Editing Mod
Post by: Trinny on October 11, 2007, 08:41:10 AM
Is anyone supporting this mod anymore? I see a lot of questions, but many are going unanswered...

I'm on 1.1.4, and the mod works fine on the default theme. Can anyone tell me why I have to edit TWICE to get the reason to show on helios multi?
Title: Re: Reason For Editing Mod
Post by: higherauthority on October 13, 2007, 04:13:04 PM
Great mod this is exactly what I needed.   Is there any way to set permissions so if someone edits their post they can not unless they type a reason in the field?  I cant seem to find the permissions or see it in features and options.

Im running 1.1.4 smf with mod 1.1.4 just downloaded it today
Title: Re: Reason For Editing Mod
Post by: Teunel on November 23, 2007, 11:39:19 AM
Hi,

I'm using this mod for my Moderators and Admins to edit user posts. I like it very much, but there's one little thing that Id like: Send the user a Personal Message when a mod edits his or her post.

Is this possable?
Title: Re: Reason For Editing Mod
Post by: dumblonde on January 07, 2008, 10:51:55 PM
I installed this & it looked like a successful install.  When I go to modify someones post there is now a box for me to fill in the reason but once I post the post the reason does not show up  ::)  Is there some setting I need to change to get this to work?

Thanks
Title: Re: Reason For Editing Mod
Post by: dumblonde on January 11, 2008, 09:13:03 PM
I understand that because I am not running a default theme that I need to manually do something to get this (& other mods) to work with my theme (cool mint & blue v1.0). 

If someone could direct me to a place where I can read & learn how to make these mods work with my theme I would greatly appreciate it or if you could just tell me where to insert & what to insert this info to get it working I would appreciate it.

Thanjs
Title: Re: Reason For Editing Mod
Post by: TrueSatan on January 11, 2008, 09:46:26 PM
Sure...official documentation links as follows:

Please read:

http://docs.simplemachines.org/index.php?topic=402.msg531#msg531 (http://docs.simplemachines.org/index.php?topic=402.msg531#msg531)

http://www.simplemachines.org/community/index.php?topic=34526.0 (http://www.simplemachines.org/community/index.php?topic=34526.0)

The following may also prove helpful:

http://modparser.dev.dansoftaustralia.net/ (http://modparser.dev.dansoftaustralia.net/)

Mirror of the last link:
Title: Re: Reason For Editing Mod
Post by: dumblonde on January 11, 2008, 10:56:52 PM
Thanks satan.  That looks like the kind of info I need to get me at least on the road to understanding some of this stuff  :D
Title: Re: Reason For Editing Mod
Post by: matt_hardwick on February 23, 2008, 06:29:20 PM
it's disabled the last edited on all new posts? Is this a theme thing?
Title: Re: Reason For Editing Mod
Post by: erlend_sh on February 24, 2008, 11:44:23 AM
Quote from: matt_hardwick on February 23, 2008, 06:29:20 PM
it's disabled the last edited on all new posts? Is this a theme thing?
Nope, works on all themes without any edits as far as my testing goes.
Title: Re: Reason For Editing Mod
Post by: Nibogo on February 27, 2008, 09:38:41 PM
this mod work with smf 1.1.4?
Title: Re: Reason For Editing Mod
Post by: erlend_sh on February 28, 2008, 10:50:18 AM
Yes, I have it installed.
Title: Re: Reason For Editing Mod
Post by: PfalzNacht on March 27, 2008, 05:28:00 PM
Is there a way to force input why editing the post, and a checkbox with reasons why editing post?

Title: Re: Reason For Editing Mod
Post by: Trinny on April 18, 2008, 07:31:32 PM
Has anyone tested this mod for 2.0b3?
Title: Re: Reason For Editing Mod
Post by: PrizeLive.com on April 22, 2008, 10:46:43 PM
Does this work with 1.1.4? If so, where do I find the edits that need to be made?
Title: Re: Reason For Editing Mod
Post by: perplexed on April 25, 2008, 10:26:26 AM
yes it does work with 1.1.4 but I didnt have to edit any files.  Have you tried to install the mod yet?
Title: Re: Reason For Editing Mod
Post by: PrizeLive.com on April 25, 2008, 01:37:01 PM
Quote from: quiteperplexed on April 25, 2008, 10:26:26 AM
yes it does work with 1.1.4 but I didnt have to edit any files.  Have you tried to install the mod yet?

No, not yet. So you just did the regular install?
Title: Re: Reason For Editing Mod
Post by: perplexed on April 25, 2008, 03:06:00 PM
yes, I did, no problems.

Try but if you get any 'test failed' files on install, you will have to edit the files manually
Title: Re: Reason For Editing Mod
Post by: cellax on April 26, 2008, 09:20:36 PM
the mod on my smf1.1.4 just installed works great.

Attach the package with the Language de-hardcoded, there is only English translation, I am translating in italian, have fun guys.

Try it at your own risk (but I am using  ;))
Title: Re: Reason For Editing Mod
Post by: General_Naga on May 18, 2008, 05:12:13 PM
This looks like a really good mod, is there any plans to update it for SMF 2.0?
Title: Re: Reason For Editing Mod
Post by: Kimmie on June 02, 2008, 04:43:43 PM
On initial install there were no Test Failed's, however I got these errors in my error log:

2: Missing argument 2 for db_query(), called in /Packages/temp/reasonforeditinginstall.php on line 5 and defined
File: /Sources/Subs.php
Line: 238

8: Undefined variable: found
File: /Packages/temp/reasonforeditinginstall.php
Line: 8


I tested out the mod anad have received no other errors (yet), however you mat want to look into the install errors.
Title: Re: Reason For Editing Mod
Post by: Alpay on June 12, 2008, 07:16:52 AM
Quote from: General_Naga on May 18, 2008, 05:12:13 PM
This looks like a really good mod, is there any plans to update it for SMF 2.0?

yep =) winrules ?
Title: Re: Reason For Editing Mod
Post by: winrules on June 12, 2008, 04:52:21 PM
I'll see what I can do as far as 2.0.

I probably won't get it done for beta 3 though, but probably beta 4 and up.
Title: Re: Reason For Editing Mod
Post by: erlend_sh on June 13, 2008, 06:13:19 PM
Quote from: winrules on June 12, 2008, 04:52:21 PM
I'll see what I can do as far as 2.0.

I probably won't get it done for beta 3 though, but probably beta 4 and up.
Loving it :) I think this is one of those "Doesn't have to come with SMF out-of-the-box but is still a must-have"-kind of mod ;)

Looking forward to Beta4 even more then!
Title: Re: Reason For Editing Mod
Post by: Ace Frye on June 25, 2008, 04:51:27 PM
This only seems to work with certain themes... Bummer.  :-\

Well, all-in-all, I would really like to see the reason being required.
Title: Re: Reason For Editing Mod
Post by: Ace Frye on June 25, 2008, 05:01:01 PM
Hmmm, but, I guess it is not that bad of a change if you know PHP.

I just added it to my custom theme.

Thanks much for this bro!
Title: Re: Reason For Editing Mod
Post by: L'AltroWeb on July 03, 2008, 03:39:14 PM
Hi!
I want change this line:
&#171; <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], !empty($message['modified']['edit_reason']) ? ', Reason: ' . $message['modified']['edit_reason'] : '' , '  </i> &#187;';
for multilanguage ($txt[1010] = 'Reason:';).
I have test like this: &#171; <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], !empty($message['modified']['edit_reason']) ? ', $txt[1010]' ' . $message['modified']['edit_reason'] : '' , '  </i> &#187;';but i receive error :(
How i can fix???
-
Another questions: with resolution to 1024x768 i see:
(http://img392.imageshack.us/img392/8987/resonwt5.gif) (http://img392.imageshack.us/img392/8987/resonwt5.gif)
how i can fix to maintain in only one line (fox max free space)?
-
Thanks in advance, DarkWolf  :)
Title: Re: Reason For Editing Mod
Post by: 58tbird on August 02, 2008, 01:05:39 PM
Great mod - thank you! :)

However, I got these errors right after I installed it and used it once:

Quote2: Missing argument 2 for db_query(), called in /home/.../public_html/Packages/temp/reasonforeditinginstall.php on line 5 and defined
File: /home/.../public_html/Sources/Subs.php
Line: 238
Quote2: Missing argument 3 for db_query(), called in /home/.../public_html/Packages/temp/reasonforeditinginstall.php on line 5 and defined
File: /home/.../public_html/Sources/Subs.php
Line: 238
Quote8: Undefined variable: found
File: /home/.../public_html/Packages/temp/reasonforeditinginstall.php
Line: 8

Can anyone tell me what I need to do to remedy this?   Thank you!
Title: Re: Reason For Editing Mod
Post by: 58tbird on August 03, 2008, 04:38:31 PM
Well, it looks like I have the same situation as Kimmie (above):
http://www.simplemachines.org/community/index.php?topic=89012.msg1565565#msg1565565 (http://www.simplemachines.org/community/index.php?topic=89012.msg1565565#msg1565565)
It appears the errors were generated at installation, and none since then.

However, I would also like to know the answer to Dark-Wolf's question:
QuoteAnother questions: with resolution to 1024x768 i see:

(http://img392.imageshack.us/img392/8987/resonwt5.gif)

how i can fix to maintain in only one line (fox max free space)?
Title: Re: Reason For Editing Mod
Post by: 58tbird on August 04, 2008, 11:04:37 PM
I tried editing this in post.template.php:
<input type="text" name="edit_reason" size="50" value="" />
from "50" to "70" and "20" but neither seemed to have any effect at all.
Title: Re: Reason For Editing Mod
Post by: Kylezz on August 04, 2008, 11:49:59 PM
Hold on I will download i have to delete some mods  ;) I have like 600 of them ATM
Title: Re: Reason For Editing Mod
Post by: 58tbird on August 05, 2008, 11:12:41 AM
Okay, thanks Kylezz.  Wow, that's a lot  :o
Title: Re: Reason For Editing Mod
Post by: 58tbird on August 15, 2008, 11:29:56 AM
Hi!  I would still like to know the answer to Dark-Wolf's question if anyone can help:
Quote from: Dark-Wolf on July 03, 2008, 03:39:14 PM
-
Another questions: with resolution to 1024x768 i see:
(http://img392.imageshack.us/img392/8987/resonwt5.gif) (http://img392.imageshack.us/img392/8987/resonwt5.gif)
how i can fix to maintain in only one line (fox max free space)?
-
Thanks in advance, DarkWolf  :)
Title: Re: Reason For Editing Mod
Post by: General_Naga on August 19, 2008, 05:05:53 PM
Quote from: winrules on June 12, 2008, 04:52:21 PM
I'll see what I can do as far as 2.0.

I probably won't get it done for beta 3 though, but probably beta 4 and up.

Thanks winrules - beta 4 can't be that far away now (see bottom of page :D)
Title: Re: Reason For Editing Mod
Post by: linette97 on August 27, 2008, 12:52:43 AM
Great mod! I used with 1.15! all I did was edit my theme and works perfect! Thanks!
Title: Re: Reason For Editing Mod
Post by: Marcus Forsberg on August 30, 2008, 05:10:40 AM
Will this work whit 2.x?

And if not, will it do in the future?
Title: Re: Reason For Editing Mod
Post by: General_Naga on August 30, 2008, 04:14:34 PM
Quote from: winrules on June 12, 2008, 04:52:21 PM
I'll see what I can do as far as 2.0.

I probably won't get it done for beta 3 though, but probably beta 4 and up.

Not yet, but in the future yes.
Title: Re: Reason For Editing Mod
Post by: SpoogeBeast on September 03, 2008, 03:14:56 AM
Quote from: linette97 on August 27, 2008, 12:52:43 AM
Great mod! I used with 1.15!

Yep same here. Installed and working with no problems. Recommended mod.
Title: Re: Reason For Editing Mod
Post by: W. Riker on September 26, 2008, 01:19:42 PM
Is it possible to set things in a way that only admins and moderators can enter reason for edit?
Title: Re: Reason For Editing Mod
Post by: W. Riker on September 27, 2008, 08:30:39 PM
Quote from: W. Riker on September 26, 2008, 01:19:42 PM
Is it possible to set things in a way that only admins and moderators can enter reason for edit?

I saw how can I set this.

Now I have new problem... i enter the reason for edit, but later the reason is not in a blue box.

How can I fix that?
Title: Re: Reason For Editing Mod
Post by: aayushagrawal90 on September 30, 2008, 10:49:22 AM
i am new to smf. can u tell me after installing how to enable it.
Title: Re: Reason For Editing Mod
Post by: W. Riker on September 30, 2008, 06:16:11 PM
It is enabled automatically...

You just can choose who to show reason for editing box to. (Admin panel -> Feature and Options -> Basic Features)
Title: Re: Reason For Editing Mod
Post by: sbt on October 08, 2008, 08:49:43 AM
Question please, am a newbie to php and mods and do have a forum with SMF 1.1.6 and Tiny Portal 1.0.5 and I tried installing this mod but when getting to the final howto could not locate where to put it and which file to put it in.

Code
reasonforeditinginstall.php
This file should not be able to execute standalone. You may have to run the following queries manually.
Query: [Select]
ALTER TABLE {$db_prefix}messages
ADD edit_reason tinytext NOT NULL
Query: [Select]
INSERT IGNORE INTO {$db_prefix}settings
(variable, value)
VALUES
('er_who', 'anyone')

Where exactly does this get put please because without it being added somewhere the forum white pages with errors to php and mysql.

Thank You for any replies.
Title: Re: Reason For Editing Mod
Post by: sbt on October 09, 2008, 08:58:06 AM
Please?

Edited: Figured it out alone.
Title: Re: Reason For Editing Mod
Post by: rejetto on October 29, 2008, 09:15:39 PM
Quote from: ladyshanae on November 28, 2006, 07:47:51 AM
Whenever myself or my mods edit a post and use an apostrophe, it adds a slash. 

a very annoying bug... 

Quote from: ldk on May 30, 2007, 09:28:30 AM
I was able to make these slashes not show up by using "stripslashes" in Display.template.php where you display this information.

that's what i did, to solve quickly.
but i saw in the DB that the slashes are actually saved. that means the problem is ahead, and slashes must be removed in post.php when the form is submitted, in post2().
would anyone find the exact place...
Title: Re: Reason For Editing Mod
Post by: Nibogo on October 31, 2008, 07:13:42 PM
Winrules you have to add languages support , not add "Reason" and "Reason For Edit:" that is really important for the non-english users
Title: Re: Reason For Editing Mod
Post by: General_Naga on November 04, 2008, 04:36:28 AM
Could I add another plea for a 2.0 version? Beta 4 has been out a while now :)
Title: Re: Reason For Editing Mod
Post by: shumilica on November 07, 2008, 09:49:17 PM
I would use this mod for my  smf 2.0.3 too...
Title: Re: Reason For Editing Mod
Post by: sbt on November 08, 2008, 01:33:15 PM
First time trying to install this the forum white paged, lol, then installed again and it did say it installed and the reason for edit box is showing when modifying posts, however, the reason is not being added to the post when modifying.
Did install this in a test forum too, works perfect there.
Have tried un-reinstalling, same results.
Could it be a mod conflict please?
Mod Name Version 
1. Signature Settings Mod 1.1  [ Apply Mod ] [ List Files ] [ Delete ] 
2. SMF 1.0.15 / 1.1.7 Update 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
3. Welcome Topic Mod 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
4. Limit A Guests Daily PageViews Mod 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
5. SMF 1.0.15 / 1.1.7 Update 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
6. Custom Profile Field Mod 3.19   [ Uninstall ] [ List Files ] [ Delete ] 
7. Reason For Editing Mod 1.14   [ Uninstall ] [ List Files ] [ Delete ] 
8. SMFShop 3.0  [ Apply Mod ] [ List Files ] [ Delete ] 
9. SMF 1.0.15 / 1.1.7 Update 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
10. No Temp Directory Removal 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
11. TinyPortal 1.052   [ Uninstall ] [ List Files ] [ Delete ] 


Thank You for any help, am learning about installing mods.
Title: Re: Reason For Editing Mod
Post by: Lady Night Owl on November 09, 2008, 12:40:22 AM
Yet another plea for this mod on SMF 2 (beta 4) ;)
Title: Re: Reason For Editing Mod
Post by: tbk22 on November 18, 2008, 04:19:17 PM
Quote from: NIBOGO on October 31, 2008, 07:13:42 PM
Winrules you have to add languages support , not add "Reason" and "Reason For Edit:" that is really important for the non-english users

I could translate it to portuguese if i Knew what to edit  :P
I am a noob in php :P

BTW is this working with custom themes?
Title: Re: Reason For Editing Mod
Post by: Rattler on January 05, 2009, 07:17:50 AM
Nice, neeeded and recommended Mod, thanks!

Installed and run on 1.1.7 flawless.

Tx again, Happy New Year!

Rattler
Title: Re: Reason For Editing Mod
Post by: Zeusbrown on January 15, 2009, 05:19:37 AM
How do I get this to work with a custom theme? Thanx , Zeus
Title: Re: Reason For Editing Mod
Post by: tormi on January 15, 2009, 06:52:48 PM
Are we certain this works for 1.1.7?
Title: Re: Reason For Editing Mod
Post by: Whimsical on January 21, 2009, 12:21:50 PM
I've installed this and got it running on 1.1.7 without any problems

thank you, a very useful mod! :)
Title: Re: Reason For Editing Mod
Post by: tripl3r on January 29, 2009, 04:47:08 PM
Yes this does work for 1.1.7
only trouble i had was with the Source/post.php not writing automatically so did it manually

get your Source/post.php

find:
$msgOptions['modify_name'] = addslashes($user_info['name']);

}


Replace with:

$msgOptions['modify_name'] = addslashes($user_info['name']);
}
$msgOptions['edit_reason'] = addslashes(strtr(htmlspecialchars(isset($_POST['edit_reason']) ? $_POST['edit_reason'] : ''), array("\r" => '', "\n" => '', "\t" => '')));

echo '
<tr>
<td valign="top" align="right">
<b>Reason For Edit:</b>
</td>
<td>
<input type="text" name="edit_reason" size="50" value="" />
</td>
</tr>';



do it for every occurance there should be like 3.
Title: Re: Reason For Editing Mod
Post by: floydpink on February 13, 2009, 08:52:20 PM
Great mod that I've been using for ages and is now working in 1.1.8
One small issue though. If you press TAB from the main text box the focus moves to SAVE rather than Reason for edit and then SAVE. As a power user, it's very annoying having to always use the mouse to be able to then enter a reason!
It's easy to set the ReasonForEdit text box into the tabindex, but then ana dditional problem arises in that the number of TABs needed to get to from thte main edit text box to SAVE is different on the New and Modify Topic screens. To overcome this, a dummy additional tabindex is needed on the new topic screen to mimic the ReasonForEdit tab when it is not dislayed.
themes/default/ post.template.php
Find: <input type="text" name="edit_reason" size="50" value="" />

Replace with: <input type="text" name="edit_reason" size="50" value="" tabindex="', $context['tabindex']++, '" />

Find: // If the admin has enabled the hiding of the additional options - show a link and image for it.
if (!empty($settings['additional_options_collapsable']))
echo '
<tr>
<td colspan="2" style="padding-left: 5ex;">
<a href="javascript:swapOptions();"><img src="', $settings['images_url'], '/expand.gif" alt="+" id="postMoreExpand" /></a> <a href="javascript:swapOptions();"><b>', $txt['post_additionalopt'], '</b></a>

Replace with: // If the admin has enabled the hiding of the additional options - show a link and image for it.
if (!empty($settings['additional_options_collapsable']))
echo '
<tr>
<td colspan="2" style="padding-left: 5ex;">
<a href="javascript:swapOptions();"><img src="', $settings['images_url'], '/expand.gif" alt="+" id="postMoreExpand" /></a><a href="javascript:swapOptions();" ';
// Floyd INSERT - Reason For Edit Mod bugfix: for new posts force a dummy tabindex on Additional Options so that the same number of tab presses is needed to get from edit text to save/preview buttons
if ($context['is_new_post'])
echo '
tabindex="', $context['tabindex']++, '"';
echo '
><b>', $txt['post_additionalopt'], '</b></a>
Title: Re: Reason For Editing Mod
Post by: Molten Bear on February 14, 2009, 12:05:03 PM
This is a nice and helpful mod.  Any chance it might be updated to work in 2.0?

Thanks for considering.
Title: Re: Reason For Editing Mod
Post by: General_Naga on February 20, 2009, 10:09:48 AM
Quote from: Molten Bear on February 14, 2009, 12:05:03 PM
This is a nice and helpful mod.  Any chance it might be updated to work in 2.0?

Thanks for considering.

+1 A SMF 2.0 version would be great. This is one of those "must have" mods!
Title: Re: Reason For Editing Mod
Post by: Mai Pen Rai on March 11, 2009, 04:13:58 AM
Quote from: General_Naga on February 20, 2009, 10:09:48 AM


+1 A SMF 2.0 version would be great. This is one of those "must have" mods!

I agree
Title: Re: Reason For Editing Mod
Post by: ttuu on April 26, 2009, 04:32:32 PM
Have the option to charge users to insert reason and when they did not cause il get you receive an error message "You must put a reason to edit a message"
?
Title: Re: Reason For Editing Mod
Post by: ttuu on May 24, 2009, 01:26:29 PM
Quote from: ttuu on April 26, 2009, 04:32:32 PM
Have the option to charge users to insert reason and when they did not cause il get you receive an error message "You must put a reason to edit a message"
?
bump
Title: Re: Reason For Editing Mod
Post by: bork on June 11, 2009, 07:45:36 PM

Does anyone know if there is there any alternative to this mod for SMF 2.0?
Title: Re: Reason For Editing Mod
Post by: iceman~ on June 18, 2009, 09:35:14 AM
Quote from: Mai Pen Rai on March 11, 2009, 04:13:58 AM
Quote from: General_Naga on February 20, 2009, 10:09:48 AM


+1 A SMF 2.0 version would be great. This is one of those "must have" mods!

I agree

Ditto
Title: Re: Reason For Editing Mod
Post by: General_Naga on June 19, 2009, 03:26:56 PM
I think to be honest it will require a new mod to be created as I think winrules is just too busy to do it. Any volunteers? :)
Title: Re: Reason For Editing Mod
Post by: Nibogo on June 19, 2009, 06:19:23 PM
Quote from: General_Naga on June 19, 2009, 03:26:56 PM
I think to be honest it will require a new mod to be created as I think winrules is just too busy to do it. Any volunteers? :)

I send a PM to him asking if I can take over this mod, If I do I will do the SMF 2.0 Version ;)
Title: Re: Reason For Editing Mod
Post by: General_Naga on June 20, 2009, 06:17:58 PM
Best news I've heard all week! This is just one of those must have mods which adds something you can't do without once you've tried it ;)
Title: Re: Reason For Editing Mod
Post by: Nibogo on June 23, 2009, 02:23:50 PM
Please translators help me with this strings with utf8 support please:

// Reason for editing mod
$txt['reason'] = 'Reason';
$txt['reason_edit'] = 'Reason For Edit';
$txt['permissionname_reason_edit'] = 'Set Reason for edit';
$txt['permissionhelp_reason_edit'] = 'Set if the membergroup is allowed to put the reason for edit their own posts.';
// Reason for editing mod END


winrules says of is ok if I take over this mod and is already finished I just need add more languages
Title: Re: Reason For Editing Mod
Post by: FragaCampos on June 23, 2009, 09:21:31 PM
Here's the Portuguese translation:

// Reason for editing mod
$txt['reason'] = 'Motivo';
$txt['reason_edit'] = 'Motivo Para Editar';
$txt['permissionname_reason_edit'] = 'Escreva o Motivo Para Editar';
$txt['permissionhelp_reason_edit'] = 'Escolha se quer que determinado grupo tenha permiss&atilde;o para escrever o motivo para editar as suas pr&oacute;prias mensagens.';
// Reason for editing mod END


:)
Title: Re: Dutch version
Post by: movingmagic on June 24, 2009, 08:33:32 AM
// Reason for editing mod
$txt['reason'] = 'Reden';
$txt['reason_edit'] = 'Reden voor aanpassing';
$txt['permissionname_reason_edit'] = 'Instellen reden voor aanpassing';
$txt['permissionhelp_reason_edit'] = 'Instellen of de ledengroep permissie heeft om de reden voor aanpassing in de eigen posts te plaatsen.';
// Reason for editing mod END
Title: Re: Reason For Editing Mod
Post by: Nibogo on June 24, 2009, 01:14:04 PM
Changelogs:
2.0 - 22 June 2009
o Added Permission for "Set Reason for Edit"
o Added Support for SMF 2.0
o Now Developed by NIBOGO
o Changed all the text now using languages strings
o Added spanish, spanish_es, spanish_latin, portuguese and dutch all with utf8 support

VERY IMPORTANT!!

If you are using a 1.x version of this mod and want to upgrade please do this things:

1. Remove all the code MANUALLY

2. Delete the mod in the package manager

3. Install this new version

PD: If you uninstall using the package manager you will delete all the data of this mod so you need to do this or replace the package in the Packages dir with a new one without the uninstall
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Sakae on June 25, 2009, 06:44:24 PM
Good MOD.

But it's not working for me.

Apply Filter: Only show the errors of this type  Type of error: Critical
Apply Filter: Only show the error messages of this URL http://www.tigrelog.com.br/index.php?action=jsmodify;topic=4833;sesc;xml
Apply Filter: Only show the errors with the same message
The database value you're trying to insert does not exist: var_edit_reason
Function: modifyPost
Apply Filter: Only show the errors from this file
Arquivo: **/Sources/Subs-Post.php
Linha: 2475
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: General_Naga on June 26, 2009, 03:08:55 PM
NIBOGO your a god amougst men!

Thank you so much for taking over this mod.

Mod works fine on my forum - I needed to manually add the second of the Display.php changes but apart from that it went perfectly :)
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Alpay on June 27, 2009, 12:36:45 PM
NIBOGO hi ;

Turkish translate ;
Thanks for upgrade mod.


Modifications.turkish.php

// Reason for editing mod
$txt['reason'] = 'Düzenleme';
$txt['reason_edit'] = 'Düzenleme sebebi';
$txt['permissionname_reason_edit'] = 'İleti düzenleme sebebi';
$txt['permissionhelp_reason_edit'] = 'Bu üye grubuna yetki verirseniz iletilerde düzenleme sebebi yazabilir.';
// Reason for editing mod END
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: General_Naga on June 29, 2009, 06:25:26 AM
After installing this mod quick edit stopped working for me. I found that I could open quick edit fine but no changes would be saved after clicking save.

Uninstalling the mod solved the issue. :(
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Alpay on July 04, 2009, 01:55:53 PM
NIBOGO again hello ;

Can you make the modification with this way?

Link : http://www.simplemachines.org/community/index.php?topic=235170.msg1514469#msg1514469
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on July 04, 2009, 07:23:52 PM
Quote from: Alpay on July 04, 2009, 01:55:53 PM
NIBOGO again hello ;

Can you make the modification with this way?

Link : http://www.simplemachines.org/community/index.php?topic=235170.msg1514469#msg1514469


I don't think so, require a lot of changes and additional tables on the DB
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Eclipse16V on July 10, 2009, 12:37:21 AM
Nice Mod but you have an error in the smf-2.x.xml in row126

<operation>
<search position="replace"><![CDATA[$context['non_guest_permissions'] = array(]]></search>
<add><![CDATA[$context['non_guest_permissions'] = array(
'reason_edit',
]]></add>
</operation>
<operation>
<search position="replace"><![CDATA['report_any' => array(false, 'post', 'participate'),
                        'reason_edit' => array(false, 'post', 'moderate'),]]></add>
</operation>
</file>
<file name="$languagedir/Modifications.english.php">


replace
<operation>
<search position="replace"><![CDATA[$context['non_guest_permissions'] = array(]]></search>
<add><![CDATA[$context['non_guest_permissions'] = array(
'reason_edit',
]]></add>
</operation>
<operation>
<search position="replace"><![CDATA['report_any' => array(false, 'post', 'participate'),]]></search>
<add><![CDATA['report_any' => array(false, 'post', 'participate'),
                        'reason_edit' => array(false, 'post', 'moderate'),]]></add>
</operation>
</file>
<file name="$languagedir/Modifications.english.php">
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Eclipse16V on July 10, 2009, 12:49:45 AM
And this error I becaome when I edit a post:
QuoteThe database value you're trying to insert does not exist: var_edit_reason

The db_reason2.php is installed.
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: villasg on July 10, 2009, 01:52:51 AM
Nice i make a try

I have  errors in the installation
Quote8: Undefined variable: found
Αρχείο: /home/thai.gr/www/forum/Packages/temp/db_reason1.php
Γραμμή: 20

Quote2: Missing argument 3 for db_query(), called in /home/thai.gr/www/forum/Packages/temp/db_reason1.php on line 17 and defined
Αρχείο: /home/thai.gr/www/forum/Sources/Subs.php
Γραμμή: 238

Quote2: Missing argument 2 for db_query(), called in /home/thai.gr/www/forum/Packages/temp/db_reason1.php on line 17 and defined
Αρχείο: /home/thai.gr/www/forum/Sources/Subs.php
Γραμμή: 238

But mod works fine !

greek utf8
<file name="$languagedir/Modifications.greek-utf8.php" error="skip">
<operation>
<search position="end" />
<add><![CDATA[
// Reason for editing mod
$txt['reason'] = 'Λογος';
$txt['reason_edit'] = 'Λόγος επεξεργασίας';
$txt['permissionname_reason_edit'] = 'Όρισε τον λόγο επεξεργασίας ';
$txt['permissionhelp_reason_edit'] = 'Όρισε εαν το membergroup επιτρεπεται να βαζει το λογο της επεξεργασιας στα ποστ του.';
// Reason for editing mod END
]]></add>
</operation>
</file>
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: patalete on July 10, 2009, 05:02:08 AM
Im gettin this two when using "fast edit" and saving the post.. with "modify" it wont show up..



The database value you're trying to insert does not exist: var_edit_reason
Function: modifypost
###/forum/index.php?action=jsmodify;topic=8923;sesc;xml
File: ###/forum/Sources/Subs-Post.php
Line: 2396


Type of error: Undefined
###/forum/index.php?action=jsmodify;topic=8923;sesc;xml
8: Undefined index: edit_reason
File: ###/forum/Sources/Subs-Post.php
Line: 2369


btw, I have disabled "template eval" thing cause Im doing other checks in the forums...jjust in case it can affect the error output posted.. :)
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: plusev on July 17, 2009, 05:09:38 PM
Just installed the mod and get the following error:

Unknown column 'edit_reason' in 'field list'
File: /web/Sources/Display.php
Line: 950

Please advise. Thx
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Yakumo on July 20, 2009, 04:47:49 PM
just downloaded Reason_for_Editing_v2.0.zip and im being told it's not compatible with my SMF 1.1.10 install?
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on July 20, 2009, 05:14:14 PM
Quote from: Yakumo on July 20, 2009, 04:47:49 PM
just downloaded Reason_for_Editing_v2.0.zip and im being told it's not compatible with my SMF 1.1.10 install?

New package uploaded the same code, just fixing the issue with SMF 1.1.10
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: oOo--STAR--oOo on July 27, 2009, 11:22:13 AM
Hi i have installed ur mod its a fantastic mod but its the only mod that gives u error's

i want to keep the mod but i want this error fixing...

In my forum error log i am getting these messages everytime i goto features and options...



http://www.uniquez.co.cc/index.php?action=featuresettings 
8: Undefined index: reason_anyone
File: /home/*****/public_html/Sources/ModSettings.php


here in features and options right at the bottom is a list box.. and when i click it i get blank options....
obviously its pointing to a line but i dont know what its asking for.....

       ****LIST BOX SUPPOSED TO BE HERE BUT IS EMPTY*** when i click it 3 options no writing...
Maximum number of recipients allowed in a personal message.
(0 for no limit, admins are exempt)   
Post count under which users must enter code when sending personal messages.
(0 for no limit, admins are exempt)   
Number of personal messages a user may send in an hour.
(0 for no limit, moderators are exempt)

Line: 282


please could u asist me on this matter

the line on

282 is

array('select', 'er_who', array('admin' => $txt['reason_admin'], 'admin+mod' => $txt['reason_admin+mod'], 'anyone' => $txt['reason_anyone'])),
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on July 27, 2009, 03:43:00 PM
That was for the v1.4 version of the mod, please use the v2.0 and clean all the code from the v1
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: oOo--STAR--oOo on July 28, 2009, 04:03:00 AM
18. Reason For Editing Mod 2.0   [ Uninstall ] [ List Files ] [ Delete ]

no i have version 2.0 installed... so its not a problem with the version...

any help?
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: [A-US]James246 on July 28, 2009, 08:37:01 AM
I'm using it and it works great!

Anyway - Can I make it where when users edit their post they HAVE TO provide a reason for editing?

THANKS A LOT! :) :) :)
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: oOo--STAR--oOo on July 28, 2009, 11:38:18 AM
yeah it works great but im getting an error in the log and in features and option.. there is a list box with nothing in it..

obviously there is supposed to be 3 options and im getting errors when i visit features and options... any help would be great
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on July 28, 2009, 05:44:27 PM
Quote from: aljo1985 on July 28, 2009, 11:38:18 AM
yeah it works great but im getting an error in the log and in features and option.. there is a list box with nothing in it..

obviously there is supposed to be 3 options and im getting errors when i visit features and options... any help would be great

Just delete the line from the last version in the ModSettings in the v2.0 I use the permission system so that is not used anymore
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: [A-US]James246 on July 29, 2009, 06:18:34 AM
Is it possible to set it that users have to provide a reason for editing their post?
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: oOo--STAR--oOo on July 29, 2009, 11:03:48 AM
FANTASTIC PROBLEM SOLVED

thanks for that..

should take that out of 2.0

in the modsettings edit...

thanks for the help....
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Kimmie on August 12, 2009, 12:04:24 AM
Installed this on RC1.2 and the only problem on istallation I had was what others had as well and that was it wont install the 2nd part on display.php (guessing its because when you parse the mod, there is an extra indentation on the parser than what is actually in the code so it cant find it). I installed that part manually and now the problem is, the only people that can see the box are admins and I dont have the settings in Features and Options to change it. I hav checked all the edits and they all seemed to install ok.


Any ideas? Thanks in advance


Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on August 12, 2009, 03:33:51 PM
Quote from: Kimmie on August 12, 2009, 12:04:24 AM
Installed this on RC1.2 and the only problem on istallation I had was what others had as well and that was it wont install the 2nd part on display.php (guessing its because when you parse the mod, there is an extra indentation on the parser than what is actually in the code so it cant find it). I installed that part manually and now the problem is, the only people that can see the box are admins and I dont have the settings in Features and Options to change it. I hav checked all the edits and they all seemed to install ok.


Any ideas? Thanks in advance




Set the permissions ;)
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Kimmie on August 12, 2009, 11:54:49 PM
Quote from: NIBOGO on August 12, 2009, 03:33:51 PM
Quote from: Kimmie on August 12, 2009, 12:04:24 AM
Installed this on RC1.2 and the only problem on istallation I had was what others had as well and that was it wont install the 2nd part on display.php (guessing its because when you parse the mod, there is an extra indentation on the parser than what is actually in the code so it cant find it). I installed that part manually and now the problem is, the only people that can see the box are admins and I dont have the settings in Features and Options to change it. I hav checked all the edits and they all seemed to install ok.


Any ideas? Thanks in advance




Set the permissions ;)


Um..thats just it... I dont "have" those settings...lol

QuoteI dont have the settings in Features and Options to change it
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on August 13, 2009, 03:17:12 PM
In the membergroups permissions ;) ...lol
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Kimmie on August 14, 2009, 02:28:38 AM
Quote from: NIBOGO on August 13, 2009, 03:17:12 PM
In the membergroups permissions ;) ...lol


Um.. sorry but there are NO new settings under any groups permissions pertaining to the Reason To Edit mod, unless you are referring to the setting that says "Modify posts" which is the settnig that is a default setting of SMF and has nothing to do with this mod (its already set so that they can..lol). --- and there are NO settings under my Features and Options where I am suppsed to be able to set "who" sees the edits (such as just admins, etc). If I am not mistaken, isnt the one that is supposed to be under Features and Options the one that controls the mod?

Right now the ONLY people that can even SEE the box are admins.


This is what I am confused about:

QuoteAdded Permission for "Set Reason for Edit"

I have looked EVERYWHERE and there is nothing.

Please be just a tad more specific as I cant read minds..lol.

I have also been gettnig this error:

The database value you're trying to insert does not exist: var_edit_reason
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on August 14, 2009, 03:37:48 PM
You should see the permissions page...lol

and check a permission called "Set Reason for Edit"...lol

or look if you have any error re- installing the mod...lol

Regards...lol
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Kimmie on August 15, 2009, 01:32:26 AM
Quote from: NIBOGO on August 14, 2009, 03:37:48 PM
You should see the permissions page...lol

and check a permission called "Set Reason for Edit"...lol

or look if you have any error re- installing the mod...lol

Regards...lol

geez.. your not getting what I am saying..lol

ok let me see if I can explain this in ENGLISH for you...lmao

I - do - not - have - that - setting - on - the - permissions - pages - for - ANY - membergroup. Nor - do - I - have - any - settings - page - related - to - this - mod - in - my - admin - panel.

Here, you can look for yourself..lol

(http://i32.tinypic.com/jr4spv.png)

And if you go back to oh.. page 15 and 16 of this thread, you see all those people having issues with Quick Edit? Guess What, mee too. Error is below.

The database value you're trying to insert does not exist: var_edit_reason
Function: modifyPost

File: /home//public_html/Sources/Subs-Post.php
Line: 2396


I also did not have any errors when I installed it the first time. Are you telling me I need to uninstall it and REINSTALL it?  (cant quite tell on that one..lol) If so, if I didnt have any errors on the initial install, why would I have any on the reinstall?


Mind telling WHERE this permissions page is supposed to be? 

Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on August 15, 2009, 12:18:47 PM
WOW You are pretty smart, you still looking for a setting in Features and Setting when I already said that this was removed in the v2.0, also the re-installation can fix the problem in case that another mod change the code (really you are súper smart) also you should now where are the membergroups permissions, if you don't know it you should browse better an SMF System and them ask for support...lol

Regards ;)
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Kimmie on August 15, 2009, 12:36:21 PM
Quote from: NIBOGO on August 15, 2009, 12:18:47 PM
WOW You are pretty smart, you still looking for a setting in Features and Setting when I already said that this was removed in the v2.0, also the re-installation can fix the problem in case that another mod change the code (really you are súper smart) also you should now where are the membergroups permissions, if you don't know it you should browse better an SMF System and them ask for support...lol

Regards ;)


well yes, I AM the smart one because you FAILED to read and understand what I have told you THREE times now and you either dont WANT to answer my questions or you CANT because YOU dont know..lmao.

ok look.. I have not JUST looked in features and settings - I have looked EVERYWHERE and guess what.. the setting is NOT THERE..lol. And YES I know exactly where my membergoup permissions are  lol. The setting is NOT there..lol.

Since I downloaded the latest version of this mod, HOW would reinstalling it help?  lol. Wouldnt it do the SAME installation?  lmao. There has not been another mod that has changed the code..lol. This mod has not worked since I first installed it and I have NOT added another mod to my site since.

Look.. the latest version...

(http://i29.tinypic.com/e0ixw7.png)

And what about the errors this mod causes with the Quick Edit that a TON of people are having a problem with? You planning on fixing those anytime soon?



Geex, you have ALOT to learn when it comes to support and giving folks help when they ask for it. Your attitude is HORRIBLE and as been since teh first time I asked for help on this issue!!
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: CarreyCC on August 15, 2009, 11:01:10 PM
Hello, i love this mod, and i had the same problem when modified with "fast edit". I hop this solution resolve us the problem. I has solved and i'm happy now  :D

Replace this code

    // Reason for Editing Mod
    $messages_columns['edit_reason'] = $msgOptions['edit_reason'];


For this

    // Reason for Editing Mod
    if (!empty($msgOptions['edit_reason']))
        $messages_columns['edit_reason'] = $msgOptions['edit_reason'];


The next time you "fast edit", if the post yet have reason for edit, not touch the content (but you see empty, but if refresh appear again). Really the content not erase while you do "fast edit". To change the reason or delete, you must do "Normal edit".

Thans for the utility, and sorry by my bad english :(
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: bbmtalk on September 07, 2009, 11:16:35 AM
I am having errors with this and below are the error messages

8: Undefined index: reason_admin+mod

8: Undefined index: reason_anyone

8: Undefined index: reason_admin

Sources/ModSettings.php
Line: 270

Any help? Thanks!
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: villasg on September 09, 2009, 12:20:01 PM
Have errors :

http://www.************/index.php?action=featuresettings;sa=basic;sesc

8: Undefined index: reason_anyone
8: Undefined index: reason_admin+mod
8: Undefined index: reason_admin

file: /home/thai.gr/www/forum/Sources/ModSettings.php

line: 285

any help plz ?

Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on September 09, 2009, 04:10:06 PM
Quote from: villasg on September 09, 2009, 12:20:01 PM
Have errors :

http://www.************/index.php?action=featuresettings;sa=basic;sesc

8: Undefined index: reason_anyone
8: Undefined index: reason_admin+mod
8: Undefined index: reason_admin

file: /home/thai.gr/www/forum/Sources/ModSettings.php

line: 285

any help plz ?



You have to remove the code from the v1 version
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: villasg on September 10, 2009, 03:32:35 AM
Quote from: NIBOGO on September 09, 2009, 04:10:06 PM

You have to remove the code from the v1 version

I dont  understunt you .

Please help me how can remove the old code ?
or if yoy can edit for me plz
I dont have the old pakage of mod .
And i dont know what need to remove !

Thanks
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: bbmtalk on September 10, 2009, 08:22:52 AM
Quote from: villasg on September 10, 2009, 03:32:35 AM
Quote from: NIBOGO on September 09, 2009, 04:10:06 PM

You have to remove the code from the v1 version

I dont  understunt you .

Please help me how can remove the old code ?
or if yoy can edit for me plz
I dont have the old pakage of mod .
And i dont know what need to remove !

Thanks


What NIBIGO said was to remove the following code from ModSettings.php

'',
// Who should we show a box to put the reason for a edit?
array('select', 'er_who', array('admin' => $txt['reason_admin'], 'admin+mod' => $txt['reason_admin+mod'], 'anyone' => $txt['reason_anyone'])),


I did the same and now it doesn't show any error anymore.
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: villasg on September 10, 2009, 09:01:53 AM
Thank you for the explain !

I made , check and work

Thanks again
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Foreclosurepedia on September 17, 2009, 07:47:30 PM
smf 2.0 rc 1.2, playground ultimate theme, http://www.ibrr.org/forum (http://www.ibrr.org/forum)

i have tried to run this mod on both the default core theme and my theme i use above.  i get the attached errors.

i spoke w/shortie's site that runs the playground theme and they said to speak w/you first.
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on September 17, 2009, 07:52:45 PM
Just do the manual edit on the Display.php file, try to use the parser:

http://custom.simplemachines.org/mods/index.php?action=parse;mod=349;attach=107576;smf_version=1.1.9
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: M-DVD on September 27, 2009, 07:46:16 PM
Hi

Now Auto Merge Double Post (http://custom.simplemachines.org/mods/index.php?mod=1523) is compatible with this MOD :)
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on September 27, 2009, 09:07:59 PM
Quote from: M-DVD on September 27, 2009, 07:46:16 PM
Hi

Now Auto Merge Double Post (http://custom.simplemachines.org/mods/index.php?mod=1523) is compatible with this MOD :)

Glad to know it :)

Thanks my friend
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: M-DVD on September 28, 2009, 12:35:54 PM
Quote from: NIBOGO on September 27, 2009, 09:07:59 PM
Quote from: M-DVD on September 27, 2009, 07:46:16 PM
Hi

Now Auto Merge Double Post (http://custom.simplemachines.org/mods/index.php?mod=1523) is compatible with this MOD :)

Glad to know it :)

Thanks my friend

You are welcome  :D

Both MODs should work fine
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: recived on October 06, 2009, 04:39:25 AM
Hi all. How can I make a forced entry causes of editing?
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: STS on October 07, 2009, 07:46:55 PM
Quote from: Yakumo on July 20, 2009, 04:47:49 PM
just downloaded Reason_for_Editing_v2.0.zip and im being told it's not compatible with my SMF 1.1.10 install?

I'm getting the same error... is there a reason? If so, is there a fix? This is a great option to have available.
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: CapadY on October 12, 2009, 02:47:21 PM
I have the same problem as Kimmie haves.

I installed the MOD manualy, but there is still no possibility to enter the reasen for editting anywhere. Neither for a moderator or an Administrator.

I checked al the usergroup permissions but I can't find the option to enable the editting MOD anywhere.

Maybe there is somebody who can tell me in what part of the permissions I have to look and wat part of the source I have to check to be sure this part is added in it ?

Thanks in advance

John
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Verso on October 16, 2009, 10:46:28 AM
This will not install on my forum.........

Reason1.PNG is the errors I receive

Reason2.PNG is the mods I have installed.



Can anyone advise to why I cannot install?

Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: CapadY on October 23, 2009, 09:16:06 AM
It's a pitty the author of this MOD dont't react at all in this topic.

There are several problems in this MOD.
One of them is the name of an text variabele. In the code he uses "edit_reason" while in the language file the name "reason_edit" is used. So this will give a problem.

Another problem is in Subs_post. There the field "var_edit_reason" is tried to add to the message record but this field don't exist. This should be the field "edit_reason" but I have not find how to solve this because the fieldname is in a list en I didn't find where this list is filled.

So, don't use this MOD if you want a MOD that is working properly.

John
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Maxtor on October 25, 2009, 08:04:08 AM
Quote from: Verso on October 16, 2009, 10:46:28 AM
This will not install on my forum.........

Reason1.PNG is the errors I receive

Reason2.PNG is the mods I have installed.



Can anyone advise to why I cannot install?



smf-2.x.xml file has a wrong syntax , try this !



Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: PAPABEAR on October 29, 2009, 08:32:47 AM
Quote from: maxtor on October 25, 2009, 08:04:08 AM
smf-2.x.xml file has a wrong syntax , try this !

THANKS MAN!
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: fox0r on November 06, 2009, 08:11:54 PM
This just isn't showing for me.  The auto installer did everything find but Display.php so I did that one by hand.  No other errors.

It shows up when I go to edit a post, lets me put in a reason with no errors, but it does not show up on the post itself.  As far as I can tell everything installed correctly.

I got this error in my error logs:
       Apply Filter: Only show the errors of this type  Type of error: Undefined
Apply Filter: Only show the error messages of this URL http://hellestar.com/index.php?action=admin;area=packages;sa=install2;package=Reason_for_Editing_v2.0.zip;pid=0
Apply Filter: Only show the errors with the same message
8: Undefined variable: found
Apply Filter: Only show the errors from this file
File: /usr/home2/jpohlman/public_html/htss/Packages/temp/db_reason2.php
Line: 22

I checked the database in phpmyadmin and it did put the edit_reason column in messages.

I also have nothing in my admin panel for it.

Any ideas?
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: fox0r on November 06, 2009, 10:43:27 PM
I managed to fix it now showing... Still haven't found the permission for it, or fixed it why it isn't showing.
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Joker™ on November 12, 2009, 05:06:02 AM
First of all i wanna know anyone seeing this mod or not

as no one answering any questions over here

im also facing same prob.... only admins have reason for edit box appearing while editing

i have check all permissions very carefully n no such permission was there to enable >> reason for edit ....

also i have checked all display n permission files maually also n all were fine

hope this time someone reply for god sake...
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: CapadY on November 12, 2009, 07:49:44 AM
I think this MOD should be reported as Unsave and Un-supported.
A real lot of people are investing time to get it working, no-one will get it working, and also no support for it at all.
Even whem there are 2 places noticed in this topic whith problems in this MOD nobody will react on it.

Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Verso on November 12, 2009, 08:16:31 AM
Quote from: capady on November 12, 2009, 07:49:44 AM
I think this MOD should be reported as Unsave and Un-supported.
A real lot of people are investing time to get it working, no-one will get it working, and also no support for it at all.
Even whem there are 2 places noticed in this topic whith problems in this MOD nobody will react on it.




Use the fix that Maxtor has on his post a few up........

That works for me
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Uhura! on November 17, 2009, 02:59:23 PM
NIBOGO,

I have all the permissions set up so that anyone signed into the forum has permission to add a reason edit, but only admin sees the reason box in "modify posts".

Can you help?
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Sordell Media on November 19, 2009, 08:31:28 PM
Has anyone had any luck getting this to work for RC2?
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: CapadY on November 20, 2009, 03:59:51 AM
Are you kidding ? Even with 1.2 this MOD doesn't work and from here there is no support at all.
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on November 20, 2009, 11:57:56 AM
 just want to say that will be a new version with a fix for the permission bug and curve support
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: CapadY on November 20, 2009, 02:10:22 PM
And you suppose people will spend hours and hours again to get this MOD working without any support here for about two months ??????
Title: Re: Reason For Editing Mod [v2.0 RELEASED!!]
Post by: Nibogo on November 20, 2009, 09:07:06 PM
Quote from: capady on November 20, 2009, 02:10:22 PM
And you suppose people will spend hours and hours again to get this MOD working without any support here for about two months ??????

Pfff

So you suppose that I take time from my studies (I´m finishing the school right now) just to upgrade a mod??? the mod is already done if you can't upgrade it isn't my problem just wait or pay for it
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 22, 2009, 07:12:48 PM
Here is the new package as I said, please take a look to the Permission Screenshot to see how works the new mod

Changelog:
2.2 - 22 Nov 2009
o Added Curve Support
o Added Support for SMF 2.0 RC2
o Fixed bug with the permission to use this mod.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: islam2hamy on November 22, 2009, 10:54:30 PM
Nice One,

Arabic Translation :

Quote<file name="$languagedir/Modifications.arabic-utf8.php">
    <operation>
        <search position="end" />
            <add><![CDATA[
// Reason for editing mod
$txt['reason'] = 'السبب';
$txt['reason_edit'] = 'سبب التعديل';
$txt['permissionname_reason_edit'] = 'كتابت سبب التعديل';
$txt['permissionhelp_reason_edit'] = 'للسماح للأعضاء بكتابت سبب تعديل المشاركة الخاصة بهم.';
// Reason for editing mod END
]]></add>
    </operation>
</file>

Quote<file name="$languagedir/Modifications.arabic.php">
    <operation>
        <search position="end" />
            <add><![CDATA[
// Reason for editing mod
$txt['reason'] = 'السبب';
$txt['reason_edit'] = 'سبب التعديل';
$txt['permissionname_reason_edit'] = 'كتابت سبب التعديل';
$txt['permissionhelp_reason_edit'] = 'للسماح للأعضاء بكتابت سبب تعديل المشاركة الخاصة بهم.';
// Reason for editing mod END
]]></add>
    </operation>
</file>
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 23, 2009, 11:18:57 AM
Thanks buddy, I'll add the translation in the next release
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 23, 2009, 11:26:21 AM
Nibogo

You said you fixed the bug with the Permissions. I am hoping that this fix covers the issue with regular members not being able to see the "Reason for Edit" or use it at all, even though I have the permissions set up in the admin panel for all members.

What was changed to fix the Permissions? Maybe I can just copy & paste the corrected code in the appropriate file. With manual uninstall, I am afraid of removing something I shouldn't.

Please advise.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 23, 2009, 11:33:28 AM
U should just uninstall the last version and install the new one
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 23, 2009, 11:56:15 AM
N,

Using the package manager?

Thanks
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 23, 2009, 12:29:34 PM
Yes
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 23, 2009, 02:39:46 PM
Check this out - somehow there is no "uninstall" option from the Package Manager.

Any advice?
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on November 23, 2009, 02:46:03 PM
Hi there is there any way to get a version compatiable with rc1.2 as i'm  not planning on upgrading just yet, as not all mods are yet working with rc2.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 23, 2009, 02:48:26 PM
@Uhura: Just change the emulate_version to 1.1.9.

@adbrad: No
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 23, 2009, 03:18:54 PM
Quote from: NIBOGO on November 23, 2009, 02:48:26 PM
@Uhura: Just change the emulate_version to 1.1.9.

How do I do that?
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 23, 2009, 06:52:21 PM
Quote from: Uhura! on November 23, 2009, 03:18:54 PM
Quote from: NIBOGO on November 23, 2009, 02:48:26 PM
@Uhura: Just change the emulate_version to 1.1.9.

How do I do that?

http://custom.simplemachines.org/mods/index.php?mod=2113

or add ;version_emulate=1.1.9 to the Packages Page
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 23, 2009, 08:48:27 PM
Done...but 1 problem: Uninstall Test failed.

Advice?
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 23, 2009, 08:59:58 PM
Skip that errors
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 23, 2009, 09:50:44 PM
OK...I followed your instructions & the updated version successfully installed - but we're right back where we started...Only Admin can see and use the feature although everyone has been granted permission.

Pls help us poor lades @ Mom Spot out Nibogo ....Think of your mom :)
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 23, 2009, 10:21:45 PM
Quote from: Uhura! on November 23, 2009, 09:50:44 PM
OK...I followed your instructions & the updated version successfully installed - but we're right back where we started...Only Admin can see and use the feature although everyone has been granted permission.

Pls help us poor lades @ Mom Spot out Nibogo ....Think of your mom :)

The mod was succesfully tested on my localhost in both version of SMF 1.1.10 & 2.0 RC2, works great on all the membergroups that I set the permission so isn't a problem with the mod I think of you didn't set the permission in the Membergroups Permissions (remember that the permission on the Forum Settings isn't used)
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 23, 2009, 11:18:21 PM
Quotedidn't set the permission in the Membergroups Permissions (remember that the permission on the Forum Settings isn't used)



pls clarify...

I have the permissions for everyone set up...Pls see the attachement.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: c23_Mike on November 24, 2009, 06:48:54 AM
Hi there !

Hi Uhuhra! Tnx for that pic, in my installation (SMF 2 RC2 charter Ed) I have this point not at all, so I cannot activate it for user groups.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Joker™ on November 24, 2009, 08:23:52 AM
bro what about RC 1.2..... i tried to install the mod but this comes

The package you are trying to download or install is either corrupt or not compatible with this version of SMF.

..... hope there is a solution for it
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: PalmBeachPreps on November 24, 2009, 02:34:04 PM
Quotein my installation (SMF 2 RC2 charter Ed) I have this point not at all, so I cannot activate it for user groups.
Same here.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on November 24, 2009, 08:11:45 PM
SMF 2.0 RC2 Screenshot:

(http://i.imgur.com/o5Lde.png)
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 24, 2009, 10:42:02 PM
Still need that clarification :)
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Vyache on November 25, 2009, 01:59:06 AM
Hi,

RC2 User.

I found a bug in the install script (might not be),
./Sources/Display.php
id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body,


It should be:
m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body,
m.smileys_enabled, m.poster_name, m.poster_email, m.approved,


Install script won't work otherwise.

Also, the redirect isn't working right. I get sent to a blank page with this ending address:
index.php?admin;area=permissions;sa=index
Not totally blank, just no settings...
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: PalmBeachPreps on November 26, 2009, 03:57:44 PM
Installed well on RC2.  There's a problem with the automatic redirection after install though.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Smitten on November 28, 2009, 07:22:10 AM
Excuse me, i have a problem.

I installed the mod in 2.0 RC2. I checked all modifications and everything is fine but i have this error when i try to access in post page:

Unknown column 'edit_reason' in 'field list'
Archivo: Sources/Display.php
Línea: 994


Thanks for any help.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Smitten on November 28, 2009, 07:33:24 AM
Quote from: Smitten on November 28, 2009, 07:22:10 AM
Excuse me, i have a problem.

I installed the mod in 2.0 RC2. I checked all modifications and everything is fine but i have this error when i try to access in post page:

Unknown column 'edit_reason' in 'field list'
Archivo: Sources/Display.php
Línea: 994


Thanks for any help.

Sorry, i solved!

The problem was in my DB. I had to create the column in the "message" table as the install requires. I don't know why my DB don't acept files like "install.php"
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Uhura! on November 28, 2009, 11:40:28 AM
Quote from: NIBOGO on November 23, 2009, 10:21:45 PM
Quote from: Uhura! on November 23, 2009, 09:50:44 PM
OK...I followed your instructions & the updated version successfully installed - but we're right back where we started...Only Admin can see and use the feature although everyone has been granted permission.

Pls help us poor lades @ Mom Spot out Nibogo ....Think of your mom :)

The mod was succesfully tested on my localhost in both version of SMF 1.1.10 & 2.0 RC2, works great on all the membergroups that I set the permission so isn't a problem with the mod I think of you didn't set the permission in the Membergroups Permissions (remember that the permission on the Forum Settings isn't used)

As I stated earlier, the Membergroup permissions are 100% set. Please see the attachment. The problem remains that Admin alone can see the feature and no one else can.

I have followed all your suggestions and this is still the problem. Please asist me.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on December 01, 2009, 05:16:41 PM
I tried installing this on my RC2 forum using v2.2 but get an error on install in display.php. the following code does not exist in my display .php
  id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body, 


The rest of the code installs fine and the mod works apart from reason for edit is not showing on posts.

thanks
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on December 01, 2009, 06:01:02 PM
That code is on my Display.php just try to find a query near to the line 980 ;)
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on December 01, 2009, 06:30:13 PM
SELECT id_msg, id_member, approved

is the nearest i can find on line 920 do i edit this line

ok i tryed editing but to no avail what ever i edit i get this

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM smf_messages
WHERE id_topic = 3
ORDER BY id_msg
LIMIT 0, 15' at line 2
File: /home/sites/xxxxxxxxxxxx.com/public_html/forum2/Sources/Display.php
Line: 933


I attach my display.php could some one please take alook

Thanks
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Sordell Media on December 01, 2009, 07:23:44 PM
Quote from: Uhura! on November 28, 2009, 11:40:28 AM
Quote from: NIBOGO on November 23, 2009, 10:21:45 PM
Quote from: Uhura! on November 23, 2009, 09:50:44 PM
OK...I followed your instructions & the updated version successfully installed - but we're right back where we started...Only Admin can see and use the feature although everyone has been granted permission.

Pls help us poor lades @ Mom Spot out Nibogo ....Think of your mom :)

The mod was succesfully tested on my localhost in both version of SMF 1.1.10 & 2.0 RC2, works great on all the membergroups that I set the permission so isn't a problem with the mod I think of you didn't set the permission in the Membergroups Permissions (remember that the permission on the Forum Settings isn't used)

As I stated earlier, the Membergroup permissions are 100% set. Please see the attachment. The problem remains that Admin alone can see the feature and no one else can.

I have followed all your suggestions and this is still the problem. Please asist me.

Can you try on the main permissions screen (where all the member groups are listed), clicking the checkboxes next to each of your desired membergroups, then in advanced options selecting "Add Permission" and "Set Reason For Edit" (under Topics heading). I enabled it this way for Regular Members member group and it worked perfectly.
Also check one of your regular users permissions (Profile -> Profile Info -> Permissions) and look for the Set Reason For Edit permission under the "Board Specific Permissions" for all boards, and make sure its not struck out (indicating its being denied by another permissions setting).
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: LP-san on December 14, 2009, 09:49:46 AM
Hi,

I installed the mod but there seems to be a problem with the display page
the bar shows when you want to edit but it won't show the reason why you edited in your post :s
i found that very weird hope you can help

forum: 2.0 RC2
theme: default
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: aaa3 on December 14, 2009, 04:28:12 PM
i have enabled the thing for all usergroups. i use 2.0rc2 with curve. the thing dont let making new posts at all with either admin or regular user. with admin i get a detailed error:

Database Error
Field 'edit_reason' doesn't have a default value
File: C:\web\contents\FORVM\Sources\Subs-Post.php
Line: 1830

after uninstall i still have the same... i have other packs installed as well, but i dont think any of them would produce an error like this o.O (neither is about editing posts, adding reason to it)
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: diablo3x.dk on December 18, 2009, 10:38:43 AM
Quote from: aaa3 on December 14, 2009, 04:28:12 PM
i have enabled the thing for all usergroups. i use 2.0rc2 with curve. the thing dont let making new posts at all with either admin or regular user. with admin i get a detailed error:

Database Error
Field 'edit_reason' doesn't have a default value
File: C:\web\contents\FORVM\Sources\Subs-Post.php
Line: 1830

after uninstall i still have the same... i have other packs installed as well, but i dont think any of them would produce an error like this o.O (neither is about editing posts, adding reason to it)

I get the exact same error.

Field 'edit_reason' doesn't have a default value
File: E:\HostingSpaces\xxxxxxxxxxxx\forum.diablo3x.dk_9Rhj6b4j\wwwroot\Sources\Subs-Post.php
Line: 1828

I tried uninstalling it but it did not help. I still get this error.

What should I do?

Thanks
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: aaa3 on December 26, 2009, 12:18:41 AM
after deleting every file's such version in my forum directory which had this text in it, i guessed, ok, this thing must"ve been putting such a field into the database.

doing another search with total commander but now in the data directory of my mysql install, i found 1 file which contained that string: smf_messages. yay! now what i done was opening phpmyadmin, selecting that table, and figure out how to remove that field (almost never used this program before. it took 2 minutes to find out how to do this ^^).

voila! i could post!!!!!!
this shows that actually if i reinstall the whole thing from zero (as i planned, was rly hopeless), even that wouldnt have helped.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Cafucho on December 27, 2009, 06:15:00 AM
Have some problem too.  :'(

I cannot modify the Admin Permissions, because the Admin do have all permissions. Therefore I dont know what to do now, is there any other possibility?

I'm using SMF 2.0 RC2 and the default theme.

Thanks in advance.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: PalmBeachPreps on December 27, 2009, 09:58:51 PM
Quote from: LP-san on December 14, 2009, 09:49:46 AM
Hi,

I installed the mod but there seems to be a problem with the display page
the bar shows when you want to edit but it won't show the reason why you edited in your post :s
i found that very weird hope you can help

forum: 2.0 RC2
theme: default
Same here.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on December 28, 2009, 04:23:23 AM
Quote from: adbrad on December 01, 2009, 06:30:13 PM
SELECT id_msg, id_member, approved

is the nearest i can find on line 920 do i edit this line

ok i tryed editing but to no avail what ever i edit i get this

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM smf_messages
WHERE id_topic = 3
ORDER BY id_msg
LIMIT 0, 15' at line 2
File: /home/sites/xxxxxxxxxxxx.com/public_html/forum2/Sources/Display.php
Line: 933


I attach my display.php could some one please take alook

Thanks

i have now fixed the problem or at least seem to have
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: TitbiT on December 28, 2009, 10:39:42 PM
translate russian-utf8
Title: Re: Reason For Editing Mod | ERROR
Post by: Vyache on December 29, 2009, 07:28:49 PM
Quote from: Vyache on November 25, 2009, 01:59:06 AM
Hi,

RC2 User.

I found a bug in the install script (might not be),
./Sources/Display.php
id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body,


It should be:
m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body,
m.smileys_enabled, m.poster_name, m.poster_email, m.approved,


Install script won't work otherwise.

Also, the redirect isn't working right. I get sent to a blank page with this ending address:
index.php?admin;area=permissions;sa=index
Not totally blank, just no settings...

Okay, I discovered a nasty bug by adding an m.editing_reason. After removing several mods and looking at the code, it looks like adding this mod or that line messes up selecting an icon off my messages. This is located in the picture in the attachment.

Basically I cannot change the picture of the icon after installing the mod this way. Don't do what I did to avoid error. :D

Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: MegaByte on January 03, 2010, 02:41:10 PM
This doesn't seem to install on PostgreSQL:

ERROR: syntax error at or near "FROM"
LINE 3: FROM smf_messages
^
File: /web/forums/Packages/temp/db_reason2.php
Line: 19
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Amendoim on January 12, 2010, 03:06:23 PM
Good night,

This MOD gives rise to a serious error in editing messages (fast edits) appears to change rapidly, one after editing but nothing appears, is the same as before you edited ..

It is a BUG generated, and you can not uninstall because desinstalaçã causes some errors etc. ..
Please ask to correct this error, and to test .. but also taking advantage of correcting the error of remensionar after installing the MOD ..

Thanks
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Joker™ on February 06, 2010, 08:52:47 AM
Quote from: LP-san on December 14, 2009, 09:49:46 AM
Hi,

I installed the mod but there seems to be a problem with the display page
the bar shows when you want to edit but it won't show the reason why you edited in your post :s
i found that very weird hope you can help

forum: 2.0 RC2
theme: default

same problem

is anyone doing anything about this  ????????????????????????????
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on February 06, 2010, 10:05:18 AM
did the edits in the ./sources/display.php file get done as this is similar to the problem i had.
are you also using the advanced rep mod.
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Joker™ on February 06, 2010, 10:11:19 AM
yeah im using that mod also
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on February 06, 2010, 10:59:20 AM
ok try this in the display.php file
find
m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body,
replace
m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body, edit_reason,
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Joker™ on February 06, 2010, 02:23:56 PM
still same
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on February 06, 2010, 03:18:38 PM
that worked for me have you tried clearing the cachce
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Joker™ on February 06, 2010, 03:20:33 PM
yeah tried everything n this doesn't see to work on my side
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: adbrad on February 06, 2010, 03:25:08 PM
sorry can't really help that was what fixed for me
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Joker™ on February 06, 2010, 03:31:24 PM
np bro .... i dont want to be harsh but out of curiosity i just wanna ask why mod author is not really providing any real support ?
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Joker™ on February 10, 2010, 02:57:53 AM
this mod has one more bug

On message index when you double click the title of a topic, the loading bar appears u can edit the title also , but when u click to save the loading bar don't disappear.

So u can't chnage topic titles there ..... i'm having this problem ....
Title: Re: Reason For Editing Mod [v2.3 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: Nibogo on February 13, 2010, 12:52:16 PM
Changelog:
2.3 - 13 Feb 2010 - If you are using SMF 1.1.X you don't need to upgrade
o Fixed bug with the installation. (Only for SMF 2.0)
o Fixed "Field 'edit_reason' doesn't have a default value". (Only for SMF 2.0)
o Fixed Issues editing messages using JS (Like Quick Edit, Change Title on Messageindex and Change Message Icon). (Only for SMF 2.0)
o Fixed Redirect after installation. (Only for SMF 2.0)




I hope of this fix all the issues related with this mod. I tested and works pretty well on my forum :)

About the future maybe I'm going to add a option to set the reason for edit on Quick Edit.
Title: Re: Reason For Editing Mod [v2.3 RELEASED!! - Fixed all the bugs on SMF 2.0 RC2]
Post by: edi67 on February 17, 2010, 12:56:36 PM
Please NIBOGO help me i unistalled old versione ( that worked and installed perfectly) for try new one but i have this error:

Table 'crazyzone_ediboard.{db_prefix}messages' doesn't exist
File: /home/crazyzone/data/www/crazyzone.biz/Packages/temp/db_reason2.php
Riga: 23


i using smf rc1.... why i can't install new version, and pity i deleted old version

seem as when file db_reason2.php try to add coloums in table messages it not find table messages but i have that table

For install your mod i needed to remove the file that create coulumn in table messages, i dont know the reason that creation of table give me error.

But installed without that work ok....
but you know the reason of my error?
Title: Re: Reason For Editing Mod [v2.3 RELEASED!! - Fixed all the bugs on SMF 2.0 RC2]
Post by: Nibogo on February 17, 2010, 10:14:28 PM
Try to manually add the edit_reason column to the messages table using phpmyadmin but no idea why isn't working if you uploaded to the same dir of SSI.php you should be able to execute the script using your webbrowser
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Nibogo on March 08, 2010, 09:50:30 PM
Changelog:

2.3.2 - 08 Mar 2010
o Added SMF 2.0 RC3 Support
o Fixed Incorrect Package Version on Package Manager
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: moofy on March 20, 2010, 01:52:46 AM
Hi,

I'm trying to install this mod on my forum with the non default theme

As per the manual instructions I edited the index.template.php file for my theme and replaced

<body>';

with

<body '.((isset($context['current_action']) && ($context['current_action'] == 'post') && (isset($context['current_topic']))) ? 'onLoad="post_mquotes();"' : '').'>';

I get a template parse error about there being an unexpected < in my file.


Any thoughts?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Nibogo on March 20, 2010, 10:05:31 AM
@moofy: This is the support topic for the reason editing mod not for the Multi-Quote Mod
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: moofy on March 20, 2010, 11:02:09 AM
Quote from: NIBOGO on March 20, 2010, 10:05:31 AM
@moofy: This is the support topic for the reason editing mod not for the Multi-Quote Mod
Then why does the multi-quote mod link this thread as the support topic?

http://custom.simplemachines.org/mods/index.php?mod=2360

If there is another topic for this mod could you direct me to it?

thanks
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: adbrad on March 20, 2010, 12:44:58 PM
here is the multi quote topic
http://www.simplemachines.org/community/index.php?topic=361997.0
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Nibogo on March 20, 2010, 06:45:11 PM
Quote from: moofy on March 20, 2010, 11:02:09 AM
Quote from: NIBOGO on March 20, 2010, 10:05:31 AM
@moofy: This is the support topic for the reason editing mod not for the Multi-Quote Mod
Then why does the multi-quote mod link this thread as the support topic?

http://custom.simplemachines.org/mods/index.php?mod=2360

If there is another topic for this mod could you direct me to it?

thanks

Because I do a lot of copy/paste ;)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Nibogo on March 24, 2010, 08:03:41 PM
A little preview of what is coming:

(http://img257.imageshack.us/img257/8307/fads1269475256863.png)

So far I have only one problem, when you set a new reason for edit and if you don't change the subject or body of the message the current reason dissapear and if you change subject or/and body the new reason doesn't appear. Both errors can be fixed just refreshing the page, I'll test and see if there is a way to fix it in case that I don't find it I'll publish the version with this bugs.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: matiaz on April 05, 2010, 05:16:54 PM
Thanks for the mod NIBOGO. I'll waiting for Reason for Editing Mod on Quick Edit ;D
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: adbrad on April 05, 2010, 05:57:45 PM
Quote from: NIBOGO on March 24, 2010, 08:03:41 PM
A little preview of what is coming:

(http://img257.imageshack.us/img257/8307/fads1269475256863.png)

So far I have only one problem, when you set a new reason for edit and if you don't change the subject or body of the message the current reason dissapear and if you change subject or/and body the new reason doesn't appear. Both errors can be fixed just refreshing the page, I'll test and see if there is a way to fix it in case that I don't find it I'll publish the version with this bugs.
is this gonna be another paid mod or free mod
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Nibogo on April 05, 2010, 05:59:03 PM
Free Mod, I was working on it but I saw that no-one reply or comment about it so I stop the development as I saw that no-one was interested in that feature
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: matiaz on April 08, 2010, 02:27:54 PM
I'm interested on that feature NIBOGO  :-\
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Nibogo on April 08, 2010, 02:37:47 PM
Quote from: matiaz on April 08, 2010, 02:27:54 PM
I'm interested on that feature NIBOGO  :-\

You're only one, SM.org has 217,334 members and 40695 members had downloaded this mod
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: adbrad on April 08, 2010, 03:58:05 PM
i would also like that feature
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Bobn on April 11, 2010, 11:11:56 AM
I set permissions for the mod and see the "Reason for Edit" box but it will not take. Im using RC2
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Bobn on April 11, 2010, 11:51:01 AM
Quote from: Bobn on April 11, 2010, 11:11:56 AM
I set permissions for the mod and see the "Reason for Edit" box but it will not take. Im using RC2

Anyone please?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: matiaz on April 11, 2010, 02:24:12 PM
¿Are you added the table in your's forum database?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Neo_TE on September 10, 2010, 02:32:11 AM
Quote from: Nibogo on April 05, 2010, 05:59:03 PM
Free Mod, I was working on it but I saw that no-one reply or comment about it so I stop the development as I saw that no-one was interested in that feature
lot of people are using this mod but no one is asking for this new feature because they never bother to visit the support forum until they encounter an error. i am also looking for that feature.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Neo_TE on September 10, 2010, 02:41:30 AM
For people who are having problem with smf 2.0 rc versions then do the following edit.

browse to $/Sources/Display.php

find
m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body,

replace
m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body, m.edit_reason,

we need to add m.edit_reason, (don't miss the ',' at the end of the line) to the end of the line so that the reason for edit will also be fetched from the database.


@ mod author, please fix the bug and a big thanks for the mod. :D
Title: Re: Reason For Editing Mod [v2.2 RELEASED!! - Supporting SMF 2.0 RC2]
Post by: devoetbalkantine on October 10, 2010, 03:22:50 PM
Quote from: Sordell Media on December 01, 2009, 07:23:44 PM
Quote from: Uhura! on November 28, 2009, 11:40:28 AM
Quote from: NIBOGO on November 23, 2009, 10:21:45 PM
Quote from: Uhura! on November 23, 2009, 09:50:44 PM
OK...I followed your instructions & the updated version successfully installed - but we're right back where we started...Only Admin can see and use the feature although everyone has been granted permission.

Pls help us poor lades @ Mom Spot out Nibogo ....Think of your mom :)

The mod was succesfully tested on my localhost in both version of SMF 1.1.10 & 2.0 RC2, works great on all the membergroups that I set the permission so isn't a problem with the mod I think of you didn't set the permission in the Membergroups Permissions (remember that the permission on the Forum Settings isn't used)

As I stated earlier, the Membergroup permissions are 100% set. Please see the attachment. The problem remains that Admin alone can see the feature and no one else can.

I have followed all your suggestions and this is still the problem. Please asist me.

Can you try on the main permissions screen (where all the member groups are listed), clicking the checkboxes next to each of your desired membergroups, then in advanced options selecting "Add Permission" and "Set Reason For Edit" (under Topics heading). I enabled it this way for Regular Members member group and it worked perfectly.
Also check one of your regular users permissions (Profile -> Profile Info -> Permissions) and look for the Set Reason For Edit permission under the "Board Specific Permissions" for all boards, and make sure its not struck out (indicating its being denied by another permissions setting).

This solved the problem for me. Thanks!
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: voythas on October 10, 2010, 06:58:50 PM
Great mod, thank you!
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: Nibogo on October 10, 2010, 07:34:42 PM
You're welcome!
Title: Re: Reason For Editing Mod
Post by: HunterP on October 19, 2010, 04:51:07 AM
Quote from: dampier on April 22, 2007, 02:16:48 PMA while after my first edit, I needed to make another change. The Reason For Edit box was blank, but that didn't bother me. I assumed that my original edit reason would remain at the bottom of the post. It didn't.
Is there a way to make the Reason For Edit box default to the reason previously entered? Or make the reason persist unless changed?

Any chance that this could be added some day?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC3]
Post by: ACPh on November 05, 2010, 11:17:23 PM
Great Mods, and I am using it with my 1.1.12,

Any chance for ver 2rc4?

[edit]
re: 2rc4
Runs using emulation,
Admin>Main>Packages(Package Manager)>Browse Packages>Advanced(Located @ right buttom)
Change, Emulate Version:  SMF 2.0 RC3
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on January 19, 2011, 04:43:19 PM
Added SMF 2.0 RC4
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: impreza on January 19, 2011, 06:10:46 PM
Great addition - I tested it, I greet and thank
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on January 19, 2011, 06:16:01 PM
You're welcome :)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: !RFAN on January 19, 2011, 08:36:26 PM
nice mod
thanks
can we ad it to quick modify??
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on January 19, 2011, 09:34:24 PM
Quote from: !RFAN on January 19, 2011, 08:36:26 PM
nice mod
thanks
can we ad it to quick modify??

Already explained what happend with that
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: More-to-life on January 20, 2011, 12:21:47 PM
Hi Great mod thank you

Do you have a permission on it to not allowed a edit unless a reason is given?

Thanks in advance
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on January 20, 2011, 12:24:09 PM
No, that isn't implemented.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: More-to-life on January 20, 2011, 12:38:33 PM
If enough are interested would you consider making it?

Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on January 20, 2011, 01:00:12 PM
Sure, it should be pretty easy
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: More-to-life on January 20, 2011, 02:14:09 PM
Many thanks I hope others need/want it now  :laugh:
Title: Re: Reason For Editing Mod
Post by: HunterP on January 20, 2011, 09:23:32 PM

This really is a good suggestion :

Quote from: dampier on April 22, 2007, 02:16:48 PMHad this question/suggestion from one of my users:

A while after my first edit, I needed to make another change. The Reason For Edit box was blank, but that didn't bother me. I assumed that my original edit reason would remain at the bottom of the post. It didn't.

Is there a way to make the Reason For Edit box default to the reason previously entered? Or make the reason persist unless changed?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Omniverse on February 10, 2011, 04:25:38 PM
Nice mod.

Have one suggestion.
What about an option to show last X number of edits with reason?

Say you could set it for 5. So for the last 5 edits, it would show when, who, and why (even if no reason given).

Basically an option to show multiple edits and reasons.


Edit: Also discovered when using ' or " in the edit field, it doesn't escape them correctly, you end up with extra /'s.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Leppie on February 11, 2011, 10:06:33 AM
i'm using this mod on RC4, but my logs are flooded with these errors:

8: Undefined index: multi_quote_remove
File: /Themes/default/languages/index.english.php (main sub template - eval?)
Line: 435

8: Undefined index: multi_quote
File: /Themes/default/languages/index.english.php (main sub template - eval?)
Line: 434

any suggestions?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: dcmouser on February 13, 2011, 04:24:15 PM
Thank you very much for this mod.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on February 13, 2011, 08:01:20 PM
Quote from: dcmouser on February 13, 2011, 04:24:15 PM
Thank you very much for this mod.

Glad you like it :)

Quote from: Leppie on February 11, 2011, 10:06:33 AM
i'm using this mod on RC4, but my logs are flooded with these errors:

8: Undefined index: multi_quote_remove
File: /Themes/default/languages/index.english.php (main sub template - eval?)
Line: 435

8: Undefined index: multi_quote
File: /Themes/default/languages/index.english.php (main sub template - eval?)
Line: 434

any suggestions?

That isn't related with this mod
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Leppie on February 14, 2011, 05:05:56 AM
Quote from: Nibogo on February 13, 2011, 08:01:20 PM
Quote from: Leppie on February 11, 2011, 10:06:33 AM
i'm using this mod on RC4, but my logs are flooded with these errors:

8: Undefined index: multi_quote_remove
File: /Themes/default/languages/index.english.php (main sub template - eval?)
Line: 435

8: Undefined index: multi_quote
File: /Themes/default/languages/index.english.php (main sub template - eval?)
Line: 434

any suggestions?

That isn't related with this mod
can you then tell me where the support thread is for your multi quote mod? i clicked support thread on the mod page which lead me to this thread...

edit: never mind, found the thread... anyways, would've been nice if you had posted the link since  you are the author of that mod as well.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: pvdleek on February 18, 2011, 04:13:41 PM
Are you planning to add support for 1.1.13?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: More-to-life on February 20, 2011, 10:56:01 AM
Any updates for RC5 or should it be OK with RC4
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: vlad2 on March 15, 2011, 08:52:33 AM
Hi,

I use smf 1.1.13 and I tried to convert it manually and i got this

Unknown column 'edit_reason' in 'field list'
File: /home/site/public_html/forum/Sources/Display.php
Line: 751

Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.13, while your database is at version 1.1.12. The above error might possibly go away if you execute the latest version of upgrade.php.


Can I do something?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on March 15, 2011, 10:20:43 AM
Upload the .php script that is in the package into your forum and open it using Firefox, u should get a blank screen, that means everything should be working now
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: vlad2 on March 15, 2011, 01:00:07 PM
I didn't get it.. Could you exlpain a bit more?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Krillin on March 27, 2011, 09:22:40 PM
Followed the instructions for RC4 in RC5.

Just wanted to say it looks like it works perfectly!

Thanks a mill ! !

SMF 2.0 RC5 Mods Installed: Reason For Editing, EmailValidator, UpdateRegAgreement, notCaptcha_v1.06 and Password Strength Meter. The first three had to be installed manually and Reason For Editing and UpdateRegAgreement needed to have their database entries added manually.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on March 28, 2011, 06:05:59 PM
You're welcome :)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Krillin on March 31, 2011, 03:19:28 PM
There is a problem with this MOD in 2.0 RC5 using 2.0 RC4 emulator pack to install.

We can not seem to post new message in board. The following error occurs:

Database Error
Field 'edit_reason' doesn't have a default value
File: C:\inetpub\krillinsworld\forum\Sources\Subs-Post.php
Line: 1835

Code on like 1835 is:
(Will have to update this part later when I get to a proper editor)
If this is the only bug which is stopping this from happening, then I think this can get RC5 approved? (We Hope) We would really require something like this on our forums as posts get updated regularly some montly.

Thanks
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Alex4108 on June 05, 2011, 09:03:18 PM
is RC5 planned to be added?  Could really use this mod
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: HunterP on June 06, 2011, 01:02:22 AM
Quote from: Alex4108 on June 05, 2011, 09:03:18 PM
is RC5 planned to be added?  Could really use this mod

It works for RC5. You can emulate RC4 in de package manager or edit the package for RC5 support.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Alex4108 on June 06, 2011, 05:50:04 PM
Quote from: HunterP on June 06, 2011, 01:02:22 AM
Quote from: Alex4108 on June 05, 2011, 09:03:18 PM
is RC5 planned to be added?  Could really use this mod

It works for RC5. You can emulate RC4 in de package manager or edit the package for RC5 support.

I followed the instructions to edit the package info for RC5, during the test it failed on Subs/Post.php, so I didn't install it.  As for emulation, where is this setting?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: HunterP on June 07, 2011, 01:31:20 AM
Quote from: Alex4108 on June 06, 2011, 05:50:04 PM
I followed the instructions to edit the package info for RC5, during the test it failed on Subs/Post.php, so I didn't install it.  As for emulation, where is this setting?

In the package manager you should see "advanced" in the right bottom? But please note that even though emulation might be correct, or the package could be used for your SMF version, an other mod might already have altered this specific code in Subs-Post.php. If so, you will need to install the mod manually, or alter the package in the correct way.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Lady Night Owl on June 24, 2011, 10:13:22 PM
What is the ETA for the 2.0 update? Thanks! :)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Markco on June 26, 2011, 03:54:31 AM
Please update for 2.0Gold
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on June 29, 2011, 03:05:37 PM
Marked as compatible with 2.0 Final, it was working without emulation or any other changes
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Lady Night Owl on June 30, 2011, 03:10:16 AM
Hmm...test failed on DisplayTemplate.php and Post.php

Thank you for updating it!
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 RC4]
Post by: Nibogo on June 30, 2011, 11:44:12 AM
It must be incompatibilities with other mods, it worked just fine in a clean installation
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Lady Night Owl on June 30, 2011, 06:03:17 PM
Quote from: Nibogo on June 30, 2011, 11:44:12 AM
It must be incompatibilities with other mods, it worked just fine in a clean installation

Okay, yes I do have quite a few installed now, I'll do the manual edits then when I get a chance. Thanks again!
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Inti31 on July 01, 2011, 10:22:49 AM
i tried that mod in my testboard (2.0 Gold)

i installed it successfully and set the permission.

When I edit a post, I see the new field to enter the reason - by the way, only if I use the full change button. (screenshot 1)
When I change sth and save the post again (I set the reason) - I don't see the reason next to the last change date...
(screenshot 2)

(http://s2.postimage.org/d510alj0z/change.jpg) (http://s2.postimage.org/d511y4vir/noreason.jpg)

Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: geff_chang on July 05, 2011, 05:52:16 PM
Quote from: Inti31 on July 01, 2011, 10:22:49 AM
i tried that mod in my testboard (2.0 Gold)

i installed it successfully and set the permission.

When I edit a post, I see the new field to enter the reason - by the way, only if I use the full change button. (screenshot 1)
When I change sth and save the post again (I set the reason) - I don't see the reason next to the last change date...
(screenshot 2)

(http://s2.postimage.org/d510alj0z/change.jpg) (http://s2.postimage.org/d511y4vir/noreason.jpg)



I also have the same issue.

I have the following mods installed:
Spoiler BBCode
SMF Staff Page
Quick Reply on Top
Restrict Email Providers on Registration
Aeva ~ Auto-Embed Video & Audio
SMF Multi Quote
Welcome Topic Mod
View Voters at Polls
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MaNaRa on July 27, 2011, 08:34:20 PM
Nice mod but Is there the possibility of adding some background or design to make it more appealing?
Something like this

(http://www.simplemachines.org/community/index.php?action=dlattach;topic=89012.0;attach=183272;image)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Krillin on August 07, 2011, 04:39:54 AM
For those of you who are having trouble installing this mod via the package manager as we are with SMF 2.0 FINAL. You need to modify the database manually. This is the script you need to modify the database yourself to make the changes if you do not understand what the db_reasonX.php means and you CANNOT run this file against the database.

ALTER TABLE `smf_messages` ADD `edit_reason` TINYTEXT NOT NULL ;

PLEASE NOTE: if your prefix is NOT smf_ then modify the code to YOUR database prefix.

Enjoy!
Title: Re: Reason For Editing Mod for SMF 2.0.1
Post by: Krillin on October 03, 2011, 07:38:45 PM
Any chance of getting this updated to SMM 2.0.1 soon?

We have to reinstall our forum software due to the SMF 2.0.1 update. Upon completion, the Reason for Edit box is seen twice, and after removing the mod from the Package Manager the Reason For Edit text box still shows up.

So we are going to do a fresh clean install and see what MOD make it in to our fresh install.

RESULTS:
Believe there is a conflict with Advanced Reputation System. But this mod installs via package manager if it is put into compatibility mode of SMF 2.0. The end result is it works flawlessly. Just needs to be updated to support 2.0.1.

Thanks,
Krillin
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MoreBloodWine on January 03, 2012, 04:30:06 PM
I just tried to install this on 2.0.2 and it errord on me that it's not compatable... any fix for this in the works ?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: PSM on February 02, 2012, 03:36:23 PM
Quote from: MoreBloodWine on January 03, 2012, 04:30:06 PM
I just tried to install this on 2.0.2 and it errord on me that it's not compatable... any fix for this in the works ?

x2 on this.  Would love to have this working on my 2.0.2 forum.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: nixlike on April 16, 2012, 03:45:53 PM
Dear Nibogo, please release a new version to be able to install and use it with SMF 2.0.2 as well.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: dimspace on April 16, 2012, 03:54:38 PM
works here on 2.0.2 no problems at all.  Just had to do a couple of manual edits.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: nixlike on April 16, 2012, 04:54:48 PM
Thats what I usually do when a modification reports issues before installation but this time the mod wants to look in Sources\Display.php for

id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body,

and change it to that

id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body, edit_reason,

I cant even find the line by myself in the Display.php when I look for it, thats why I was asking for an update :)
Am I doing something wrong this time or overlooking something important?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: dimspace on April 16, 2012, 06:34:08 PM
its in mine.

the full section of code is

// What?  It's not like it *couldn't* be only guests in this topic...
if (!empty($posters))
loadMemberData($posters);
$messages_request = $smcFunc['db_query']('', '
SELECT
id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body, edit_reason,
smileys_enabled, poster_name, poster_email, approved,

' . ($board_info['thank_you_post_enable'] && allowedTo('thank_you_post_show') ? 'thank_you_post, thank_you_post_counter,' : '') . '
id_msg_modified < {int:new_from} AS is_read
FROM {db_prefix}messages

WHERE id_msg IN ({array_int:message_list})
ORDER BY id_msg' . (empty($options['view_newest_first']) ? '' : ' DESC'),
array(
'message_list' => $messages,
'new_from' => $topicinfo['new_from'],
)
);


maybe youve got a mod that has changed that line slightly.

On a side note, the verification on here drives me nuts, it generally takes me about 12 attempts to work out what the letters are.. does it go away after ten posts or something :S
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: nixlike on April 17, 2012, 12:14:30 PM
I was afraid already that it might be what I found already when I crawled around the code lines to manually replace it. To be honest I have no idea which mod could have changed that and why, see my code here:


// What?  It's not like it *couldn't* be only guests in this topic...
if (!empty($posters))
loadMemberData($posters);
$messages_request = $smcFunc['db_query']('', '
SELECT
m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body,
m.smileys_enabled, m.poster_name, m.poster_email, m.approved,
m.id_msg_modified < {int:new_from} AS is_read, k.message AS is_repped
FROM {db_prefix}messages AS m
LEFT JOIN {db_prefix}log_karma AS k ON (k.message = m.id_msg AND k.id_executor = {int:current_member})
WHERE m.id_msg IN ({array_int:message_list})
ORDER BY m.id_msg' . (empty($options['view_newest_first']) ? '' : ' DESC'),
array(
'message_list' => $messages,
'new_from' => $topicinfo['new_from'],
'current_member' => $user_info['id'],
)
);


So according to the installer file, the only thing that needs to be done is to have edit_reason added to that list. Now in my case I'm unsure if to just put edit_reason or m.edit_reason there. Maybe you are able to point me to the right spot once more dimspace :)

//edit
Looking at the code part again makes me wonder if this could have been the reputation mod...  ???
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: dimspace on April 17, 2012, 12:45:40 PM
the m prefix is because thats how things are in your database table, so in the members table you have things prefixed with an m ie.    m.id_msg   m.id_topic   m.id_board   m.poster_time   m.id_member   

in theory, the database entry for reason for editing, should still be edit_reason but it may be that it goes into your database as m.edit_reason

two ways to find out, look in the database under phpmyadmin and located the table after doing the routine to the database.

Or do what I do, download display.php
MAKE A COPY
Make the change to the copied file and upload it
If it doesnt work or gives you a database error that it cant find the line then quickly re-upload the original php file back up again.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on April 17, 2012, 01:03:29 PM
what it looks like is that the reputation or some similar mod alreayd made changes to that section and since it's joining data from a second table to the list of variables, it had to identify the message table (m.) and the new table (k.)

add the edit_reason as m.edit_reason

e.g.
m.modified_time, m.modified_name, m.body, m.edit_reason,
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: nixlike on April 17, 2012, 01:06:25 PM
That's what I thought so far, personally for other projects I completely coded on my own I used `tablename`.`rowname` for multiple table/row access within a single query. It's much better to have another person looking through it to make sure I dont push things down the stairs ^^

Backup copies are always available plus I never go productive without intensive testing on my local dev environment :)
I'll go and check out your suggestions and reply later on. Thanks already so far!

@Kindred: Great, so all in all it sounds like a plan. I'll be back later with news on this one.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: nixlike on April 17, 2012, 01:27:36 PM
Ok guys, this is kind of funny lol. Installed the mod, edited Display.php manually, looks fine and no errors so far. But ... theres no input box to enter the edit reason. So I went into the code, Post.template.php this time to do some testing and to see whats causing the missing input box.

Replaced
if ((!$context['is_new_post']) && (allowedTo('reason_edit')))

with
if ((!$context['is_new_post']))

And bloop, there is the line. So usually anyone reading that would go like "Have you set the correct permissions?". Let me answer that with: Yes, I have. First I applied the new permission only to the membergroup my username is in but since my trial and error testing I granted that permission to all membergroups on my devel environment. Same thing, the input box does not appear with the && (allowedTo('reason_edit'))) part.

Is it me who is missing something?

//edit
For the purpose of the functions I can say it works. The only thing I'm a bit confused about is the fact that - once edited with a reason - the reason applied before doesnt show up in the input box. Is this supposed to be like that?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on April 17, 2012, 01:36:42 PM
it would not re-fill the input box with a previous edit reason....
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: dimspace on April 17, 2012, 01:42:05 PM
the code in my post.template is as per the mod parser

// Reason for Editing Mod
    if ((!$context['is_new_post']) && (allowedTo('reason_edit')))
    echo '
<div class="padding smalltext">


which includes the && allowed to.

If you are using utf-8 make sure you have done the manual edits to Modifications.english-utf8.php etc. Im finding a lot of mods where that isnt auto installing and is causing problems down the line.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: dimspace on April 17, 2012, 01:42:53 PM
Quote from: Kindred on April 17, 2012, 01:36:42 PM
it would not re-fill the input box with a previous edit reason....

yeh, ive found that, tis a bit annoying that it doesnt remember it.

hurrah.. ive reached ten posts, no more idiotic verification that it takes me twenty attempts to read.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on April 17, 2012, 01:44:18 PM
well, it would have to do a database call and fill in order to find the last entered reason...

If you're editing it again, in theory, it's for another reason.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: nixlike on April 17, 2012, 01:47:36 PM
Alright, the edit reason being put into the box at new edit isn't a big deal since - as you say Kindred - it's most probably a different reason when you're editing again.
Regarding the utf-8 suggestion - let me ask a dumb question: how do I find out if I'm running on utf8 or not?

Congratz to your breaking-the-10th-post-and-now-be-running-without-verification dimspace :D
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: dimspace on April 17, 2012, 01:56:14 PM
just have a look in your /Themes/default/languages/ directory and see if you have Modifications.english-utf8.php (thats the only related utf-8 file)

Not sure how you do your manual editing. I do all of mine using FTP.
I download all the files to be changed, and sort them into an exact directory structure on my computer.
I then make a copy of the whole lot, make the edits, and then can upload all the changed files in one go.
Then if it screws up i can just in a matter of seconds upload the original files in one go again.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: nixlike on April 17, 2012, 02:01:51 PM
If this is an indicator then I dont have any utf8 files in my language directory at all. I'm thinking of possible solutions now and right now I'm wondering if that permission check is required at all as I run a registered members only board anyway. Of course I'd be happy if that permission stuff works out as supposed but better to have it working at all than dont have anything working - what's your opinion about it (as I dont seem to be able to hunt down the cause properly enough)?

The way you do it was the way I once did it as well but it got a bit sucky for lots of small edits, trials and error testing processes. Running wamp with an exact copy of all the files online, using notepad++ for proper file editing :)

//edit
I chose to go hand in hand with the dont-check-the-permissions solution, works out great! Thanks to dimspace and Kindred for some appropriate and highly appreciated help, thumbs up :)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Steve on December 31, 2012, 09:59:52 AM
Will this be updated to be compatible with 2.0.3?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on December 31, 2012, 03:21:24 PM
Quote from: Nuttysman on December 31, 2012, 09:59:52 AM
Will this be updated to be compatible with 2.0.3?

It should work without any change
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Steve on December 31, 2012, 03:35:42 PM
When I try to install it the Package Manager tells me it's not compatible with my version of SMF (2.0.3).  :-\
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on December 31, 2012, 03:37:45 PM
Try using version emulate. At the bottom of the package manager page
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Steve on December 31, 2012, 04:29:57 PM
I tried it with 2.0 but will try an earlier version. :)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MoreBloodWine on January 11, 2013, 05:48:07 AM
This is labeled to work with 2.0.3 but there is no install link... I tried modifying the xml to reference 2.0.3 along with he other versions but that seemed to not even have the mod show in the package list. It's been a while since I modified an XML but I dont believe I did it wrong since I mirrored what was already there.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Arantor on January 11, 2013, 07:31:41 AM
Check what version you have listed in the Emulate area, Admin > Main > Package Manager > Advanced (right at the bottom)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on January 11, 2013, 07:40:33 AM
You are completely correct....   the mod does list that it runs on 2.0.3 but it apparently has not been correctly updated to run automatically on 2.0.3.

Use the emulate command, as Arantor has indicated and emulate SMF 2.0, it will install then. No need to edi any XML files.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Arantor on January 11, 2013, 07:45:02 AM
Um, Kindred... he said he'd modified the XML file to include 2.0.3... if that's true, the only reason it won't work is if the package manager is already set to emulate something else.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on January 11, 2013, 07:51:32 AM
Well, I checked on the mod download page using the "show manual install for..."
and it fails for 2.0.3, 2.0.2, and 2.0.1 but works for 2.0

So, maybe he incorrectly edited the XML...   either way, it wasn't necesarry to edit the XML in the first place (which is what I was trying to say). :P
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MoreBloodWine on January 11, 2013, 02:34:32 PM
Quote from: Kindred on January 11, 2013, 07:51:32 AM
Well, I checked on the mod download page using the "show manual install for..."
and it fails for 2.0.3, 2.0.2, and 2.0.1 but works for 2.0

So, maybe he incorrectly edited the XML...   either way, it wasn't necesarry to edit the XML in the first place (which is what I was trying to say). :P
I know I can do that but when you emulate to fix one mod it might cause issues for another you need / want to install in regards to not showing uninstall/install links. So I'd prefer them all to work the same in that regard.

As for editing the XML file, I tried a few different ways but adding to what was already there.

ex. 2.0 - 2.0.99

or

ex. 2.0, 2.0.1, 2.0.3 etc etc etc

Both ways, as already evidenced in the XML for 1.0 etc should have worked but did not. I rmember doing edits like this some time in the ago in other mods that worked just fine.

Edit; Until today I never touched the emulator so it reference the sites current 2.0.3 version.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on January 11, 2013, 03:13:30 PM
MoreBloodWine,

you emulate the version to install a mod and then reset it back to your actual version...   when you need to uninstall, you emulate again to get the uninstall link.

I installed over 200 mods using this method, with no difficulties at all.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: xdbmw on February 08, 2013, 08:52:15 AM
Hello Nibogo,

I have added german language support to your mod. If you like you can add this to your smf-2.x.xml

Regards,
Matthias

<file name="$languagedir/Modifications.german.php">
<operation>
<search position="end" />
<add><![CDATA[
// Reason for editing mod
$txt['reason'] = 'Grund';
$txt['reason_edit'] = '&Auml;nderungsgrund';
$txt['permissionname_reason_edit'] = '&Auml;nderungsgrund aktivieren';
$txt['permissionhelp_reason_edit'] = 'Aktivieren, wenn es Mitgliedern dieser Gruppe erlaubt sein soll, einen &Auml;nderungsgrund für eigene Beitr&auml;ge eintragen zu k&ouml;nnen.';
// Reason for editing mod END
]]></add>
</operation>
</file>
<file name="$languagedir/Modifications.german-utf8.php" error="skip">
<operation>
<search position="end" />
<add><![CDATA[
// Reason for editing mod
$txt['reason'] = 'Grund';
$txt['reason_edit'] = '&Auml;nderungsgrund';
$txt['permissionname_reason_edit'] = '&Auml;nderungsgrund aktivieren';
$txt['permissionhelp_reason_edit'] = 'Aktivieren, wenn es Mitgliedern dieser Gruppe erlaubt sein soll, einen &Auml;nderungsgrund für eigene Beitr&auml;ge eintragen zu k&ouml;nnen.';
// Reason for editing mod END
]]></add>
</operation>
</file>

[/quote]
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Torx on July 06, 2013, 08:18:02 PM
Any updates for this planned. Looking for 2.0.4. It did install and test OK, however there are errors reported when edits are done.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on July 07, 2013, 05:42:07 AM
What errors? If you are reporting issues, you need to include specific details
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Torx on July 07, 2013, 08:34:51 AM
Here is the info from the error log. After a few coffees this morning and playing through ftp, looks like I may have been wrong last night in thinking that this was related to this mod. It appears whenever I access the admin section. I will post in a new thread on help on this one. Thank you for the prompt reply Kindred

http://www.thefragtank.ca/forum/index.php?action=admin;area=featuresettings
8: Undefined index: label
File: /home1/forum1/public_html/forum/Themes/default/languages/SPortalHelp.english.php (generic_menu_dropdown_above sub template - eval?)
Line: 327
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on July 08, 2013, 09:51:07 AM
that would be related to one of your menus and the SimplePortal mod, and, as you suspected on review, has nothing at all to do with this mod.

(it may have to do with something called within a portal block)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Antros22 on October 25, 2013, 10:52:39 AM
the mod is not work   on  smf 2.0.6 (new install) not update

The package you are trying to download or install is either corrupt or not compatible with this version of SMF.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Arantor on October 25, 2013, 10:57:48 AM
How can I install a mod that doesn't work in my SMF version? (http://wiki.simplemachines.org/smf/How_can_install_a_mod_that_doesn%27t_work_in_my_SMF_version)

(The version you will want to use is 2.0.3)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: TeoTwawki on July 28, 2014, 12:36:20 AM
I had no trouble installing this mod (ver 2.3.2) by emulating smf 2.0.3 (I'm actually on smf 2.0.8), but recently I had to move my forum to a new host. I fixed the broken paths and imported my backed up database and everything looked fine. until I went to post and got an database error saying "Field 'edit_reason' doesn't have a default value" that is. This is on a new post, not an edit.

I set my emulated version to 2.0.3 again, uninstalled the mod, and I am stillgetting that error!

My entire forum is broken, no new posts can be made. And this is an error that was fixed quite some time ago in an older version - I don't understand why it even started happening to my forum, let alone how it can still be there after removing the mod completely.

For the last hour and a half I've been searching my way through the files installation changes, and not seeing anything related to this mod that got left behind by the uninstall.  ???
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: TeoTwawki on July 28, 2014, 12:51:58 AM
Solved it: uninstall didn't remove the database changes the mod made.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on July 28, 2014, 09:07:10 AM
I'm glad you were able to resolve it
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Ninja ZX-10RR on August 26, 2014, 09:11:34 PM
Strange... Installed the mod with no errors, the box shows up when editing but after filling it and re-posting it doesn't show up in the topic view as if it wasn't installed O.o error log clear, no custom edits except for the xml file edited to install properly.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: BonoVox on December 04, 2014, 04:14:27 PM
Hi. I got a kinda problem here, I can't see the reason of editing after posting the reason in the box, I mean, I wrote the reason in the box and when I send the post, it doesn't appear the reason that I wrote, just my nickname and that X post has been edited by me, but it doesn't show the reason that I wrote.

I didn't get any error during the installation.

My forum is http://foro.outbreakzrp.es/, I am using the Reseller theme and it's using the 2.0.9. Please, help.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Ninja ZX-10RR on December 04, 2014, 04:24:26 PM
As you can see the last post before yours was mine, and I had the same problem, however the mod author is unfortunately well known for not supporting his mods anymore. I couldn't figure out a fix so I just dropped this mod. Doesn't really matter which theme you are using, it gives me the same problem on the freaking default theme.
Sorry for being blunt, I am seriously depressed for SimplePortal not working properly either.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: BonoVox on December 04, 2014, 04:41:43 PM
Huh, that's bad. Is there another mod like this? Thanks for reply.
Maybe there was a situation like this before in previous comments, I haven't checked yet because there are like 26 pages.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Ninja ZX-10RR on December 04, 2014, 05:42:05 PM
Not that I know. I chose this one: http://custom.simplemachines.org/mods/index.php?mod=2104 but does something way different. And has a stupid bug that allows people to bypass it in PMs... I'm investigating on that.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: BonoVox on December 04, 2014, 09:11:45 PM
I fixed it by trying to unistall it, so I was able to see if there was an error and indeed there was, something in Display Template.php of the theme.

PS: I checked every page but I couldn't find anything related to the reason for edit in quick reply, how can I do it?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Ninja ZX-10RR on December 04, 2014, 10:03:16 PM
I wonder why you could do it like that. You said you installed it with no errors but since you uninstalled and it had errors you surely installed it ignoring the red warning...

Btw I'm glad you got it working. No clues about the "quick reply", no clues about what you are talking about...
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: BonoVox on December 17, 2014, 05:22:34 PM
I meant on quick edit, not quick reply, sorry.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on December 17, 2014, 06:56:19 PM
no. there will be no "reason for edit" field on the quick edit option....  there can not be, given the fact that it uses ajax and only loads the minimum
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: bryantdl7 on September 14, 2015, 10:25:13 AM
Sorry for bumping an old post; I was wondering if  anyone has made this mod work with SMF 2.0.10.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on September 14, 2015, 10:45:06 AM
it should work fine for 2.0.10
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on September 22, 2015, 12:22:10 AM
Quote from: bryantdl7 on September 14, 2015, 10:25:13 AM
Sorry for bumping an old post; I was wondering if  anyone has made this mod work with SMF 2.0.10.

User version emulate, it should work just fine.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Livaco on October 24, 2015, 04:50:07 PM
[quote from: nubogo on September 22, 2015, 12:22:10 AM]User version emulate, it should work just fine.[/quote]
It doesent, I tried it and got: The package you are trying to download or install is either corrupt or not compatible with this version of SMF.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Kindred on October 24, 2015, 05:17:37 PM
Then you must have picked the wrong version to emulate
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Saxon044 on January 03, 2016, 07:22:28 AM
I just tried installing this mod on 2.0.10. I had to change emulation to SMF 2.0 RC4 to allow installation but then it installed without error and I was able to edit and add a reason. However, on creating a new post all users got:

Field 'edit_reason' doesn't have a default value

I uninstalled the mod but the error remained. I have dropped the 'edit_reason' field from the database and posting is now working normally. Any thoughts?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on January 04, 2016, 07:53:47 AM
Open phpMyAdmin and set the default value of edit_reason from smf_posts to an empty value.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Saxon044 on January 04, 2016, 11:10:56 AM
Thank you for your response. I don't have a smf_posts table, although I do have smf_messages which is where I dropped the edit_reason field. This field was already blank, which it would be because I hadn't entered any edit reasons, so in phpMyAdmin what (precisely) should the default value of the field be set to? I am puzzled that the mod installation doesn't take care of this automatically, after all, my failed installation killed my forum until I was able to untangle it.

I am wary of trying to reinstall the mod without fully understanding what and why it went wrong the first time.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: margarett on January 04, 2016, 12:02:00 PM
Quote from: Saxon044 on January 04, 2016, 11:10:56 AM
what and why it went wrong the first time.
MySQL newest versions added some requisites (strict modes especially) that didn't exist by the time the MOD was developed ;) In strict mode text fields need a default value when that wasn't the case before.
That's why the installer doesn't "take care of it automatically", it requires an update really.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Saxon044 on January 04, 2016, 01:49:19 PM
Ah so, that makes sense, thank you  :)

Because this is potentially a forum killer, perhaps the mod should be flagged as unsafe until it is updated?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: aegersz on August 22, 2016, 11:46:36 AM
I believe this won't fit if the Post History mod and i want that more ... pity though
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on August 23, 2016, 10:43:08 AM
Unfortunately there is no integration between both mods.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MensaMod on August 28, 2016, 06:33:48 PM


Long ago on a release far away, we'd installed and then uninstalled this mod.  Apparently the uninstall process (or our own negligence) failed to remove the edit_reason column that the install process had added to the messages table.  Worse, that column had a default value of None.  That was OK until our hosting service upleveled our mySQL, which suddenly became too proud to allow us to update the table.

Thanks to y'all's discussion earlier on this thread, plus some help from the hosting service support team, we identified the problem and fixed it by dropping that column.

You have our gratitude.

Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MacRR on November 07, 2016, 09:51:44 AM
Quote from: Nibogo on September 22, 2015, 12:22:10 AM
Quote from: bryantdl7 on September 14, 2015, 10:25:13 AM
Sorry for bumping an old post; I was wondering if  anyone has made this mod work with SMF 2.0.10.

User version emulate, it should work just fine.


Hey, this will work in Reason for Editing Mod SMF 2.0.12 version?
What should I do that I get to work?

Thank you!
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: pocttopus on November 07, 2016, 02:46:52 PM
Quote from: MacRR on November 07, 2016, 09:51:44 AM
Quote from: Nibogo on September 22, 2015, 12:22:10 AM
Quote from: bryantdl7 on September 14, 2015, 10:25:13 AM
Sorry for bumping an old post; I was wondering if  anyone has made this mod work with SMF 2.0.10.

User version emulate, it should work just fine.


Hey, this will work in Reason for Editing Mod SMF 2.0.12 version?
What should I do that I get to work?

Thank you!
It works without any issues.  ;)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MacRR on November 07, 2016, 03:32:34 PM
Hey, thanks for the reply. I do not understand how it works? How can I enable it?

Thank you!
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: pocttopus on November 07, 2016, 05:10:22 PM
Quote from: MacRR on November 07, 2016, 03:32:34 PM
Hey, thanks for the reply. I do not understand how it works? How can I enable it?

Thank you!

After installation you can modify a post and bellow the post there is a little text field to fill the reason for editing. Save the changes and that's it.
It's simple and it's not a rocket science.  ;)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MacRR on November 08, 2016, 02:10:43 AM
Hey, thanks for the reply. I got to the mod :)

Is it possible to turn the mod Finnish language?
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on November 08, 2016, 08:21:11 AM
Quote from: MacRR on November 08, 2016, 02:10:43 AM
Hey, thanks for the reply. I got to the mod :)

Is it possible to turn the mod Finnish language?

Just open /Themes/default/languages/Modifications.finnish.php and before "?>" add the following:


// Reason for editing mod
$txt['reason'] = 'Reason';
$txt['reason_edit'] = 'Reason For Edit';
$txt['permissionname_reason_edit'] = 'Set Reason for edit';
$txt['permissionhelp_reason_edit'] = 'Set if the membergroup is allowed to put the reason for edit their own posts.';
// Reason for editing mod END


You just need to replace the strings between the apostrophes
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: MacRR on November 08, 2016, 08:59:57 AM
Quote from: Nibogo on November 08, 2016, 08:21:11 AM
Quote from: MacRR on November 08, 2016, 02:10:43 AM
Hey, thanks for the reply. I got to the mod :)

Is it possible to turn the mod Finnish language?

Just open /Themes/default/languages/Modifications.finnish.php and before "?>" add the following:


// Reason for editing mod
$txt['reason'] = 'Reason';
$txt['reason_edit'] = 'Reason For Edit';
$txt['permissionname_reason_edit'] = 'Set Reason for edit';
$txt['permissionhelp_reason_edit'] = 'Set if the membergroup is allowed to put the reason for edit their own posts.';
// Reason for editing mod END


You just need to replace the strings between the apostrophes

Hello, thank you very much for your help. Translation works really well
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on November 09, 2016, 08:16:17 AM
Glad to help :)
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: pocttopus on April 11, 2017, 02:54:26 AM
Somehow the mod is not working on 2.0.13 version.  :-\
I don't know how to make it work since Emulate version under Advanced link in listing mods is not working either.
Title: Re: Reason For Editing Mod [v2.3.2 RELEASED!! - Supporting SMF 2.0 Final]
Post by: Nibogo on April 11, 2017, 10:19:21 AM
Try to emulate to 2.0, that should do it.
Title: Re: Reason For Editing Mod
Post by: pocttopus on June 26, 2018, 07:32:40 AM
Again... this mod was working fine but suddenly don't work properly.
Even to emulate to 2.0 version is not working again.

Any reason for that and how can I solve the issue!?  :-\

Title: Re: Reason For Editing Mod
Post by: -Rock Lee- on June 26, 2018, 01:06:07 PM
Quote from: pocttopus on June 26, 2018, 07:32:40 AM
Again... this mod was working fine but suddenly don't work properly.
Even to emulate to 2.0 version is not working again.

Any reason for that and how can I solve the issue!?  :-\

It's just supposition but what version of PHP do you use? have you also looked at the error logs?


Regards!

Title: Re: Reason For Editing Mod
Post by: pocttopus on June 27, 2018, 03:09:03 AM
PHP version: 5.6.30

The error log is pretty big and I don't have a clue how to solve it out.  :-\
Title: Re: Reason For Editing Mod
Post by: -Rock Lee- on June 27, 2018, 09:39:29 AM
Quote from: pocttopus on June 27, 2018, 03:09:03 AM
PHP version: 5.6.30

The error log is pretty big and I don't have a clue how to solve it out.  :-\

Try to clean the records and navigate the issues ... with so many mistakes I guess I am not, it can be a conflict but the issue is to know which one.


Regards!
Title: Re: Reason For Editing Mod
Post by: pocttopus on June 30, 2018, 02:00:43 PM
I had cleaned the error log and mod is still no working.  :-[ :-\
Title: Re: Reason For Editing Mod
Post by: Nibogo on July 01, 2018, 12:30:01 PM
The best thing you could do is use the package parser and check step by step that all code is where it should be.
Title: Re: Reason For Editing Mod
Post by: jack208 on July 01, 2018, 05:23:17 PM
Installed this today on ver 2.0.15. I then hit an issue where I cannot post a reply to any topic. The error log said something about default value in DB.

Database Error: Field 'edit_reason' doesn't have a default valueOnly show the errors from this file File: /mydomain.com/wwwroot/Sources/Subs-Post.phpLine: 1846

The mod creates a new field "edit_reason" in the smf_messages table, but the field is set with the following attributes
- Null = Not allowed
- Default Value = None

After changing the attributes (via phpMyAdmin) to
- Null = Allowed
- Default Value = Null

... posting replies is back to working condition.

Not sure whether it's my hosting's MySQL server setup that defines the Null/Default attributes or is this something the Nibogo can built into his mod codes. Anyway if you face a DB issue around no default values for the edit_reason, this should fix it.
Title: Re: Reason For Editing Mod
Post by: Arantor on July 01, 2018, 05:24:34 PM
It's more that not defining a default used to be OK on MySQL but now it's not.
Title: Re: Reason For Editing Mod
Post by: Kindred on July 01, 2018, 07:07:27 PM
Well, it was not for several MySQL versions. They fixed it with the more recent versions
Title: Re: Reason For Editing Mod
Post by: Arantor on July 02, 2018, 02:12:31 AM
Strict mode is alive and well and continues to function this way, as it should.

The main difference is that a lot of hosts turn it off.
Title: Re: Reason For Editing Mod
Post by: Kindred on July 02, 2018, 11:23:45 AM
true....  but for a few versions my MySQL, it was not alterable - it was always on.
Title: Re: Reason For Editing Mod
Post by: Arantor on July 02, 2018, 11:59:16 AM
Yes, but a lot of hosts are leaving it on because it's the default in MySQL now.

I'd note that if mod authors used the tools available correctly this would not even be a problem.
Title: Re: Reason For Editing Mod
Post by: jack208 on July 15, 2018, 08:02:49 PM
Quote from: jack208 on July 01, 2018, 05:23:17 PM
Installed this today on ver 2.0.15. I then hit an issue where I cannot post a reply to any topic. The error log said something about default value in DB.

Database Error: Field 'edit_reason' doesn't have a default valueOnly show the errors from this file File: /mydomain.com/wwwroot/Sources/Subs-Post.phpLine: 1846

The mod creates a new field "edit_reason" in the smf_messages table, but the field is set with the following attributes
- Null = Not allowed
- Default Value = None

After changing the attributes (via phpMyAdmin) to
- Null = Allowed
- Default Value = Null

... posting replies is back to working condition.

Not sure whether it's my hosting's MySQL server setup that defines the Null/Default attributes or is this something the Nibogo can built into his mod codes. Anyway if you face a DB issue around no default values for the edit_reason, this should fix it.

If you have this problem when installing/using this mod - due to the NULL in column issue - then you'll have this same issue if you are uninstalling/re-installing this mod (with existing data in the edit_reason column) for eg after installing a new theme.

1) The installation checks will pass all tests including those on the custom/new themes
2) However when you try to run the install, it'll give you a DB error (below) (this is assuming you have already entered new mesages after installing the mod the first time)

>Data truncated for column 'edit_reason' at row 22594
>File: mydomain.com\wwwroot\Packages\temp\db_reason2.php
>Line: 23

The error is becoz the above script is trying to update the DB with the same no NULL allowed setting for the column.

To resolve this, I amended the db_reason2.php to change the value of 'null' from false to true.

    // Add the new column
$smcFunc['db_add_column'] ('{db_prefix}messages', array(
'name' => 'edit_reason',
'type' => 'tinytext',
'null' => true
));
Title: Re: Reason For Editing Mod
Post by: pocttopus on July 18, 2018, 06:51:53 AM
Is there any way to fix this issue?
In attachment there is Display.php file uploaded.

(https://s20.postimg.cc/qm6cwdap9/Untitled.png)
Title: Re: Reason For Editing Mod
Post by: pocttopus on July 23, 2018, 04:43:14 AM
I had reinstalled the mod and now it works!
Title: Re: Reason For Editing Mod
Post by: jack208 on July 25, 2018, 09:43:08 AM
Just noted one behaviour of the mod...
1) Let's say we've edited one post, and updated the Reason for Edit2) If we now try to modify the same post, the Reason for Edit field is shown as empty
Can the mod be updated to populate the Reason for Edit with existing text value instead of starting as a blank field?
Title: Re: Reason For Editing Mod
Post by: Nibogo on September 13, 2018, 11:06:04 PM
Quote from: jack208 on July 25, 2018, 09:43:08 AM
Just noted one behaviour of the mod...
1) Let's say we've edited one post, and updated the Reason for Edit2) If we now try to modify the same post, the Reason for Edit field is shown as empty
Can the mod be updated to populate the Reason for Edit with existing text value instead of starting as a blank field?


You would have to include that in the code Jack, this isn't how the mod was designed in first place since every edit is possibly for different reasons.
Title: Re: Reason For Editing Mod
Post by: shadav on August 21, 2019, 01:14:25 PM
I got this installed onto 2.0.15
question though...
how can I show the reason for editing? It's not showing up anywhere on the post after editing and putting the reason for editing....
Title: Re: Reason For Editing Mod
Post by: Kindred on August 21, 2019, 01:15:43 PM
WHat is the courtesy edit time setting?

It looks like you may have edited the post before edits are tracked
Title: Re: Reason For Editing Mod
Post by: shadav on August 21, 2019, 01:30:19 PM
Quote from: Kindred on August 21, 2019, 01:15:43 PM
WHat is the courtesy edit time setting?

It looks like you may have edited the post before edits are tracked
hm... 90 seconds, so then after that time it will appear or i have to wait until after that time for it to work?
Title: Re: Reason For Editing Mod
Post by: Kindred on August 21, 2019, 01:47:37 PM
you have to wait to edit the post until after that time...

the other option might be that you are using a theme other than the default theme and forgot to install the mod into that theme
Title: Re: Reason For Editing Mod
Post by: shadav on September 29, 2019, 10:28:54 PM
I still haven't been able to get this to work...
I checked my db, it was added there.... I've gone through and made sure that everything was added.....
when I edit a post the box is there to put the reason for editing, but it never displays on the post after saving...
2.0.15 using the nightbreeze theme, even on the curve theme it doesn't show up

Title: Re: Reason For Editing Mod
Post by: kapt on December 25, 2021, 03:51:50 AM
When I do quick edit, Edit Reason does not appear. Can you add edit reason for quick edit?