Login module

Started by chadness, February 21, 2005, 01:03:36 PM

Previous topic - Next topic

chadness

I like all of the parameters!  Very nice!

A couple of minor bugs:
"Personal welcome:" is accidently spelled "Personal welome:" on the admin screen
If you turn of the Personal welcome, but want to leave Notify: on, you get funny results.

Like I said, pretty minor, but I wanted to let you know.

One other possibility for the future (you know, when you're bored looking for something else to do) is to allow customization of all of the text in the login box, with the default fallback being to pull the text from the SMF config like is currently done.

Slack

Yes, I reall like the Login parameters too -- nice job Orstio!

A couple of additional bugs:

If you turn off  "Unread" and "New Answers" (which are confusing descriptions in themselves) - this will truncate "Hey Bud, you have 200 messages and 2 are new" to "Hey Bud, you have 200 messages"

Checking the "New PMs" box has no effect.

Having a variable to specify the Font would be nice.

Cheers,
slack

chadness

Quote from: Slack on February 21, 2005, 01:13:49 PM
Having a variable to specify the Font would be nice.
You can set the module class suffix, which allows you to set the font in your CSS file.  That's the traditional Mambo way of doing things.

Slack

Quote from: chadness on February 21, 2005, 02:37:46 PM
Quote from: Slack on February 21, 2005, 01:13:49 PM
Having a variable to specify the Font would be nice.
You can set the module class suffix, which allows you to set the font in your CSS file.  That's the traditional Mambo way of doing things.

Aha, thanks Chad!

Orstio

Excellent.  Thanks, guys.  Looks like a little bit of cleanup is necessary.

QuoteYes, I reall like the Login parameters too -- nice job Orstio!

Actually, most of the params in the login box are Mic's work. ;)


mic

Quote from: Orstio on February 21, 2005, 06:07:07 PM
Excellent. Thanks, guys. Looks like a little bit of cleanup is necessary.

QuoteYes, I reall like the Login parameters too -- nice job Orstio!

Actually, most of the params in the login box are Mic's work. ;)



Hello,

and yes, thats truth (about the parameters).
So, if someone is having troubles with them (i did extended testing with them, but i am only human), feel free to contact me (here by PM or by email > [email protected]).
I will correct if a bug is inside asap!

thx - michael

mic

Quote from: Slack on February 21, 2005, 01:13:49 PM
Yes, I reall like the Login parameters too -- nice job Orstio!

A couple of additional bugs:

If you turn off "Unread" and "New Answers" (which are confusing descriptions in themselves) - this will truncate "Hey Bud, you have 200 messages and 2 are new" to "Hey Bud, you have 200 messages"

Checking the "New PMs" box has no effect.

Having a variable to specify the Font would be nice.

Cheers,
slack
Hello slack,

the parameters are working completely correct.
Why? As i can see (your message above), you have
QuoteHey Bud, you have 200 messages and 2 are new
.
When i split this message, it says that you have '200 messages' at all and '2 new'.
But no PM's
And thats what the parameter is for: "New PMs box ". Therefore there can be no result either switching this ON or OFF, because it handles only PMs.
About the other 2 parameters "Unread" and "New", well in conclusion this means the same, because if a message is new it means also that you havent read it at all  ::)
Maybe i thought the wrong way, but i looked at the original SMF-window which tells you many things.
My parameters are doing not more, than not displaying parts of the original smf.message. To have it more userfriendly, a added so many diferent parameters, because some of us want to show only one line, others more. Also dependig of the space in your layout do you have, as we are using those mods inside the sidebars of mambo and as we all know, space is there sometimes very rare ...

Generaly, if i thought wrong with some, please tell me.

michael

Slack

Hi Mic,

Nice job on the parameters, very handy and it saves having to modify the source code.

Quotethe parameters are working completely correct.
Why? As i can see (your message above), you have

Not for me. :)  The message above was just an example that I typed - I did not copy and paste it form my site.

If I hide "Unread" and "New Answers" then New PMs will never be displayed.  EVEN if I check 'Show' New PMs.  Maybe someone else could confirm this.

(I hope that is clear - I realize we may have a little language barrier.)

My other suggestions are cosmetic.  It would be less confusing if you renamed:  "Unread" to "Unread Posts" and renamed "New Answers" to "New Replies"  -  that way you are consistent with the display.

Also as Chad mentions, it woud be nice to have a variable for at least some of the text.  Like the Greeting.  If you are running a site doing commerce you don't want to address your potential customers with "Hey"  - you would use "Hi" or "Hello"

Keep up the good work - it is starting to look very professional.

Cheers,
slack

Kindred

Slack...  that "greeting" of "Hey" comes from the SMF language file...  You can change that to anything you'd like by modifying your SMF index.LANGUAGE.php

it is:  $txt['hello_member']
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

mic

Okay,
now i realize whats going on/wrong! Sorry not to have it seen earlier ..

We are talking about two diferent versions, Orstio packed one former from me into the package.
Now, (actual version) handles everything correct (i hope), even you can switch off and on in any combination.
There is also a "Intro" text and a "Final" text which can me defined as you want and shown single/both to everybody or only to logged in users.

Hope this will clerify this a little bit.

michael

Slack

thanks Kindred - forgot about that variable.

Thanks Mic, is the updated version in the 3.01 bridge?  (I have not upgraded to that version yet, still on 3.0)

Cheers,
slack

mic

#11
Quote from: Slack on February 22, 2005, 02:44:29 PM
thanks Kindred - forgot about that variable.

Thanks Mic, is the updated version in the 3.01 bridge? (I have not upgraded to that version yet, still on 3.0)

Cheers,
slack

No, sorry not til lyet.
But will update within a few minutes at Mamboforge.

michael

[edit] Mamborforge yet updated (22:25 GMT) SMF.Bridge Modules

Slack

Hi Mic, thanks for the update - but still no go:


mic

Quote from: Slack on February 22, 2005, 06:45:54 PM
Hi Mic, thanks for the update - but still no go:



Sorry, if you mean the typo -> corrected!
Was it that, or more (hope not!)

michael

Advertisement: